43230 2010-07-29 18:50:44 -0700 REGRESSION: Memory leak within JSParser::JSParser 2010-09-02 05:58:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r64324%20(9455)/DumpRenderTree7-leaks.txt InRadar, Regression P1 Normal --- 1 mrowe ap ap commit-queue ggaren oliver oldest_to_newest 258028 0 mrowe 2010-07-29 18:50:44 -0700 The build bot shows memory leaks from within JSParser::JSParser at <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r64324%20(9455)/DumpRenderTree7-leaks.txt>. I believe these showed up shortly after the new JavaScript parser was turned on. Oliver said he was going to look at them then but I don’t think a bug was ever filed. 258029 1 mrowe 2010-07-29 18:51:14 -0700 <rdar://problem/8254215> 259568 2 ggaren 2010-08-03 11:16:41 -0700 Is this a bug in ThreadSpecific? 273057 3 ap 2010-09-01 15:16:02 -0700 I think that this is a misuse of ThreadSpecific. It can't possibly destroy data for all threads in its own destructor. template<typename T> inline ThreadSpecific<T>::~ThreadSpecific() { pthread_key_delete(m_key); // Does not invoke destructor functions. } 273114 4 66301 ap 2010-09-01 17:13:23 -0700 Created attachment 66301 proposed fix 273357 5 66301 commit-queue 2010-09-02 05:58:24 -0700 Comment on attachment 66301 proposed fix Clearing flags on attachment: 66301 Committed r66665: <http://trac.webkit.org/changeset/66665> 273358 6 commit-queue 2010-09-02 05:58:29 -0700 All reviewed patches have been landed. Closing bug. 66301 2010-09-01 17:13:23 -0700 2010-09-02 05:58:24 -0700 proposed fix StackGuard.txt text/plain 5929 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2NjI1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDktMDEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQzMjMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MjU0MjE1PiBSRUdSRVNTSU9OOiBN ZW1vcnkgbGVhayB3aXRoaW4gSlNQYXJzZXI6OkpTUGFyc2VyCisKKyAgICAgICAgT25lIGNhbid0 IGRlbGV0ZSBhIFRocmVhZFNwZWNpZmljIG9iamVjdCB0aGF0IGhhcyBkYXRhIGluIGl0LiBJdCdz IG5vdCBldmVuIHBvc3NpYmxlIHRvCisgICAgICAgIGVudW1lcmF0ZSBkYXRhIG9iamVjdHMgaW4g YWxsIHRocmVhZHMsIG11Y2ggbGVzcyBkZXN0cm95IHRoZW0gZnJvbSBhIHRocmVhZCB0aGF0J3Mg ZGVzdHJveWluZworICAgICAgICB0aGUgVGhyZWFkU3BlY2lmaWMuCisKKyAgICAgICAgKiBwYXJz ZXIvSlNQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpKU1BhcnNlcjo6SlNQYXJzZXIpOgorICAg ICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxEYXRhLmg6IAorICAgICAgICAqIHd0Zi9XVEZUaHJlYWRE YXRhLmNwcDoKKyAgICAgICAgKFdURjo6V1RGVGhyZWFkRGF0YTo6V1RGVGhyZWFkRGF0YSk6Cisg ICAgICAgICogd3RmL1dURlRocmVhZERhdGEuaDoKKyAgICAgICAgKFdURjo6V1RGVGhyZWFkRGF0 YTo6YXBwcm94aW1hdGVkU3RhY2tTdGFydCk6CisgICAgICAgIE1vdmVkIHN0YWNrIGd1YXJkIHRy YWNraW5nIGZyb20gSlNHbG9iYWxEYXRhIHRvIFdURlRocmVhZERhdGEuCisKKyAgICAgICAgKiB3 dGYvVGhyZWFkU3BlY2lmaWMuaDogTWFkZSBkZXN0cnVjdG9yIHVuaW1wbGVtZW50ZWQuIEl0J3Mg ZGFuZ2Vyb3VzLCBhbmQgd2UgcHJvYmFibHkgd29uJ3QKKyAgICAgICAgZXZlciBmYWNlIGEgc2l0 dWF0aW9uIHdoZXJlIHdlJ2Qgd2FudCB0byBkZWxldGUgYSBUaHJlYWRTcGVjaWZpYyBvYmplY3Qu CisKIDIwMTAtMDktMDEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29t PgogCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IE9saXZlciBIdW50LgpJbmRleDogSmF2YVNj cmlwdENvcmUvcGFyc2VyL0pTUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29y ZS9wYXJzZXIvSlNQYXJzZXIuY3BwCShyZXZpc2lvbiA2NjU1MSkKKysrIEphdmFTY3JpcHRDb3Jl L3BhcnNlci9KU1BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDcgQEAgdXNp bmcgbmFtZXNwYWNlIEpTQzsKICNpbmNsdWRlICJOb2RlSW5mby5oIgogI2luY2x1ZGUgIkFTVEJ1 aWxkZXIuaCIKICNpbmNsdWRlIDx3dGYvSGFzaEZ1bmN0aW9ucy5oPgorI2luY2x1ZGUgPHd0Zi9X VEZUaHJlYWREYXRhLmg+CiAjaW5jbHVkZSA8dXRpbGl0eT4KIAogdXNpbmcgbmFtZXNwYWNlIHN0 ZDsKQEAgLTIyMCwxMiArMjIxLDcgQEAgSlNQYXJzZXI6OkpTUGFyc2VyKExleGVyKiBsZXhlciwg SlNHbG9iYQogICAgICwgbV9ub25MSFNDb3VudCgwKQogICAgICwgbV9zeW50YXhBbHJlYWR5VmFs aWRhdGVkKHByb3ZpZGVyLT5pc1ZhbGlkKCkpCiB7Ci0gICAgbV9lbmRBZGRyZXNzID0gKihnbG9i YWxEYXRhLT5zdGFja0d1YXJkcyk7Ci0gICAgaWYgKCFtX2VuZEFkZHJlc3MpIHsKLSAgICAgICAg Y2hhciBzYW1wbGUgPSAwOwotICAgICAgICBtX2VuZEFkZHJlc3MgPSAmc2FtcGxlIC0ga01heFBh cnNlclN0YWNrVXNhZ2U7Ci0gICAgICAgICooZ2xvYmFsRGF0YS0+c3RhY2tHdWFyZHMpID0gbV9l bmRBZGRyZXNzOwotICAgIH0KKyAgICBtX2VuZEFkZHJlc3MgPSB3dGZUaHJlYWREYXRhKCkuYXBw cm94aW1hdGVkU3RhY2tTdGFydCgpIC0ga01heFBhcnNlclN0YWNrVXNhZ2U7CiAgICAgbmV4dCgp OwogICAgIG1fbGV4ZXItPnNldExhc3RMaW5lTnVtYmVyKHRva2VuTGluZSgpKTsKIH0KSW5kZXg6 IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxEYXRhLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuaAkocmV2aXNpb24gNjY1NTEpCisrKyBK YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0y MjcsNyArMjI3LDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAjZW5kaWYKIAogICAgICAgICBDYWNoZWRU cmFuc2NlbmRlbnRhbEZ1bmN0aW9uPHNpbj4gY2FjaGVkU2luOwotICAgICAgICBXVEY6OlRocmVh ZFNwZWNpZmljPGNoYXIqPiBzdGFja0d1YXJkczsKIAogICAgICAgICB2b2lkIHJlc2V0RGF0ZUNh Y2hlKCk7CiAKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRTcGVjaWZpYy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRTcGVjaWZpYy5oCShyZXZpc2lvbiA2 NjU1MSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRTcGVjaWZpYy5oCSh3b3JraW5nIGNv cHkpCkBAIC02NywxMiArNjcsMTcgQEAgcHVibGljOgogICAgIFQqIG9wZXJhdG9yLT4oKTsKICAg ICBvcGVyYXRvciBUKigpOwogICAgIFQmIG9wZXJhdG9yKigpOwotICAgIH5UaHJlYWRTcGVjaWZp YygpOwogCiBwcml2YXRlOgogI2lmICFVU0UoUFRIUkVBRFMpICYmICFQTEFURk9STShRVCkgJiYg IVBMQVRGT1JNKEdUSykgJiYgT1MoV0lORE9XUykKICAgICBmcmllbmQgdm9pZCBUaHJlYWRTcGVj aWZpY1RocmVhZEV4aXQoKTsKICNlbmRpZgorCisgICAgLy8gTm90IGltcGxlbWVudGVkLiBJdCdz IHRlY2huaWNhbGx5IHBvc3NpYmxlIHRvIGRlc3Ryb3kgYSB0aHJlYWQgc3BlY2lmaWMga2V5LCBi dXQgb25lIHdvdWxkIG5lZWQKKyAgICAvLyB0byBtYWtlIHN1cmUgdGhhdCBhbGwgdmFsdWVzIGhh dmUgYmVlbiBkZXN0cm95ZWQgYWxyZWFkeSAodXN1YWxseSwgdGhhdCBhbGwgdGhyZWFkcyB0aGF0 IHVzZWQgaXQKKyAgICAvLyBoYXZlIGV4aXRlZCkuIEl0J3MgdW5saWtlbHkgdGhhdCBhbnkgdXNl ciBvZiB0aGlzIGNhbGwgd2lsbCBiZSBpbiB0aGF0IHNpdHVhdGlvbiAtIGFuZCBoYXZpbmcKKyAg ICAvLyBhIGRlc3RydWN0b3IgZGVmaW5lZCBjYW4gYmUgY29uZnVzaW5nLCBnaXZlbiB0aGF0IGl0 IGhhcyBzdWNoIHN0cm9uZyBwcmUtcmVxdWlzaXRlcyB0byB3b3JrIGNvcnJlY3RseS4KKyAgICB+ VGhyZWFkU3BlY2lmaWMoKTsKICAgICAKICAgICBUKiBnZXQoKTsKICAgICB2b2lkIHNldChUKik7 CkBAIC0xMTYsMTEgKzEyMSw2IEBAIGlubGluZSBUaHJlYWRTcGVjaWZpYzxUPjo6VGhyZWFkU3Bl Y2lmaWMKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4KLWlubGluZSBUaHJlYWRTcGVjaWZpYzxU Pjo6flRocmVhZFNwZWNpZmljKCkKLXsKLX0KLQotdGVtcGxhdGU8dHlwZW5hbWUgVD4KIGlubGlu ZSBUKiBUaHJlYWRTcGVjaWZpYzxUPjo6Z2V0KCkKIHsKICAgICByZXR1cm4gbV92YWx1ZTsKQEAg LTE0MywxMiArMTQzLDYgQEAgaW5saW5lIFRocmVhZFNwZWNpZmljPFQ+OjpUaHJlYWRTcGVjaWZp YwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgotaW5saW5lIFRocmVhZFNwZWNpZmljPFQ+Ojp+ VGhyZWFkU3BlY2lmaWMoKQotewotICAgIHB0aHJlYWRfa2V5X2RlbGV0ZShtX2tleSk7IC8vIERv ZXMgbm90IGludm9rZSBkZXN0cnVjdG9yIGZ1bmN0aW9ucy4KLX0KLQotdGVtcGxhdGU8dHlwZW5h bWUgVD4KIGlubGluZSBUKiBUaHJlYWRTcGVjaWZpYzxUPjo6Z2V0KCkKIHsKICAgICBEYXRhKiBk YXRhID0gc3RhdGljX2Nhc3Q8RGF0YSo+KHB0aHJlYWRfZ2V0c3BlY2lmaWMobV9rZXkpKTsKQEAg LTE3MCwxMiArMTY0LDYgQEAgaW5saW5lIFRocmVhZFNwZWNpZmljPFQ+OjpUaHJlYWRTcGVjaWZp YwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgotaW5saW5lIFRocmVhZFNwZWNpZmljPFQ+Ojp+ VGhyZWFkU3BlY2lmaWMoKQotewotICAgIC8vIERvZXMgbm90IGludm9rZSBkZXN0cnVjdG9yIGZ1 bmN0aW9ucy4gUVRocmVhZFN0b3JhZ2Ugd2lsbCBkbyBpdAotfQotCi10ZW1wbGF0ZTx0eXBlbmFt ZSBUPgogaW5saW5lIFQqIFRocmVhZFNwZWNpZmljPFQ+OjpnZXQoKQogewogICAgIERhdGEqIGRh dGEgPSBzdGF0aWNfY2FzdDxEYXRhKj4obV9rZXkubG9jYWxEYXRhKCkpOwpAQCAtMTk5LDEyICsx ODcsNiBAQCBpbmxpbmUgVGhyZWFkU3BlY2lmaWM8VD46OlRocmVhZFNwZWNpZmljCiB9CiAKIHRl bXBsYXRlPHR5cGVuYW1lIFQ+Ci1pbmxpbmUgVGhyZWFkU3BlY2lmaWM8VD46On5UaHJlYWRTcGVj aWZpYygpCi17Ci0gICAgZ19zdGF0aWNfcHJpdmF0ZV9mcmVlKCZtX2tleSk7Ci19Ci0KLXRlbXBs YXRlPHR5cGVuYW1lIFQ+CiBpbmxpbmUgVCogVGhyZWFkU3BlY2lmaWM8VD46OmdldCgpCiB7CiAg ICAgRGF0YSogZGF0YSA9IHN0YXRpY19jYXN0PERhdGEqPihnX3N0YXRpY19wcml2YXRlX2dldCgm bV9rZXkpKTsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9XVEZUaHJlYWREYXRhLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvV1RGVGhyZWFkRGF0YS5jcHAJKHJldmlzaW9u IDY2NTUxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00Myw2ICs0Myw4IEBAIFdURlRocmVhZERhdGE6OldURlRocmVhZERhdGEoKQog ICAgICwgbV9jdXJyZW50SWRlbnRpZmllclRhYmxlKG1fZGVmYXVsdElkZW50aWZpZXJUYWJsZSkK ICNlbmRpZgogeworICAgIGNoYXIgc2FtcGxlID0gMDsKKyAgICBtX2FwcHJveGltYXRlZFN0YWNr U3RhcnQgPSAmc2FtcGxlOwogfQogCiBXVEZUaHJlYWREYXRhOjp+V1RGVGhyZWFkRGF0YSgpCklu ZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvV1RGVGhyZWFkRGF0YS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph dmFTY3JpcHRDb3JlL3d0Zi9XVEZUaHJlYWREYXRhLmgJKHJldmlzaW9uIDY2NTUxKQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuaAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDYg KzExMiwxMSBAQCBwdWJsaWM6CiAgICAgfQogI2VuZGlmCiAKKyAgICBjaGFyKiBhcHByb3hpbWF0 ZWRTdGFja1N0YXJ0KCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiBtX2FwcHJveGltYXRl ZFN0YWNrU3RhcnQ7CisgICAgfQorCiBwcml2YXRlOgogICAgIEF0b21pY1N0cmluZ1RhYmxlKiBt X2F0b21pY1N0cmluZ1RhYmxlOwogICAgIEF0b21pY1N0cmluZ1RhYmxlRGVzdHJ1Y3RvciBtX2F0 b21pY1N0cmluZ1RhYmxlRGVzdHJ1Y3RvcjsKQEAgLTEyOCw2ICsxMzMsOCBAQCBwcml2YXRlOgog I2VuZGlmCiAgICAgZnJpZW5kIFdURlRocmVhZERhdGEmIHd0ZlRocmVhZERhdGEoKTsKICAgICBm cmllbmQgY2xhc3MgQXRvbWljU3RyaW5nVGFibGU7CisKKyAgICBjaGFyKiBtX2FwcHJveGltYXRl ZFN0YWNrU3RhcnQ7CiB9OwogCiBpbmxpbmUgV1RGVGhyZWFkRGF0YSYgd3RmVGhyZWFkRGF0YSgp Cg==