43229 2010-07-29 18:46:45 -0700 REGRESSION: False-positive memory leak within JSArray::JSArray 2010-08-03 14:48:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r64324%20(9455)/ InRadar, Regression P1 Normal --- 1 mrowe msaboff abarth barraclough eric ggaren msaboff webkit.review.bot oldest_to_newest 258026 0 mrowe 2010-07-29 18:46:45 -0700 The buildbot is showing many memory leaks within JSArray. See the numerous DumpRenderTreeFoo-leaks.txt files at <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r64324%20(9455)/>, such as <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r64324%20(9455)/DumpRenderTree14-leaks.txt>. 258027 1 mrowe 2010-07-29 18:48:13 -0700 <rdar://problem/8254202> 258985 2 63237 msaboff 2010-08-02 10:58:50 -0700 Created attachment 63237 Patch to save alloc'ed pointer in ArrayAStorage structure. 259080 3 63237 barraclough 2010-08-02 13:46:19 -0700 Comment on attachment 63237 Patch to save alloc'ed pointer in ArrayAStorage structure. Please remove the redundant static_cast<void*>()s 259091 4 63257 msaboff 2010-08-02 13:57:21 -0700 Created attachment 63257 Updated patch without redundant void* casts. 259690 5 barraclough 2010-08-03 14:29:43 -0700 Transmitting file data .... Committed revision 64588. 259703 6 webkit.review.bot 2010-08-03 14:48:59 -0700 http://trac.webkit.org/changeset/64588 might have broken GTK Linux 64-bit Debug 63237 2010-08-02 10:58:50 -0700 2010-08-02 13:57:21 -0700 Patch to save alloc'ed pointer in ArrayAStorage structure. 43229.patch text/plain 6848 msaboff SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0NDczKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAtMDgtMDIgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHRvIGtlZXAgcmV0dXJuZWQgcG9pbnRlciBmcm9t IG1hbGxvYyBmYW1pbHkgZnVuY3Rpb25zIHRvCisgICAgICAgIHF1aWV0IG1lbW9yeSBsZWFrIGRl dGVjdC4gIFRoZSBwb2ludGVyIGlzIHNhdmVkIGluIHRoZSBuZXcgbV9hbGxvY0Jhc2UKKyAgICAg ICAgbWVtYmVyIG9mIHRoZSBBcnJheVN0b3JhZ2Ugc3RydWN0dXJlLiAgVGhpcyBmaXhlcyB0aGUg aXNzdWUgZm91bmQgaW4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MzIyOS4KKworICAgICAgICBBcyBwYXJ0IG9mIHRoaXMgY2hhbmdlLCB3ZSB1c2Ug bV9hbGxvY0Jhc2Ugd2hlbiByZWFsbG9jYXRpbmcgYW5kCisgICAgICAgIGZyZWVpbmcgdGhlIG1l bW9yeSBhc3NvY2lhdGVkIHdpdGggQXJyYXlTdG9yYWdlLgorCisgICAgICAgICogcnVudGltZS9K U0FycmF5LmNwcDoKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6SlNBcnJheSk6CisgICAgICAgIChK U0M6OkpTQXJyYXk6On5KU0FycmF5KToKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6cHV0U2xvd0Nh c2UpOgorICAgICAgICAoSlNDOjpKU0FycmF5OjppbmNyZWFzZVZlY3Rvckxlbmd0aCk6CisgICAg ICAgIChKU0M6OkpTQXJyYXk6OmluY3JlYXNlVmVjdG9yUHJlZml4TGVuZ3RoKToKKyAgICAgICAg KiBydW50aW1lL0pTQXJyYXkuaDoKKwogMjAxMC0wOC0wMiAgTWFoZXNoIEt1bGthcm5pICA8bWFo ZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVz bWFubi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNpb24gNjQ0Njgp CisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMzIsMTEgKzEzMiwxNCBAQCBKU0FycmF5OjpKU0FycmF5KE5vbk51bGxQYXNzUmVmUHRyPFN0 cnVjCiAgICAgdW5zaWduZWQgaW5pdGlhbENhcGFjaXR5ID0gMDsKIAogICAgIEFycmF5U3RvcmFn ZSogc3RvcmFnZSA9IHN0YXRpY19jYXN0PEFycmF5U3RvcmFnZSo+KGZhc3RaZXJvZWRNYWxsb2Mo c3RvcmFnZVNpemUoaW5pdGlhbENhcGFjaXR5KSkpOworICAgIHN0b3JhZ2UtPm1fYWxsb2NCYXNl ID0gc3RhdGljX2Nhc3Q8dm9pZCo+KHN0b3JhZ2UpOwogICAgIG1faW5kZXhCaWFzID0gMDsKICAg ICBzZXRBcnJheVN0b3JhZ2Uoc3RvcmFnZSk7CiAgICAgbV92ZWN0b3JMZW5ndGggPSBpbml0aWFs Q2FwYWNpdHk7CiAKICAgICBjaGVja0NvbnNpc3RlbmN5KCk7CisKKyAgICBIZWFwOjpoZWFwKHRo aXMpLT5yZXBvcnRFeHRyYU1lbW9yeUNvc3Qoc3RvcmFnZVNpemUoMCkpOwogfQogCiBKU0FycmF5 OjpKU0FycmF5KE5vbk51bGxQYXNzUmVmUHRyPFN0cnVjdHVyZT4gc3RydWN0dXJlLCB1bnNpZ25l ZCBpbml0aWFsTGVuZ3RoLCBBcnJheUNyZWF0aW9uTW9kZSBjcmVhdGlvbk1vZGUpCkBAIC0xNDks NiArMTUyLDcgQEAgSlNBcnJheTo6SlNBcnJheShOb25OdWxsUGFzc1JlZlB0cjxTdHJ1YwogICAg ICAgICBpbml0aWFsQ2FwYWNpdHkgPSBtaW4oQkFTRV9WRUNUT1JfTEVOLCBNSU5fU1BBUlNFX0FS UkFZX0lOREVYKTsKICAgICAKICAgICBBcnJheVN0b3JhZ2UqIHN0b3JhZ2UgPSBzdGF0aWNfY2Fz dDxBcnJheVN0b3JhZ2UqPihmYXN0TWFsbG9jKHN0b3JhZ2VTaXplKGluaXRpYWxDYXBhY2l0eSkp KTsKKyAgICBzdG9yYWdlLT5tX2FsbG9jQmFzZSA9IHN0YXRpY19jYXN0PHZvaWQqPihzdG9yYWdl KTsKICAgICBzdG9yYWdlLT5tX2xlbmd0aCA9IGluaXRpYWxMZW5ndGg7CiAgICAgbV9pbmRleEJp YXMgPSAwOwogICAgIG1fdmVjdG9yTGVuZ3RoID0gaW5pdGlhbENhcGFjaXR5OwpAQCAtMTc2LDcg KzE4MCw3IEBAIEpTQXJyYXk6OkpTQXJyYXkoTm9uTnVsbFBhc3NSZWZQdHI8U3RydWMKIAogICAg IGNoZWNrQ29uc2lzdGVuY3koKTsKICAgICAKLSAgICBIZWFwOjpoZWFwKHRoaXMpLT5yZXBvcnRF eHRyYU1lbW9yeUNvc3QoaW5pdGlhbENhcGFjaXR5ICogc2l6ZW9mKEpTVmFsdWUpKTsKKyAgICBI ZWFwOjpoZWFwKHRoaXMpLT5yZXBvcnRFeHRyYU1lbW9yeUNvc3Qoc3RvcmFnZVNpemUoaW5pdGlh bENhcGFjaXR5KSk7CiB9CiAKIEpTQXJyYXk6OkpTQXJyYXkoTm9uTnVsbFBhc3NSZWZQdHI8U3Ry dWN0dXJlPiBzdHJ1Y3R1cmUsIGNvbnN0IEFyZ0xpc3QmIGxpc3QpCkBAIC0xODUsNiArMTg5LDcg QEAgSlNBcnJheTo6SlNBcnJheShOb25OdWxsUGFzc1JlZlB0cjxTdHJ1YwogICAgIHVuc2lnbmVk IGluaXRpYWxDYXBhY2l0eSA9IGxpc3Quc2l6ZSgpOwogCiAgICAgQXJyYXlTdG9yYWdlKiBzdG9y YWdlID0gc3RhdGljX2Nhc3Q8QXJyYXlTdG9yYWdlKj4oZmFzdE1hbGxvYyhzdG9yYWdlU2l6ZShp bml0aWFsQ2FwYWNpdHkpKSk7CisgICAgc3RvcmFnZS0+bV9hbGxvY0Jhc2UgPSBzdGF0aWNfY2Fz dDx2b2lkKj4oc3RvcmFnZSk7CiAgICAgbV9pbmRleEJpYXMgPSAwOwogICAgIHN0b3JhZ2UtPm1f bGVuZ3RoID0gaW5pdGlhbENhcGFjaXR5OwogICAgIG1fdmVjdG9yTGVuZ3RoID0gaW5pdGlhbENh cGFjaXR5OwpAQCAtMjE1LDggKzIyMCw3IEBAIEpTQXJyYXk6On5KU0FycmF5KCkKIAogICAgIEFy cmF5U3RvcmFnZSogc3RvcmFnZSA9IGFycmF5U3RvcmFnZSgpOwogICAgIGRlbGV0ZSBzdG9yYWdl LT5tX3NwYXJzZVZhbHVlTWFwOwotICAgIGNoYXIqIHJlYWxTdG9yYWdlID0gcmVpbnRlcnByZXRf Y2FzdDxjaGFyKj4oc3RvcmFnZSkgLSAobV9pbmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSkpOwot ICAgIGZhc3RGcmVlKHJlYWxTdG9yYWdlKTsKKyAgICBmYXN0RnJlZShzdG9yYWdlLT5tX2FsbG9j QmFzZSk7CiB9CiAKIGJvb2wgSlNBcnJheTo6Z2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSog ZXhlYywgdW5zaWduZWQgaSwgUHJvcGVydHlTbG90JiBzbG90KQpAQCAtNDE2LDE1ICs0MjAsMTUg QEAgTkVWRVJfSU5MSU5FIHZvaWQgSlNBcnJheTo6cHV0U2xvd0Nhc2UoRQogICAgICAgICB9CiAg ICAgfQogCi0gICAgaW50IGJhc2VCaWFzID0gbV9pbmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSk7 Ci0gICAgY2hhciogYmFzZVN0b3JhZ2UgPSByZWludGVycHJldF9jYXN0PGNoYXIqPihzdG9yYWdl IC0gYmFzZUJpYXMpOworICAgIHZvaWQqIGJhc2VTdG9yYWdlID0gc3RvcmFnZS0+bV9hbGxvY0Jh c2U7CiAgICAgCiAgICAgaWYgKCF0cnlGYXN0UmVhbGxvYyhiYXNlU3RvcmFnZSwgc3RvcmFnZVNp emUobmV3VmVjdG9yTGVuZ3RoICsgbV9pbmRleEJpYXMpKS5nZXRWYWx1ZShiYXNlU3RvcmFnZSkp IHsKICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMpOwogICAgICAgICByZXR1cm47 CiAgICAgfQogCi0gICAgc3RvcmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJyYXlTdG9yYWdlKj4o YmFzZVN0b3JhZ2UgKyBiYXNlQmlhcyk7CisgICAgc3RvcmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8 QXJyYXlTdG9yYWdlKj4oc3RhdGljX2Nhc3Q8Y2hhcio+KGJhc2VTdG9yYWdlKSArIG1faW5kZXhC aWFzICogc2l6ZW9mKEpTVmFsdWUpKTsKKyAgICBzdG9yYWdlLT5tX2FsbG9jQmFzZSA9IGJhc2VT dG9yYWdlOwogICAgIHNldEFycmF5U3RvcmFnZShzdG9yYWdlKTsKICAgICAKICAgICB1bnNpZ25l ZCB2ZWN0b3JMZW5ndGggPSBtX3ZlY3Rvckxlbmd0aDsKQEAgLTU2NywxMyArNTcxLDEzIEBAIGJv b2wgSlNBcnJheTo6aW5jcmVhc2VWZWN0b3JMZW5ndGgodW5zaWcKICAgICBBU1NFUlQobmV3TGVu Z3RoID4gdmVjdG9yTGVuZ3RoKTsKICAgICBBU1NFUlQobmV3TGVuZ3RoIDw9IE1BWF9TVE9SQUdF X1ZFQ1RPUl9JTkRFWCk7CiAgICAgdW5zaWduZWQgbmV3VmVjdG9yTGVuZ3RoID0gZ2V0TmV3VmVj dG9yTGVuZ3RoKG5ld0xlbmd0aCk7Ci0gICAgaW50IGJhc2VCaWFzID0gbV9pbmRleEJpYXMgKiBz aXplb2YoSlNWYWx1ZSk7Ci0gICAgY2hhciogYmFzZVN0b3JhZ2UgPSByZWludGVycHJldF9jYXN0 PGNoYXIqPihzdG9yYWdlKSAtIGJhc2VCaWFzOworICAgIHZvaWQqIGJhc2VTdG9yYWdlID0gc3Rv cmFnZS0+bV9hbGxvY0Jhc2U7CiAKICAgICBpZiAoIXRyeUZhc3RSZWFsbG9jKGJhc2VTdG9yYWdl LCBzdG9yYWdlU2l6ZShuZXdWZWN0b3JMZW5ndGggKyBtX2luZGV4QmlhcykpLmdldFZhbHVlKGJh c2VTdG9yYWdlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIAotICAgIHN0b3JhZ2UgPSBy ZWludGVycHJldF9jYXN0PEFycmF5U3RvcmFnZSo+KGJhc2VTdG9yYWdlICsgYmFzZUJpYXMpOwor CisgICAgc3RvcmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJyYXlTdG9yYWdlKj4oc3RhdGljX2Nh c3Q8Y2hhcio+KGJhc2VTdG9yYWdlKSArIG1faW5kZXhCaWFzICogc2l6ZW9mKEpTVmFsdWUpKTsK KyAgICBzdG9yYWdlLT5tX2FsbG9jQmFzZSA9IGJhc2VTdG9yYWdlOwogICAgIHNldEFycmF5U3Rv cmFnZShzdG9yYWdlKTsKIAogICAgIEpTVmFsdWUqIHZlY3RvciA9IG1fdmVjdG9yOwpAQCAtNTk5 LDIzICs2MDMsMjIgQEAgYm9vbCBKU0FycmF5OjppbmNyZWFzZVZlY3RvclByZWZpeExlbmd0aAog ICAgIEFTU0VSVChuZXdMZW5ndGggPiB2ZWN0b3JMZW5ndGgpOwogICAgIEFTU0VSVChuZXdMZW5n dGggPD0gTUFYX1NUT1JBR0VfVkVDVE9SX0lOREVYKTsKICAgICB1bnNpZ25lZCBuZXdWZWN0b3JM ZW5ndGggPSBnZXROZXdWZWN0b3JMZW5ndGgobmV3TGVuZ3RoKTsKLSAgICBjaGFyKiBiYXNlU3Rv cmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KHN0b3JhZ2UpIC0gKG1faW5kZXhCaWFzICog c2l6ZW9mKEpTVmFsdWUpKTsKLSAgICAKLSAgICBjaGFyKiBuZXdCYXNlU3RvcmFnZSA9IHJlaW50 ZXJwcmV0X2Nhc3Q8Y2hhcio+KGZhc3RNYWxsb2Moc3RvcmFnZVNpemUobmV3VmVjdG9yTGVuZ3Ro ICsgbV9pbmRleEJpYXMpKSk7CisKKyAgICB2b2lkKiBuZXdCYXNlU3RvcmFnZSA9IGZhc3RNYWxs b2Moc3RvcmFnZVNpemUobmV3VmVjdG9yTGVuZ3RoICsgbV9pbmRleEJpYXMpKTsKICAgICBpZiAo IW5ld0Jhc2VTdG9yYWdlKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCiAgICAgbV9pbmRl eEJpYXMgKz0gbmV3VmVjdG9yTGVuZ3RoIC0gbmV3TGVuZ3RoOwotICAgIGludCBuZXdTdG9yYWdl T2Zmc2V0ID0gbV9pbmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSk7Ci0gICAgCi0gICAgbmV3U3Rv cmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJyYXlTdG9yYWdlKj4obmV3QmFzZVN0b3JhZ2UgKyBu ZXdTdG9yYWdlT2Zmc2V0KTsKICAgICAKKyAgICBuZXdTdG9yYWdlID0gcmVpbnRlcnByZXRfY2Fz dDxBcnJheVN0b3JhZ2UqPihzdGF0aWNfY2FzdDxjaGFyKj4obmV3QmFzZVN0b3JhZ2UpICsgbV9p bmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSkpOworCiAgICAgbWVtY3B5KG5ld1N0b3JhZ2UsIHN0 b3JhZ2UsIHN0b3JhZ2VTaXplKDApKTsKICAgICBtZW1jcHkoJm5ld1N0b3JhZ2UtPm1fdmVjdG9y W25ld0xlbmd0aCAtIG1fdmVjdG9yTGVuZ3RoXSwgJnN0b3JhZ2UtPm1fdmVjdG9yWzBdLCBzdG9y YWdlLT5tX2xlbmd0aCAqIHNpemVvZihKU1ZhbHVlKSk7CiAgICAgCisgICAgbmV3U3RvcmFnZS0+ bV9hbGxvY0Jhc2UgPSBuZXdCYXNlU3RvcmFnZTsKICAgICBtX3ZlY3Rvckxlbmd0aCA9IG5ld0xl bmd0aDsKICAgICAKLSAgICBmYXN0RnJlZShiYXNlU3RvcmFnZSk7CisgICAgZmFzdEZyZWUoc3Rv cmFnZS0+bV9hbGxvY0Jhc2UpOwogCiAgICAgc2V0QXJyYXlTdG9yYWdlKG5ld1N0b3JhZ2UpOwog ICAgIApJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgJKHJldmlzaW9uIDY0NDY4KQorKysg SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYg KzM5LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHVuc2lnbmVkIG1fbnVtVmFsdWVzSW5W ZWN0b3I7CiAgICAgICAgIFNwYXJzZUFycmF5VmFsdWVNYXAqIG1fc3BhcnNlVmFsdWVNYXA7CiAg ICAgICAgIHZvaWQqIHN1YmNsYXNzRGF0YTsgLy8gQSBKU0FycmF5IHN1YmNsYXNzIGNhbiB1c2Ug dGhpcyB0byBmaWxsIHRoZSB2ZWN0b3IgbGF6aWx5LgorICAgICAgICB2b2lkKiBtX2FsbG9jQmFz ZTsgLy8gUG9pbnRlciB0byBiYXNlIGFkZHJlc3MgcmV0dXJuZWQgYnkgbWFsbG9jKCkuICBLZWVw aW5nIHRoaXMgcG9pbnRlciBkb2VzIGVsaW1pbmF0ZSBmYWxzZSBwb3NpdGl2ZXMgZnJvbSB0aGUg bGVhayBkZXRlY3Rvci4KICAgICAgICAgc2l6ZV90IHJlcG9ydGVkTWFwQ2FwYWNpdHk7CiAjaWYg Q0hFQ0tfQVJSQVlfQ09OU0lTVEVOQ1kKICAgICAgICAgYm9vbCBtX2luQ29tcGFjdEluaXRpYWxp emF0aW9uOwo= 63257 2010-08-02 13:57:21 -0700 2010-08-03 14:29:15 -0700 Updated patch without redundant void* casts. 43229.patch text/plain 6788 msaboff SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0NDczKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAtMDgtMDIgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHRvIGtlZXAgcmV0dXJuZWQgcG9pbnRlciBmcm9t IG1hbGxvYyBmYW1pbHkgZnVuY3Rpb25zIHRvCisgICAgICAgIHF1aWV0IG1lbW9yeSBsZWFrIGRl dGVjdC4gIFRoZSBwb2ludGVyIGlzIHNhdmVkIGluIHRoZSBuZXcgbV9hbGxvY0Jhc2UKKyAgICAg ICAgbWVtYmVyIG9mIHRoZSBBcnJheVN0b3JhZ2Ugc3RydWN0dXJlLiAgVGhpcyBmaXhlcyB0aGUg aXNzdWUgZm91bmQgaW4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MzIyOS4KKworICAgICAgICBBcyBwYXJ0IG9mIHRoaXMgY2hhbmdlLCB3ZSB1c2Ug bV9hbGxvY0Jhc2Ugd2hlbiByZWFsbG9jYXRpbmcgYW5kCisgICAgICAgIGZyZWVpbmcgdGhlIG1l bW9yeSBhc3NvY2lhdGVkIHdpdGggQXJyYXlTdG9yYWdlLgorCisgICAgICAgICogcnVudGltZS9K U0FycmF5LmNwcDoKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6SlNBcnJheSk6CisgICAgICAgIChK U0M6OkpTQXJyYXk6On5KU0FycmF5KToKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6cHV0U2xvd0Nh c2UpOgorICAgICAgICAoSlNDOjpKU0FycmF5OjppbmNyZWFzZVZlY3Rvckxlbmd0aCk6CisgICAg ICAgIChKU0M6OkpTQXJyYXk6OmluY3JlYXNlVmVjdG9yUHJlZml4TGVuZ3RoKToKKyAgICAgICAg KiBydW50aW1lL0pTQXJyYXkuaDoKKwogMjAxMC0wOC0wMiAgTWFoZXNoIEt1bGthcm5pICA8bWFo ZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVz bWFubi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNpb24gNjQ0Njgp CisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMzIsMTEgKzEzMiwxNCBAQCBKU0FycmF5OjpKU0FycmF5KE5vbk51bGxQYXNzUmVmUHRyPFN0 cnVjCiAgICAgdW5zaWduZWQgaW5pdGlhbENhcGFjaXR5ID0gMDsKIAogICAgIEFycmF5U3RvcmFn ZSogc3RvcmFnZSA9IHN0YXRpY19jYXN0PEFycmF5U3RvcmFnZSo+KGZhc3RaZXJvZWRNYWxsb2Mo c3RvcmFnZVNpemUoaW5pdGlhbENhcGFjaXR5KSkpOworICAgIHN0b3JhZ2UtPm1fYWxsb2NCYXNl ID0gc3RvcmFnZTsKICAgICBtX2luZGV4QmlhcyA9IDA7CiAgICAgc2V0QXJyYXlTdG9yYWdlKHN0 b3JhZ2UpOwogICAgIG1fdmVjdG9yTGVuZ3RoID0gaW5pdGlhbENhcGFjaXR5OwogCiAgICAgY2hl Y2tDb25zaXN0ZW5jeSgpOworCisgICAgSGVhcDo6aGVhcCh0aGlzKS0+cmVwb3J0RXh0cmFNZW1v cnlDb3N0KHN0b3JhZ2VTaXplKDApKTsKIH0KIAogSlNBcnJheTo6SlNBcnJheShOb25OdWxsUGFz c1JlZlB0cjxTdHJ1Y3R1cmU+IHN0cnVjdHVyZSwgdW5zaWduZWQgaW5pdGlhbExlbmd0aCwgQXJy YXlDcmVhdGlvbk1vZGUgY3JlYXRpb25Nb2RlKQpAQCAtMTQ5LDYgKzE1Miw3IEBAIEpTQXJyYXk6 OkpTQXJyYXkoTm9uTnVsbFBhc3NSZWZQdHI8U3RydWMKICAgICAgICAgaW5pdGlhbENhcGFjaXR5 ID0gbWluKEJBU0VfVkVDVE9SX0xFTiwgTUlOX1NQQVJTRV9BUlJBWV9JTkRFWCk7CiAgICAgCiAg ICAgQXJyYXlTdG9yYWdlKiBzdG9yYWdlID0gc3RhdGljX2Nhc3Q8QXJyYXlTdG9yYWdlKj4oZmFz dE1hbGxvYyhzdG9yYWdlU2l6ZShpbml0aWFsQ2FwYWNpdHkpKSk7CisgICAgc3RvcmFnZS0+bV9h bGxvY0Jhc2UgPSBzdG9yYWdlOwogICAgIHN0b3JhZ2UtPm1fbGVuZ3RoID0gaW5pdGlhbExlbmd0 aDsKICAgICBtX2luZGV4QmlhcyA9IDA7CiAgICAgbV92ZWN0b3JMZW5ndGggPSBpbml0aWFsQ2Fw YWNpdHk7CkBAIC0xNzYsNyArMTgwLDcgQEAgSlNBcnJheTo6SlNBcnJheShOb25OdWxsUGFzc1Jl ZlB0cjxTdHJ1YwogCiAgICAgY2hlY2tDb25zaXN0ZW5jeSgpOwogICAgIAotICAgIEhlYXA6Omhl YXAodGhpcyktPnJlcG9ydEV4dHJhTWVtb3J5Q29zdChpbml0aWFsQ2FwYWNpdHkgKiBzaXplb2Yo SlNWYWx1ZSkpOworICAgIEhlYXA6OmhlYXAodGhpcyktPnJlcG9ydEV4dHJhTWVtb3J5Q29zdChz dG9yYWdlU2l6ZShpbml0aWFsQ2FwYWNpdHkpKTsKIH0KIAogSlNBcnJheTo6SlNBcnJheShOb25O dWxsUGFzc1JlZlB0cjxTdHJ1Y3R1cmU+IHN0cnVjdHVyZSwgY29uc3QgQXJnTGlzdCYgbGlzdCkK QEAgLTE4NSw2ICsxODksNyBAQCBKU0FycmF5OjpKU0FycmF5KE5vbk51bGxQYXNzUmVmUHRyPFN0 cnVjCiAgICAgdW5zaWduZWQgaW5pdGlhbENhcGFjaXR5ID0gbGlzdC5zaXplKCk7CiAKICAgICBB cnJheVN0b3JhZ2UqIHN0b3JhZ2UgPSBzdGF0aWNfY2FzdDxBcnJheVN0b3JhZ2UqPihmYXN0TWFs bG9jKHN0b3JhZ2VTaXplKGluaXRpYWxDYXBhY2l0eSkpKTsKKyAgICBzdG9yYWdlLT5tX2FsbG9j QmFzZSA9IHN0b3JhZ2U7CiAgICAgbV9pbmRleEJpYXMgPSAwOwogICAgIHN0b3JhZ2UtPm1fbGVu Z3RoID0gaW5pdGlhbENhcGFjaXR5OwogICAgIG1fdmVjdG9yTGVuZ3RoID0gaW5pdGlhbENhcGFj aXR5OwpAQCAtMjE1LDggKzIyMCw3IEBAIEpTQXJyYXk6On5KU0FycmF5KCkKIAogICAgIEFycmF5 U3RvcmFnZSogc3RvcmFnZSA9IGFycmF5U3RvcmFnZSgpOwogICAgIGRlbGV0ZSBzdG9yYWdlLT5t X3NwYXJzZVZhbHVlTWFwOwotICAgIGNoYXIqIHJlYWxTdG9yYWdlID0gcmVpbnRlcnByZXRfY2Fz dDxjaGFyKj4oc3RvcmFnZSkgLSAobV9pbmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSkpOwotICAg IGZhc3RGcmVlKHJlYWxTdG9yYWdlKTsKKyAgICBmYXN0RnJlZShzdG9yYWdlLT5tX2FsbG9jQmFz ZSk7CiB9CiAKIGJvb2wgSlNBcnJheTo6Z2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSogZXhl YywgdW5zaWduZWQgaSwgUHJvcGVydHlTbG90JiBzbG90KQpAQCAtNDE2LDE1ICs0MjAsMTUgQEAg TkVWRVJfSU5MSU5FIHZvaWQgSlNBcnJheTo6cHV0U2xvd0Nhc2UoRQogICAgICAgICB9CiAgICAg fQogCi0gICAgaW50IGJhc2VCaWFzID0gbV9pbmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSk7Ci0g ICAgY2hhciogYmFzZVN0b3JhZ2UgPSByZWludGVycHJldF9jYXN0PGNoYXIqPihzdG9yYWdlIC0g YmFzZUJpYXMpOworICAgIHZvaWQqIGJhc2VTdG9yYWdlID0gc3RvcmFnZS0+bV9hbGxvY0Jhc2U7 CiAgICAgCiAgICAgaWYgKCF0cnlGYXN0UmVhbGxvYyhiYXNlU3RvcmFnZSwgc3RvcmFnZVNpemUo bmV3VmVjdG9yTGVuZ3RoICsgbV9pbmRleEJpYXMpKS5nZXRWYWx1ZShiYXNlU3RvcmFnZSkpIHsK ICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMpOwogICAgICAgICByZXR1cm47CiAg ICAgfQogCi0gICAgc3RvcmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJyYXlTdG9yYWdlKj4oYmFz ZVN0b3JhZ2UgKyBiYXNlQmlhcyk7CisgICAgc3RvcmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJy YXlTdG9yYWdlKj4oc3RhdGljX2Nhc3Q8Y2hhcio+KGJhc2VTdG9yYWdlKSArIG1faW5kZXhCaWFz ICogc2l6ZW9mKEpTVmFsdWUpKTsKKyAgICBzdG9yYWdlLT5tX2FsbG9jQmFzZSA9IGJhc2VTdG9y YWdlOwogICAgIHNldEFycmF5U3RvcmFnZShzdG9yYWdlKTsKICAgICAKICAgICB1bnNpZ25lZCB2 ZWN0b3JMZW5ndGggPSBtX3ZlY3Rvckxlbmd0aDsKQEAgLTU2NywxMyArNTcxLDEzIEBAIGJvb2wg SlNBcnJheTo6aW5jcmVhc2VWZWN0b3JMZW5ndGgodW5zaWcKICAgICBBU1NFUlQobmV3TGVuZ3Ro ID4gdmVjdG9yTGVuZ3RoKTsKICAgICBBU1NFUlQobmV3TGVuZ3RoIDw9IE1BWF9TVE9SQUdFX1ZF Q1RPUl9JTkRFWCk7CiAgICAgdW5zaWduZWQgbmV3VmVjdG9yTGVuZ3RoID0gZ2V0TmV3VmVjdG9y TGVuZ3RoKG5ld0xlbmd0aCk7Ci0gICAgaW50IGJhc2VCaWFzID0gbV9pbmRleEJpYXMgKiBzaXpl b2YoSlNWYWx1ZSk7Ci0gICAgY2hhciogYmFzZVN0b3JhZ2UgPSByZWludGVycHJldF9jYXN0PGNo YXIqPihzdG9yYWdlKSAtIGJhc2VCaWFzOworICAgIHZvaWQqIGJhc2VTdG9yYWdlID0gc3RvcmFn ZS0+bV9hbGxvY0Jhc2U7CiAKICAgICBpZiAoIXRyeUZhc3RSZWFsbG9jKGJhc2VTdG9yYWdlLCBz dG9yYWdlU2l6ZShuZXdWZWN0b3JMZW5ndGggKyBtX2luZGV4QmlhcykpLmdldFZhbHVlKGJhc2VT dG9yYWdlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIAotICAgIHN0b3JhZ2UgPSByZWlu dGVycHJldF9jYXN0PEFycmF5U3RvcmFnZSo+KGJhc2VTdG9yYWdlICsgYmFzZUJpYXMpOworCisg ICAgc3RvcmFnZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJyYXlTdG9yYWdlKj4oc3RhdGljX2Nhc3Q8 Y2hhcio+KGJhc2VTdG9yYWdlKSArIG1faW5kZXhCaWFzICogc2l6ZW9mKEpTVmFsdWUpKTsKKyAg ICBzdG9yYWdlLT5tX2FsbG9jQmFzZSA9IGJhc2VTdG9yYWdlOwogICAgIHNldEFycmF5U3RvcmFn ZShzdG9yYWdlKTsKIAogICAgIEpTVmFsdWUqIHZlY3RvciA9IG1fdmVjdG9yOwpAQCAtNTk5LDIz ICs2MDMsMjIgQEAgYm9vbCBKU0FycmF5OjppbmNyZWFzZVZlY3RvclByZWZpeExlbmd0aAogICAg IEFTU0VSVChuZXdMZW5ndGggPiB2ZWN0b3JMZW5ndGgpOwogICAgIEFTU0VSVChuZXdMZW5ndGgg PD0gTUFYX1NUT1JBR0VfVkVDVE9SX0lOREVYKTsKICAgICB1bnNpZ25lZCBuZXdWZWN0b3JMZW5n dGggPSBnZXROZXdWZWN0b3JMZW5ndGgobmV3TGVuZ3RoKTsKLSAgICBjaGFyKiBiYXNlU3RvcmFn ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KHN0b3JhZ2UpIC0gKG1faW5kZXhCaWFzICogc2l6 ZW9mKEpTVmFsdWUpKTsKLSAgICAKLSAgICBjaGFyKiBuZXdCYXNlU3RvcmFnZSA9IHJlaW50ZXJw cmV0X2Nhc3Q8Y2hhcio+KGZhc3RNYWxsb2Moc3RvcmFnZVNpemUobmV3VmVjdG9yTGVuZ3RoICsg bV9pbmRleEJpYXMpKSk7CisKKyAgICB2b2lkKiBuZXdCYXNlU3RvcmFnZSA9IGZhc3RNYWxsb2Mo c3RvcmFnZVNpemUobmV3VmVjdG9yTGVuZ3RoICsgbV9pbmRleEJpYXMpKTsKICAgICBpZiAoIW5l d0Jhc2VTdG9yYWdlKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCiAgICAgbV9pbmRleEJp YXMgKz0gbmV3VmVjdG9yTGVuZ3RoIC0gbmV3TGVuZ3RoOwotICAgIGludCBuZXdTdG9yYWdlT2Zm c2V0ID0gbV9pbmRleEJpYXMgKiBzaXplb2YoSlNWYWx1ZSk7Ci0gICAgCi0gICAgbmV3U3RvcmFn ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8QXJyYXlTdG9yYWdlKj4obmV3QmFzZVN0b3JhZ2UgKyBuZXdT dG9yYWdlT2Zmc2V0KTsKICAgICAKKyAgICBuZXdTdG9yYWdlID0gcmVpbnRlcnByZXRfY2FzdDxB cnJheVN0b3JhZ2UqPihzdGF0aWNfY2FzdDxjaGFyKj4obmV3QmFzZVN0b3JhZ2UpICsgbV9pbmRl eEJpYXMgKiBzaXplb2YoSlNWYWx1ZSkpOworCiAgICAgbWVtY3B5KG5ld1N0b3JhZ2UsIHN0b3Jh Z2UsIHN0b3JhZ2VTaXplKDApKTsKICAgICBtZW1jcHkoJm5ld1N0b3JhZ2UtPm1fdmVjdG9yW25l d0xlbmd0aCAtIG1fdmVjdG9yTGVuZ3RoXSwgJnN0b3JhZ2UtPm1fdmVjdG9yWzBdLCBzdG9yYWdl LT5tX2xlbmd0aCAqIHNpemVvZihKU1ZhbHVlKSk7CiAgICAgCisgICAgbmV3U3RvcmFnZS0+bV9h bGxvY0Jhc2UgPSBuZXdCYXNlU3RvcmFnZTsKICAgICBtX3ZlY3Rvckxlbmd0aCA9IG5ld0xlbmd0 aDsKICAgICAKLSAgICBmYXN0RnJlZShiYXNlU3RvcmFnZSk7CisgICAgZmFzdEZyZWUoc3RvcmFn ZS0+bV9hbGxvY0Jhc2UpOwogCiAgICAgc2V0QXJyYXlTdG9yYWdlKG5ld1N0b3JhZ2UpOwogICAg IApJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgJKHJldmlzaW9uIDY0NDY4KQorKysgSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5 LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHVuc2lnbmVkIG1fbnVtVmFsdWVzSW5WZWN0 b3I7CiAgICAgICAgIFNwYXJzZUFycmF5VmFsdWVNYXAqIG1fc3BhcnNlVmFsdWVNYXA7CiAgICAg ICAgIHZvaWQqIHN1YmNsYXNzRGF0YTsgLy8gQSBKU0FycmF5IHN1YmNsYXNzIGNhbiB1c2UgdGhp cyB0byBmaWxsIHRoZSB2ZWN0b3IgbGF6aWx5LgorICAgICAgICB2b2lkKiBtX2FsbG9jQmFzZTsg Ly8gUG9pbnRlciB0byBiYXNlIGFkZHJlc3MgcmV0dXJuZWQgYnkgbWFsbG9jKCkuICBLZWVwaW5n IHRoaXMgcG9pbnRlciBkb2VzIGVsaW1pbmF0ZSBmYWxzZSBwb3NpdGl2ZXMgZnJvbSB0aGUgbGVh ayBkZXRlY3Rvci4KICAgICAgICAgc2l6ZV90IHJlcG9ydGVkTWFwQ2FwYWNpdHk7CiAjaWYgQ0hF Q0tfQVJSQVlfQ09OU0lTVEVOQ1kKICAgICAgICAgYm9vbCBtX2luQ29tcGFjdEluaXRpYWxpemF0 aW9uOwo=