43222 2010-07-29 17:32:42 -0700 Setting empty document schemes on the WKContext shouldn't start the WebProcess 2010-07-29 17:40:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 beidson beidson oldest_to_newest 257999 0 beidson 2010-07-29 17:32:42 -0700 Setting empty document schemes on the WKContext shouldn't start the WebProcess 258002 1 63016 beidson 2010-07-29 17:33:55 -0700 Created attachment 63016 Patch 258004 2 63016 sam 2010-07-29 17:39:43 -0700 Comment on attachment 63016 Patch > > void WebContext::registerURLSchemeAsEmptyDocument(const String& urlScheme) > { > - ensureWebProcess(); > + if (!hasValidProcess()) { > + m_schemesToRegisterAsEmptyDocument.add(urlScheme); I think we always want to store these for the crashing case and we shouldn't clear them after sending. Otherwise, r=me. 258005 3 beidson 2010-07-29 17:40:54 -0700 Committed r64324: <http://trac.webkit.org/changeset/64324> 63016 2010-07-29 17:33:55 -0700 2010-07-29 17:39:42 -0700 Patch bug-43222-20100729173354.patch text/plain 2612 beidson SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDMyMykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMjkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNl dHRpbmcgZW1wdHkgZG9jdW1lbnQgc2NoZW1lcyBvbiB0aGUgV0tDb250ZXh0IHNob3VsZG4ndCBz dGFydCB0aGUgV2ViUHJvY2VzcworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODI1MzczND4gYW5k IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzIyMgorICAgICAgICAK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkNvbnRleHQ6OmVuc3VyZVdlYlByb2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0 OjpyZWdpc3RlclVSTFNjaGVtZUFzRW1wdHlEb2N1bWVudCk6CisgICAgICAgICogVUlQcm9jZXNz L1dlYkNvbnRleHQuaDoKKwogMjAxMC0wNy0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYktpdDIv VUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNz L1dlYkNvbnRleHQuY3BwCShyZXZpc2lvbiA2NDMyMykKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dl YkNvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsNiArMTA2LDEwIEBAIHZvaWQgV2Vi Q29udGV4dDo6ZW5zdXJlV2ViUHJvY2VzcygpCiAgICAgbV9wcm9jZXNzID0gV2ViUHJvY2Vzc01h bmFnZXI6OnNoYXJlZCgpLmdldFdlYlByb2Nlc3ModGhpcyk7CiAKICAgICBtX3Byb2Nlc3MtPnNl bmQoV2ViUHJvY2Vzc01lc3NhZ2U6OlNldFNob3VsZFRyYWNrVmlzaXRlZExpbmtzLCAwLCBDb3Jl SVBDOjpJbihtX2hpc3RvcnlDbGllbnQuc2hvdWxkVHJhY2tWaXNpdGVkTGlua3MoKSkpOworCisg ICAgZm9yIChIYXNoU2V0PFN0cmluZz46Oml0ZXJhdG9yIGl0ID0gbV9zY2hlbWVzVG9SZWdpc3Rl ckFzRW1wdHlEb2N1bWVudC5iZWdpbigpLCBlbmQgPSBtX3NjaGVtZXNUb1JlZ2lzdGVyQXNFbXB0 eURvY3VtZW50LmVuZCgpOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAgIG1fcHJvY2Vzcy0+c2Vu ZChXZWJQcm9jZXNzTWVzc2FnZTo6UmVnaXN0ZXJVUkxTY2hlbWVBc0VtcHR5RG9jdW1lbnQsIDAs IENvcmVJUEM6OkluKCppdCkpOworICAgIG1fc2NoZW1lc1RvUmVnaXN0ZXJBc0VtcHR5RG9jdW1l bnQuY2xlYXIoKTsKIH0KIAogV2ViUGFnZVByb3h5KiBXZWJDb250ZXh0OjpjcmVhdGVXZWJQYWdl KFdlYlBhZ2VOYW1lc3BhY2UqIHBhZ2VOYW1lc3BhY2UpCkBAIC0yMjgsNyArMjMyLDEwIEBAIHZv aWQgV2ViQ29udGV4dDo6c2V0QWRkaXRpb25hbFBsdWdpbnNEaXIKIAogdm9pZCBXZWJDb250ZXh0 OjpyZWdpc3RlclVSTFNjaGVtZUFzRW1wdHlEb2N1bWVudChjb25zdCBTdHJpbmcmIHVybFNjaGVt ZSkKIHsKLSAgICBlbnN1cmVXZWJQcm9jZXNzKCk7CisgICAgaWYgKCFoYXNWYWxpZFByb2Nlc3Mo KSkgeworICAgICAgICBtX3NjaGVtZXNUb1JlZ2lzdGVyQXNFbXB0eURvY3VtZW50LmFkZCh1cmxT Y2hlbWUpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgbV9wcm9jZXNzLT5zZW5kKFdl YlByb2Nlc3NNZXNzYWdlOjpSZWdpc3RlclVSTFNjaGVtZUFzRW1wdHlEb2N1bWVudCwgMCwgQ29y ZUlQQzo6SW4odXJsU2NoZW1lKSk7CiB9CkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250 ZXh0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCShyZXZp c2lvbiA2NDMyMykKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAkod29ya2luZyBj b3B5KQpAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgIldlYkhpc3RvcnlDbGllbnQuaCIKICNp bmNsdWRlICJXZWJQcm9jZXNzUHJveHkuaCIKICNpbmNsdWRlIDxXZWJDb3JlL1BsYXRmb3JtU3Ry aW5nLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9TdHJpbmdIYXNoLmg+CiAjaW5jbHVkZSA8d3RmL0Zv cndhcmQuaD4KICNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVm UHRyLmg+CkBAIC0xMTgsNiArMTE5LDggQEAgcHJpdmF0ZToKICAgICBXZWJIaXN0b3J5Q2xpZW50 IG1faGlzdG9yeUNsaWVudDsKIAogICAgIFBsdWdpbkluZm9TdG9yZSBtX3BsdWdpbkluZm9TdG9y ZTsKKyAgICAKKyAgICBIYXNoU2V0PFdlYkNvcmU6OlN0cmluZz4gbV9zY2hlbWVzVG9SZWdpc3Rl ckFzRW1wdHlEb2N1bWVudDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=