4322 2005-08-07 13:56:00 -0700 date-big-setdate.html testcase fails if the timezone isn't UTC-8 2005-08-09 14:45:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 16129 0 andersca 2005-08-07 13:56:00 -0700 Since the date-big-setdate.html test case prints out the times, and since -expected.txt contains "UTC-8", it will fail if the timezone is different. Also, setDate sets different dates depending on the time zone. With UTC+1, setDate(120) sets the date to Thu Apr 30 1970 01:00:00 GMT+0100 With UTC-8, setDate(120) sets the date to Mon Mar 30 1970 16:00:00 GMT-0800 (Both Mozilla and Opera does the same thing, so this isn't a bug) 16133 1 3268 andersca 2005-08-07 14:01:48 -0700 Created attachment 3268 Determine if the dates are sequential This patch compares two following dates to see if they're sequential instead of printing out the dates. 16149 2 3268 darin 2005-08-07 18:00:54 -0700 Comment on attachment 3268 Determine if the dates are sequential Looks to me like this has some && where it should have || in the success check. No? Also, should get rid of the unneeded "if (!validVars)". 16166 3 3273 andersca 2005-08-08 00:18:28 -0700 Created attachment 3273 Better test Turns out the test case was really broken. Here's a much simpler one that should work better 16309 4 justin.garcia 2005-08-09 14:45:32 -0700 Landing this 3268 2005-08-07 14:01:48 -0700 2005-08-08 00:18:28 -0700 Determine if the dates are sequential date-big-setdate.diff text/plain 3707 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDUzOQpkaWZmIC11IC1wIC1yMS40NTM5 IENoYW5nZUxvZwotLS0gQ2hhbmdlTG9nCTcgQXVnIDIwMDUgMjA6MjE6MDYgLTAwMDAJMS40NTM5 CisrKyBDaGFuZ2VMb2cJNyBBdWcgMjAwNSAyMTowMTo0MiAtMDAwMApAQCAtMSwzICsxLDE1IEBA CisyMDA1LTA4LTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBtYWMuY29tPgorCisJLSBG aXhlcyA8aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD00MzIy PgorCQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 IGNhc2VzIGFkZGVkOiAKKyAgICAgICAgKiBsYXlvdXQtdGVzdHMvZmFzdC9qcy9kYXRlLWJpZy1z ZXRkYXRlLWV4cGVjdGVkLnR4dDogCisgICAgICAgICogbGF5b3V0LXRlc3RzL2Zhc3QvanMvZGF0 ZS1iaWctc2V0ZGF0ZS5odG1sOiAKKwlDb21wYXJlIHllYXIsIG1vbnRoIGFuZCBkYXRlIHRvIHNl ZSBpZiB0aGUgZGF0ZXMgYXJlCisJc2VxdWVudGlhbCBpbnN0ZWFkIG9mIHNpbXBseSBwcmludGlu ZyB0aGUgZGF0ZXMuCisJCiAyMDA1LTA4LTA3ICBFcmljIFNlaWRlbCAgPGVzZWlkZWxAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IGRhcmluLgpJbmRleDogbGF5b3V0LXRlc3RzL2Zh c3QvanMvZGF0ZS1iaWctc2V0ZGF0ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYkNvcmUvbGF5b3V0LXRlc3RzL2Zhc3QvanMvZGF0ZS1iaWctc2V0ZGF0ZS1l eHBlY3RlZC50eHQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC11IC1wIC1yMS4xIGRh dGUtYmlnLXNldGRhdGUtZXhwZWN0ZWQudHh0Ci0tLSBsYXlvdXQtdGVzdHMvZmFzdC9qcy9kYXRl LWJpZy1zZXRkYXRlLWV4cGVjdGVkLnR4dAkyNyBKdWwgMjAwNSAxOTo1NDoxOCAtMDAwMAkxLjEK KysrIGxheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUtYmlnLXNldGRhdGUtZXhwZWN0ZWQudHh0CTcg QXVnIDIwMDUgMjE6MDE6NDQgLTAwMDAKQEAgLTEsMjMgKzEsNSBAQAogVGhpcyB0ZXN0IGNoZWNr cyBmb3IgcmVncmVzc2lvbiBhZ2FpbnN0OiAzMzgxIERhdGUucHJvdG90eXBlLnNldERhdGUoKSBp bmNvcnJlY3QgZm9yIHZhbHVlcyA+PTEyOC4KIAotSWYgdGhlIHRlc3QgcGFzc2VzLCBhbGwgdGhl IGRhdGVzIGJlbG93IHdpbGwgYmUgc2VxdWVudGlhbC4KK0lmIHRoZSB0ZXN0IHBhc3NlcywgIlN1 Y2Nlc3MiIHdpbGwgYmUgcHJpbnRlZCBiZWxvdy4KIAotc2V0RGF0ZSgxMjApOiBNb24gTWFyIDMw IDE5NzAgMTY6MDA6MDAgR01ULTA4MDAKLQotc2V0RGF0ZSgxMjEpOiBUdWUgTWFyIDMxIDE5NzAg MTY6MDA6MDAgR01ULTA4MDAKLQotc2V0RGF0ZSgxMjIpOiBXZWQgQXByIDAxIDE5NzAgMTY6MDA6 MDAgR01ULTA4MDAKLQotc2V0RGF0ZSgxMjMpOiBUaHUgQXByIDAyIDE5NzAgMTY6MDA6MDAgR01U LTA4MDAKLQotc2V0RGF0ZSgxMjQpOiBGcmkgQXByIDAzIDE5NzAgMTY6MDA6MDAgR01ULTA4MDAK LQotc2V0RGF0ZSgxMjUpOiBTYXQgQXByIDA0IDE5NzAgMTY6MDA6MDAgR01ULTA4MDAKLQotc2V0 RGF0ZSgxMjYpOiBTdW4gQXByIDA1IDE5NzAgMTY6MDA6MDAgR01ULTA4MDAKLQotc2V0RGF0ZSgx MjcpOiBNb24gQXByIDA2IDE5NzAgMTY6MDA6MDAgR01ULTA4MDAKLQotc2V0RGF0ZSgxMjgpOiBU dWUgQXByIDA3IDE5NzAgMTY6MDA6MDAgR01ULTA4MDAKLQotc2V0RGF0ZSgxMjkpOiBXZWQgQXBy IDA4IDE5NzAgMTY6MDA6MDAgR01ULTA4MDAKK1N1Y2Nlc3MhCkluZGV4OiBsYXlvdXQtdGVzdHMv ZmFzdC9qcy9kYXRlLWJpZy1zZXRkYXRlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L1dlYkNvcmUvbGF5b3V0LXRlc3RzL2Zhc3QvanMvZGF0ZS1iaWctc2V0ZGF0ZS5odG1sLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjEKZGlmZiAtdSAtcCAtcjEuMSBkYXRlLWJpZy1zZXRkYXRl Lmh0bWwKLS0tIGxheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUtYmlnLXNldGRhdGUuaHRtbAkyNyBK dWwgMjAwNSAxOTo1NDoxOCAtMDAwMAkxLjEKKysrIGxheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUt YmlnLXNldGRhdGUuaHRtbAk3IEF1ZyAyMDA1IDIxOjAxOjQ0IC0wMDAwCkBAIC0xMywxMSArMTMs MzUgQEAgZnVuY3Rpb24gdGVzdCgpIHsKIAkJbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4 dCgpOwogCX0KIAorICAgIHZhciB2YWxpZFZhcnMgPSBmYWxzZTsKKwl2YXIgY3VyWWVhciwgY3Vy TW9udGgsIGN1ckRhdGU7CisJdmFyIHN1Y2Nlc3MgPSB0cnVlOworCQogICAgIGZvciAodmFyIGkg PSAxMjA7IGkgPCAxMzA7IGkrKykgewogICAgICAgICB2YXIgZCA9IG5ldyBEYXRlKDApOwogICAg ICAgICBkLnNldERhdGUoaSk7Ci0gICAgICAgIHByaW50KCJzZXREYXRlKCIgKyBpICsgIikiICsg IjogIiArIGQpOworICAgICAgICAKKyAgICAgICAgLy8gU2VlIGlmIHRoZSBkYXRlIGlzIHNlcXVl bnRpYWwgY29tcGFyZWQgdG8gdGhlIHByZXZpb3VzIG9uZQorICAgICAgICBpZiAodmFsaWRWYXJz ICYmIAorICAgICAgICAgICAgY3VyRGF0ZSArIDEgIT0gZC5nZXREYXRlKCkgJiYKKyAgICAgICAg ICAgIGN1ck1vbnRoICsgMSAhPSBkLmdldE1vbnRoKCkgJiYKKyAgICAgICAgICAgIGN1clllYXIg KyAxICE9IGQuZ2V0RnVsbFllYXIoKSkgeworICAgICAgICAgICAgc3VjY2VzcyA9IGZhbHNlOwor ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgCX0KKyAgICAgICAgICAgCQorICAgICAgIAljdXJZ ZWFyID0gZC5nZXRGdWxsWWVhcigpOworICAgICAgIAljdXJNb250aCA9IGQuZ2V0TW9udGgoKTsK KyAgICAgICAJY3VyRGF0ZSA9IGQuZ2V0RGF0ZSgpOworICAgICAgIAkKKyAgICAgICAgaWYgKCF2 YWxpZFZhcnMpIAorICAgICAgICAJdmFsaWRWYXJzID0gdHJ1ZTsKICAgICB9CisgICAgCisgICAg aWYgKHN1Y2Nlc3MpCisgICAgCXByaW50KCJTdWNjZXNzISIpOworICAgIGVsc2UKKyAgICAJcHJp bnQoIkZhaWx1cmUhIik7CiB9CiA8L3NjcmlwdD4KIDwvaGVhZD4KQEAgLTI2LDcgKzUwLDcgQEAg ZnVuY3Rpb24gdGVzdCgpIHsKIFRoaXMgdGVzdCBjaGVja3MgZm9yIHJlZ3Jlc3Npb24gYWdhaW5z dDogPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMzgxIj4KIDMzODEgRGF0ZS5wcm90b3R5cGUuc2V0RGF0ZSgpIGluY29ycmVjdCBmb3IgdmFs dWVzID49MTI4LjwvYT4KIDwvcD4KLTxwPklmIHRoZSB0ZXN0IHBhc3NlcywgYWxsIHRoZSBkYXRl cyBiZWxvdyB3aWxsIGJlIHNlcXVlbnRpYWwuPC9wPgorPHA+SWYgdGhlIHRlc3QgcGFzc2VzLCAi U3VjY2VzcyIgd2lsbCBiZSBwcmludGVkIGJlbG93LjwvcD4KIDxocj4KIDxkaXYgaWQ9J2NvbnNv bGUnLyBzdHlsZT0iZm9udC1mYW1pbHk6IGNvdXJpZXI7IGZvbnQtc2l6ZTogMTIiPgogPC9ib2R5 Pgo= 3273 2005-08-08 00:18:28 -0700 2005-08-08 00:24:21 -0700 Better test date-big-setdate-2.diff text/plain 3476 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDU0MApkaWZmIC11IC1wIC1yMS40NTQw IENoYW5nZUxvZwotLS0gQ2hhbmdlTG9nCTggQXVnIDIwMDUgMDQ6MDc6MzYgLTAwMDAJMS40NTQw CisrKyBDaGFuZ2VMb2cJOCBBdWcgMjAwNSAwNzoxODozNyAtMDAwMApAQCAtMSwzICsxLDE1IEBA CisyMDA1LTA4LTA4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBtYWMuY29tPgorCisJLSBG aXhlcyA8aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD00MzIy PgorCQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 IGNhc2VzIGFkZGVkOgorICAgICAgICAqIGxheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUtYmlnLXNl dGRhdGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGxheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUt YmlnLXNldGRhdGUuaHRtbDoKKwlDb21wYXJlIHRoZSBtaWxsaXNlY29uZCB2YWx1ZSBvZiB0aGUg ZGF0ZXMgdG8gc2VlIGlmIHRoZXkncmUKKwlzZXF1ZW50aWFsIGluc3RlYWQgb2Ygc2ltcGx5IHBy aW50aW5nIHRoZSBkYXRlcy4KKwkKIDIwMDUtMDgtMDcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IE1hY2llai4KSW5kZXg6IGxheW91 dC10ZXN0cy9mYXN0L2pzL2RhdGUtYmlnLXNldGRhdGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2xheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUtYmln LXNldGRhdGUtZXhwZWN0ZWQudHh0LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEKZGlmZiAtdSAt cCAtcjEuMSBkYXRlLWJpZy1zZXRkYXRlLWV4cGVjdGVkLnR4dAotLS0gbGF5b3V0LXRlc3RzL2Zh c3QvanMvZGF0ZS1iaWctc2V0ZGF0ZS1leHBlY3RlZC50eHQJMjcgSnVsIDIwMDUgMTk6NTQ6MTgg LTAwMDAJMS4xCisrKyBsYXlvdXQtdGVzdHMvZmFzdC9qcy9kYXRlLWJpZy1zZXRkYXRlLWV4cGVj dGVkLnR4dAk4IEF1ZyAyMDA1IDA3OjE4OjM3IC0wMDAwCkBAIC0xLDIzICsxLDUgQEAKIFRoaXMg dGVzdCBjaGVja3MgZm9yIHJlZ3Jlc3Npb24gYWdhaW5zdDogMzM4MSBEYXRlLnByb3RvdHlwZS5z ZXREYXRlKCkgaW5jb3JyZWN0IGZvciB2YWx1ZXMgPj0xMjguCiAKLUlmIHRoZSB0ZXN0IHBhc3Nl cywgYWxsIHRoZSBkYXRlcyBiZWxvdyB3aWxsIGJlIHNlcXVlbnRpYWwuCitJZiB0aGUgdGVzdCBw YXNzZXMsICJTdWNjZXNzIiB3aWxsIGJlIHByaW50ZWQgYmVsb3cuCiAKLXNldERhdGUoMTIwKTog TW9uIE1hciAzMCAxOTcwIDE2OjAwOjAwIEdNVC0wODAwCi0KLXNldERhdGUoMTIxKTogVHVlIE1h ciAzMSAxOTcwIDE2OjAwOjAwIEdNVC0wODAwCi0KLXNldERhdGUoMTIyKTogV2VkIEFwciAwMSAx OTcwIDE2OjAwOjAwIEdNVC0wODAwCi0KLXNldERhdGUoMTIzKTogVGh1IEFwciAwMiAxOTcwIDE2 OjAwOjAwIEdNVC0wODAwCi0KLXNldERhdGUoMTI0KTogRnJpIEFwciAwMyAxOTcwIDE2OjAwOjAw IEdNVC0wODAwCi0KLXNldERhdGUoMTI1KTogU2F0IEFwciAwNCAxOTcwIDE2OjAwOjAwIEdNVC0w ODAwCi0KLXNldERhdGUoMTI2KTogU3VuIEFwciAwNSAxOTcwIDE2OjAwOjAwIEdNVC0wODAwCi0K LXNldERhdGUoMTI3KTogTW9uIEFwciAwNiAxOTcwIDE2OjAwOjAwIEdNVC0wODAwCi0KLXNldERh dGUoMTI4KTogVHVlIEFwciAwNyAxOTcwIDE2OjAwOjAwIEdNVC0wODAwCi0KLXNldERhdGUoMTI5 KTogV2VkIEFwciAwOCAxOTcwIDE2OjAwOjAwIEdNVC0wODAwCitTdWNjZXNzIQpJbmRleDogbGF5 b3V0LXRlc3RzL2Zhc3QvanMvZGF0ZS1iaWctc2V0ZGF0ZS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9XZWJDb3JlL2xheW91dC10ZXN0cy9mYXN0L2pzL2RhdGUtYmlnLXNldGRh dGUuaHRtbCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLXUgLXAgLXIxLjEgZGF0ZS1i aWctc2V0ZGF0ZS5odG1sCi0tLSBsYXlvdXQtdGVzdHMvZmFzdC9qcy9kYXRlLWJpZy1zZXRkYXRl Lmh0bWwJMjcgSnVsIDIwMDUgMTk6NTQ6MTggLTAwMDAJMS4xCisrKyBsYXlvdXQtdGVzdHMvZmFz dC9qcy9kYXRlLWJpZy1zZXRkYXRlLmh0bWwJOCBBdWcgMjAwNSAwNzoxODozNyAtMDAwMApAQCAt MTMsMTEgKzEzLDI5IEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAJCWxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKIAl9CiAKKyAgICB2YXIgdmFsaWRWYXJzID0gZmFsc2U7CisJdmFyIGN1 clZhbHVlOworCXZhciBzdWNjZXNzID0gdHJ1ZTsKKwl2YXIgbWlsbGlzZWNvbmRzUGVyRGF5ID0g MTAwMCAqIDYwICogNjAgKiAyNDsKKwkKICAgICBmb3IgKHZhciBpID0gMTIwOyBpIDwgMTMwOyBp KyspIHsKICAgICAgICAgdmFyIGQgPSBuZXcgRGF0ZSgwKTsKICAgICAgICAgZC5zZXREYXRlKGkp OwotICAgICAgICBwcmludCgic2V0RGF0ZSgiICsgaSArICIpIiArICI6ICIgKyBkKTsKKyAgICAg ICAgCisgICAgICAgIGlmICh2YWxpZFZhcnMgJiYKKyAgICAgICAgCWQudmFsdWVPZigpIC0gY3Vy VmFsdWUgIT0gbWlsbGlzZWNvbmRzUGVyRGF5KSB7CisgICAgICAgIAlzdWNjZXNzID0gZmFsc2U7 CisgICAgICAgIAlicmVhazsKKyAgICAgICAgfQorCisJCWN1clZhbHVlID0gZC52YWx1ZU9mKCk7 ICAgICAgICAKKyAgICAgICAgdmFsaWRWYXJzID0gdHJ1ZTsKICAgICB9CisgICAgCisgICAgaWYg KHN1Y2Nlc3MpCisgICAgCXByaW50KCJTdWNjZXNzISIpOworICAgIGVsc2UKKyAgICAJcHJpbnQo IkZhaWx1cmUhIik7CiB9CiA8L3NjcmlwdD4KIDwvaGVhZD4KQEAgLTI2LDcgKzQ0LDcgQEAgZnVu Y3Rpb24gdGVzdCgpIHsKIFRoaXMgdGVzdCBjaGVja3MgZm9yIHJlZ3Jlc3Npb24gYWdhaW5zdDog PGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD0z MzgxIj4KIDMzODEgRGF0ZS5wcm90b3R5cGUuc2V0RGF0ZSgpIGluY29ycmVjdCBmb3IgdmFsdWVz ID49MTI4LjwvYT4KIDwvcD4KLTxwPklmIHRoZSB0ZXN0IHBhc3NlcywgYWxsIHRoZSBkYXRlcyBi ZWxvdyB3aWxsIGJlIHNlcXVlbnRpYWwuPC9wPgorPHA+SWYgdGhlIHRlc3QgcGFzc2VzLCAiU3Vj Y2VzcyIgd2lsbCBiZSBwcmludGVkIGJlbG93LjwvcD4KIDxocj4KIDxkaXYgaWQ9J2NvbnNvbGUn LyBzdHlsZT0iZm9udC1mYW1pbHk6IGNvdXJpZXI7IGZvbnQtc2l6ZTogMTIiPgogPC9ib2R5Pgo=