43209 2010-07-29 13:53:52 -0700 [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken 2010-07-30 06:34:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 tonikitoo tonikitoo kenneth oldest_to_newest 257857 0 tonikitoo 2010-07-29 13:53:52 -0700 try running the launcher with the following command line: $ run-launcher --qt -graphicsbased -resizes-to-contents I'll launcher in GraphicsView mode and ResizesToContents (Developers->GraphicsView->Toggle Resizes To Contents Mode) menu item toggle ON, however the property is not set in fact. Browser through sites that require scrollbars, and they will show up. It applies to other supported command line parameters too. 258025 1 tonikitoo 2010-07-29 18:46:11 -0700 Lets fix -resizes-to-contents for now 258030 2 63021 tonikitoo 2010-07-29 18:54:05 -0700 Created attachment 63021 patch v1 When -resizes-to-content was being passed as a command line parameter it was simply not being set (although the corresponding menu item was marked as ON). User had to toggle the menu OFF and then ON again for it to take place. Reason: LauncherWindow::applyPrefs method sets many user options passed in from the command line, but not resizesToContents. Patch addresses that. 258180 3 63021 tonikitoo 2010-07-30 06:34:40 -0700 Comment on attachment 63021 patch v1 Clearing flags on attachment: 63021 Committed r64354: <http://trac.webkit.org/changeset/64354> 63021 2010-07-29 18:54:05 -0700 2010-07-30 06:34:40 -0700 patch v1 0001-2010-07-29-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 4801 tonikitoo RnJvbSBmOWZkMzhmOTNhMzI3MWZhY2Q1YmI4MTEwZWI2Mzc4YWY2MGM2OGVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAyOSBKdWwgMjAxMCAyMTo0NTo0NyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDctMjkgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gUXRUZXN0QnJvd3Nlcjog LXJlc2l6ZXMtdG8tY29udGVudHMgY29tbWFuZCBsaW5lIHBhcmFtZXRlciBpcyBicm9rZW4KICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMyMDkKCiAgICAg ICAgV2hlbiAtcmVzaXplcy10by1jb250ZW50IHdhcyBiZWluZyBwYXNzZWQgYXMgYSBjb21tYW5k IGxpbmUgcGFyYW1ldGVyIGl0IHdhcyBzaW1wbHkKICAgICAgICBub3QgYmVpbmcgc2V0IChhbHRo b3VnaCB0aGUgY29ycmVzcG9uZGluZyBtZW51IGl0ZW0gd2FzIG1hcmtlZCBhcyBPTikuCiAgICAg ICAgVXNlciBoYWQgdG8gdG9nZ2xlIHRoZSBtZW51IE9GRiBhbmQgdGhlbiBPTiBhZ2FpbiBmb3Ig aXQgdG8gdGFrZSBwbGFjZS4KCiAgICAgICAgUmVhc29uOiBMYXVuY2hlcldpbmRvdzo6YXBwbHlQ cmVmcyBtZXRob2Qgc2V0cyBtYW55IHVzZXIgb3B0aW9ucyBwYXNzZWQgaW4gZnJvbQogICAgICAg IHRoZSBjb21tYW5kIGxpbmUsIGJ1dCBub3QgcmVzaXplc1RvQ29udGVudHMuIFBhdGNoIGFkZHJl c3NlcyB0aGF0LgoKICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwOgog ICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKToKICAgICAgICAoTGF1bmNoZXJX aW5kb3c6OmFwcGx5UHJlZnMpOgogICAgICAgIChMYXVuY2hlcldpbmRvdzo6dG9nZ2xlUmVzaXpl c1RvQ29udGVudHMpOgogICAgICAgICogUXRUZXN0QnJvd3Nlci93ZWJ2aWV3Lmg6CiAgICAgICAg KFdlYlZpZXdHcmFwaGljc0Jhc2VkOjpyZXNpemVzVG9Db250ZW50cyk6Ci0tLQogV2ViS2l0VG9v bHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIxICsrKysrKysrKysrKysr KysrKysrKwogV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAgfCAg IDEwICsrKysrKystLS0KIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvd2Vidmlldy5oICAgICAg ICAgIHwgICAgMSArCiAzIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCmluZGV4IGQ5ZGJlNTEuLjg4NDAyYzEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNiBAQAog MjAxMC0wNy0yOSAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUXRUZXN0QnJv d3NlcjogLXJlc2l6ZXMtdG8tY29udGVudHMgY29tbWFuZCBsaW5lIHBhcmFtZXRlciBpcyBicm9r ZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjA5 CisKKyAgICAgICAgV2hlbiAtcmVzaXplcy10by1jb250ZW50IHdhcyBiZWluZyBwYXNzZWQgYXMg YSBjb21tYW5kIGxpbmUgcGFyYW1ldGVyIGl0IHdhcyBzaW1wbHkKKyAgICAgICAgbm90IGJlaW5n IHNldCAoYWx0aG91Z2ggdGhlIGNvcnJlc3BvbmRpbmcgbWVudSBpdGVtIHdhcyBtYXJrZWQgYXMg T04pLgorICAgICAgICBVc2VyIGhhZCB0byB0b2dnbGUgdGhlIG1lbnUgT0ZGIGFuZCB0aGVuIE9O IGFnYWluIGZvciBpdCB0byB0YWtlIHBsYWNlLgorCisgICAgICAgIFJlYXNvbjogTGF1bmNoZXJX aW5kb3c6OmFwcGx5UHJlZnMgbWV0aG9kIHNldHMgbWFueSB1c2VyIG9wdGlvbnMgcGFzc2VkIGlu IGZyb20KKyAgICAgICAgdGhlIGNvbW1hbmQgbGluZSwgYnV0IG5vdCByZXNpemVzVG9Db250ZW50 cy4gUGF0Y2ggYWRkcmVzc2VzIHRoYXQuCisKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL2xhdW5j aGVyd2luZG93LmNwcDoKKyAgICAgICAgKExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUpOgor ICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OmFwcGx5UHJlZnMpOgorICAgICAgICAoTGF1bmNoZXJX aW5kb3c6OnRvZ2dsZVJlc2l6ZXNUb0NvbnRlbnRzKToKKyAgICAgICAgKiBRdFRlc3RCcm93c2Vy L3dlYnZpZXcuaDoKKyAgICAgICAgKFdlYlZpZXdHcmFwaGljc0Jhc2VkOjpyZXNpemVzVG9Db250 ZW50cyk6CisKKzIwMTAtMDctMjkgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIENocmlzdGlhbnNlbi4KIAogICAgICAg ICBbUXRdIFF0VGVzdEJyb3dzZXI6IE1vdmUgV2ViUGFnZSBjbGFzcyBtZXRob2RzIGRlZmluaXRp b25zIGZyb20gbWFpbi5jcHAgdG8gd2VicGFnZS5jcHAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwIGIvV2ViS2l0VG9vbHMvUXRUZXN0QnJv d3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKaW5kZXggYzNiZmZkZi4uMTc3YWRlYSAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKKysrIGIvV2Vi S2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKQEAgLTI3Nyw3ICsyNzcs NyBAQCB2b2lkIExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogCiAgICAgUUFjdGlvbiog dG9nZ2xlUmVzaXplc1RvQ29udGVudHMgPSBncmFwaGljc1ZpZXdNZW51LT5hZGRBY3Rpb24oIlRv Z2dsZSBSZXNpemVzIFRvIENvbnRlbnRzIE1vZGUiLCB0aGlzLCBTTE9UKHRvZ2dsZVJlc2l6ZXNU b0NvbnRlbnRzKGJvb2wpKSk7CiAgICAgdG9nZ2xlUmVzaXplc1RvQ29udGVudHMtPnNldENoZWNr YWJsZSh0cnVlKTsKLSAgICB0b2dnbGVSZXNpemVzVG9Db250ZW50cy0+c2V0Q2hlY2tlZChmYWxz ZSk7CisgICAgdG9nZ2xlUmVzaXplc1RvQ29udGVudHMtPnNldENoZWNrZWQoZ1Jlc2l6ZXNUb0Nv bnRlbnRzKTsKICAgICB0b2dnbGVSZXNpemVzVG9Db250ZW50cy0+c2V0RW5hYmxlZChpc0dyYXBo aWNzQmFzZWQoKSk7CiAgICAgdG9nZ2xlUmVzaXplc1RvQ29udGVudHMtPmNvbm5lY3QodG9nZ2xl R3JhcGhpY3NWaWV3LCBTSUdOQUwodG9nZ2xlZChib29sKSksIFNMT1Qoc2V0RW5hYmxlZChib29s KSkpOwogCkBAIC0zOTksMTAgKzM5OSwxMyBAQCB2b2lkIExhdW5jaGVyV2luZG93OjphcHBseVBy ZWZzKExhdW5jaGVyV2luZG93KiBzb3VyY2UpCiAgICAgdmlldy0+c2V0Vmlld3BvcnRVcGRhdGVN b2RlKG90aGVyVmlldyA/IG90aGVyVmlldy0+dmlld3BvcnRVcGRhdGVNb2RlKCkgOiBnVmlld3Bv cnRVcGRhdGVNb2RlKTsKICAgICB2aWV3LT5zZXRGcmFtZVJhdGVNZWFzdXJlbWVudEVuYWJsZWQo b3RoZXJWaWV3ID8gb3RoZXJWaWV3LT5mcmFtZVJhdGVNZWFzdXJlbWVudEVuYWJsZWQoKSA6IGdT aG93RnJhbWVSYXRlKTsKIAotICAgIGlmIChvdGhlclZpZXcpCisgICAgaWYgKG90aGVyVmlldykg ewogICAgICAgICB2aWV3LT5zZXRJdGVtQ2FjaGVNb2RlKG90aGVyVmlldy0+aXRlbUNhY2hlTW9k ZSgpKTsKLSAgICBlbHNlCisgICAgICAgIHZpZXctPnNldFJlc2l6ZXNUb0NvbnRlbnRzKG90aGVy Vmlldy0+cmVzaXplc1RvQ29udGVudHMoKSk7CisgICAgfSBlbHNlIHsKICAgICAgICAgdmlldy0+ c2V0SXRlbUNhY2hlTW9kZShnQ2FjaGVXZWJWaWV3ID8gUUdyYXBoaWNzSXRlbTo6RGV2aWNlQ29v cmRpbmF0ZUNhY2hlIDogUUdyYXBoaWNzSXRlbTo6Tm9DYWNoZSk7CisgICAgICAgIHZpZXctPnNl dFJlc2l6ZXNUb0NvbnRlbnRzKGdSZXNpemVzVG9Db250ZW50cyk7CisgICAgfQogfQogCiB2b2lk IExhdW5jaGVyV2luZG93OjprZXlQcmVzc0V2ZW50KFFLZXlFdmVudCogZXZlbnQpCkBAIC03MTks NiArNzIyLDcgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xlVGlsZWRCYWNraW5nU3RvcmUo Ym9vbCB0b2dnbGUpCiAKIHZvaWQgTGF1bmNoZXJXaW5kb3c6OnRvZ2dsZVJlc2l6ZXNUb0NvbnRl bnRzKGJvb2wgdG9nZ2xlKQogeworICAgIGdSZXNpemVzVG9Db250ZW50cyA9IHRvZ2dsZTsKICAg ICBzdGF0aWNfY2FzdDxXZWJWaWV3R3JhcGhpY3NCYXNlZCo+KG1fdmlldyktPnNldFJlc2l6ZXNU b0NvbnRlbnRzKHRvZ2dsZSk7CiB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F0VGVzdEJy b3dzZXIvd2Vidmlldy5oIGIvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci93ZWJ2aWV3LmgKaW5k ZXggMzAxNjFiYi4uOWI1MzNiMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nl ci93ZWJ2aWV3LmgKKysrIGIvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci93ZWJ2aWV3LmgKQEAg LTgyLDYgKzgyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBwYWludEV2ZW50KFFQYWlu dEV2ZW50KiBldmVudCk7CiAKICAgICB2b2lkIHNldFJlc2l6ZXNUb0NvbnRlbnRzKGJvb2wgYik7 CisgICAgYm9vbCByZXNpemVzVG9Db250ZW50cygpIGNvbnN0IHsgcmV0dXJuIG1fcmVzaXplc1Rv Q29udGVudHM7IH0KIAogICAgIHZvaWQgc2V0WVJvdGF0aW9uKHFyZWFsIGFuZ2xlKQogICAgIHsK LS0gCjEuNy4wLjQKCg==