43206 2010-07-29 12:58:47 -0700 Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl 2010-07-29 14:35:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr fishd senorblanco simon.fraser oldest_to_newest 257824 0 jamesr 2010-07-29 12:58:47 -0700 Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl 257825 1 62978 jamesr 2010-07-29 13:01:02 -0700 Created attachment 62978 Patch 257831 2 62978 simon.fraser 2010-07-29 13:10:04 -0700 Comment on attachment 62978 Patch > #if ENABLE(3D_CANVAS) > HTMLCanvasElement* canvas = static_cast<HTMLCanvasElement*>(node()); > - return canvas && canvas->is3D(); > + return canvas && canvas->renderingContext() && canvas->renderingContext()->isAccelerated(); No need for the #if ENABLE(3D_CANVAS) any more? 257839 3 jamesr 2010-07-29 13:37:50 -0700 True, I'll get rid of the #ifs. 257893 4 jamesr 2010-07-29 14:35:47 -0700 Committed r64308: <http://trac.webkit.org/changeset/64308> 62978 2010-07-29 13:01:02 -0700 2010-07-29 13:10:04 -0700 Patch bug-43206-20100729130101.patch text/plain 4171 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDBhNjM0Y2NmYTBjNTdlZTVkZjk0Njk1OGZhNWI2NDk1M2VjMWQ1Ny4uNWZmZjJmODVkNTUzNTc0 OGJmZTliNmVlMTJlNzA1YmU2ZDE3NTM0OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNy0yOSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzayBhIGNhbnZhcycgcmVuZGVyaW5nIGNvbnRl eHQgaWYgaXQgaXMgYWNjZWxlcmF0ZWQgaW5zdGVhZCB0eWluZyBpdCBkaXJlY3RseSB0byB3ZWJn bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMyMDYK KworICAgICAgICBUaGlzIHVuaWZpZXMgdGhlIGxvZ2ljIGZvciB3aGV0aGVyIGEgY2FudmFzIGlz IGFjY2VsZXJhdGVkIG9yIG5vdCBpbnRvIG9uZSBwbGFjZQorICAgICAgICBhbmQgbWFrZXMgaXQg ZWFzaWVyIHRvIGV4cGFuZCB0aGUgbG9naWMgaW4gdGhlIGZ1dHVyZSB0bywgZm9yIGV4YW1wbGUs IGNvdmVyIHNvbWUKKyAgICAgICAgMmQgY2FudmFzZXMuCisKKyAgICAgICAgSnVzdCBhIHJlZmFj dG9yaW5nLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3Igc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAg ICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dC5oOgorICAgICAgICAoV2ViQ29y ZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDo6aXNBY2NlbGVyYXRlZCk6CisgICAgICAgICogaHRt bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpXZWJH TFJlbmRlcmluZ0NvbnRleHQ6OmlzQWNjZWxlcmF0ZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJIVE1MQ2FudmFzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckhUTUxDYW52YXM6 OnJlcXVpcmVzTGF5ZXIpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJl c0NvbXBvc2l0aW5nRm9yQ2FudmFzKToKKwogMjAxMC0wNy0yOSAgQWRhbSBSb2JlbiAgPGFyb2Jl bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgdW51c2VkIFdLQ0FDRkxheWVyIG1l bWJlcnMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29u dGV4dC5oIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0LmgKaW5k ZXggZjc1MjM3NzcyZGVjZTk1YzcxM2NlNzYxNmM1NTljYTZiYTNlYzE5My4uMmVlMTY5MzhmNzgy OGM5Nzc3OGU0ZTRjYjQxODcwOTAxZjNhOTlkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL2Nh bnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0LmgKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9D YW52YXNSZW5kZXJpbmdDb250ZXh0LmgKQEAgLTQ2LDYgKzQ2LDcgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICAKICAgICAgICAgdmlydHVhbCBib29sIGlzMmQoKSBjb25zdCB7IHJldHVy biBmYWxzZTsgfQogICAgICAgICB2aXJ0dWFsIGJvb2wgaXMzZCgpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CisgICAgICAgIHZpcnR1YWwgYm9vbCBpc0FjY2VsZXJhdGVkKCkgY29uc3QgeyByZXR1 cm4gZmFsc2U7IH0KIAogICAgIHByaXZhdGU6CiAgICAgICAgIEhUTUxDYW52YXNFbGVtZW50KiBt X2NhbnZhczsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdD b250ZXh0LmggYi9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCmlu ZGV4IGZhOWZmZGI4YTBkZTNiZTU1ZmYxYjg4ODRjNDRmYzFlYjlhNWYwOTUuLjAxNzU3MGJlZDQy MDIzZGJjNTRkNGI5N2ZmNGUyNjA5YTY4MjRiNWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTFJlbmRlcmluZ0NvbnRleHQuaApAQCAtNTgsNiArNTgsNyBAQCBjbGFzcyBXZWJLaXRDU1NN YXRyaXg7CiAgICAgICAgIHZpcnR1YWwgfldlYkdMUmVuZGVyaW5nQ29udGV4dCgpOwogCiAgICAg ICAgIHZpcnR1YWwgYm9vbCBpczNkKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQorICAgICAgICB2 aXJ0dWFsIGJvb2wgaXNBY2NlbGVyYXRlZCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAogICAg ICAgICAvLyBIZWxwZXIgdG8gcmV0dXJuIHRoZSBzaXplIGluIGJ5dGVzIG9mIE9wZW5HTCBkYXRh IHR5cGVzCiAgICAgICAgIC8vIGxpa2UgR0xfRkxPQVQsIEdMX0lOVCwgZXRjLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySFRNTENhbnZhcy5jcHAgYi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJIVE1MQ2FudmFzLmNwcAppbmRleCA4YzE3YTBlMGU5Y2RmNTk5Njg4ZTQyYzE2 YTM1ZTllNzgyNjM0NDY2Li44MGQxNzA0Mzc1YTFkY2JkNWIxMTMyODdhMzcxMWY5YWEwZDIxOTYx IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJIVE1MQ2FudmFzLmNwcAorKysg Yi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJIVE1MQ2FudmFzLmNwcApAQCAtMjYsNiArMjYsNyBA QAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlJlbmRlckhUTUxDYW52YXMuaCIKIAor I2luY2x1ZGUgIkNhbnZhc1JlbmRlcmluZ0NvbnRleHQuaCIKICNpbmNsdWRlICJEb2N1bWVudC5o IgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkhUTUxDYW52YXNFbGVt ZW50LmgiCkBAIC01MCw3ICs1MSw3IEBAIGJvb2wgUmVuZGVySFRNTENhbnZhczo6cmVxdWlyZXNM YXllcigpIGNvbnN0CiAgICAgCiAjaWYgRU5BQkxFKDNEX0NBTlZBUykKICAgICBIVE1MQ2FudmFz RWxlbWVudCogY2FudmFzID0gc3RhdGljX2Nhc3Q8SFRNTENhbnZhc0VsZW1lbnQqPihub2RlKCkp OwotICAgIHJldHVybiBjYW52YXMgJiYgY2FudmFzLT5pczNEKCk7CisgICAgcmV0dXJuIGNhbnZh cyAmJiBjYW52YXMtPnJlbmRlcmluZ0NvbnRleHQoKSAmJiBjYW52YXMtPnJlbmRlcmluZ0NvbnRl eHQoKS0+aXNBY2NlbGVyYXRlZCgpOwogI2Vsc2UKICAgICByZXR1cm4gZmFsc2U7CiAjZW5kaWYK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAg Yi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDUxZjcw YmIxY2IyZGM4MDU1ODYzZmNlYzA2MWZiM2YyZjkxYTJjNzYuLjlkOTliNTNjM2Y5MDZlMTcxMmZl MWZlMzE4ZWMzNDUxNTFhNTA1MDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmNwcApAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIlJlbmRlckxheWVyQ29t cG9zaXRvci5oIgogCiAjaW5jbHVkZSAiQW5pbWF0aW9uQ29udHJvbGxlci5oIgorI2luY2x1ZGUg IkNhbnZhc1JlbmRlcmluZ0NvbnRleHQuaCIKICNpbmNsdWRlICJDU1NQcm9wZXJ0eU5hbWVzLmgi CiAjaW5jbHVkZSAiQ2hyb21lLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50LmgiCkBAIC0xMTg4 LDcgKzExODksNyBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wb3Np dGluZ0ZvckNhbnZhcyhSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogI2lmIEVOQUJMRSgzRF9DQU5W QVMpICAgIAogICAgIGlmIChyZW5kZXJlci0+aXNDYW52YXMoKSkgewogICAgICAgICBIVE1MQ2Fu dmFzRWxlbWVudCogY2FudmFzID0gc3RhdGljX2Nhc3Q8SFRNTENhbnZhc0VsZW1lbnQqPihyZW5k ZXJlci0+bm9kZSgpKTsKLSAgICAgICAgcmV0dXJuIGNhbnZhcy0+aXMzRCgpOworICAgICAgICBy ZXR1cm4gY2FudmFzLT5yZW5kZXJpbmdDb250ZXh0KCkgJiYgY2FudmFzLT5yZW5kZXJpbmdDb250 ZXh0KCktPmlzQWNjZWxlcmF0ZWQoKTsKICAgICB9CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShy ZW5kZXJlcik7Cg==