43196 2010-07-29 09:41:56 -0700 Java applets should be blocked when plugins are blocked (in Chromium, at least) 2010-07-29 15:10:03 -0700 1 1 1 Unclassified WebKit Java 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 bauerb webkit-unassigned andersca brettw commit-queue darin fishd oldest_to_newest 257740 0 bauerb 2010-07-29 09:41:56 -0700 After removing click-to-play in Chromium, Java applets aren't blocked when plugins are disabled in the content setting (http://crbug.com/50506). Turns out, this was already broken some time before click-to-play landed, namely since http://trac.webkit.org/changeset/60178. Even before that, applets were only blocked pretty much as a side effect of the code removed in that revision. Patch forthcoming. 257742 1 62964 bauerb 2010-07-29 09:49:01 -0700 Created attachment 62964 Check if plugins are allowed before creating a Java applet 257747 2 bauerb 2010-07-29 09:53:53 -0700 Bonus: with this patch, you also get the plugins blocked bubble (you didn't before). 257789 3 62964 darin 2010-07-29 11:23:22 -0700 Comment on attachment 62964 Check if plugins are allowed before creating a Java applet This is not a Chromium-specific patch. Do all platforms want to block Java if plug-ins are blocked? 257884 4 62964 fishd 2010-07-29 14:25:13 -0700 Comment on attachment 62964 Check if plugins are allowed before creating a Java applet R+CQ=me No other ports override allowPlugins to block plugins on a per-frame basis. Other ports use the global settings to block Java, etc. It seems appropriate to me to treat Java as a plugin. (It is an ordinary NPAPI plugin these days, at least on Windows.) 257905 5 62964 commit-queue 2010-07-29 15:09:58 -0700 Comment on attachment 62964 Check if plugins are allowed before creating a Java applet Clearing flags on attachment: 62964 Committed r64311: <http://trac.webkit.org/changeset/64311> 257906 6 commit-queue 2010-07-29 15:10:03 -0700 All reviewed patches have been landed. Closing bug. 62964 2010-07-29 09:49:01 -0700 2010-07-29 15:09:58 -0700 Check if plugins are allowed before creating a Java applet block_java.patch text/plain 1335 bauerb ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWFiNTliYS4uYzdkYTg2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0yOSAgQmVybmhhcmQgQmF1 ZXIgIDxiYXVlcmJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoZWNrIGlmIHBsdWdpbnMgYXJlIGFsbG93ZWQgYmVmb3JlIGNy ZWF0aW5nIGEgSmF2YSBhcHBsZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MzE5NgorCisgICAgICAgICogbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlN1YmZyYW1lTG9hZGVyOjpjcmVhdGVKYXZhQXBwbGV0V2lk Z2V0KToKKwogMjAxMC0wNy0yOCAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL1N1YmZy YW1lTG9hZGVyLmNwcAppbmRleCAyMjA2YjRlLi5kYzJjY2UxIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvU3ViZnJhbWVM b2FkZXIuY3BwCkBAIC0yMjYsNyArMjI2LDkgQEAgUGFzc1JlZlB0cjxXaWRnZXQ+IFN1YmZyYW1l TG9hZGVyOjpjcmVhdGVKYXZhQXBwbGV0V2lkZ2V0KGNvbnN0IEludFNpemUmIHNpemUsIEgKICAg ICAgICAgYmFzZVVSTFN0cmluZyA9IG1fZnJhbWUtPmRvY3VtZW50KCktPmJhc2VVUkwoKS5zdHJp bmcoKTsKICAgICBLVVJMIGJhc2VVUkwgPSBjb21wbGV0ZVVSTChiYXNlVVJMU3RyaW5nKTsKIAot ICAgIFJlZlB0cjxXaWRnZXQ+IHdpZGdldCA9IG1fZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKS0+ Y3JlYXRlSmF2YUFwcGxldFdpZGdldChzaXplLCBlbGVtZW50LCBiYXNlVVJMLCBwYXJhbU5hbWVz LCBwYXJhbVZhbHVlcyk7CisgICAgUmVmUHRyPFdpZGdldD4gd2lkZ2V0OworICAgIGlmIChhbGxv d1BsdWdpbnMoQWJvdXRUb0luc3RhbnRpYXRlUGx1Z2luKSkKKyAgICAgICAgd2lkZ2V0ID0gbV9m cmFtZS0+bG9hZGVyKCktPmNsaWVudCgpLT5jcmVhdGVKYXZhQXBwbGV0V2lkZ2V0KHNpemUsIGVs ZW1lbnQsIGJhc2VVUkwsIHBhcmFtTmFtZXMsIHBhcmFtVmFsdWVzKTsKICAgICBpZiAoIXdpZGdl dCkKICAgICAgICAgcmV0dXJuIDA7CiAK