43193 2010-07-29 09:01:12 -0700 Initialize all members of NPClass struct 2010-07-29 09:38:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned oldest_to_newest 257703 0 ossy 2010-07-29 09:01:12 -0700 We should initialize all members of NPClass struct to avoid gcc warnings. Warnings on Qt bots: /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::removeProperty’ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::enumerate’ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::construct’ 257706 1 62953 ossy 2010-07-29 09:05:14 -0700 Created attachment 62953 proposed patch Members of "static NPClass pluginClass" are initialized with zeros by crt0. We can do it explicitly to avoid gcc warnings. 257734 2 62953 ossy 2010-07-29 09:36:43 -0700 Comment on attachment 62953 proposed patch Clearing flags on attachment: 62953 Committed r64285: <http://trac.webkit.org/changeset/64285> 257737 3 ossy 2010-07-29 09:38:31 -0700 All reviewed patches have been landed. Closing bug. 62953 2010-07-29 09:05:14 -0700 2010-07-29 09:36:43 -0700 proposed patch 2.patch text/plain 1032 ossy SW5kZXg6IER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5PYmplY3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5P YmplY3QuY3BwCShyZXZpc2lvbiA2NDI4MCkKKysrIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2Fw ZVBsdWdJbi9QbHVnaW5PYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNiArMTE2LDkg QEAKICAgICBwbHVnaW5IYXNQcm9wZXJ0eSwKICAgICBwbHVnaW5HZXRQcm9wZXJ0eSwKICAgICBw bHVnaW5TZXRQcm9wZXJ0eSwKKyAgICAwLCAvLyBOUENsYXNzOjpyZW1vdmVQcm9wZXJ0eQorICAg IDAsIC8vIE5QQ2xhc3M6OmVudW1lcmF0ZQorICAgIDAgIC8vIE5QQ2xhc3M6OmNvbnN0cnVjdAog fTsKIAogTlBDbGFzcyAqZ2V0UGx1Z2luQ2xhc3Modm9pZCkKSW5kZXg6IENoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY0MjgwKQorKysgQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMjkgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbml0aWFsaXplIGFsbCBtZW1iZXJzIG9mIE5QQ2xhc3Mgc3RydWN0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMxOTMKKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5PYmplY3Qu Y3BwOgorCiAyMDEwLTA3LTI5ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBHaXZlIGZpbmQtaW5jbHVkZWQtZnJhbWV3b3JrLWhlYWRlcnMgb3VyIHN0YW5kYXJkIGxp Y2Vuc2UK