43192 2010-07-29 08:46:35 -0700 Warning fix on platforms where XP_MACOSX is undefined. 2010-07-29 09:14:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned oldest_to_newest 257698 0 ossy 2010-07-29 08:46:35 -0700 Warnings on Qt buildbot: /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:28:5: warning: "XP_MACOSX" is not defined /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:69:5: warning: "XP_MACOSX" is not defined /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:83:5: warning: "XP_MACOSX" is not defined 257699 1 62950 ossy 2010-07-29 08:48:52 -0700 Created attachment 62950 accidentally uploaded We can use #if defined(XP_MACOSX) instead of #if XP_MACOSX , because XP_MACOSX is 1 when it is defined. 257700 2 62951 ossy 2010-07-29 08:51:10 -0700 Created attachment 62951 proposed patch We can use #if defined(XP_MACOSX) instead of #if XP_MACOSX , because XP_MACOSX is 1 when it is defined. 257701 3 62951 tonikitoo 2010-07-29 08:55:47 -0700 Comment on attachment 62951 proposed patch r=me , can you wait green builtbots before commit, please? 257715 4 62951 ossy 2010-07-29 09:14:03 -0700 Comment on attachment 62951 proposed patch Clearing flags on attachment: 62951 Committed r64282: <http://trac.webkit.org/changeset/64282> 257716 5 ossy 2010-07-29 09:14:11 -0700 All reviewed patches have been landed. Closing bug. 62950 2010-07-29 08:48:52 -0700 2010-07-29 08:49:56 -0700 accidentally uploaded 1.patch text/plain 1389 ossy ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvYm9yZGVycy9kaWZmZXJl bnQtY29sb3ItYm9yZGVycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9m YXN0L2JvcmRlcnMvZGlmZmVyZW50LWNvbG9yLWJvcmRlcnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBiNzhhMDcKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2JvcmRlcnMvZGlmZmVyZW50LWNvbG9yLWJvcmRl cnMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTQgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAw eDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkg c2l6ZSA4MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAK KyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1NzIKKyAgICAgIFJlbmRl ckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc4NHg2MAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4 dH0gYXQgKDAsMCkgc2l6ZSA3NjF4NjAKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0 aCA3NjE6ICJXaGVuIHR3byBib3JkZXIgc2lkZXMgaGF2ZSBkaWZmZXJlbnQgY29sb3JzLCB0aGUg ZWRnZSBqb2luaW5nIHRoZW0gc2hvdWxkIGJlIGFudGktYWxpYXNlZC4gV2hlbiB0d28gYm9yZGVy IgorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDIwKSB3aWR0aCA3NTE6ICJzaWRlcyBoYXZlIHRo ZSBzYW1lIGNvbG9yLCB0aGUgZWRnZSBqb2luaW5nIHRoZW0gc2hvdWxkIG5vdCBiZSBhbnRpLWFs aWFzZWQgYW5kIG5vIGNvcm5lciBqb2ludHMgc2hvdWxkIGJlIgorICAgICAgICAgIHRleHQgcnVu IGF0ICgwLDQwKSB3aWR0aCA1MDogInZpc2libGUuIgorICAgICAgUmVuZGVyQmxvY2sge0RJVn0g YXQgKDIwLDgwKSBzaXplIDI0MHg4MCBbYm9yZGVyOiAoMjBweCBzb2xpZCAjRkYwMDAwKSAoMjBw eCBzb2xpZCAjMDAwMDAwKV0KKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgyMCwxODApIHNp emUgMjQweDgwIFtib3JkZXI6ICgyMHB4IHNvbGlkICNGRjAwMDApICgyMHB4IHNvbGlkICMwMDAw MDApICgyMHB4IHNvbGlkICNGRjAwMDApXQorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDIw LDI4MCkgc2l6ZSAyNDB4ODAgW2JvcmRlcjogKDIwcHggc29saWQgI0ZGMDAwMCkgKDIwcHggc29s aWQgIzAwMDAwMCldCisgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMjAsMzgwKSBzaXplIDI0 MHg4MCBbYm9yZGVyOiAoMjBweCBzb2xpZCAjRkYwMDAwKSAoMjBweCBzb2xpZCAjMDAwMDAwKSAo MjBweCBzb2xpZCAjRkYwMDAwKV0K 62951 2010-07-29 08:51:10 -0700 2010-07-29 09:14:03 -0700 proposed patch 1.patch text/plain 1750 ossy SW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVn aW5PYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0 TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmgJKHJldmlzaW9uIDY0MjgwKQorKysgV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVjdC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbmNsdWRlIDxXZWJLaXQvbnBmdW5j dGlvbnMuaD4KIAotI2lmIFhQX01BQ09TWAorI2lmIGRlZmluZWQoWFBfTUFDT1NYKQogI2lmICFk ZWZpbmVkKE1BQ19PU19YX1ZFUlNJT05fMTBfNSkgfHwgTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxM T1dFRCA8IE1BQ19PU19YX1ZFUlNJT05fMTBfNQogI2RlZmluZSBCVUlMRElOR19PTl9USUdFUiAx CiAjZWxpZiAhZGVmaW5lZChNQUNfT1NfWF9WRVJTSU9OXzEwXzYpIHx8IE1BQ19PU19YX1ZFUlNJ T05fTUFYX0FMTE9XRUQgPCBNQUNfT1NfWF9WRVJTSU9OXzEwXzYKQEAgLTY2LDcgKzY2LDcgQEAK ICNpZmRlZiBYUF9NQUNPU1gKICAgICBOUEV2ZW50TW9kZWwgZXZlbnRNb2RlbDsKICNlbmRpZgot I2lmIFhQX01BQ09TWCAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikKKyNpZiBkZWZpbmVk KFhQX01BQ09TWCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpCiAgICAgdm9pZCogY29y ZUFuaW1hdGlvbkxheWVyOwogI2VuZGlmCiAgICAgTlBXaW5kb3cgbGFzdFdpbmRvdzsKQEAgLTgw LDcgKzgwLDcgQEAKIGV4dGVybiBib29sIHRlc3REb2N1bWVudE9wZW4oTlBQIG5wcCk7CiBleHRl cm4gYm9vbCB0ZXN0V2luZG93T3BlbihOUFAgbnBwKTsKIAotI2lmIFhQX01BQ09TWCAmJiAhZGVm aW5lZChCVUlMRElOR19PTl9USUdFUikKKyNpZiBkZWZpbmVkKFhQX01BQ09TWCkgJiYgIWRlZmlu ZWQoQlVJTERJTkdfT05fVElHRVIpCiBleHRlcm4gdm9pZCogY3JlYXRlQ29yZUFuaW1hdGlvbkxh eWVyKCk7CiAjZW5kaWYKIApJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNjQyODApCisrKyBXZWJLaXRUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0yOSAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdhcm5pbmcgZml4IG9uIHBsYXRmb3JtcyB3 aGVyZSBYUF9NQUNPU1ggaXMgdW5kZWZpbmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMxOTIKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rl c3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5PYmplY3QuaDoKKyAgICAgICAgVXNlICNpZiBkZWZpbmVk KFhQX01BQ09TWCkgaW5zdGVhZCBvZiAjaWYgWFBfTUFDT1NYIC4KKwogMjAxMC0wNy0yOSAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgR2l2ZSBmaW5kLWluY2x1ZGVk LWZyYW1ld29yay1oZWFkZXJzIG91ciBzdGFuZGFyZCBsaWNlbnNlCg==