43191 2010-07-29 08:39:34 -0700 [Qt] Treat warnings as errors by default for gcc 2013-11-22 08:54:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED WONTFIX Qt, QtTriaged P3 Normal --- 20721 37916 38045 43192 43193 43350 43353 43355 43356 43358 43359 43360 43412 43413 43698 43876 43920 43963 44466 44468 44593 44672 44843 44855 45246 45301 45373 45384 67778 67928 83584 1 ossy webkit-unassigned abecsi allan.jensen benjamin eric hausmann kenneth laszlo.gombos tonikitoo oldest_to_newest 257695 0 ossy 2010-07-29 08:39:34 -0700 I create this bug because of discussion in https://bugs.webkit.org/show_bug.cgi?id=30958 . I agree with Laszlo, we should treat warnings as errors to avoid breaking other platforms accidentally. The main goal of this patch is adding -Werror to QMAKE_CFLAGS, but it depends on fixing dozens of warning. First we can focus on x86-linux and x86-windows platforms and then ARM-linux and other platforms. 257697 1 ossy 2010-07-29 08:42:40 -0700 (In reply to comment #9 in https://bugs.webkit.org/show_bug.cgi?id=30958) > My only concern would be the extra pressure to fix these warnings to keep the bot green. CCing Ossy to see what he think. > A somewhat relaxed version of this - which I think we should do - is to start treating warnings as errors by default (at least on platforms where this is realistic like i386) but have a provision (e.g. environment variable) not to do this for the build bot. > This will force most developers to look into the warning but does not put extra pressure on the bot. I absolutely agree with Laszlo, it is a good way to solve this bug. 258940 2 ossy 2010-08-02 10:05:29 -0700 *** Bug 37916 has been marked as a duplicate of this bug. *** 275679 3 66858 ossy 2010-09-08 01:55:33 -0700 Created attachment 66858 enable -Werror on x86/Linux/GCC platforms I think it's time to enable -Werror on x86/Linux/GCC platforms after https://bugs.webkit.org/show_bug.cgi?id=45373 fixed. The next steps will be Windows/GCC and ARM/Linux/GCC after all warnings fixed. 275718 4 66858 kling 2010-09-08 03:35:29 -0700 Comment on attachment 66858 enable -Werror on x86/Linux/GCC platforms r=me I always feel silly when the EWS slaps me about some warning that my own machine knew about but wasn't loud enough. 275720 5 66858 ossy 2010-09-08 03:38:25 -0700 Comment on attachment 66858 enable -Werror on x86/Linux/GCC platforms cq-, because I will land manually after https://bugs.webkit.org/show_bug.cgi?id=45373 fixed 275751 6 66858 ossy 2010-09-08 04:35:11 -0700 Comment on attachment 66858 enable -Werror on x86/Linux/GCC platforms Clearing flags on attachment: 66858 Committed r66972: <http://trac.webkit.org/changeset/66972> 275901 7 ossy 2010-09-08 09:54:19 -0700 (In reply to comment #6) > (From update of attachment 66858 [details]) > Clearing flags on attachment: 66858 > > Committed r66972: <http://trac.webkit.org/changeset/66972> And a buildfix landed in http://trac.webkit.org/changeset/66990 , because linux-g++ is true when you build for maemo inside sbox, but we didn't want to enable -Werror for it now. I didn't run into this issue, because linux-g++ is false for ARM cross compiling, but linux-arm-g++ is true. 276085 8 laszlo.gombos 2010-09-08 14:49:24 -0700 Very nice, thanks for all this work ! 66858 2010-09-08 01:55:33 -0700 2010-09-08 04:35:11 -0700 enable -Werror on x86/Linux/GCC platforms 1.patch text/plain 1230 ossy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY2OTU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDkt MDggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFRyZWF0IHdhcm5pbmdzIGFz IGVycm9ycyBieSBkZWZhdWx0IGZvciBnY2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQzMTkxCisKKyAgICAgICAgKiBXZWJLaXQucHJpOiAtV2Vycm9y IGFkZGVkIHRvIFFNQUtFX0NYWEZMQUdTIGZvciB4ODYgTGludXggcGxhdGZvcm1zCisKIDIwMTAt MDktMDcgIEFybm8gUmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KIAogICAgICAgICBSZXZp ZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4OiBXZWJLaXQucHJpCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC5wcmkJKHJldmlzaW9uIDY2OTU1KQorKysgV2ViS2l0LnByaQkod29ya2luZyBjb3B5 KQpAQCAtNjYsNiArNjYsOSBAQAogQ09ORklHIC09IHdhcm5fb24KICotZysrKjpRTUFLRV9DWFhG TEFHUyArPSAtV2FsbCAtV2V4dHJhIC1XcmV0dXJuLXR5cGUgLWZuby1zdHJpY3QtYWxpYXNpbmcg LVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3JpcHRzIC1XZm9ybWF0LXNlY3VyaXR5IC1XcmV0dXJu LXR5cGUgLVduby11bnVzZWQtcGFyYW1ldGVyIC1Xbm8tc2lnbi1jb21wYXJlIC1Xbm8tc3dpdGNo IC1Xbm8tc3dpdGNoLWVudW0gLVd1bmRlZiAtV21pc3Npbmctbm9yZXR1cm4gLVdpbml0LXNlbGYK IAorIyBUcmVhdCB3YXJuaW5ncyBhcyBlcnJvcnMgb24geDg2L0xpbnV4L0dDQworbGludXgtZysr KjogUU1BS0VfQ1hYRkxBR1MgKz0gLVdlcnJvcgorCiAjIEVuYWJsZSBHTlUgY29tcGlsZXIgZXh0 ZW5zaW9ucyB0byB0aGUgQVJNIGNvbXBpbGVyIGZvciBhbGwgUXQgcG9ydHMgdXNpbmcgUlZDVAog c3ltYmlhbnwqLWFybWNjIHsKICAgICBSVkNUX0NPTU1PTl9DRkxBR1MgPSAtLWdudSAtLWRpYWdf c3VwcHJlc3MgNjgsMTExLDE3NywzNjgsODMwLDEyOTMK