43183 2010-07-29 02:24:03 -0700 Web Inspector: Crash on refresh with a comment selected in the Elements panel 2010-07-30 01:44:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 257594 0 apavlov 2010-07-29 02:24:03 -0700 1) Open the following HTML file: <!-- 111 --> 2) Bring up the WebInspector and select the comment "111" in the Elements panel. 3) Refresh the inspected page by hitting Ctrl-R in the inspector a couple times. A crash occurs. 257602 1 62932 apavlov 2010-07-29 03:01:22 -0700 Created attachment 62932 [PATCH] Suggested solution 257603 2 apavlov 2010-07-29 03:01:49 -0700 Upstreamed issue http://code.google.com/p/chromium/issues/detail?id=50207 257607 3 62933 apavlov 2010-07-29 03:11:04 -0700 Created attachment 62933 [PATCH] A more bulletproof fix. Returns 0 instead of the document element if the node path is empty 257608 4 apavlov 2010-07-29 03:11:48 -0700 Also http://code.google.com/p/chromium/issues/detail?id=49550 in Chromium bugs 258089 5 apavlov 2010-07-30 01:44:54 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/front-end/ElementsPanel.js Committed r64341 62932 2010-07-29 03:01:22 -0700 2010-07-29 03:11:04 -0700 [PATCH] Suggested solution reloadcrash.patch text/plain 1994 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDU5NmE0ZC4uMzA2YTBmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0yOSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENyYXNoIG9uIHJlZnJlc2ggd2l0 aCBhIGNvbW1lbnQgc2VsZWN0ZWQgaW4gdGhlIEVsZW1lbnRzIHBhbmVsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzE4MworCisgICAgICAgICogaW5z cGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rv ckRPTUFnZW50Ojpub2RlRm9yUGF0aCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJv dG90eXBlLnJlc2V0KToKKwogMjAxMC0wNy0yNyAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggYWQ0MDQ2NC4uMmI4NTUzZiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtMTU2MCw3ICsxNTYw LDcgQEAgTm9kZSogSW5zcGVjdG9yRE9NQWdlbnQ6Om5vZGVGb3JQYXRoKGNvbnN0IFN0cmluZyYg cGF0aCkKIAogICAgIFZlY3RvcjxTdHJpbmc+IHBhdGhUb2tlbnM7CiAgICAgcGF0aC5zcGxpdCgi LCIsIGZhbHNlLCBwYXRoVG9rZW5zKTsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHBhdGhU b2tlbnMuc2l6ZSgpIC0gMTsgaSArPSAyKSB7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBw YXRoVG9rZW5zLnNpemUoKTsgaSArPSAyKSB7CiAgICAgICAgIGJvb2wgc3VjY2VzcyA9IHRydWU7 CiAgICAgICAgIHVuc2lnbmVkIGNoaWxkTnVtYmVyID0gcGF0aFRva2Vuc1tpXS50b1VJbnQoJnN1 Y2Nlc3MpOwogICAgICAgICBpZiAoIXN1Y2Nlc3MpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1BhbmVsLmpzCmluZGV4IGVjOTU1OWYuLjU1N2E4YmQgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCkBAIC0xNjEsNyArMTYxLDcg QEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICBpZiAo dGhpcy5mb2N1c2VkRE9NTm9kZSkgewogICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRQYXRoT25S ZXNldCA9IFtdOwogICAgICAgICAgICAgdmFyIG5vZGUgPSB0aGlzLmZvY3VzZWRET01Ob2RlOwot ICAgICAgICAgICAgd2hpbGUgKCJpbmRleCIgaW4gbm9kZSkgeworICAgICAgICAgICAgd2hpbGUg KCJpbmRleCIgaW4gbm9kZSAmJiBub2RlLm5vZGVOYW1lICYmIG5vZGUubm9kZU5hbWUubGVuZ3Ro KSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRQYXRoT25SZXNldC5wdXNoKG5vZGUu bm9kZU5hbWUpOwogICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkUGF0aE9uUmVzZXQucHVz aChub2RlLmluZGV4KTsKICAgICAgICAgICAgICAgICBub2RlID0gbm9kZS5wYXJlbnROb2RlOwo= 62933 2010-07-29 03:11:04 -0700 2010-07-30 01:29:49 -0700 [PATCH] A more bulletproof fix. Returns 0 instead of the document element if the node path is empty reloadcrash.patch text/plain 1962 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDU5NmE0ZC4uMzA2YTBmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0yOSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENyYXNoIG9uIHJlZnJlc2ggd2l0 aCBhIGNvbW1lbnQgc2VsZWN0ZWQgaW4gdGhlIEVsZW1lbnRzIHBhbmVsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzE4MworCisgICAgICAgICogaW5z cGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rv ckRPTUFnZW50Ojpub2RlRm9yUGF0aCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJv dG90eXBlLnJlc2V0KToKKwogMjAxMC0wNy0yNyAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggYWQ0MDQ2NC4uMDc1OTQ0YSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtMTU2MCw2ICsxNTYw LDggQEAgTm9kZSogSW5zcGVjdG9yRE9NQWdlbnQ6Om5vZGVGb3JQYXRoKGNvbnN0IFN0cmluZyYg cGF0aCkKIAogICAgIFZlY3RvcjxTdHJpbmc+IHBhdGhUb2tlbnM7CiAgICAgcGF0aC5zcGxpdCgi LCIsIGZhbHNlLCBwYXRoVG9rZW5zKTsKKyAgICBpZiAoIXBhdGhUb2tlbnMuc2l6ZSgpKQorICAg ICAgICByZXR1cm4gMDsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHBhdGhUb2tlbnMuc2l6 ZSgpIC0gMTsgaSArPSAyKSB7CiAgICAgICAgIGJvb2wgc3VjY2VzcyA9IHRydWU7CiAgICAgICAg IHVuc2lnbmVkIGNoaWxkTnVtYmVyID0gcGF0aFRva2Vuc1tpXS50b1VJbnQoJnN1Y2Nlc3MpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMg Yi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcwppbmRleCBlYzk1 NTlmLi41NTdhOGJkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxl bWVudHNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQ YW5lbC5qcwpAQCAtMTYxLDcgKzE2MSw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnBy b3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRoaXMuZm9jdXNlZERPTU5vZGUpIHsKICAgICAgICAg ICAgIHRoaXMuX3NlbGVjdGVkUGF0aE9uUmVzZXQgPSBbXTsKICAgICAgICAgICAgIHZhciBub2Rl ID0gdGhpcy5mb2N1c2VkRE9NTm9kZTsKLSAgICAgICAgICAgIHdoaWxlICgiaW5kZXgiIGluIG5v ZGUpIHsKKyAgICAgICAgICAgIHdoaWxlICgiaW5kZXgiIGluIG5vZGUgJiYgbm9kZS5ub2RlTmFt ZSAmJiBub2RlLm5vZGVOYW1lLmxlbmd0aCkgewogICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVj dGVkUGF0aE9uUmVzZXQucHVzaChub2RlLm5vZGVOYW1lKTsKICAgICAgICAgICAgICAgICB0aGlz Ll9zZWxlY3RlZFBhdGhPblJlc2V0LnB1c2gobm9kZS5pbmRleCk7CiAgICAgICAgICAgICAgICAg bm9kZSA9IG5vZGUucGFyZW50Tm9kZTsK