43180 2010-07-29 01:51:27 -0700 Change permission to access methods in XMLDocumentParser.h 2019-02-06 09:02:51 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim webkit-unassigned cdumez commit-queue darin hyuki.kim oldest_to_newest 257587 0 gyuyoung.kim 2010-07-29 01:51:27 -0700 When WML is enabled, there are build breaks by 3 methods of XMLDocumentParser.h. The methods are wellFormed(), lineNumber() and columnNumber(). These methods is private accessibility. However, WMLErrorHandling.cpp file is using the methods. I am not sure if this accessibility change is correct or not. If we can't change the accessibility, We need to modify the WMLErrorHandling.cpp file. 257588 1 62928 gyuyoung.kim 2010-07-29 01:54:58 -0700 Created attachment 62928 Patch 257771 2 62928 darin 2010-07-29 11:02:37 -0700 Comment on attachment 62928 Patch This is not the right fix. If we have to make these public we will, but we should not use conditionals. Where is the code in WML that uses these? Why is it using an XMLDocumentParser* instead of a DocumentParser*? 258111 3 gyuyoung.kim 2010-07-30 03:22:58 -0700 (In reply to comment #2) > (From update of attachment 62928 [details]) > This is not the right fix. If we have to make these public we will, but we should not use conditionals. > > Where is the code in WML that uses these? Why is it using an XMLDocumentParser* instead of a DocumentParser*? The reportWMLError() of WMLErrorHandling.cpp is using these functions. It seems that the accessibility was changed by Bug 41114 - Start to clean up DocumentParser interface. But, there are no the reasons in the bug. Frankly, I don't know why this WMLErrorHandling.cpp uses XMLDocumentParser.cpp yet. I am trying to trace the reason via log. I suspects that WML guys uses XMLDocumentParser to handle error via these functions. In my opinion, there are two solutions. One is we change these functions's accessibility with public. As you said, other is that we don't use XMLDocumentParser in WMLErrorHandling.cpp. 258329 4 darin 2010-07-30 12:24:14 -0700 (In reply to comment #3) > In my opinion, there are two solutions. One is we change these functions's accessibility with public. As you said, other is that we don't use XMLDocumentParser in WMLErrorHandling.cpp. I think making them public is fine. 260307 5 63523 gyuyoung.kim 2010-08-04 17:53:49 -0700 Created attachment 63523 Patch Sorry for my late response. I was summer vacation. Ok, I change the accessibility with public. Please review this patch. :) 260597 6 63523 darin 2010-08-05 07:27:10 -0700 Comment on attachment 63523 Patch > + // WMLErrorHandling uses these methods. In future, please use the C++ term, functions, rather than calling these methods. 261008 7 gyuyoung.kim 2010-08-05 18:21:59 -0700 (In reply to comment #6) > (From update of attachment 63523 [details]) > > + // WMLErrorHandling uses these methods. > > In future, please use the C++ term, functions, rather than calling these methods. Ok, I keep in mind. Thank you. 261013 8 gyuyoung.kim 2010-08-05 18:26:16 -0700 Hello darin, It seems that reviewed patch doesn't pass style error for gtk. However, I don't know why this patch cannot pass the gtk style error. If there are no style errors, could you commit this patch manually ? But, if I need to modify this patch, please let me know. Thank you. 261024 9 63676 gyuyoung.kim 2010-08-05 18:36:01 -0700 Created attachment 63676 Patch for commit Hello Darin, I change "methods' with "functions" for commit. :) 261043 10 darin 2010-08-05 19:35:35 -0700 (In reply to comment #8) > It seems that reviewed patch doesn't pass style error for gtk. That’s incorrect. I just reviewed the patch before the GTK EWS bot got a chance to compile it, and once reviewed the bots stop processing a path. There is nothing wrong with the patch. 261044 11 63523 darin 2010-08-05 19:36:07 -0700 Comment on attachment 63523 Patch Clear the flags on the older patch. 261303 12 63676 commit-queue 2010-08-06 09:43:57 -0700 Comment on attachment 63676 Patch for commit Clearing flags on attachment: 63676 Committed r64855: <http://trac.webkit.org/changeset/64855> 261304 13 commit-queue 2010-08-06 09:44:02 -0700 All reviewed patches have been landed. Closing bug. 1502855 14 lforschler 2019-02-06 09:02:51 -0800 Mass moving XML DOM bugs to the "DOM" Component. 62928 2010-07-29 01:54:58 -0700 2010-08-04 17:53:49 -0700 Patch patch-wml-xmldoc.txt text/plain 1907 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaGFuZ2UgcGVybWlzc2lvbiB0byBhY2Nlc3MgbWV0aG9kcyBpbiBYTUxEb2N1bWVudFBh cnNlci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MzE4MAorCisgICAgICAgIENoYW5nZSBwZXJtaXNzaW9uIHRvIGFjY2VzcyB3ZWxsRm9ybWVkKCks IGxpbmVOdW1iZXIoKSBhbmQgY29sdW1uTnVtYmVyKCkKKyAgICAgICAgaW4gWE1MRG9jdW1lbnRQ YXJzZXIuaC4gQmVjYXVzZSwgdGhlIG1ldGhvZHMgYXJlIHVzZWQgYnkgV01MLgorCisgICAgICAg ICogZG9tL1hNTERvY3VtZW50UGFyc2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVu dFBhcnNlcjo6d2VsbEZvcm1lZCk6IENoYW5nZSBhY2NlYmlsaXR5IHBlcm1pc3Npb24uIAorCiAy MDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRrYXJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL2RvbS9YTUxE b2N1bWVudFBhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFy c2VyLmgJKHJldmlzaW9uIDY0MjU3KQorKysgV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXIu aAkod29ya2luZyBjb3B5KQpAQCAtOTIsNiArOTIsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgc3RhdGljIGJvb2wgcGFyc2VEb2N1bWVudEZyYWdtZW50KGNvbnN0IFN0cmluZyYsIERv Y3VtZW50RnJhZ21lbnQqLCBFbGVtZW50KiBwYXJlbnQgPSAwLCBGcmFnbWVudFNjcmlwdGluZ1Bl cm1pc3Npb24gPSBGcmFnbWVudFNjcmlwdGluZ0FsbG93ZWQpOwogCisjaWYgRU5BQkxFKFdNTCkK KyAgICBwdWJsaWM6CisgICAgICAgIHZpcnR1YWwgYm9vbCB3ZWxsRm9ybWVkKCkgY29uc3QgeyBy ZXR1cm4gIW1fc2F3RXJyb3I7IH0KKyAgICAgICAgdmlydHVhbCBpbnQgbGluZU51bWJlcigpIGNv bnN0OworICAgICAgICB2aXJ0dWFsIGludCBjb2x1bW5OdW1iZXIoKSBjb25zdDsKKyNlbmRpZgog ICAgIHByaXZhdGU6CiAgICAgICAgIC8vIEZyb20gRG9jdW1lbnRQYXJzZXIKICAgICAgICAgdmly dHVhbCB2b2lkIGluc2VydChjb25zdCBTZWdtZW50ZWRTdHJpbmcmKTsKQEAgLTEwMCw5ICsxMDYs MTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIGJvb2wgZmluaXNoV2Fz Q2FsbGVkKCk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBpc1dhaXRpbmdGb3JTY3JpcHRzKCkgY29u c3Q7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBzdG9wUGFyc2luZygpOworI2lmICFFTkFCTEUoV01M KQogICAgICAgICB2aXJ0dWFsIGJvb2wgd2VsbEZvcm1lZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Nh d0Vycm9yOyB9CiAgICAgICAgIHZpcnR1YWwgaW50IGxpbmVOdW1iZXIoKSBjb25zdDsKICAgICAg ICAgdmlydHVhbCBpbnQgY29sdW1uTnVtYmVyKCkgY29uc3Q7CisjZW5kaWYKIAogICAgICAgICAv LyBmcm9tIENhY2hlZFJlc291cmNlQ2xpZW50CiAgICAgICAgIHZpcnR1YWwgdm9pZCBub3RpZnlG aW5pc2hlZChDYWNoZWRSZXNvdXJjZSopOwo= 63523 2010-08-04 17:53:49 -0700 2010-08-06 00:37:55 -0700 Patch patch-wml-parser.txt text/plain 1893 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaGFuZ2UgcGVybWlzc2lvbiB0byBhY2Nlc3MgbWV0aG9kcyBpbiBYTUxEb2N1bWVudFBh cnNlci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MzE4MAorCisgICAgICAgIENoYW5nZSBwZXJtaXNzaW9uIHRvIGFjY2VzcyB3ZWxsRm9ybWVkKCks IGxpbmVOdW1iZXIoKSBhbmQgY29sdW1uTnVtYmVyKCkKKyAgICAgICAgaW4gWE1MRG9jdW1lbnRQ YXJzZXIuaC4gQmVjYXVzZSwgdGhlIG1ldGhvZHMgYXJlIHVzZWQgYnkgV01MLgorCisgICAgICAg ICogZG9tL1hNTERvY3VtZW50UGFyc2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVu dFBhcnNlcjo6d2VsbEZvcm1lZCk6IENoYW5nZSBhY2NlYmlsaXR5IHBlcm1pc3Npb24uIAorCiAy MDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRrYXJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL2RvbS9YTUxE b2N1bWVudFBhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFy c2VyLmgJKHJldmlzaW9uIDY0MjU3KQorKysgV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXIu aAkod29ya2luZyBjb3B5KQpAQCAtOTIsNiArOTIsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgc3RhdGljIGJvb2wgcGFyc2VEb2N1bWVudEZyYWdtZW50KGNvbnN0IFN0cmluZyYsIERv Y3VtZW50RnJhZ21lbnQqLCBFbGVtZW50KiBwYXJlbnQgPSAwLCBGcmFnbWVudFNjcmlwdGluZ1Bl cm1pc3Npb24gPSBGcmFnbWVudFNjcmlwdGluZ0FsbG93ZWQpOwogCisgICAgICAgIC8vIFdNTEVy cm9ySGFuZGxpbmcgdXNlcyB0aGVzZSBtZXRob2RzLgorICAgICAgICB2aXJ0dWFsIGJvb2wgd2Vs bEZvcm1lZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Nhd0Vycm9yOyB9CisgICAgICAgIHZpcnR1YWwg aW50IGxpbmVOdW1iZXIoKSBjb25zdDsKKyAgICAgICAgdmlydHVhbCBpbnQgY29sdW1uTnVtYmVy KCkgY29uc3Q7CisKICAgICBwcml2YXRlOgogICAgICAgICAvLyBGcm9tIERvY3VtZW50UGFyc2Vy CiAgICAgICAgIHZpcnR1YWwgdm9pZCBpbnNlcnQoY29uc3QgU2VnbWVudGVkU3RyaW5nJik7CkBA IC0xMDAsOSArMTA1LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIGJv b2wgZmluaXNoV2FzQ2FsbGVkKCk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBpc1dhaXRpbmdGb3JT Y3JpcHRzKCkgY29uc3Q7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBzdG9wUGFyc2luZygpOwotICAg ICAgICB2aXJ0dWFsIGJvb2wgd2VsbEZvcm1lZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Nhd0Vycm9y OyB9Ci0gICAgICAgIHZpcnR1YWwgaW50IGxpbmVOdW1iZXIoKSBjb25zdDsKLSAgICAgICAgdmly dHVhbCBpbnQgY29sdW1uTnVtYmVyKCkgY29uc3Q7CiAKICAgICAgICAgLy8gZnJvbSBDYWNoZWRS ZXNvdXJjZUNsaWVudAogICAgICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5RmluaXNoZWQoQ2FjaGVk UmVzb3VyY2UqKTsK 63676 2010-08-05 18:36:01 -0700 2010-08-06 09:43:56 -0700 Patch for commit patch-wml-parser.txt text/plain 1895 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaGFuZ2UgcGVybWlzc2lvbiB0byBhY2Nlc3MgbWV0aG9kcyBpbiBYTUxEb2N1bWVudFBh cnNlci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MzE4MAorCisgICAgICAgIENoYW5nZSBwZXJtaXNzaW9uIHRvIGFjY2VzcyB3ZWxsRm9ybWVkKCks IGxpbmVOdW1iZXIoKSBhbmQgY29sdW1uTnVtYmVyKCkKKyAgICAgICAgaW4gWE1MRG9jdW1lbnRQ YXJzZXIuaC4gQmVjYXVzZSwgdGhlIG1ldGhvZHMgYXJlIHVzZWQgYnkgV01MLgorCisgICAgICAg ICogZG9tL1hNTERvY3VtZW50UGFyc2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVu dFBhcnNlcjo6d2VsbEZvcm1lZCk6IENoYW5nZSBhY2NlYmlsaXR5IHBlcm1pc3Npb24uIAorCiAy MDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRrYXJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL2RvbS9YTUxE b2N1bWVudFBhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFy c2VyLmgJKHJldmlzaW9uIDY0MjU3KQorKysgV2ViQ29yZS9kb20vWE1MRG9jdW1lbnRQYXJzZXIu aAkod29ya2luZyBjb3B5KQpAQCAtOTIsNiArOTIsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgc3RhdGljIGJvb2wgcGFyc2VEb2N1bWVudEZyYWdtZW50KGNvbnN0IFN0cmluZyYsIERv Y3VtZW50RnJhZ21lbnQqLCBFbGVtZW50KiBwYXJlbnQgPSAwLCBGcmFnbWVudFNjcmlwdGluZ1Bl cm1pc3Npb24gPSBGcmFnbWVudFNjcmlwdGluZ0FsbG93ZWQpOwogCisgICAgICAgIC8vIFdNTEVy cm9ySGFuZGxpbmcgdXNlcyB0aGVzZSBmdW5jdGlvbnMuCisgICAgICAgIHZpcnR1YWwgYm9vbCB3 ZWxsRm9ybWVkKCkgY29uc3QgeyByZXR1cm4gIW1fc2F3RXJyb3I7IH0KKyAgICAgICAgdmlydHVh bCBpbnQgbGluZU51bWJlcigpIGNvbnN0OworICAgICAgICB2aXJ0dWFsIGludCBjb2x1bW5OdW1i ZXIoKSBjb25zdDsKKwogICAgIHByaXZhdGU6CiAgICAgICAgIC8vIEZyb20gRG9jdW1lbnRQYXJz ZXIKICAgICAgICAgdmlydHVhbCB2b2lkIGluc2VydChjb25zdCBTZWdtZW50ZWRTdHJpbmcmKTsK QEAgLTEwMCw5ICsxMDUsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwg Ym9vbCBmaW5pc2hXYXNDYWxsZWQoKTsKICAgICAgICAgdmlydHVhbCBib29sIGlzV2FpdGluZ0Zv clNjcmlwdHMoKSBjb25zdDsKICAgICAgICAgdmlydHVhbCB2b2lkIHN0b3BQYXJzaW5nKCk7Ci0g ICAgICAgIHZpcnR1YWwgYm9vbCB3ZWxsRm9ybWVkKCkgY29uc3QgeyByZXR1cm4gIW1fc2F3RXJy b3I7IH0KLSAgICAgICAgdmlydHVhbCBpbnQgbGluZU51bWJlcigpIGNvbnN0OwotICAgICAgICB2 aXJ0dWFsIGludCBjb2x1bW5OdW1iZXIoKSBjb25zdDsKIAogICAgICAgICAvLyBmcm9tIENhY2hl ZFJlc291cmNlQ2xpZW50CiAgICAgICAgIHZpcnR1YWwgdm9pZCBub3RpZnlGaW5pc2hlZChDYWNo ZWRSZXNvdXJjZSopOwo=