43177 2010-07-29 00:48:52 -0700 [WML] Include FormDataBuilder.h in WMLGoElement.h 2010-08-07 20:13:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned eric oldest_to_newest 257578 0 gyuyoung.kim 2010-07-29 00:48:52 -0700 There are build breaks because of WMLGoElement.cpp as below, /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp: In member function ‘void WebCore::WMLGoElement::preparePOSTRequest(WebCore::ResourceRequest&, bool, const WebCore::String&)’: /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:159: error: ‘FormDataBuilder’ has not been declared /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp: In member function ‘WTF::PassRefPtr<WebCore::FormData> WebCore::WMLGoElement::createFormData(const WTF::CString&)’: /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:192: error: ‘FormDataBuilder’ has not been declared /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:203: error: ‘FormDataBuilder’ has not been declared /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:204: error: ‘FormDataBuilder’ has not been declared /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:212: error: ‘FormDataBuilder’ has not been declared /home/gyuyoung/webkit/WebKit-EFL/WebCore/wml/WMLGoElement.cpp:216: error: ‘FormDataBuilder’ has not been declared make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLGoElement.cpp.o] error 1 make[1]: *** [WebCore/CMakeFiles/webcore_efl.dir/all] error 2 In order to fix these breaks, FormDataBuilder.h needs to be included in WMLGoElement.cpp. 257579 1 62926 gyuyoung.kim 2010-07-29 00:52:23 -0700 Created attachment 62926 patch 261403 2 62926 eric 2010-08-06 13:06:44 -0700 Comment on attachment 62926 patch OK. 261818 3 62926 eric 2010-08-07 20:13:41 -0700 Comment on attachment 62926 patch Clearing flags on attachment: 62926 Committed r64932: <http://trac.webkit.org/changeset/64932> 261819 4 eric 2010-08-07 20:13:46 -0700 All reviewed patches have been landed. Closing bug. 62926 2010-07-29 00:52:23 -0700 2010-08-07 20:13:41 -0700 patch patch-wml-formdata.txt text/plain 1017 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBJbmNsdWRlIEZvcm1EYXRhQnVpbGRlci5oIGluIFdNTEdvRWxlbWVudC5oCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzE3NworCisg ICAgICAgIFRvIGZpeCBidWlsZCBicmVha3MgaW4gV01MR29FbGVtZW50LmNwcCwgRm9ybURhdGFC dWlsZGVyLmggbmVlZHMgdG8gYmUgaW5jbHVkZWQuCisKKyAgICAgICAgKiB3bWwvV01MR29FbGVt ZW50LmNwcDogSW5jbHVkZSBGb3JtRGF0YUJ1aWxkZXIuaAorCiAyMDEwLTA3LTI4ICBLYXZpdGEg S2FuZXRrYXIgIDxra2FuZXRrYXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL3dtbC9XTUxHb0VsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTEdvRWxlbWVudC5jcHAJKHJldmlzaW9uIDY0MjU3KQor KysgV2ViQ29yZS93bWwvV01MR29FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUsNiAr MjUsNyBAQAogCiAjaW5jbHVkZSAiQXR0cmlidXRlLmgiCiAjaW5jbHVkZSAiRm9ybURhdGEuaCIK KyNpbmNsdWRlICJGb3JtRGF0YUJ1aWxkZXIuaCIKICNpbmNsdWRlICJGb3JtU3VibWlzc2lvbi5o IgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2FkZXIuaCIK