43176 2010-07-29 00:31:43 -0700 [WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement 2010-08-07 20:01:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned eric hyuki.kim ryuan.choi webkit.review.bot oldest_to_newest 257573 0 gyuyoung.kim 2010-07-29 00:31:43 -0700 An parameter was added to defaultEventHandler() of SelectElement. So, WMLSelectElement should use the defaultEventHandler with 4 parameters. However, the new parameter is HTMLFormElement. It is difficult to set the HTMLFormElement in WMLSelectElement.cpp. For now, I add NULL instead of the HTMLFormElement in order to prevent build break when wml is enabled. IMO, this issue should be fixed later. 257574 1 62924 gyuyoung.kim 2010-07-29 00:33:52 -0700 Created attachment 62924 Patch 257575 2 webkit.review.bot 2010-07-29 00:35:09 -0700 Attachment 62924 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/wml/WMLSelectElement.cpp:170: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 257576 3 62925 gyuyoung.kim 2010-07-29 00:43:05 -0700 Created attachment 62925 patch I change NULL with 0. 261816 4 62925 eric 2010-08-07 20:01:03 -0700 Comment on attachment 62925 patch Clearing flags on attachment: 62925 Committed r64931: <http://trac.webkit.org/changeset/64931> 261817 5 eric 2010-08-07 20:01:08 -0700 All reviewed patches have been landed. Closing bug. 62924 2010-07-29 00:33:52 -0700 2010-07-29 00:43:05 -0700 Patch patch-wml-eventhandler.txt text/plain 1258 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBBZGQgZHVtbXkgYXJndW1lbnQgdG8gU2VsZWN0RWxlbWVudDo6ZGVmYXVsdEV2 ZW50SGFuZGxlcigpIGluIFdNTFNlbGVjdEVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMTc2CisKKyAgICAgICAgKiB3bWwvV01MU2VsZWN0 RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxTZWxlY3RFbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKTogU2V0cyBOVUxMIHBhcmFtZXRlciB0byBTZWxlY3RFbGVtZW50OjpkZWZh dWx0RXZlbnRIYW5kbGVyLgorCiAyMDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRr YXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCklu ZGV4OiBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmNwcAkocmV2aXNpb24gNjQyNTcpCisrKyBXZWJDb3Jl L3dtbC9XTUxTZWxlY3RFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY3LDcgKzE2Nyw3 IEBAIHZvaWQgV01MU2VsZWN0RWxlbWVudDo6cmVzZXQoKQogCiB2b2lkIFdNTFNlbGVjdEVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogewotICAgIFNlbGVjdEVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIobV9kYXRhLCB0aGlzLCBldmVudCk7CisgICAgU2VsZWN0 RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihtX2RhdGEsIHRoaXMsIGV2ZW50LCBOVUxMKTsK IAogICAgIC8vIEZJWE1FOiBUaGVyZSBtdXN0IGJlIGEgYmV0dGVyIHBsYWNlIHRvIHVwZGF0ZSB0 aGUgcGFnZSB2YXJpYWJsZSBzdGF0ZS4gSW52ZXN0aWdhdGUuCiAgICAgdXBkYXRlVmFyaWFibGVz KCk7Cg== 62925 2010-07-29 00:43:05 -0700 2010-08-07 20:01:03 -0700 patch patch-wml-eventhandler.txt text/plain 1255 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBBZGQgZHVtbXkgYXJndW1lbnQgdG8gU2VsZWN0RWxlbWVudDo6ZGVmYXVsdEV2 ZW50SGFuZGxlcigpIGluIFdNTFNlbGVjdEVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMTc2CisKKyAgICAgICAgKiB3bWwvV01MU2VsZWN0 RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxTZWxlY3RFbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKTogU2V0cyBOVUxMIHBhcmFtZXRlciB0byBTZWxlY3RFbGVtZW50OjpkZWZh dWx0RXZlbnRIYW5kbGVyLgorCiAyMDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRr YXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCklu ZGV4OiBXZWJDb3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3dtbC9XTUxTZWxlY3RFbGVtZW50LmNwcAkocmV2aXNpb24gNjQyNTcpCisrKyBXZWJDb3Jl L3dtbC9XTUxTZWxlY3RFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY3LDcgKzE2Nyw3 IEBAIHZvaWQgV01MU2VsZWN0RWxlbWVudDo6cmVzZXQoKQogCiB2b2lkIFdNTFNlbGVjdEVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogewotICAgIFNlbGVjdEVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIobV9kYXRhLCB0aGlzLCBldmVudCk7CisgICAgU2VsZWN0 RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihtX2RhdGEsIHRoaXMsIGV2ZW50LCAwKTsKIAog ICAgIC8vIEZJWE1FOiBUaGVyZSBtdXN0IGJlIGEgYmV0dGVyIHBsYWNlIHRvIHVwZGF0ZSB0aGUg cGFnZSB2YXJpYWJsZSBzdGF0ZS4gSW52ZXN0aWdhdGUuCiAgICAgdXBkYXRlVmFyaWFibGVzKCk7 Cg==