43175 2010-07-29 00:18:42 -0700 [WML] Change getIDAttribute() with getIdAttribute() 2010-08-07 23:32:37 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned commit-queue eric hyuki.kim oldest_to_newest 257570 0 gyuyoung.kim 2010-07-29 00:18:42 -0700 Element class doesn't support getIDAttribute() anymore. So, WMLCardElement.cpp should not use the getIDAttribute() as well. I fix this problem. 257572 1 62923 gyuyoung.kim 2010-07-29 00:22:34 -0700 Created attachment 62923 Patch 261402 2 62923 eric 2010-08-06 13:05:56 -0700 Comment on attachment 62923 Patch Is this the right change? idForStyleResolution() doesn't sound like what you want here... 261633 3 63797 gyuyoung.kim 2010-08-06 20:03:59 -0700 Created attachment 63797 Patch Oops, sorry. This was my mistake. I change getIDAttribute() with getIdAttribute(). The function's name was changed with getIdAttribute(). 261840 4 63797 eric 2010-08-07 23:32:32 -0700 Comment on attachment 63797 Patch Clearing flags on attachment: 63797 Committed r64940: <http://trac.webkit.org/changeset/64940> 261841 5 eric 2010-08-07 23:32:37 -0700 All reviewed patches have been landed. Closing bug. 62923 2010-07-29 00:22:34 -0700 2010-08-06 20:03:59 -0700 Patch patch-wml-idattribute.txt text/plain 1197 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBDaGFuZ2UgZ2V0SURBdHRyaWJ1dGUoKSB3aXRoIGlkRm9yU3R5bGVSZXNvbHV0 aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQz MTc1CisKKyAgICAgICAgKiB3bWwvV01MQ2FyZEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V01MQ2FyZEVsZW1lbnQ6OmZpbmROYW1lZENhcmRJbkRvY3VtZW50KTogQ2hhbmdlIGdldElE QXR0cmlidXRlKCkgd2l0aCBpZEZvclN0eWxlUmVzb2x1dGlvbigpLgorCiAyMDEwLTA3LTI4ICBL YXZpdGEgS2FuZXRrYXIgIDxra2FuZXRrYXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL3dtbC9XTUxDYXJkRWxlbWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93bWwvV01MQ2FyZEVsZW1lbnQuY3BwCShyZXZpc2lv biA2NDI1NykKKysrIFdlYkNvcmUvd21sL1dNTENhcmRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjg3LDcgKzI4Nyw3IEBAIFdNTENhcmRFbGVtZW50KiBXTUxDYXJkRWxlbWVudDo6Zmlu ZE5hbWUKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAg ICAgICBXTUxDYXJkRWxlbWVudCogY2FyZCA9IHN0YXRpY19jYXN0PFdNTENhcmRFbGVtZW50Kj4o bm9kZUxpc3QtPml0ZW0oaSkpOwotICAgICAgICBpZiAoY2FyZC0+Z2V0SURBdHRyaWJ1dGUoKSAh PSBjYXJkTmFtZSkKKyAgICAgICAgaWYgKGNhcmQtPmlkRm9yU3R5bGVSZXNvbHV0aW9uKCkgIT0g Y2FyZE5hbWUpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICByZXR1cm4gY2FyZDsK 63797 2010-08-06 20:03:59 -0700 2010-08-07 23:32:31 -0700 Patch patch-wml-idattribute.txt text/plain 1281 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMjkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBDaGFuZ2UgZ2V0SURBdHRyaWJ1dGUoKSB3aXRoIGdldElkQXR0cmlidXRlKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMTc1CisK KyAgICAgICAgQ2hhbmdlIGdldElEQXR0cmlidXRlKCkgd2l0aCBnZXRJZEF0dHJpYnV0ZSgpIGJl Y2F1c2UgZnVuY3Rpb24gCisgICAgICAgIG5hbWUgd2FzIGNoYW5nZWQuCisKKyAgICAgICAgKiB3 bWwvV01MQ2FyZEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V01MQ2FyZEVsZW1lbnQ6 OmZpbmROYW1lZENhcmRJbkRvY3VtZW50KTogQ2hhbmdlIGdldElEQXR0cmlidXRlKCkgd2l0aCBn ZXRJZEF0dHJpYnV0ZSgpLgorCiAyMDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRr YXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCklu ZGV4OiBXZWJDb3JlL3dtbC9XTUxDYXJkRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS93bWwvV01MQ2FyZEVsZW1lbnQuY3BwCShyZXZpc2lvbiA2NDI1NykKKysrIFdlYkNvcmUvd21s L1dNTENhcmRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg3LDcgKzI4Nyw3IEBAIFdN TENhcmRFbGVtZW50KiBXTUxDYXJkRWxlbWVudDo6ZmluZE5hbWUKIAogICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAgICBXTUxDYXJkRWxlbWVudCogY2Fy ZCA9IHN0YXRpY19jYXN0PFdNTENhcmRFbGVtZW50Kj4obm9kZUxpc3QtPml0ZW0oaSkpOwotICAg ICAgICBpZiAoY2FyZC0+Z2V0SURBdHRyaWJ1dGUoKSAhPSBjYXJkTmFtZSkKKyAgICAgICAgaWYg KGNhcmQtPmdldElkQXR0cmlidXRlKCkgIT0gY2FyZE5hbWUpCiAgICAgICAgICAgICBjb250aW51 ZTsKIAogICAgICAgICByZXR1cm4gY2FyZDsK