43173 2010-07-28 23:16:42 -0700 [WML] Add KURL parameter to WMLDocument::create() 2019-05-02 16:22:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned ap commit-queue eric hyuki.kim michael3myers1 oldest_to_newest 257558 0 gyuyoung.kim 2010-07-28 23:16:42 -0700 An url parameter was added to Document class. So. WMLDocument should support url parameter as well. 257560 1 62919 gyuyoung.kim 2010-07-28 23:20:31 -0700 Created attachment 62919 Patch Patch. 261019 2 gyuyoung.kim 2010-08-05 18:31:36 -0700 Hello Eric, Could you please review this patch? 261346 3 62919 eric 2010-08-06 10:45:15 -0700 Comment on attachment 62919 Patch Why? Neither your bug or your ChangeLog say why? Is this a build fix? 261624 4 63795 gyuyoung.kim 2010-08-06 19:22:40 -0700 Created attachment 63795 Patch (In reply to comment #3) > (From update of attachment 62919 [details]) > Why? Neither your bug or your ChangeLog say why? > > Is this a build fix? Yes, right. This patch is to fix build break. WMLDocument inherits Document class as below, WMLDocument::WMLDocument(Frame* frame) : Document(frame, false, false) However, the Document Class's construct parameters were changed. url was added. Document::Document(Frame* frame, const KURL& url, bool isXHTML, bool isHTML) So. I make this patch to fix build break when wml is enabled. I add comment to Changelog. 261636 5 63798 gyuyoung.kim 2010-08-06 20:10:33 -0700 Created attachment 63798 Patch Previous patch has something wrong. I upload this patch again. Thank you. 261637 6 63795 eric 2010-08-06 20:10:43 -0700 Comment on attachment 63795 Patch Looks fine. Looks like it does not apply though. 261842 7 63798 eric 2010-08-07 23:45:42 -0700 Comment on attachment 63798 Patch Clearing flags on attachment: 63798 Committed r64941: <http://trac.webkit.org/changeset/64941> 261843 8 eric 2010-08-07 23:45:48 -0700 All reviewed patches have been landed. Closing bug. 62919 2010-07-28 23:20:31 -0700 2010-08-06 19:22:40 -0700 Patch patch-wml-url.txt text/plain 1925 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMjggIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBBZGQgS1VSTCBwYXJhbWV0ZXIgdG8gV01MRG9jdW1lbnQ6OmNyZWF0ZSgpIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMxNzMKKwor ICAgICAgICAqIHdtbC9XTUxEb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxEb2N1 bWVudDo6V01MRG9jdW1lbnQpOgorICAgICAgICAqIHdtbC9XTUxEb2N1bWVudC5oOgorICAgICAg ICAoV2ViQ29yZTo6V01MRG9jdW1lbnQ6OmNyZWF0ZSk6IEFkZCBhbiB1cmwgcGFyYW1ldGVyIHRv IGNyZWF0ZSgpIG1ldGhvZAorCiAyMDEwLTA3LTI4ICBLYXZpdGEgS2FuZXRrYXIgIDxra2FuZXRr YXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCklu ZGV4OiBXZWJDb3JlL3dtbC9XTUxEb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93 bWwvV01MRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA2NDI1NykKKysrIFdlYkNvcmUvd21sL1dNTERv Y3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQsOCArMzQsOCBAQAogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKLVdNTERvY3VtZW50OjpXTUxEb2N1bWVudChGcmFtZSogZnJhbWUpCi0gICAg OiBEb2N1bWVudChmcmFtZSwgZmFsc2UsIGZhbHNlKSAKK1dNTERvY3VtZW50OjpXTUxEb2N1bWVu dChGcmFtZSogZnJhbWUsIGNvbnN0IEtVUkwmIHVybCkKKyAgICA6IERvY3VtZW50KGZyYW1lLCB1 cmwsIGZhbHNlLCBmYWxzZSkgCiAgICAgLCBtX2FjdGl2ZUNhcmQoMCkKIHsKICAgICBjbGVhclhN TFZlcnNpb24oKTsKSW5kZXg6IFdlYkNvcmUvd21sL1dNTERvY3VtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS93bWwvV01MRG9jdW1lbnQuaAkocmV2aXNpb24gNjQyNTcpCisrKyBXZWJDb3Jl L3dtbC9XTUxEb2N1bWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw5ICszMiw5IEBAIGNsYXNz IFdNTENhcmRFbGVtZW50OwogCiBjbGFzcyBXTUxEb2N1bWVudCA6IHB1YmxpYyBEb2N1bWVudCB7 CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8V01MRG9jdW1lbnQ+IGNyZWF0ZShGcmFt ZSogZnJhbWUpCisgICAgc3RhdGljIFBhc3NSZWZQdHI8V01MRG9jdW1lbnQ+IGNyZWF0ZShGcmFt ZSogZnJhbWUsIGNvbnN0IEtVUkwmIHVybCkKICAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJl ZihuZXcgV01MRG9jdW1lbnQoZnJhbWUpKTsKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBX TUxEb2N1bWVudChmcmFtZSwgdXJsKSk7CiAgICAgfQogCiAgICAgdmlydHVhbCB+V01MRG9jdW1l bnQoKTsKQEAgLTQ3LDcgKzQ3LDcgQEAgcHVibGljOgogICAgIFdNTENhcmRFbGVtZW50KiBhY3Rp dmVDYXJkKCkgY29uc3QgeyByZXR1cm4gbV9hY3RpdmVDYXJkOyB9CiAKIHByaXZhdGU6Ci0gICAg V01MRG9jdW1lbnQoRnJhbWUqKTsKKyAgICBXTUxEb2N1bWVudChGcmFtZSosIGNvbnN0IEtVUkwm KTsKICAgICBXTUxDYXJkRWxlbWVudCogbV9hY3RpdmVDYXJkOwogfTsKIAo= 63795 2010-08-06 19:22:40 -0700 2010-08-06 20:10:43 -0700 Patch patch-wml-url.txt text/plain 2041 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMjggIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV01MXSBBZGQgS1VSTCBwYXJhbWV0ZXIgdG8gV01MRG9jdW1lbnQ6OmNyZWF0ZSgpIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMxNzMKKyAK KyAgICAgICAgVG8gZml4IGJ1aWxkIGJyZWFrIGluIFdNTCwgdXJsIHBhcmFtZXRlciBpcyBhZGRl ZC4gQmVjYXVzZSwgCisgICAgICAgIERvY3VtZW50IGNsYXNzIGhhcyB1cmwgcGFyYW1ldGVyLgor CisgICAgICAgICogd21sL1dNTERvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldNTERv Y3VtZW50OjpXTUxEb2N1bWVudCk6CisgICAgICAgICogd21sL1dNTERvY3VtZW50Lmg6CisgICAg ICAgIChXZWJDb3JlOjpXTUxEb2N1bWVudDo6Y3JlYXRlKTogQWRkIGFuIHVybCBwYXJhbWV0ZXIg dG8gY3JlYXRlKCkgbWV0aG9kCisKIDIwMTAtMDctMjggIEthdml0YSBLYW5ldGthciAgPGtrYW5l dGthckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4K SW5kZXg6IFdlYkNvcmUvd21sL1dNTERvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3dtbC9XTUxEb2N1bWVudC5jcHAJKHJldmlzaW9uIDY0MjU3KQorKysgV2ViQ29yZS93bWwvV01M RG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw4ICszNCw4IEBACiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAotV01MRG9jdW1lbnQ6OldNTERvY3VtZW50KEZyYW1lKiBmcmFtZSkKLSAg ICA6IERvY3VtZW50KGZyYW1lLCBmYWxzZSwgZmFsc2UpIAorV01MRG9jdW1lbnQ6OldNTERvY3Vt ZW50KEZyYW1lKiBmcmFtZSwgY29uc3QgS1VSTCYgdXJsKQorICAgIDogRG9jdW1lbnQoZnJhbWUs IHVybCwgZmFsc2UsIGZhbHNlKSAKICAgICAsIG1fYWN0aXZlQ2FyZCgwKQogewogICAgIGNsZWFy WE1MVmVyc2lvbigpOwpJbmRleDogV2ViQ29yZS93bWwvV01MRG9jdW1lbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3dtbC9XTUxEb2N1bWVudC5oCShyZXZpc2lvbiA2NDI1NykKKysrIFdlYkNv cmUvd21sL1dNTERvY3VtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDkgKzMyLDkgQEAgY2xh c3MgV01MQ2FyZEVsZW1lbnQ7CiAKIGNsYXNzIFdNTERvY3VtZW50IDogcHVibGljIERvY3VtZW50 IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxXTUxEb2N1bWVudD4gY3JlYXRlKEZy YW1lKiBmcmFtZSkKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxXTUxEb2N1bWVudD4gY3JlYXRlKEZy YW1lKiBmcmFtZSwgY29uc3QgS1VSTCYgdXJsKQogICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0 UmVmKG5ldyBXTUxEb2N1bWVudChmcmFtZSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3 IFdNTERvY3VtZW50KGZyYW1lLCB1cmwpKTsKICAgICB9CiAKICAgICB2aXJ0dWFsIH5XTUxEb2N1 bWVudCgpOwpAQCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAgICAgV01MQ2FyZEVsZW1lbnQqIGFj dGl2ZUNhcmQoKSBjb25zdCB7IHJldHVybiBtX2FjdGl2ZUNhcmQ7IH0KIAogcHJpdmF0ZToKLSAg ICBXTUxEb2N1bWVudChGcmFtZSopOworICAgIFdNTERvY3VtZW50KEZyYW1lKiwgY29uc3QgS1VS TCYpOwogICAgIFdNTENhcmRFbGVtZW50KiBtX2FjdGl2ZUNhcmQ7CiB9OwogCg== 63798 2010-08-06 20:10:33 -0700 2010-08-07 23:45:42 -0700 Patch patch-wml-url.txt text/plain 2038 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDI2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMjggIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1dNTF0gQWRkIEtVUkwgcGFyYW1ldGVyIHRvIFdNTERvY3VtZW50OjpjcmVhdGUoKSAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMTczCisKKyAg ICAgICAgVG8gZml4IGJ1aWxkIGJyZWFrIGluIFdNTCwgdXJsIHBhcmFtZXRlciBpcyBhZGRlZC4g QmVjYXVzZSwgCisgICAgICAgIERvY3VtZW50IGNsYXNzIGhhcyB1cmwgcGFyYW1ldGVyLgorCisg ICAgICAgICogd21sL1dNTERvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldNTERvY3Vt ZW50OjpXTUxEb2N1bWVudCk6CisgICAgICAgICogd21sL1dNTERvY3VtZW50Lmg6CisgICAgICAg IChXZWJDb3JlOjpXTUxEb2N1bWVudDo6Y3JlYXRlKTogQWRkIGFuIHVybCBwYXJhbWV0ZXIgdG8g Y3JlYXRlKCkgbWV0aG9kCisKIDIwMTAtMDctMjggIEthdml0YSBLYW5ldGthciAgPGtrYW5ldGth ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5k ZXg6IFdlYkNvcmUvd21sL1dNTERvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dt bC9XTUxEb2N1bWVudC5jcHAJKHJldmlzaW9uIDY0MjU3KQorKysgV2ViQ29yZS93bWwvV01MRG9j dW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw4ICszNCw4IEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotV01MRG9jdW1lbnQ6OldNTERvY3VtZW50KEZyYW1lKiBmcmFtZSkKLSAgICA6 IERvY3VtZW50KGZyYW1lLCBmYWxzZSwgZmFsc2UpIAorV01MRG9jdW1lbnQ6OldNTERvY3VtZW50 KEZyYW1lKiBmcmFtZSwgY29uc3QgS1VSTCYgdXJsKQorICAgIDogRG9jdW1lbnQoZnJhbWUsIHVy bCwgZmFsc2UsIGZhbHNlKSAKICAgICAsIG1fYWN0aXZlQ2FyZCgwKQogewogICAgIGNsZWFyWE1M VmVyc2lvbigpOwpJbmRleDogV2ViQ29yZS93bWwvV01MRG9jdW1lbnQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3dtbC9XTUxEb2N1bWVudC5oCShyZXZpc2lvbiA2NDI1NykKKysrIFdlYkNvcmUv d21sL1dNTERvY3VtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDkgKzMyLDkgQEAgY2xhc3Mg V01MQ2FyZEVsZW1lbnQ7CiAKIGNsYXNzIFdNTERvY3VtZW50IDogcHVibGljIERvY3VtZW50IHsK IHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxXTUxEb2N1bWVudD4gY3JlYXRlKEZyYW1l KiBmcmFtZSkKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxXTUxEb2N1bWVudD4gY3JlYXRlKEZyYW1l KiBmcmFtZSwgY29uc3QgS1VSTCYgdXJsKQogICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVm KG5ldyBXTUxEb2N1bWVudChmcmFtZSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdN TERvY3VtZW50KGZyYW1lLCB1cmwpKTsKICAgICB9CiAKICAgICB2aXJ0dWFsIH5XTUxEb2N1bWVu dCgpOwpAQCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAgICAgV01MQ2FyZEVsZW1lbnQqIGFjdGl2 ZUNhcmQoKSBjb25zdCB7IHJldHVybiBtX2FjdGl2ZUNhcmQ7IH0KIAogcHJpdmF0ZToKLSAgICBX TUxEb2N1bWVudChGcmFtZSopOworICAgIFdNTERvY3VtZW50KEZyYW1lKiwgY29uc3QgS1VSTCYp OwogICAgIFdNTENhcmRFbGVtZW50KiBtX2FjdGl2ZUNhcmQ7CiB9OwogCg==