43167 2010-07-28 18:17:54 -0700 SHOULD NEVER BE REACHED assertion when switching tabs with composited content 2010-07-29 11:43:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 257508 0 62909 simon.fraser 2010-07-28 18:17:54 -0700 Created attachment 62909 Testcase Load the attached testcase in Safari, switch to another tab, then switch back. You often hit: SHOULD NEVER BE REACHED (RenderLayerBacking.cpp:941 void WebCore::RenderLayerBacking::paintIntoLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, const WebCore::IntRect&, WebCore::PaintBehavior, WebCore::GraphicsLayerPaintingPhase, WebCore::RenderObject*)) 257772 1 simon.fraser 2010-07-29 11:04:56 -0700 The issue here is that as the root layer attachment changes, setDrawsContent(true) gets called on the RenderView's compositing layer, which in turn cause a -setNeedsDisplay. That should never happen. 257778 2 62970 simon.fraser 2010-07-29 11:15:16 -0700 Created attachment 62970 Patch 257783 3 62970 darin 2010-07-29 11:18:57 -0700 Comment on attachment 62970 Patch Can you land a manual test? Just an HTML file with steps to reproduce in it. We do have a directory full of manual tests, although I’m not sure we get maximum value from them. 257798 4 simon.fraser 2010-07-29 11:43:19 -0700 http://trac.webkit.org/changeset/64296, including manual test. 62909 2010-07-28 18:17:54 -0700 2010-07-28 18:17:54 -0700 Testcase backface-hidden-reflection.html text/html 623 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBt ZWRpYT0ic2NyZWVuIj4KICAgIAogICAgLmNvbnRhaW5lciB7CiAgICAgIGhlaWdodDogMTAwcHg7 CiAgICAgIHdpZHRoOjEwMHB4OwogICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKICAgICAg YmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CiAgICB9CiAgICAKICAgIC5yZWZsZWN0ZWQgewogICAg ICBoZWlnaHQ6IDEwMHB4OwogICAgICB3aWR0aDogMTAwcHg7CiAgICAgIGJhY2tncm91bmQtY29s b3I6IHJlZDsKICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHJvdGF0ZTNkKDAsIDEsIDAsIDE4MGRl Zyk7CiAgICAgIC13ZWJraXQtYm94LXJlZmxlY3Q6IGJlbG93OwogICAgICAtd2Via2l0LWJhY2tm YWNlLXZpc2liaWxpdHk6IGhpZGRlbjsKICAgIH0KICAgIAogICAgLnJlZmxlY3RlZDpob3ZlciB7 CiAgICAgIC13ZWJraXQtYmFja2ZhY2UtdmlzaWJpbGl0eTogdmlzaWJsZTsKICAgIH0KICA8L3N0 eWxlPgo8L2hlYWQ+Cjxib2R5PgogIDxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CiAgICA8ZGl2IGNs YXNzPSJyZWZsZWN0ZWQiPgogICAgPC9kaXY+CiAgPC9kaXY+CjwvYm9keT4KPC9odG1sPgo= 62970 2010-07-29 11:15:16 -0700 2010-07-29 11:18:57 -0700 Patch bug-43167-20100729111515.patch text/plain 1839 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmYwZjM3NWI5YWFkNTY5NTg2NmJjMGI5N2U1OWM0ZWEwYTllZmIyYi4uNTBjOWY3NzViZDdjZjY0 NDBjOWM4YmI2ZmQ0ZWU3NzIwZGQ3YTg2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMC0wNy0yOSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTSE9VTEQgTkVWRVIgQkUgUkVBQ0hFRCBhc3Nl cnRpb24gd2hlbiBzd2l0Y2hpbmcgdGFicyB3aXRoIGNvbXBvc2l0ZWQgY29udGVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMxNjcKKworICAgICAg ICBXaGVuIHRoZSByb290IGxheWVyIGJlY29tZXMgdW5hdHRhY2hlZCAoZS5nLiB3aGVuIHN3aXRj aGluZyB0YWJzKSwgZG9uJ3QgcmV0dXJuCisgICAgICAgICdmYWxzZScgZnJvbSBwYWludGluZ0dv ZXNUb1dpbmRvdygpIGJlY2F1c2UgdGhhdCB3aWxsIGNhdXNlIGEgLXNldE5lZWRzRGlzcGF5LCB3 aGljaAorICAgICAgICBib3RoIGFsbG9jYXRlcyB3YXN0ZWZ1bCBiYWNraW5nIHN0b3JlLCBhbmQg Y2F1c2VzIGFuIGFzc2VydGlvbiB3aGVuIHdlIHRyeSB0bworICAgICAgICBwYWludCB0aGUgbGF5 ZXIuCisgICAgICAgIAorICAgICAgICBObyB0ZXN0cyBiZWNhdXNlIGl0IHJlcXVpcmVzIHRhYiBz d2l0Y2hpbmcuCisgICAgICAgIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tp bmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludGluZ0dv ZXNUb1dpbmRvdyk6CisKKzIwMTAtMDctMjkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KIAogICAgICAg ICBDcmFzaCB3aGVuIGNvbXB1dGluZyBwc2V1ZG8tc3R5bGUgb2YgYSB2YW5pc2hlZCBzY3JvbGxi YXIgaW4gaW5zcGVjdG9yCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApp bmRleCBlYTcxMTRhOGFkOGFjNGNlZjJkYTVhYzdiNWZlYzI5MTNhZDUyMDg3Li4xM2E4MTQ1MTM5 YWQ1NzM0NTliMzc0NTE2MTczOWM2ZTkzODQ2NGQ5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQmFja2luZy5jcHAKQEAgLTg3Nyw3ICs4NzcsNyBAQCBGbG9hdFBvaW50IFJlbmRlckxh eWVyQmFja2luZzo6Y29udGVudHNUb0dyYXBoaWNzTGF5ZXJDb29yZGluYXRlcyhjb25zdCBHcmFw aGljcwogYm9vbCBSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50aW5nR29lc1RvV2luZG93KCkgY29u c3QKIHsKICAgICBpZiAobV9vd25pbmdMYXllci0+aXNSb290TGF5ZXIoKSkKLSAgICAgICAgcmV0 dXJuIGNvbXBvc2l0b3IoKS0+cm9vdExheWVyQXR0YWNobWVudCgpID09IFJlbmRlckxheWVyQ29t cG9zaXRvcjo6Um9vdExheWVyQXR0YWNoZWRWaWFDaHJvbWVDbGllbnQ7CisgICAgICAgIHJldHVy biBjb21wb3NpdG9yKCktPnJvb3RMYXllckF0dGFjaG1lbnQoKSAhPSBSZW5kZXJMYXllckNvbXBv c2l0b3I6OlJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9zaW5nSWZyYW1lOwogICAgIAogICAgIHJl dHVybiBmYWxzZTsKIH0K