43162 2010-07-28 17:24:22 -0700 Add support for MADV_FREE to PageAllocation 2010-07-28 20:22:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough webkit-ews oldest_to_newest 257463 0 barraclough 2010-07-28 17:24:22 -0700 This is useful on platforms that don't have MADV_FREE_REUS(ABL)E. 257466 1 62897 barraclough 2010-07-28 17:27:52 -0700 Created attachment 62897 The patch 257468 2 62898 barraclough 2010-07-28 17:29:53 -0700 Created attachment 62898 Errk, better patch 257469 3 webkit-ews 2010-07-28 17:32:50 -0700 Attachment 62897 did not build on qt: Build output: http://queues.webkit.org/results/3596522 257476 4 62898 darin 2010-07-28 17:36:02 -0700 Comment on attachment 62898 Errk, better patch I think this would be more readable if the #ifs were moved exclusively inside the commit and decommit functions. This won't compile because you've left the argument names out even though you are using them in decommit. 257504 5 62908 barraclough 2010-07-28 18:13:13 -0700 Created attachment 62908 Even better patch! 257528 6 barraclough 2010-07-28 20:22:54 -0700 Transmitting file data .. Committed revision 64261. 62897 2010-07-28 17:27:52 -0700 2010-07-28 17:29:53 -0700 The patch MADV_FREE.patch text/plain 1418 barraclough SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0MjQ2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjggIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA0MzE2MiAtIEFkZCBzdXBwb3J0IGZvciBN QURWX0ZSRUUgdG8gUGFnZUFsbG9jYXRpb24uCisKKyAgICAgICAgKiB3dGYvUGFnZUFsbG9jYXRp b24uY3BwOgorICAgICAgICAoV1RGOjpQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KToKKyAgICAgICAg KFdURjo6UGFnZUFsbG9jYXRpb246OmRlY29tbWl0KToKKwogMjAxMC0wNy0yNyAgS2ludWtvIFlh c3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QYWdlQWxsb2NhdGlvbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0aW9uLmNwcAkocmV2aXNpb24g NjQxODIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRpb24uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02MSw2ICs2MSwxOSBAQCB2b2lkIFBhZ2VBbGxvY2F0aW9uOjpkZWNvbW1pdCh2 b2lkKiBzdGFyCiB7CiAgICAgd2hpbGUgKG1hZHZpc2Uoc3RhcnQsIHNpemUsIE1BRFZfRlJFRV9S RVVTQUJMRSkgPT0gLTEgJiYgZXJybm8gPT0gRUFHQUlOKSB7IH0KIH0KKyNlbGlmIEhBVkUoTUFE Vl9GUkVFKQorYm9vbCBQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KHZvaWQqIHN0YXJ0LCBzaXplX3Qg c2l6ZSwgYm9vbCB3cml0YWJsZSwgYm9vbCBleGVjdXRhYmxlKSBjb25zdAoreworICAgIFVOVVNF RF9QQVJBTSh3cml0YWJsZSk7CisgICAgVU5VU0VEX1BBUkFNKGV4ZWN1dGFibGUpOworICAgIHJl dHVybiB0cnVlOworfQorCit2b2lkIFBhZ2VBbGxvY2F0aW9uOjpkZWNvbW1pdCh2b2lkKiwgc2l6 ZV90KSBjb25zdAoreworICAgIHdoaWxlIChtYWR2aXNlKHN0YXJ0LCBzaXplLCBNQURWX0ZSRUUp ID09IC0xICYmIGVycm5vID09IEVBR0FJTikgeyB9Cit9CisjZWxzZQogI2VsaWYgSEFWRShNQURW X0RPTlRORUVEKQogYm9vbCBQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KHZvaWQqIHN0YXJ0LCBzaXpl X3Qgc2l6ZSwgYm9vbCB3cml0YWJsZSwgYm9vbCBleGVjdXRhYmxlKSBjb25zdAogewo= 62898 2010-07-28 17:29:53 -0700 2010-07-28 18:13:13 -0700 Errk, better patch MADV_FREE.2.patch text/plain 1998 barraclough SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0MjQ2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjggIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA0MzE2MiAtIEFkZCBzdXBwb3J0IGZvciBN QURWX0ZSRUUgdG8gUGFnZUFsbG9jYXRpb24uCisKKyAgICAgICAgKiB3dGYvUGFnZUFsbG9jYXRp b24uY3BwOgorICAgICAgICAoV1RGOjpQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KToKKyAgICAgICAg KFdURjo6UGFnZUFsbG9jYXRpb246OmRlY29tbWl0KToKKwogMjAxMC0wNy0yNyAgS2ludWtvIFlh c3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QYWdlQWxsb2NhdGlvbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0aW9uLmNwcAkocmV2aXNpb24g NjQxODIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRpb24uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02MSwzMCArNjEsMzAgQEAgdm9pZCBQYWdlQWxsb2NhdGlvbjo6ZGVjb21taXQo dm9pZCogc3RhcgogewogICAgIHdoaWxlIChtYWR2aXNlKHN0YXJ0LCBzaXplLCBNQURWX0ZSRUVf UkVVU0FCTEUpID09IC0xICYmIGVycm5vID09IEVBR0FJTikgeyB9CiB9Ci0jZWxpZiBIQVZFKE1B RFZfRE9OVE5FRUQpCi1ib29sIFBhZ2VBbGxvY2F0aW9uOjpjb21taXQodm9pZCogc3RhcnQsIHNp emVfdCBzaXplLCBib29sIHdyaXRhYmxlLCBib29sIGV4ZWN1dGFibGUpIGNvbnN0CisjZWxzZQor Ym9vbCBQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KHZvaWQqLCBzaXplX3QsIGJvb2wgd3JpdGFibGUs IGJvb2wgZXhlY3V0YWJsZSkgY29uc3QKIHsKICAgICBVTlVTRURfUEFSQU0od3JpdGFibGUpOwog ICAgIFVOVVNFRF9QQVJBTShleGVjdXRhYmxlKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorI2lm IEhBVkUoTUFEVl9GUkVFKQogdm9pZCBQYWdlQWxsb2NhdGlvbjo6ZGVjb21taXQodm9pZCosIHNp emVfdCkgY29uc3QKIHsKLSAgICB3aGlsZSAobWFkdmlzZShzdGFydCwgc2l6ZSwgTUFEVl9ET05U TkVFRCkgPT0gLTEgJiYgZXJybm8gPT0gRUFHQUlOKSB7IH0KKyAgICB3aGlsZSAobWFkdmlzZShz dGFydCwgc2l6ZSwgTUFEVl9GUkVFKSA9PSAtMSAmJiBlcnJubyA9PSBFQUdBSU4pIHsgfQogfQot I2Vsc2UKLWJvb2wgUGFnZUFsbG9jYXRpb246OmNvbW1pdCh2b2lkKiwgc2l6ZV90LCBib29sIHdy aXRhYmxlLCBib29sIGV4ZWN1dGFibGUpIGNvbnN0CisjZWxpZiBIQVZFKE1BRFZfRE9OVE5FRUQp Cit2b2lkIFBhZ2VBbGxvY2F0aW9uOjpkZWNvbW1pdCh2b2lkKiwgc2l6ZV90KSBjb25zdAogewot ICAgIFVOVVNFRF9QQVJBTSh3cml0YWJsZSk7Ci0gICAgVU5VU0VEX1BBUkFNKGV4ZWN1dGFibGUp OwotICAgIHJldHVybiB0cnVlOworICAgIHdoaWxlIChtYWR2aXNlKHN0YXJ0LCBzaXplLCBNQURW X0RPTlRORUVEKSA9PSAtMSAmJiBlcnJubyA9PSBFQUdBSU4pIHsgfQogfQotCisjZWxzZQogdm9p ZCBQYWdlQWxsb2NhdGlvbjo6ZGVjb21taXQodm9pZCosIHNpemVfdCkgY29uc3QKIHsKIH0KICNl bmRpZgorI2VuZGlmCiAKIFBhZ2VBbGxvY2F0aW9uIFBhZ2VBbGxvY2F0aW9uOjphbGxvY2F0ZShz aXplX3Qgc2l6ZSwgVXNhZ2UgdXNhZ2UsIGJvb2wgd3JpdGFibGUsIGJvb2wgZXhlY3V0YWJsZSkK IHsK 62908 2010-07-28 18:13:13 -0700 2010-07-28 18:14:14 -0700 Even better patch! MADV_FREE.3.patch text/plain 2330 barraclough SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0MjQ2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjggIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA0MzE2MiAtIEFkZCBzdXBwb3J0IGZvciBN QURWX0ZSRUUgdG8gUGFnZUFsbG9jYXRpb24uCisKKyAgICAgICAgKiB3dGYvUGFnZUFsbG9jYXRp b24uY3BwOgorICAgICAgICAoV1RGOjpQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KToKKyAgICAgICAg KFdURjo6UGFnZUFsbG9jYXRpb246OmRlY29tbWl0KToKKwogMjAxMC0wNy0yNyAgS2ludWtvIFlh c3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QYWdlQWxsb2NhdGlvbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0aW9uLmNwcAkocmV2aXNpb24g NjQxODIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRpb24uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00OCw0MyArNDgsMzAgQEAgbmFtZXNwYWNlIFdURiB7CiAKICNpZiBIQVZFKE1N QVApCiAKLSNpZiBIQVZFKE1BRFZfRlJFRV9SRVVTRSkKLWJvb2wgUGFnZUFsbG9jYXRpb246OmNv bW1pdCh2b2lkKiBzdGFydCwgc2l6ZV90IHNpemUsIGJvb2wgd3JpdGFibGUsIGJvb2wgZXhlY3V0 YWJsZSkgY29uc3QKK2Jvb2wgUGFnZUFsbG9jYXRpb246OmNvbW1pdCh2b2lkKiBzdGFydCwgc2l6 ZV90IHNpemUsIGJvb2wsIGJvb2wpIGNvbnN0CiB7Ci0gICAgVU5VU0VEX1BBUkFNKHdyaXRhYmxl KTsKLSAgICBVTlVTRURfUEFSQU0oZXhlY3V0YWJsZSk7CisjaWYgSEFWRShNQURWX0ZSRUVfUkVV U0UpCiAgICAgd2hpbGUgKG1hZHZpc2Uoc3RhcnQsIHNpemUsIE1BRFZfRlJFRV9SRVVTRSkgPT0g LTEgJiYgZXJybm8gPT0gRUFHQUlOKSB7IH0KKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHN0YXJ0 KTsKKyAgICBVTlVTRURfUEFSQU0oc2l6ZSk7CisjZW5kaWYKICAgICByZXR1cm4gdHJ1ZTsKIH0K IAogdm9pZCBQYWdlQWxsb2NhdGlvbjo6ZGVjb21taXQodm9pZCogc3RhcnQsIHNpemVfdCBzaXpl KSBjb25zdAogeworI2lmIEhBVkUoTUFEVl9GUkVFX1JFVVNFKQogICAgIHdoaWxlIChtYWR2aXNl KHN0YXJ0LCBzaXplLCBNQURWX0ZSRUVfUkVVU0FCTEUpID09IC0xICYmIGVycm5vID09IEVBR0FJ TikgeyB9Ci19CisjZWxpZiBIQVZFKE1BRFZfRlJFRSkKKyAgICB3aGlsZSAobWFkdmlzZShzdGFy dCwgc2l6ZSwgTUFEVl9GUkVFKSA9PSAtMSAmJiBlcnJubyA9PSBFQUdBSU4pIHsgfQogI2VsaWYg SEFWRShNQURWX0RPTlRORUVEKQotYm9vbCBQYWdlQWxsb2NhdGlvbjo6Y29tbWl0KHZvaWQqIHN0 YXJ0LCBzaXplX3Qgc2l6ZSwgYm9vbCB3cml0YWJsZSwgYm9vbCBleGVjdXRhYmxlKSBjb25zdAot ewotICAgIFVOVVNFRF9QQVJBTSh3cml0YWJsZSk7Ci0gICAgVU5VU0VEX1BBUkFNKGV4ZWN1dGFi bGUpOwotICAgIHJldHVybiB0cnVlOwotfQotCi12b2lkIFBhZ2VBbGxvY2F0aW9uOjpkZWNvbW1p dCh2b2lkKiwgc2l6ZV90KSBjb25zdAotewogICAgIHdoaWxlIChtYWR2aXNlKHN0YXJ0LCBzaXpl LCBNQURWX0RPTlRORUVEKSA9PSAtMSAmJiBlcnJubyA9PSBFQUdBSU4pIHsgfQotfQogI2Vsc2UK LWJvb2wgUGFnZUFsbG9jYXRpb246OmNvbW1pdCh2b2lkKiwgc2l6ZV90LCBib29sIHdyaXRhYmxl LCBib29sIGV4ZWN1dGFibGUpIGNvbnN0Ci17Ci0gICAgVU5VU0VEX1BBUkFNKHdyaXRhYmxlKTsK LSAgICBVTlVTRURfUEFSQU0oZXhlY3V0YWJsZSk7Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KLXZv aWQgUGFnZUFsbG9jYXRpb246OmRlY29tbWl0KHZvaWQqLCBzaXplX3QpIGNvbnN0Ci17Ci19Cisg ICAgVU5VU0VEX1BBUkFNKHN0YXJ0KTsKKyAgICBVTlVTRURfUEFSQU0oc2l6ZSk7CiAjZW5kaWYK K30KIAogUGFnZUFsbG9jYXRpb24gUGFnZUFsbG9jYXRpb246OmFsbG9jYXRlKHNpemVfdCBzaXpl LCBVc2FnZSB1c2FnZSwgYm9vbCB3cml0YWJsZSwgYm9vbCBleGVjdXRhYmxlKQogewo=