43158 2010-07-28 16:25:25 -0700 Implement NPN_Invoke 2010-07-28 16:38:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 257428 0 andersca 2010-07-28 16:25:25 -0700 Implement NPN_Invoke 257430 1 62890 andersca 2010-07-28 16:28:07 -0700 Created attachment 62890 Patch 257433 2 62890 sam 2010-07-28 16:32:09 -0700 Comment on attachment 62890 Patch A bunch of *'s on the wrong side. Otherwise, r=me. 257437 3 webkit.review.bot 2010-07-28 16:34:06 -0700 Attachment 62890 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:533: NPN_Invoke is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:219: NPJSObject::NP_Invoke is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 257445 4 andersca 2010-07-28 16:38:54 -0700 Committed r64244: <http://trac.webkit.org/changeset/64244> 62890 2010-07-28 16:28:07 -0700 2010-07-28 16:32:09 -0700 Patch bug-43158-20100728162805.patch text/plain 6460 andersca ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwYWU0MmI5M2EyNGQ2MmQyMjYyNTZkYWRlY2M2ODRhZWE3ZjE0MWRkLi41MmFjOWY2 MmJhYzFkYjE4YmU2OTQ1Mzc2Zjg4ZDMzNjlkYmI3NjY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAK IDIwMTAtMDctMjggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgTlBO X0ludm9rZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDMxNTgKKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvU2tpcHBlZDoKKyAgICAgICAgUmVt b3ZlIHBsdWdpbnMvbnBydW50aW1lL2ludm9rZS5odG1sLgorCisyMDEwLTA3LTI4ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgU2Ft IFdlaW5pZy4KIAogICAgICAgICBJbXBsZW1lbnQgTlBOX0hhc01ldGhvZApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjLXdrMi9Ta2lwcGVkCmluZGV4IDFiYTVhYmM4NGUwODE0NGNjNWM2ZGQ2YTFlM2U3ZDQy ZjE5ZTAwNDguLjU5M2Q4ZGQ0MTEzMzhmYzlhZjA5Yzc1YzdiYzQ3ZTliMmU0ZjE3NGIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKQEAgLTE0MTUsNyArMTQxNSw2IEBAIHBsdWdp bnMvbnBydW50aW1lL2JpbmRpbmdzLXRlc3QuaHRtbAogcGx1Z2lucy9ucHJ1bnRpbWUvZW51bWVy YXRlLmh0bWwKIHBsdWdpbnMvbnBydW50aW1lL2dldC1wcm9wZXJ0eS1yZXR1cm4tdmFsdWUuaHRt bAogcGx1Z2lucy9ucHJ1bnRpbWUvaW52b2tlLWRlZmF1bHQuaHRtbAotcGx1Z2lucy9ucHJ1bnRp bWUvaW52b2tlLmh0bWwKIHBsdWdpbnMvbnBydW50aW1lL25wcnVudGltZS5odG1sCiBwbHVnaW5z L25wcnVudGltZS9yb3VuZC10cmlwLW5wb2JqZWN0Lmh0bWwKIHBsdWdpbnMvb3ZlcnJpZGUtbm9k ZS1tZXRob2QuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMzcwNWZjNDQxNzQyZDgxZDJiNmFlOTQ4NmFkZDE1OTVlMjcyMGViLi5k Y2VkYjI4Mzc5N2NlNDdmNjA0YWI2NmQzZDNmNTYxZmM3Y2I1ZjI3IDEwMDY0NAotLS0gYS9XZWJL aXQyL0NoYW5nZUxvZworKysgYi9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAy MDEwLTA3LTI4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IE5QTl9J bnZva2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQz MTU4CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTlBKU09iamVjdC5jcHA6CisgICAg ICAgIChXZWJLaXQ6Ok5QSlNPYmplY3Q6Omhhc01ldGhvZCk6CisgICAgICAgIFVzZSB0aGUgZnJl ZSBnZXRDYWxsRGF0YSBmdW5jdGlvbi4KKworICAgICAgICAoV2ViS2l0OjpOUEpTT2JqZWN0Ojpp bnZva2UpOgorICAgICAgICBHZXQgdGhlIEphdmFTY3JpcHQgZnVuY3Rpb24gYW5kIGNhbGwgaXQu CisKKyAgICAgICAgKFdlYktpdDo6TlBKU09iamVjdDo6TlBfSW52b2tlKToKKyAgICAgICAgQ2Fs bCBOUEpTT2JqZWN0OjppbnZva2UuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0 c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOUE5fSW52 b2tlKToKKyAgICAgICAgQ2FsbCB0aGUgTlBDbGFzczo6aW52b2tlIGZ1bmN0aW9uLgorCisyMDEw LTA3LTI4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAg UmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KIAogICAgICAgICBJbXBsZW1lbnQgTlBOX0hhc01ldGhv ZApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTlBKU09iamVjdC5jcHAg Yi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OUEpTT2JqZWN0LmNwcAppbmRleCAxM2ZmZTY0 MDY3MzM5MmNhZDIzNjg3NmM3NWRkOWI2MjQ5MjBkZmVlLi4wMGE2Yzk1NTRmYWNkNjI1ODRlNmFk ZWUwNGVlN2Y1YWNkYmE1YzM3IDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9OUEpTT2JqZWN0LmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OUEpTT2Jq ZWN0LmNwcApAQCAtOTcsMTEgKzk3LDQ0IEBAIGJvb2wgTlBKU09iamVjdDo6aGFzTWV0aG9kKE5Q SWRlbnRpZmllciBtZXRob2ROYW1lKQogCiAgICAgSlNWYWx1ZSB2YWx1ZSA9IG1fanNPYmplY3Qt PmdldChleGVjLCBpZGVudGlmaWVyRnJvbUlkZW50aWZpZXJSZXAoZXhlYywgaWRlbnRpZmllclJl cCkpOyAgICAKICAgICBleGVjLT5jbGVhckV4Y2VwdGlvbigpOwotICAgIGlmICghdmFsdWUuaXNP YmplY3QoKSkKKworICAgIENhbGxEYXRhIGNhbGxEYXRhOworICAgIHJldHVybiBnZXRDYWxsRGF0 YSh2YWx1ZSwgY2FsbERhdGEpICE9IENhbGxUeXBlTm9uZTsKK30KKworYm9vbCBOUEpTT2JqZWN0 OjppbnZva2UoTlBJZGVudGlmaWVyIG1ldGhvZE5hbWUsIGNvbnN0IE5QVmFyaWFudCAqYXJndW1l bnRzLCB1aW50MzJfdCBhcmd1bWVudENvdW50LCBOUFZhcmlhbnQgKnJlc3VsdCkKK3sKKyAgICBJ ZGVudGlmaWVyUmVwKiBpZGVudGlmaWVyUmVwID0gc3RhdGljX2Nhc3Q8SWRlbnRpZmllclJlcCo+ KG1ldGhvZE5hbWUpOworICAgIAorICAgIGlmICghaWRlbnRpZmllclJlcC0+aXNTdHJpbmcoKSkK KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAgIEV4ZWNTdGF0ZSogZXhlYyA9IG1fb2Jq ZWN0TWFwLT5nbG9iYWxFeGVjKCk7CisgICAgaWYgKCFleGVjKQogICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgCisgICAgSlNMb2NrIGxvY2soU2lsZW5jZUFzc2VydGlvbnNPbmx5KTsKIAorICAg IEpTVmFsdWUgZnVuY3Rpb24gPSBtX2pzT2JqZWN0LT5nZXQoZXhlYywgaWRlbnRpZmllckZyb21J ZGVudGlmaWVyUmVwKGV4ZWMsIGlkZW50aWZpZXJSZXApKTsKICAgICBDYWxsRGF0YSBjYWxsRGF0 YTsKLSAgICByZXR1cm4gdmFsdWUudG9PYmplY3QoZXhlYyktPmdldENhbGxEYXRhKGNhbGxEYXRh KSAhPSBDYWxsVHlwZU5vbmU7CisgICAgQ2FsbFR5cGUgY2FsbFR5cGUgPSBnZXRDYWxsRGF0YShm dW5jdGlvbiwgY2FsbERhdGEpOworICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlwZU5vbmUpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIC8vIENvbnZlcnQgdGhlIHBhc3NlZCBpbiBhcmd1 bWVudHMuCisgICAgTWFya2VkQXJndW1lbnRCdWZmZXIgYXJndW1lbnRMaXN0OworICAgIGZvciAo dWludDMyX3QgaSA9IDA7IGkgPCBhcmd1bWVudENvdW50OyArK2kpCisgICAgICAgIGFyZ3VtZW50 TGlzdC5hcHBlbmQobV9vYmplY3RNYXAtPmNvbnZlcnROUFZhcmlhbnRUb0pTVmFsdWUoZXhlYywg YXJndW1lbnRzW2ldKSk7CisKKyAgICBleGVjLT5nbG9iYWxEYXRhKCkudGltZW91dENoZWNrZXIu c3RhcnQoKTsKKyAgICBKU1ZhbHVlIHZhbHVlID0gSlNDOjpjYWxsKGV4ZWMsIGZ1bmN0aW9uLCBj YWxsVHlwZSwgY2FsbERhdGEsIG1fanNPYmplY3QsIGFyZ3VtZW50TGlzdCk7CisgICAgZXhlYy0+ Z2xvYmFsRGF0YSgpLnRpbWVvdXRDaGVja2VyLnN0b3AoKTsKKworICAgIC8vIENvbnZlcnQgYW5k IHJldHVybiB0aGUgcmVzdWx0IG9mIHRoZSBmdW5jdGlvbiBjYWxsLgorICAgIG1fb2JqZWN0TWFw LT5jb252ZXJ0SlNWYWx1ZVRvTlBWYXJpYW50KGV4ZWMsIHZhbHVlLCAqcmVzdWx0KTsKKyAgICBl eGVjLT5jbGVhckV4Y2VwdGlvbigpOworICAgIAorICAgIHJldHVybiB0cnVlOwogfQogCiBib29s IE5QSlNPYmplY3Q6Omhhc1Byb3BlcnR5KE5QSWRlbnRpZmllciBpZGVudGlmaWVyKQpAQCAtMTgz LDEwICsyMTYsOSBAQCBib29sIE5QSlNPYmplY3Q6Ok5QX0hhc01ldGhvZChOUE9iamVjdCogbnBP YmplY3QsIE5QSWRlbnRpZmllciBtZXRob2ROYW1lKQogICAgIHJldHVybiB0b05QSlNPYmplY3Qo bnBPYmplY3QpLT5oYXNNZXRob2QobWV0aG9kTmFtZSk7CiB9CiAgICAgCi1ib29sIE5QSlNPYmpl Y3Q6Ok5QX0ludm9rZShOUE9iamVjdCosIE5QSWRlbnRpZmllciBtZXRob2ROYW1lLCBjb25zdCBO UFZhcmlhbnQgKmFyZ3VtZW50cywgdWludDMyX3QgYXJndW1lbnRDb3VudCwgTlBWYXJpYW50ICpy ZXN1bHQpCitib29sIE5QSlNPYmplY3Q6Ok5QX0ludm9rZShOUE9iamVjdCogbnBPYmplY3QsIE5Q SWRlbnRpZmllciBtZXRob2ROYW1lLCBjb25zdCBOUFZhcmlhbnQgKmFyZ3VtZW50cywgdWludDMy X3QgYXJndW1lbnRDb3VudCwgTlBWYXJpYW50ICpyZXN1bHQpCiB7Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIHRvTlBKU09iamVjdChucE9iamVj dCktPmludm9rZShtZXRob2ROYW1lLCBhcmd1bWVudHMsIGFyZ3VtZW50Q291bnQsIHJlc3VsdCk7 CiB9CiAgICAgCiBib29sIE5QSlNPYmplY3Q6Ok5QX0ludm9rZURlZmF1bHQoTlBPYmplY3QqLCBj b25zdCBOUFZhcmlhbnQgKmFyZ3VtZW50cywgdWludDMyX3QgYXJndW1lbnRDb3VudCwgTlBWYXJp YW50ICpyZXN1bHQpCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OUEpT T2JqZWN0LmggYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OUEpTT2JqZWN0LmgKaW5kZXgg YzI2NjRlNDdhMmIxMmM3N2JlMWMxNTQzNTc4ZDI1YzJlMDg0YjNmMy4uNTAyOTI0NzMzYzQ3MTdh NWEyMzY1YjVkNGZiZjk3ZTJmZTNmMjNjMyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTlBKU09iamVjdC5oCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05Q SlNPYmplY3QuaApAQCAtNjAsNiArNjAsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgaW5pdGlhbGl6 ZShOUFJ1bnRpbWVPYmplY3RNYXAqLCBKU0M6OkpTT2JqZWN0KiBqc09iamVjdCk7CiAKICAgICBi b29sIGhhc01ldGhvZChOUElkZW50aWZpZXIgbWV0aG9kTmFtZSk7CisgICAgYm9vbCBpbnZva2Uo TlBJZGVudGlmaWVyIG1ldGhvZE5hbWUsIGNvbnN0IE5QVmFyaWFudCAqYXJndW1lbnRzLCB1aW50 MzJfdCBhcmd1bWVudENvdW50LCBOUFZhcmlhbnQgKnJlc3VsdCk7CiAgICAgYm9vbCBoYXNQcm9w ZXJ0eShOUElkZW50aWZpZXIgcHJvcGVydHlOYW1lKTsKICAgICBib29sIGdldFByb3BlcnR5KE5Q SWRlbnRpZmllciBwcm9wZXJ0eU5hbWUsIE5QVmFyaWFudCogcmVzdWx0KTsKIApkaWZmIC0tZ2l0 IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVu Y3MuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93 c2VyRnVuY3MuY3BwCmluZGV4IGMzNDIxMDg5N2RiODViZjQ1NjM5ZjJiM2YwN2JkODcyOWJkYTli ZmIuLjQxODRjYWNmZmQyYzIwOTkwYzg3YzZiMzYxNTk0NTA3NjljODI1Y2UgMTAwNjQ0Ci0tLSBh L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNz LmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJy b3dzZXJGdW5jcy5jcHAKQEAgLTUzMCw5ICs1MzAsMTEgQEAgc3RhdGljIHZvaWQgTlBOX1JlbGVh c2VPYmplY3QoTlBPYmplY3QgKm5wT2JqZWN0KQogICAgIHJlbGVhc2VOUE9iamVjdChucE9iamVj dCk7CiB9CiAKLXN0YXRpYyBib29sIE5QTl9JbnZva2UoTlBQIG5wcCwgTlBPYmplY3QgKm5wb2Jq LCBOUElkZW50aWZpZXIgbWV0aG9kTmFtZSwgY29uc3QgTlBWYXJpYW50ICphcmdzLCB1aW50MzJf dCBhcmdDb3VudCwgTlBWYXJpYW50ICpyZXN1bHQpCitzdGF0aWMgYm9vbCBOUE5fSW52b2tlKE5Q UCwgTlBPYmplY3QgKm5wT2JqZWN0LCBOUElkZW50aWZpZXIgbWV0aG9kTmFtZSwgY29uc3QgTlBW YXJpYW50ICphcmd1bWVudHMsIHVpbnQzMl90IGFyZ3VtZW50Q291bnQsIE5QVmFyaWFudCAqcmVz dWx0KQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgaWYgKG5wT2JqZWN0LT5fY2xhc3Mt Pmludm9rZSkKKyAgICAgICAgcmV0dXJuIG5wT2JqZWN0LT5fY2xhc3MtPmludm9rZShucE9iamVj dCwgbWV0aG9kTmFtZSwgYXJndW1lbnRzLCBhcmd1bWVudENvdW50LCByZXN1bHQpOworCiAgICAg cmV0dXJuIGZhbHNlOwogfQogCg==