43146 2010-07-28 14:18:11 -0700 Runtime feature switch for speech input 2010-07-29 05:40:01 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned abarth commit-queue eric hans jorlow steveblock webkit.review.bot oldest_to_newest 257356 0 satish 2010-07-28 14:18:11 -0700 Runtime feature switch for speech input 257368 1 62879 satish 2010-07-28 14:45:57 -0700 Created attachment 62879 Patch 257605 2 62879 steveblock 2010-07-29 03:06:55 -0700 Comment on attachment 62879 Patch WebCore/bindings/generic/RuntimeEnabledFeatures.h:123 + static bool speechInputEnabled() { return isSpeechInputEnabled; } For DeviceOrientation, the flag was used by Page to prevent the controller being created if the feature is disabled. Is there no equivalent use for Speech? 257606 3 satish 2010-07-29 03:08:15 -0700 The flag is used to not expose the 'speech' attribute in HTMLInputElement.idl . Without that attribute, the page cannot turn on speech input, hence nothing else needs to be disabled in code. 257610 4 steveblock 2010-07-29 03:19:52 -0700 > The flag is used to not expose the 'speech' attribute in HTMLInputElement.idl . Without that attribute, > the page cannot turn on speech input, hence nothing else needs to be disabled in code. Sure, but I think Hans added the extra use of the flag for DeviceOrientation to avoid unnecessary member initialisation. Just wondering if we can do any of that here, for consistency? 257611 5 satish 2010-07-29 03:22:13 -0700 For speech input, the controller (of type SpeechInput) is created in Webcore/page/Page.cpp lazily, i.e. on first use. Without the IDL attribute enabled at runtime, this call will never be made so the controller will remain null. 257612 6 62879 steveblock 2010-07-29 03:24:30 -0700 Comment on attachment 62879 Patch r=me 257616 7 hans 2010-07-29 03:32:12 -0700 (In reply to comment #4) > > The flag is used to not expose the 'speech' attribute in HTMLInputElement.idl . Without that attribute, > > the page cannot turn on speech input, hence nothing else needs to be disabled in code. > Sure, but I think Hans added the extra use of the flag for DeviceOrientation to avoid unnecessary member initialisation. Just wondering if we can do any of that here, for consistency? The reason for the extra use of the flag was to prevent the controller being instantiated if a page did window.addEventListener('deviceorientation'). As I understand, that shouldn't be an issue with speech, as the attribute to the input tag is the only entry point to this functionality. 257627 8 62879 commit-queue 2010-07-29 04:28:05 -0700 Comment on attachment 62879 Patch Clearing flags on attachment: 62879 Committed r64269: <http://trac.webkit.org/changeset/64269> 257628 9 commit-queue 2010-07-29 04:28:10 -0700 All reviewed patches have been landed. Closing bug. 257644 10 webkit.review.bot 2010-07-29 05:40:01 -0700 http://trac.webkit.org/changeset/64269 might have broken Chromium Win Release 62879 2010-07-28 14:45:57 -0700 2010-07-29 04:28:05 -0700 Patch bug-43146-20100728224554.patch text/plain 6326 satish ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjJiOGFjYWE5OWQ3ZGIyZjFmZDZkMWEzMDFmYzRiZDRmMTI4Y2E2YS4uY2I5ZTU0MmY3YWFmMWVk OWEwMGVjMGM5Y2EwZmY0ZWJiYWJmOTdhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNy0yOCAgU2F0 aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJ1bnRpbWUgZmVhdHVyZSBzd2l0Y2ggZm9yIHNw ZWVjaCBpbnB1dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQzMTQ2CisKKyAgICAgICAgQWRkIGEgcnVudGltZSBmZWF0dXJlIHN3aXRjaCB0aGF0IGRl Y2lkZXMgd2hldGhlciBzcGVlY2ggaW5wdXQgYXR0cmlidXRlcyBhcmUgYXZhaWxhYmxlIG9yIG5v dC4KKyAgICAgICAgRGVmYXVsdHMgdG8gdHJ1ZS4KKworICAgICAgICAqIGJpbmRpbmdzL2dlbmVy aWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHA6CisgICAgICAgICogYmluZGluZ3MvZ2VuZXJp Yy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmg6CisgICAgICAgIChXZWJDb3JlOjpSdW50aW1lRW5h YmxlZEZlYXR1cmVzOjpzZXRTcGVlY2hJbnB1dEVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6 UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c3BlZWNoSW5wdXRFbmFibGVkKToKKyAgICAgICAgKFdl YkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNwZWVjaEVuYWJsZWQpOgorICAgICAgICAq IGh0bWwvSFRNTElucHV0RWxlbWVudC5pZGw6CisKIDIwMTAtMDctMjggIEphbWVzIFJvYmluc29u ICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNo ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRG ZWF0dXJlcy5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0 dXJlcy5jcHAKaW5kZXggMTUzZjk5NWNkOWY3NmI0ZTFjMWIyOGQ1NDYzMDU3M2QzOTc3OWE2ZC4u ZWIwMjdjMzBhZTRmMzM2NjQ5ZTJmMzAxNzYyZmM5ZmQ1OGNkYjA0ZSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCisrKyBiL1dl YkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcApAQCAtNDgs NiArNDgsNyBAQCBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzV2ViR0xFbmFibGVkID0g ZmFsc2U7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzUHVzaFN0YXRlRW5hYmxlZCA9 IGZhbHNlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc1RvdWNoRW5hYmxlZCA9IHRy dWU7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzRGV2aWNlT3JpZW50YXRpb25FbmFi bGVkID0gdHJ1ZTsKK2Jvb2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNTcGVlY2hJbnB1dEVu YWJsZWQgPSB0cnVlOwogCiAjaWYgRU5BQkxFKFZJREVPKQogCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIGIvV2ViQ29yZS9iaW5k aW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAppbmRleCBiMDU5ZDZlMjYyNzU1 OTI4MGFlMjA4MDZlNGRjYzA1YWI4MmU4NTNhLi5jOWViMjFmNTQ1N2U3NGQ2MTExOTI2YzdlYWI4 ODFkYzA0ZjRlNWViIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGlt ZUVuYWJsZWRGZWF0dXJlcy5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1l RW5hYmxlZEZlYXR1cmVzLmgKQEAgLTExOSw2ICsxMTksMTAgQEAgcHVibGljOgogICAgIHN0YXRp YyBib29sIGRldmljZU9yaWVudGF0aW9uRXZlbnRFbmFibGVkKCkgeyByZXR1cm4gaXNEZXZpY2VP cmllbnRhdGlvbkVuYWJsZWQ7IH0KICAgICBzdGF0aWMgYm9vbCBvbmRldmljZW9yaWVudGF0aW9u RW5hYmxlZCgpIHsgcmV0dXJuIGlzRGV2aWNlT3JpZW50YXRpb25FbmFibGVkOyB9CiAKKyAgICBz dGF0aWMgdm9pZCBzZXRTcGVlY2hJbnB1dEVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNTcGVl Y2hJbnB1dEVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0KKyAgICBzdGF0aWMgYm9vbCBzcGVlY2hJbnB1 dEVuYWJsZWQoKSB7IHJldHVybiBpc1NwZWVjaElucHV0RW5hYmxlZDsgfQorICAgIHN0YXRpYyBi b29sIHNwZWVjaEVuYWJsZWQoKSB7IHJldHVybiBpc1NwZWVjaElucHV0RW5hYmxlZDsgfQorCiBw cml2YXRlOgogICAgIC8vIE5ldmVyIGluc3RhbnRpYXRlLgogICAgIFJ1bnRpbWVFbmFibGVkRmVh dHVyZXMoKSB7IH0KQEAgLTEzMyw2ICsxMzcsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBib29s IGlzUHVzaFN0YXRlRW5hYmxlZDsKICAgICBzdGF0aWMgYm9vbCBpc1RvdWNoRW5hYmxlZDsKICAg ICBzdGF0aWMgYm9vbCBpc0RldmljZU9yaWVudGF0aW9uRW5hYmxlZDsKKyAgICBzdGF0aWMgYm9v bCBpc1NwZWVjaElucHV0RW5hYmxlZDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbCBiL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmlkbAppbmRleCBjNjZlNzc1NTcyOTkwM2VkOWU5YjNjMTJlMDdk YmM3M2NkZTFiODlhLi5jNzI2Y2FhZjBiYjc2YzYzYWU0YWMxNWU2MTIxNmY5YTUxMjkzNTg0IDEw MDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKKysrIGIvV2ViQ29y ZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsCkBAIC0xMDAsNyArMTAwLDcgQEAgbW9kdWxlIGh0 bWwgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgTm9kZUxpc3QgbGFiZWxzOwogCiAjaWYg ZGVmaW5lZChFTkFCTEVfSU5QVVRfU1BFRUNIKSAmJiBFTkFCTEVfSU5QVVRfU1BFRUNICi0gICAg ICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiBzcGVlY2g7CisgICAgICAgIGF0dHJpYnV0 ZSBbUmVmbGVjdCwgRW5hYmxlZEF0UnVudGltZV0gYm9vbGVhbiBzcGVlY2g7CiAjZW5kaWYKICAg ICB9OwogCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwppbmRleCA0MzVhNjc1ZjIwYTdmMDVmNDA0ODI4OWEyYmY1ZjNmMzJj OTIzM2Y3Li4wMGU2MDE4NTc0YzgyMmU4ODMwMjQyMjliYTkwYzI4MDI1YjdiODU0IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNy0yOCAgU2F0aXNoIFNhbXBhdGggIDxzYXRp c2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJ1bnRpbWUgZmVhdHVyZSBzd2l0Y2ggZm9yIHNwZWVjaCBpbnB1dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMxNDYKKworICAgICAg ICBBZGQgYSBydW50aW1lIGZlYXR1cmUgc3dpdGNoIHRoYXQgZGVjaWRlcyB3aGV0aGVyIHNwZWVj aCBpbnB1dCBhdHRyaWJ1dGVzIGFyZSBhdmFpbGFibGUgb3Igbm90LgorICAgICAgICBEZWZhdWx0 cyB0byB0cnVlLgorCisgICAgICAgICogcHVibGljL1dlYlJ1bnRpbWVGZWF0dXJlcy5oOgorICAg ICAgICAqIHNyYy9TcGVlY2hJbnB1dENsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpT cGVlY2hJbnB1dENsaWVudEltcGw6OlNwZWVjaElucHV0Q2xpZW50SW1wbCk6CisgICAgICAgICog c3JjL1dlYlJ1bnRpbWVGZWF0dXJlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlJ1bnRpbWVG ZWF0dXJlczo6ZW5hYmxlU3BlZWNoSW5wdXQpOgorICAgICAgICAoV2ViS2l0OjpXZWJSdW50aW1l RmVhdHVyZXM6OmlzU3BlZWNoSW5wdXRFbmFibGVkKToKKwogMjAxMC0wNy0yOCAgSmFtZXMgUm9i aW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUnVudGltZUZl YXR1cmVzLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlJ1bnRpbWVGZWF0dXJlcy5oCmlu ZGV4IDk1MzA3YTJjYjYxODc2MDk4ODJmYzA3M2U3NzJiOTg2NDZhNjE2NzkuLjUxN2FhZDVmYWNj OWQ1ZjhkYWRiZGJkMWFjZjRjZjc0ZjVmOGM4ZjUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViUnVudGltZUZlYXR1cmVzLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJSdW50aW1lRmVhdHVyZXMuaApAQCAtODAsNiArODAsOSBAQCBwdWJsaWM6CiAgICAgV0VC S0lUX0FQSSBzdGF0aWMgdm9pZCBlbmFibGVEZXZpY2VPcmllbnRhdGlvbihib29sKTsKICAgICBX RUJLSVRfQVBJIHN0YXRpYyBib29sIGlzRGV2aWNlT3JpZW50YXRpb25FbmFibGVkKCk7CiAKKyAg ICBXRUJLSVRfQVBJIHN0YXRpYyB2b2lkIGVuYWJsZVNwZWVjaElucHV0KGJvb2wpOworICAgIFdF QktJVF9BUEkgc3RhdGljIGJvb2wgaXNTcGVlY2hJbnB1dEVuYWJsZWQoKTsKKwogcHJpdmF0ZToK ICAgICBXZWJSdW50aW1lRmVhdHVyZXMoKTsKIH07CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vc3JjL1NwZWVjaElucHV0Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1Nw ZWVjaElucHV0Q2xpZW50SW1wbC5jcHAKaW5kZXggOGJjY2FjZmE0ZjczZDQ3MjI1ODFlYmZiZDU1 ODYyYTFhZDFiZDZmNC4uNmJkMGEyY2U2NmFmZmZjNTUzYmRlMzA4NGFjMGEwYzM0YWU0MGY1MiAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9TcGVlY2hJbnB1dENsaWVudEltcGwuY3Bw CisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvU3BlZWNoSW5wdXRDbGllbnRJbXBsLmNwcApAQCAt NDUsNyArNDUsMTEgQEAgU3BlZWNoSW5wdXRDbGllbnRJbXBsOjpTcGVlY2hJbnB1dENsaWVudElt cGwoV2ViVmlld0NsaWVudCogd2ViX3ZpZXdfY2xpZW50KQogICAgIDogbV9jb250cm9sbGVyKHdl Yl92aWV3X2NsaWVudC0+c3BlZWNoSW5wdXRDb250cm9sbGVyKHRoaXMpKQogICAgICwgbV9saXN0 ZW5lcigwKQogewotICAgIEFTU0VSVChtX2NvbnRyb2xsZXIpOworICAgIC8vIEZJWE1FOiBSaWdo dCBub3cgV2ViVmlld0NsaWVudCBnaXZlcyBhIG51bGwgcG9pbnRlciwgYW5kIHdpdGggdGhlCisg ICAgLy8gcnVudGltZSBmbGFnIGZvciBzcGVlY2ggaW5wdXQgZmVhdHVyZSBzZXQgdG8gdHJ1ZSBi eSBkZWZhdWx0IHRoaXMgd2lsbAorICAgIC8vIGFsd2F5cyBhc3NlcnQuIEVuYWJsZSB0aGlzIGFz c2VydCBvbmNlIHRoZSBXZWJWaWV3Q2xpZW50IHN0YXJ0cyB0bworICAgIC8vIGdpdmUgYSB2YWxp ZCBwb2ludGVyLgorICAgIC8vIEFTU0VSVChtX2NvbnRyb2xsZXIpOwogfQogCiBTcGVlY2hJbnB1 dENsaWVudEltcGw6On5TcGVlY2hJbnB1dENsaWVudEltcGwoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJSdW50aW1lRmVhdHVyZXMuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJSdW50aW1lRmVhdHVyZXMuY3BwCmluZGV4IGVmYjI4N2M2ZThhNmJkNDBjNGRmZjM3ZWQy MzgyYTk4ZTVlY2M3MWMuLjIxNzU1M2IxZmQ5ZTBhZWFhMDlkMmUyZTkyNzI5NjQ2YzI2ODNmZmUg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUnVudGltZUZlYXR1cmVzLmNwcAor KysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlJ1bnRpbWVGZWF0dXJlcy5jcHAKQEAgLTIzNiw0 ICsyMzYsMTQgQEAgYm9vbCBXZWJSdW50aW1lRmVhdHVyZXM6OmlzRGV2aWNlT3JpZW50YXRpb25F bmFibGVkKCkKICAgICByZXR1cm4gUnVudGltZUVuYWJsZWRGZWF0dXJlczo6ZGV2aWNlT3JpZW50 YXRpb25FbmFibGVkKCk7CiB9CiAKK3ZvaWQgV2ViUnVudGltZUZlYXR1cmVzOjplbmFibGVTcGVl Y2hJbnB1dChib29sIGVuYWJsZSkKK3sKKyAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXRT cGVlY2hJbnB1dEVuYWJsZWQoZW5hYmxlKTsKK30KKworYm9vbCBXZWJSdW50aW1lRmVhdHVyZXM6 OmlzU3BlZWNoSW5wdXRFbmFibGVkKCkKK3sKKyAgICByZXR1cm4gUnVudGltZUVuYWJsZWRGZWF0 dXJlczo6c3BlZWNoSW5wdXRFbmFibGVkKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=