43141 2010-07-28 13:15:45 -0700 Minor compile errors in loadMediaPlayerProxyPlugin 2010-07-28 20:25:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 bgislason58 webkit-unassigned commit-queue japhet oldest_to_newest 257328 0 62870 bgislason58 2010-07-28 13:15:45 -0700 Created attachment 62870 3 small fixes These were not caught in initial compile because PLUGIN_PROXY_PROXY_FOR_VIDEO was not enabled. 257334 1 62870 japhet 2010-07-28 13:27:37 -0700 Comment on attachment 62870 3 small fixes Code looks fine, but you need a ChangeLog. WebKitTools/Scripts/prepare-changelog will give you a stub in WebCore/ChangeLog that you can fill out. 257385 2 62884 bgislason58 2010-07-28 15:17:01 -0700 Created attachment 62884 add a changelog 257390 3 62884 japhet 2010-07-28 15:23:12 -0700 Comment on attachment 62884 add a changelog Thanks! 257529 4 62884 commit-queue 2010-07-28 20:25:03 -0700 Comment on attachment 62884 add a changelog Clearing flags on attachment: 62884 Committed r64262: <http://trac.webkit.org/changeset/64262> 257530 5 commit-queue 2010-07-28 20:25:07 -0700 All reviewed patches have been landed. Closing bug. 62870 2010-07-28 13:15:45 -0700 2010-07-28 15:17:01 -0700 3 small fixes SubframeLoader.patch text/plain 1898 bgislason58 Y29tbWl0IDAwNjE2NTkzYWI0YThiMGNmOTIwZTE3N2JiYjA0M2JkNDBlY2I4N2UKQXV0aG9yOiBC cnlhbiBHaXNsYXNvbiA8Ymdpc2xhc29uQHJpbS5jb20+CkRhdGU6ICAgV2VkIEp1bCAyOCAxNTo0 Nzo1OCAyMDEwIC0wNDAwCgogICAgMjAxMC0wNy0yOCAgQnJ5YW4gR2lzbGFzb24gIDxiZ2lzbGFz b25AcmltLmNvbT4KICAgIAogICAgICAgICAgICBGaXhlZCBtaW5vciBlcnJvcnMgdGhhdCB3ZXJl IG1pc3NlZCBpbiB0aGUgZnVuY3Rpb24gbG9hZE1lZGlhUGxheWVyUHJveHlQbHVnaW4KICAgICAg ICAgICAgYmVjYXVzZSBQTFVHSU5fUFJPWFlfUFJPWFlfRk9SX1ZJREVPIHdhcyBkaXNhYmxlZCBk dXJpbmcgY29tcGlsYXRpb24uCiAgICAKICAgICAgICAgICAgKiBsb2FkZXIvU3ViZnJhbWVMb2Fk ZXIuY3BwOgogICAgICAgICAgICAoV2ViQ29yZTo6U3ViZnJhbWVMb2FkZXI6OmxvYWRNZWRpYVBs YXllclByb3h5UGx1Z2luKToKCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxv YWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAKaW5kZXggMjNkODNi MS4uZTZjYjAyOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvU3ViZnJhbWVMb2FkZXIuY3Bw CisrKyBiL1dlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcApAQCAtMTU5LDcgKzE1OSw3 IEBAIGJvb2wgU3ViZnJhbWVMb2FkZXI6OnJlcXVlc3RPYmplY3QoUmVuZGVyRW1iZWRkZWRPYmpl Y3QqIHJlbmRlcmVyLCBjb25zdCBTdHJpbmcmCiAKIAogI2lmIEVOQUJMRShQTFVHSU5fUFJPWFlf Rk9SX1ZJREVPKQotUGFzc1JlZlB0cjxXaWRnZXQ+IEZyYW1lTG9hZGVyOjpsb2FkTWVkaWFQbGF5 ZXJQcm94eVBsdWdpbihOb2RlKiBub2RlLCBjb25zdCBLVVJMJiB1cmwsIAorUGFzc1JlZlB0cjxX aWRnZXQ+IFN1YmZyYW1lTG9hZGVyOjpsb2FkTWVkaWFQbGF5ZXJQcm94eVBsdWdpbihOb2RlKiBu b2RlLCBjb25zdCBLVVJMJiB1cmwsIAogICAgIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBwYXJhbU5h bWVzLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFyYW1WYWx1ZXMpCiB7CiAgICAgQVNTRVJUKG5v ZGUtPmhhc1RhZ05hbWUodmlkZW9UYWcpIHx8IG5vZGUtPmhhc1RhZ05hbWUoYXVkaW9UYWcpKTsK QEAgLTE3MSw3ICsxNzEsNyBAQCBQYXNzUmVmUHRyPFdpZGdldD4gRnJhbWVMb2FkZXI6OmxvYWRN ZWRpYVBsYXllclByb3h5UGx1Z2luKE5vZGUqIG5vZGUsIGNvbnN0IEtVUgogICAgIGlmICghdXJs LmlzRW1wdHkoKSkKICAgICAgICAgY29tcGxldGVkVVJMID0gY29tcGxldGVVUkwodXJsKTsKIAot ICAgIGlmICghU2VjdXJpdHlPcmlnaW46OmNhbkxvYWQoY29tcGxldGVkVVJMLCBTdHJpbmcoKSwg ZnJhbWUoKS0+ZG9jdW1lbnQoKSkpIHsKKyAgICBpZiAoIVNlY3VyaXR5T3JpZ2luOjpjYW5Mb2Fk KGNvbXBsZXRlZFVSTCwgU3RyaW5nKCksIG1fZnJhbWUtPmRvY3VtZW50KCkpKSB7CiAgICAgICAg IEZyYW1lTG9hZGVyOjpyZXBvcnRMb2NhbExvYWRGYWlsZWQobV9mcmFtZSwgY29tcGxldGVkVVJM LnN0cmluZygpKTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQpAQCAtMTkyLDcgKzE5Miw3IEBA IFBhc3NSZWZQdHI8V2lkZ2V0PiBGcmFtZUxvYWRlcjo6bG9hZE1lZGlhUGxheWVyUHJveHlQbHVn aW4oTm9kZSogbm9kZSwgY29uc3QgS1VSCiAKICAgICBpZiAod2lkZ2V0ICYmIHJlbmRlcmVyKSB7 CiAgICAgICAgIHJlbmRlcmVyLT5zZXRXaWRnZXQod2lkZ2V0KTsKLSAgICAgICAgbV9jb250YWlu c1BsdWdJbnMgPSB0cnVlOworICAgICAgICBtX2NvbnRhaW5zUGx1Z2lucyA9IHRydWU7CiAgICAg ICAgIHJlbmRlcmVyLT5ub2RlKCktPnNldE5lZWRzU3R5bGVSZWNhbGMoU3ludGhldGljU3R5bGVD aGFuZ2UpOwogICAgIH0KIAo= 62884 2010-07-28 15:17:01 -0700 2010-07-28 20:25:02 -0700 add a changelog SubframeLoader.patch text/plain 1914 bgislason58 ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWI5ZTcyNy4uZjRjYTdhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNy0yOCAgQnJ5YW4gR2lzbGFz b24gIDxiZ2lzbGFzb25AcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNaW5vciBjb21waWxlIGVycm9ycyBpbiBsb2FkTWVkaWFQbGF5ZXJQ cm94eVBsdWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDMxNDEKKworICAgICAgICAqIFdlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcDoK KwogMjAxMC0wNy0yOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRl ci9TdWJmcmFtZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAK aW5kZXggMjIwNmI0ZS4uMjgyMWE1MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvU3ViZnJh bWVMb2FkZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcApAQCAt MTQ2LDcgKzE0Niw3IEBAIGJvb2wgU3ViZnJhbWVMb2FkZXI6OnJlcXVlc3RPYmplY3QoUmVuZGVy RW1iZWRkZWRPYmplY3QqIHJlbmRlcmVyLCBjb25zdCBTdHJpbmcmCiAKIAogI2lmIEVOQUJMRShQ TFVHSU5fUFJPWFlfRk9SX1ZJREVPKQotUGFzc1JlZlB0cjxXaWRnZXQ+IEZyYW1lTG9hZGVyOjps b2FkTWVkaWFQbGF5ZXJQcm94eVBsdWdpbihOb2RlKiBub2RlLCBjb25zdCBLVVJMJiB1cmwsIAor UGFzc1JlZlB0cjxXaWRnZXQ+IFN1YmZyYW1lTG9hZGVyOjpsb2FkTWVkaWFQbGF5ZXJQcm94eVBs dWdpbihOb2RlKiBub2RlLCBjb25zdCBLVVJMJiB1cmwsCiAgICAgY29uc3QgVmVjdG9yPFN0cmlu Zz4mIHBhcmFtTmFtZXMsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBwYXJhbVZhbHVlcykKIHsKICAg ICBBU1NFUlQobm9kZS0+aGFzVGFnTmFtZSh2aWRlb1RhZykgfHwgbm9kZS0+aGFzVGFnTmFtZShh dWRpb1RhZykpOwpAQCAtMTU4LDcgKzE1OCw3IEBAIFBhc3NSZWZQdHI8V2lkZ2V0PiBGcmFtZUxv YWRlcjo6bG9hZE1lZGlhUGxheWVyUHJveHlQbHVnaW4oTm9kZSogbm9kZSwgY29uc3QgS1VSCiAg ICAgaWYgKCF1cmwuaXNFbXB0eSgpKQogICAgICAgICBjb21wbGV0ZWRVUkwgPSBjb21wbGV0ZVVS TCh1cmwpOwogCi0gICAgaWYgKCFTZWN1cml0eU9yaWdpbjo6Y2FuTG9hZChjb21wbGV0ZWRVUkws IFN0cmluZygpLCBmcmFtZSgpLT5kb2N1bWVudCgpKSkgeworICAgIGlmICghU2VjdXJpdHlPcmln aW46OmNhbkxvYWQoY29tcGxldGVkVVJMLCBTdHJpbmcoKSwgbV9mcmFtZS0+ZG9jdW1lbnQoKSkp IHsKICAgICAgICAgRnJhbWVMb2FkZXI6OnJlcG9ydExvY2FsTG9hZEZhaWxlZChtX2ZyYW1lLCBj b21wbGV0ZWRVUkwuc3RyaW5nKCkpOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CkBAIC0xODEs NyArMTgxLDcgQEAgUGFzc1JlZlB0cjxXaWRnZXQ+IEZyYW1lTG9hZGVyOjpsb2FkTWVkaWFQbGF5 ZXJQcm94eVBsdWdpbihOb2RlKiBub2RlLCBjb25zdCBLVVIKICAgICAgICAgcmVuZGVyZXItPnNl dFdpZGdldCh3aWRnZXQpOwogICAgICAgICByZW5kZXJlci0+bm9kZSgpLT5zZXROZWVkc1N0eWxl UmVjYWxjKFN5bnRoZXRpY1N0eWxlQ2hhbmdlKTsKICAgICB9Ci0gICAgbV9jb250YWluc1BsdWdJ bnMgPSB0cnVlOworICAgIG1fY29udGFpbnNQbHVnaW5zID0gdHJ1ZTsKIAogICAgIHJldHVybiB3 aWRnZXQgPyB3aWRnZXQucmVsZWFzZSgpIDogMDsKIH0K