43120 2010-07-28 08:19:59 -0700 [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash. 2010-07-28 09:28:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 andreip webkit-unassigned jorlow oldest_to_newest 257161 0 andreip 2010-07-28 08:19:59 -0700 [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash. 257166 1 62824 andreip 2010-07-28 08:24:27 -0700 Created attachment 62824 Patch 257179 2 62824 jorlow 2010-07-28 08:46:52 -0700 Comment on attachment 62824 Patch LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37 + shouldBe("storeNames.contains('storeName')", "true"); Maybe also check that there's only this one item? WebKit/chromium/public/WebDOMStringList.h:49 + WebDOMStringList(); I'd lean towards making this private and have 2 factory methods instead: "createEmpty" and "createNull". Though since no one needs the "null" behavior today, I'm OK with you leaving this as is. me 257193 3 andreip 2010-07-28 09:18:48 -0700 (In reply to comment #2) > (From update of attachment 62824 [details]) > LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37 > + shouldBe("storeNames.contains('storeName')", "true"); > Maybe also check that there's only this one item? > Checked. > WebKit/chromium/public/WebDOMStringList.h:49 > + WebDOMStringList(); > I'd lean towards making this private and have 2 factory methods instead: "createEmpty" and "createNull". Though since no one needs the "null" behavior today, I'm OK with you leaving this as is. > Cool, thank you. 257199 4 andreip 2010-07-28 09:28:06 -0700 Committed r64209: <http://trac.webkit.org/changeset/64209> 62824 2010-07-28 08:24:27 -0700 2010-07-28 08:46:52 -0700 Patch bug-43120-20100728162423.patch text/plain 4128 andreip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYWJlZTBhNmNjNzhkNzYyOWE4N2VlYWJjNjc3ZWU0MTMxNzc2OTllLi4yMTVkMTEz ZWNmODdhODBmOWQzNzBmODk3ZDZkMTFkYzRjMzZlZTc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDctMjggIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtJbmRleGVkREJdIFdl YkRPTVN0cmluZ0xpc3QgZGVmYXVsdCBjdG9yIGRvZXMgbm90IGluaXRpYWxpemUgaXRzIG1fcHJp dmF0ZSBtZW1iZXIKKyAgICAgICAgdmFyaWFibGUgc28gYW55IGF0dGVtcHQgdG8gYXBwZW5kIHN0 cmluZ3MgdG8gYSBXZWJET01TdHJpbmdMaXN0IGluc3RhbmNlIHJlc3VsdHMgaW4gYSBjcmFzaC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMTIwCisK KyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9zY3JpcHQtdGVzdHMvb2JqZWN0c3RvcmUtYmFz aWNzLmpzOgorICAgICAgICAob3BlblN1Y2Nlc3MpOgorICAgICAgICAoY3JlYXRlU3VjY2Vzcyk6 CisKIDIwMTAtMDctMjggIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+ CiAKICAgICAgICAgTm90IHJldmlld2VkLiBGaXggdHdvIGxheW91dCB0ZXN0IGZhaWx1cmUgb24g dGhlIHdpbmRvd3Mgc2xhdmUuIFJlbW92ZSB3aW4teHAgc3BlY2lmaWMgcmVzdWx0cyBhZnRlciB0 aGUgcjY0MTg2IGNoYW5nZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL3NjcmlwdC10ZXN0cy9vYmplY3RzdG9yZS1iYXNpY3MuanMgYi9MYXlvdXRUZXN0cy9zdG9y YWdlL2luZGV4ZWRkYi9zY3JpcHQtdGVzdHMvb2JqZWN0c3RvcmUtYmFzaWNzLmpzCmluZGV4IDJl NDJlMzg1MGY0NDQ0OGE3ZGQyODI2NjUwZmY3Mjg3YTYyMzI5NTYuLmRlNWQyZTNlMzA3NWU5MWE3 N2FkZDFjMTU5MzI0YWNiNzMzNDJkN2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL3NjcmlwdC10ZXN0cy9vYmplY3RzdG9yZS1iYXNpY3MuanMKKysrIGIvTGF5b3V0 VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvc2NyaXB0LXRlc3RzL29iamVjdHN0b3JlLWJhc2ljcy5q cwpAQCAtMTQsNyArMTQsNyBAQCBmdW5jdGlvbiBvcGVuU3VjY2VzcygpCiB7CiAgICAgZGVidWco Im9wZW5TdWNjZXNzKCk6Iik7CiAgICAgdmVyaWZ5U3VjY2Vzc0V2ZW50KGV2ZW50KTsKLSAgICB2 YXIgZGIgPSBldmFsQW5kTG9nKCJkYiA9IGV2ZW50LnJlc3VsdCIpOworICAgIGRiID0gZXZhbEFu ZExvZygiZGIgPSBldmVudC5yZXN1bHQiKTsKIAogICAgIC8vIEZJWE1FOiByZW1vdmUgYW55IHBy ZXZpb3VzbHkgY3JlYXRlZCBvYmplY3Qgc3RvcmVzLgogICAgIC8vIFRoaXMgcmVxdWlyZXMgSURC RGF0YWJhc2VSZXF1ZXN0OjpyZW1vdmVPYmplY3RTdG9yZSB0byBiZSBpbXBsZW1lbnRlZC4KQEAg LTMwLDkgKzMwLDExIEBAIGZ1bmN0aW9uIGNyZWF0ZVN1Y2Nlc3MoKQogICAgIGRlYnVnKCJjcmVh dGVTdWNjZXNzKCk6Iik7CiAgICAgdmVyaWZ5U3VjY2Vzc0V2ZW50KGV2ZW50KTsKICAgICB2YXIg c3RvcmUgPSBldmFsQW5kTG9nKCJzdG9yZSA9IGV2ZW50LnJlc3VsdCIpOworICAgIHZhciBzdG9y ZU5hbWVzID0gZXZhbEFuZExvZygic3RvcmVOYW1lcyA9IGRiLm9iamVjdFN0b3JlcyIpOwogCiAg ICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJzdG9yZS5uYW1lIiwgInN0b3JlTmFtZSIpOwogICAg IHNob3VsZEJlTnVsbCgic3RvcmUua2V5UGF0aCIpOworICAgIHNob3VsZEJlKCJzdG9yZU5hbWVz LmNvbnRhaW5zKCdzdG9yZU5hbWUnKSIsICJ0cnVlIik7CiAgICAgLy8gRklYTUU6IHRlc3Qgc3Rv cmUuaW5kZXhOYW1lcywgYXMgd2VsbCBhcyBhbGwgb2JqZWN0IHN0b3JlJ3MgbWV0aG9kcy4KIAog ICAgIHJlc3VsdCA9IGV2YWxBbmRMb2coInN0b3JlLmFkZCgndmFsdWUnLCAna2V5JykiKTsKZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCmluZGV4IGQwYjE3OTJkMzE5YTRlYmM1N2I4MGY0NGRjZjhlYTU5NTAzZmE0NmQuLmM5 YjQ5OWZmODUwNjFiNDg2NTc5NjUxZGM1OThlM2IzZDA3YTU2NDIgMTAwNjQ0Ci0tLSBhL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDEwLTA3LTI4ICBBbmRyZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb SW5kZXhlZERCXSBXZWJET01TdHJpbmdMaXN0IGRlZmF1bHQgY3RvciBkb2VzIG5vdCBpbml0aWFs aXplIGl0cyBtX3ByaXZhdGUgbWVtYmVyCisgICAgICAgIHZhcmlhYmxlIHNvIGFueSBhdHRlbXB0 IHRvIGFwcGVuZCBzdHJpbmdzIHRvIGEgV2ViRE9NU3RyaW5nTGlzdCBpbnN0YW5jZSByZXN1bHRz IGluIGEgY3Jhc2guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MzEyMAorCisgICAgICAgIE1ha2VzIHRoZSBkZWZhdWx0IFdlYktpdDo6V2ViRE9NU3Ry aW5nTGlzdCBjdG9yIGFjdHVhbGx5IGNyZWF0ZSBpdHMgd3JhcHBlZAorICAgICAgICBXZWJDb3Jl OjpET01TdHJpbmdMaXN0IGluc3RhbmNlLgorCisgICAgICAgICogcHVibGljL1dlYkRPTVN0cmlu Z0xpc3QuaDoKKyAgICAgICAgKiBzcmMvV2ViRE9NU3RyaW5nTGlzdC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkRPTVN0cmluZ0xpc3Q6OldlYkRPTVN0cmluZ0xpc3QpOgorCiAyMDEwLTA3LTI4 ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vdCBy ZXZpZXdlZDogY2hyb21pdW0gdGVzdHMgZml4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJET01TdHJpbmdMaXN0LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRP TVN0cmluZ0xpc3QuaAppbmRleCBiM2ZiNTMzNGFmZTM3MDkxN2U4MGEzMjMxMDgwZjY3NTdjNTQ2 NmU4Li5kODhmY2VlOTc4OTM3ZTk1YzBiMzQ0NWY4OTNmN2Y0YmM5NTkzZjU1IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTVN0cmluZ0xpc3QuaAorKysgYi9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkRPTVN0cmluZ0xpc3QuaApAQCAtNDYsNyArNDYsNyBAQCBjbGFz cyBXZWJET01TdHJpbmdMaXN0IHsKIHB1YmxpYzoKICAgICB+V2ViRE9NU3RyaW5nTGlzdCgpIHsg cmVzZXQoKTsgfQogCi0gICAgV2ViRE9NU3RyaW5nTGlzdCgpIHsgfQorICAgIFdlYkRPTVN0cmlu Z0xpc3QoKTsKICAgICBXZWJET01TdHJpbmdMaXN0KGNvbnN0IFdlYkRPTVN0cmluZ0xpc3QmIGwp IHsgYXNzaWduKGwpOyB9CiAgICAgV2ViRE9NU3RyaW5nTGlzdCYgb3BlcmF0b3I9KGNvbnN0IFdl YkRPTVN0cmluZ0xpc3QmIGwpCiAgICAgewpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJET01TdHJpbmdMaXN0LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NU3RyaW5n TGlzdC5jcHAKaW5kZXggY2QxNDViZmYxOTM0NTViNDUxY2E3ZDdhMDZjNzZjNTYyOGU3NDI5Yi4u NGJlN2ZhYmEyOGY1OGI3ZDRmMjBjYzdkYWRmNDVkNjA0MTE2NjY2MSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJET01TdHJpbmdMaXN0LmNwcAorKysgYi9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRPTVN0cmluZ0xpc3QuY3BwCkBAIC0zOCw2ICszOCwxMSBAQCB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK1dlYkRPTVN0cmluZ0xpc3Q6 OldlYkRPTVN0cmluZ0xpc3QoKQoreworICAgIG1fcHJpdmF0ZSA9IFdlYkNvcmU6OkRPTVN0cmlu Z0xpc3Q6OmNyZWF0ZSgpOworfQorCiB2b2lkIFdlYkRPTVN0cmluZ0xpc3Q6OnJlc2V0KCkKIHsK ICAgICBtX3ByaXZhdGUucmVzZXQoKTsK