43114 2010-07-28 05:07:58 -0700 [Qt] putImageData(): Combine premultiplication and BGR->RGB 2010-07-28 05:55:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 257111 0 kling 2010-07-28 05:07:58 -0700 Further optimize putImageData() by doing BGR->RGB inside the premultiplication routine. 257112 1 62813 kling 2010-07-28 05:11:04 -0700 Created attachment 62813 Proposed patch 257116 2 62813 kenneth 2010-07-28 05:17:01 -0700 Comment on attachment 62813 Proposed patch When will we get the asm version? :-) 257123 3 62813 kling 2010-07-28 05:55:32 -0700 Comment on attachment 62813 Proposed patch Clearing flags on attachment: 62813 Committed r64202: <http://trac.webkit.org/changeset/64202> 257124 4 kling 2010-07-28 05:55:41 -0700 All reviewed patches have been landed. Closing bug. 62813 2010-07-28 05:11:04 -0700 2010-07-28 05:55:32 -0700 Proposed patch bug-43114.diff text/plain 2205 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTU2YjRlMy4uYjc5MTNhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0yOCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gcHV0SW1hZ2VEYXRhKCk6IENvbWJpbmUgcHJlbXVs dGlwbGljYXRpb24gYW5kIEJHUi0+UkdCCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MzExNAorCisgICAgICAgIEZ1cnRoZXIgb3B0aW1pemVkIHB1dElt YWdlRGF0YSgpIGJ5IGRvaW5nIEJHUi0+UkdCIGluc2lkZSB0aGUKKyAgICAgICAgcHJlbXVsdGlw bGljYXRpb24gcm91dGluZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdl QnVmZmVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJlbXVsdGlwbHlBQkdSdG9BUkdCKTog UmVuYW1lZCBmcm9tIHByZW11bHRpcGx5LgorICAgICAgICAoV2ViQ29yZTo6cHV0SW1hZ2VEYXRh KToKKwogMjAxMC0wNy0yOCAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNv bT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuIEZvcmdvdCB0byBsYW5kIEdOVW1ha2VmaWxlLmFt IGNoYW5nZXMsIGJyb2tlIGJ1aWxkIGluIHI2NDE5Ni4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCmluZGV4IGUwZTJkZTYuLmJjMjUwMDMgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcApAQCAtMjM3 LDE0ICsyMzcsMTQgQEAgUGFzc1JlZlB0cjxJbWFnZURhdGE+IEltYWdlQnVmZmVyOjpnZXRQcmVt dWx0aXBsaWVkSW1hZ2VEYXRhKGNvbnN0IEludFJlY3QmIHJlY3QKICAgICByZXR1cm4gZ2V0SW1h Z2VEYXRhPFByZW11bHRpcGxpZWQ+KHJlY3QsIG1fZGF0YSwgbV9zaXplKTsKIH0KIAotc3RhdGlj IGlubGluZSB1bnNpZ25lZCBpbnQgcHJlbXVsdGlwbHkodW5zaWduZWQgaW50IHgpCitzdGF0aWMg aW5saW5lIHVuc2lnbmVkIGludCBwcmVtdWx0aXBseUFCR1J0b0FSR0IodW5zaWduZWQgaW50IHgp CiB7CiAgICAgdW5zaWduZWQgaW50IGEgPSB4ID4+IDI0OwogICAgIGlmIChhID09IDI1NSkKLSAg ICAgICAgcmV0dXJuIHg7CisgICAgICAgIHJldHVybiAoeCA8PCAxNikgfCAoKHggPj4gMTYpICYg MHhmZikgfCAoeCAmIDB4ZmYwMGZmMDApOwogICAgIHVuc2lnbmVkIGludCB0ID0gKHggJiAweGZm MDBmZikgKiBhOwogICAgIHQgPSAodCArICgodCA+PiA4KSAmIDB4ZmYwMGZmKSArIDB4ODAwMDgw KSA+PiA4OwotICAgIHQgJj0gMHhmZjAwZmY7CisgICAgdCA9ICgodCA8PCAxNikgfCAodCA+PiAx NikpICYgMHhmZjAwZmY7CiAKICAgICB4ID0gKCh4ID4+IDgpICYgMHhmZikgKiBhOwogICAgIHgg PSAoeCArICgoeCA+PiA4KSAmIDB4ZmYpICsgMHg4MCk7CkBAIC0yOTcsNyArMjk3LDcgQEAgdm9p ZCBwdXRJbWFnZURhdGEoSW1hZ2VEYXRhKiYgc291cmNlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VS ZWN0LCBjb25zdCBJbnRQb2ludCYKICAgICAgICAgICAgIGZvciAoaW50IHggPSAwOyB4IDwgbnVt Q29sdW1uczsgeCsrKSB7CiAgICAgICAgICAgICAgICAgLy8gUHJlbXVsdGlwbHkgYW5kIGNvbnZl cnQgQkdSIHRvIFJHQi4KICAgICAgICAgICAgICAgICBxdWludDMyIHBpeGVsID0gc3JjU2Nhbkxp bmVbeF07Ci0gICAgICAgICAgICAgICAgZGVzdFNjYW5MaW5lW3hdID0gcHJlbXVsdGlwbHkoKChw aXhlbCA8PCAxNikgJiAweGZmMDAwMCkgfCAoKHBpeGVsID4+IDE2KSAmIDB4ZmYpIHwgKHBpeGVs ICYgMHhmZjAwZmYwMCkpOworICAgICAgICAgICAgICAgIGRlc3RTY2FuTGluZVt4XSA9IHByZW11 bHRpcGx5QUJHUnRvQVJHQihwaXhlbCk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBzcmNT Y2FuTGluZSArPSBzb3VyY2UtPndpZHRoKCk7CiAgICAgICAgIH0K