4310 2005-08-06 20:19:16 -0700 "sheet" method is unimplemented in Obj-C DOM API 2005-09-23 11:21:28 -0700 1 1 1 Unclassified WebKit WebKit API 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 darin darin eric oldest_to_newest 16047 0 darin 2005-08-06 20:19:16 -0700 There's a sheet method declared but not implemented in the Objective-C DOM wrappers. 16049 1 3247 darin 2005-08-06 20:20:08 -0700 Created attachment 3247 patch to implement the method 16201 2 3247 sullivan 2005-08-08 09:25:24 -0700 Comment on attachment 3247 patch to implement the method Patch looks good, but needs some sort of testing. r=me if you find a way to test it. 19809 3 3247 eric 2005-09-17 14:57:48 -0700 Comment on attachment 3247 patch to implement the method Looks great. (this code actually benifits from the odd behavior of the last patch, in that it will "correctly" return a DOMCSSStyleSheet or DOMStyleSheet depending on the impl.) r=me 19968 4 eric 2005-09-18 14:44:45 -0700 As ggaren correctly points out, all of these really should have layout tests. For better or worse I ignored that fact, realizing that we don't currently (AFAIK) have any way of testing the Obj-C DOM API. I talked with andersca a bit on IRC, he said he started the py-objc Obj-C DOM testing system, but hasn't finished yet. 20315 5 darin 2005-09-23 11:20:16 -0700 Note that the "odd behavior" that Eric mentions here is the design of the DOM wrappers. The class of the Objective-C DOM wrapper mirrors the class of the actual DOM object it's wrapping. That way you can use standard Objective-C techniques like "isKindOfClass:" and downcasting on the wrappers. 3247 2005-08-06 20:20:08 -0700 2005-09-17 14:57:48 -0700 patch to implement the method ObjCSheetMethodPatch.txt text/plain 1859 darin SW5kZXg6IGt3cS9ET00tQ1NTLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJD b3JlL2t3cS9ET00tQ1NTLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIzCmRpZmYgLXAgLXUg LXUgLXAgLXIxLjIzIGt3cS9ET00tQ1NTLm1tCi0tLSBrd3EvRE9NLUNTUy5tbQkxNCBKdWwgMjAw NSAwMjoyMjoxMSAtMDAwMAkxLjIzCisrKyBrd3EvRE9NLUNTUy5tbQk3IEF1ZyAyMDA1IDAzOjAy OjM5IC0wMDAwCkBAIC0zMywxMCArMzMsMTIgQEAKICNpbXBvcnQgImNzc192YWx1ZWltcGwuaCIK ICNpbXBvcnQgImNzc192YWx1ZS5oIgogI2ltcG9ydCAiZG9tX3N0cmluZy5oIgorI2ltcG9ydCAi ZG9tX3htbGltcGwuaCIKICNpbXBvcnQgIktXUUNvbG9yLmgiCiAjaW1wb3J0ICJzaGFyZWQuaCIK ICNpbXBvcnQgImRvbV9zdHJpbmdpbXBsLmgiCiAjaW1wb3J0ICJkb20yX3ZpZXdzaW1wbC5oIgor I2ltcG9ydCAiaHRtbF9oZWFkaW1wbC5oIgogCiAjaW1wb3J0ICJET01JbnRlcm5hbC5oIgogI2lt cG9ydCAiS1dRQXNzZXJ0aW9ucy5oIgpAQCAtNTgsNyArNjAsMTAgQEAgdXNpbmcgRE9NOjpDU1NT dHlsZVNoZWV0SW1wbDsKIHVzaW5nIERPTTo6Q1NTVmFsdWVJbXBsOwogdXNpbmcgRE9NOjpDU1NW YWx1ZUxpc3RJbXBsOwogdXNpbmcgRE9NOjpET01TdHJpbmc7Cit1c2luZyBET006OkhUTUxMaW5r RWxlbWVudEltcGw7Cit1c2luZyBET006OkhUTUxTdHlsZUVsZW1lbnRJbXBsOwogdXNpbmcgRE9N OjpNZWRpYUxpc3RJbXBsOwordXNpbmcgRE9NOjpQcm9jZXNzaW5nSW5zdHJ1Y3Rpb25JbXBsOwog dXNpbmcgRE9NOjpSZWN0SW1wbDsKIHVzaW5nIERPTTo6U3R5bGVTaGVldEltcGw7CiB1c2luZyBE T006OlN0eWxlU2hlZXRMaXN0SW1wbDsKQEAgLTI1MzIsMTMgKzI1MzcsMjIgQEAgdm9pZCByZW1v dmVXcmFwcGVyRm9yUkdCKFFSZ2IgdmFsdWUpCiAKIC8vLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAKLQogQGltcGxlbWVudGF0aW9uIERPTU9iamVjdCAoRE9NTGlua1N0eWxlKQog CiAtIChET01TdHlsZVNoZWV0ICopc2hlZXQKIHsKLSAgICBFUlJPUigidW5pbXBsZW1lbnRlZCIp OwotICAgIHJldHVybiBuaWw7CisgICAgU3R5bGVTaGVldEltcGwgKnNoZWV0OworCisgICAgaWYg KFtzZWxmIGlzS2luZE9mQ2xhc3M6W0RPTVByb2Nlc3NpbmdJbnN0cnVjdGlvbiBjbGFzc11dKQor ICAgICAgICBzaGVldCA9IHN0YXRpY19jYXN0PFByb2Nlc3NpbmdJbnN0cnVjdGlvbkltcGwgKj4o WyhET01Qcm9jZXNzaW5nSW5zdHJ1Y3Rpb24gKilzZWxmIF9ub2RlSW1wbF0pLT5zaGVldCgpOwor ICAgIGVsc2UgaWYgKFtzZWxmIGlzS2luZE9mQ2xhc3M6W0RPTUhUTUxMaW5rRWxlbWVudCBjbGFz c11dKQorICAgICAgICBzaGVldCA9IHN0YXRpY19jYXN0PEhUTUxMaW5rRWxlbWVudEltcGwgKj4o WyhET01IVE1MTGlua0VsZW1lbnQgKilzZWxmIF9ub2RlSW1wbF0pLT5zaGVldCgpOworICAgIGVs c2UgaWYgKFtzZWxmIGlzS2luZE9mQ2xhc3M6W0RPTUhUTUxTdHlsZUVsZW1lbnQgY2xhc3NdXSkK KyAgICAgICAgc2hlZXQgPSBzdGF0aWNfY2FzdDxIVE1MU3R5bGVFbGVtZW50SW1wbCAqPihbKERP TUhUTUxTdHlsZUVsZW1lbnQgKilzZWxmIF9ub2RlSW1wbF0pLT5zaGVldCgpOworICAgIGVsc2UK KyAgICAgICAgcmV0dXJuIG5pbDsKKworICAgIHJldHVybiBbRE9NU3R5bGVTaGVldCBfRE9NU3R5 bGVTaGVldFdpdGhJbXBsOnNoZWV0XTsKIH0KIAogQGVuZAo=