43090 2010-07-27 16:04:31 -0700 Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to 2010-07-27 18:51:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 256920 0 mrobinson 2010-07-27 16:04:31 -0700 A NULL sentinel is required for these methods to prevent a compiler warning. 256926 1 62766 mrobinson 2010-07-27 16:14:17 -0700 Created attachment 62766 Patch for this issue 256982 2 mrobinson 2010-07-27 18:51:08 -0700 Committed r64185: <http://trac.webkit.org/changeset/64185> 62766 2010-07-27 16:14:17 -0700 2010-07-27 16:45:44 -0700 Patch for this issue bug-43090-20100727161417.patch text/plain 2632 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4NmMxNWMxYzU5MTQyNzA4MzE0OGE4ZTJkNjI2ZWZjMmQ4ZTQ4ODlhLi42YWYyODhi ZGEzNTYzOGY2YzFkYjhkOWFhOWQwNWUyZGRlNTFhODE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDctMjcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0eWxlYm90IHNo b3VsZCBub3QgY29tcGxhaW4gYWJvdXQgTlVMTCB1c2FnZSBpbiBjYWxscyB0byBnZGtfcGl4YnVm X3NhdmVfdG8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQzMDkwCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eTogQWRkIGV4ZW1wdGlvbiBmb3Igc29tZSBHZGtQaXhidWYgbWV0aG9kcy4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weTogQWRkZWQgc29t ZSB0ZXN0cyBmb3IgdGhpcyBiZWhhdmlvci4KKwogMjAxMC0wNy0yNyAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK aW5kZXggNjExYWZkYzE5MGFmMjE4ZTdmZjNkYTFiZjFmMDQ3YTY0OTVmYThlMy4uZWJiNzkyZDMz N2Y2YWU1ZjJhZTNjYWYwMDNhOGQzYWYzNzFjYmM0OCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTE4ODQsNiArMTg4NCwx MCBAQCBkZWYgY2hlY2tfZm9yX251bGwoZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5l X251bWJlciwgZXJyb3IpOgogICAgIGlmIHNlYXJjaChyJ1xiZ19zdHIoam9pbnxjb25jYXQpXGIn LCBsaW5lKToKICAgICAgICAgcmV0dXJuCiAKKyAgICAjIERvbid0IHdhcm4gYWJvdXQgTlVMTCB1 c2FnZSBpbiBnZGtfcGl4YnVmX3NhdmVfdG9fKntqb2luLGNvbmNhdH0oKS4gU2VlIEJ1ZyA0MzA5 MC4KKyAgICBpZiBzZWFyY2gocidcYmdka19waXhidWZfc2F2ZV90b1x3K1xiJywgbGluZSk6Cisg ICAgICAgIHJldHVybgorCiAgICAgaWYgc2VhcmNoKHInXGJOVUxMXGInLCBsaW5lKToKICAgICAg ICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9udWxsJywgNSwgJ1VzZSAwIGluc3Rl YWQgb2YgTlVMTC4nKQogICAgICAgICByZXR1cm4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXgg MmRkZTU0OTI2YWNkOThmODUxZDAxNDc4OWQzMzc1MTU1Y2VkOTE4Yy4uYjU1ODRkMDNiZjZjZDhm M2VkMWRlMTQyMDFhZjBhYmFjODJhMmU0NSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTM0 NzIsNiArMzQ3MiwxNSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6 CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAnZ2NoYXIqIHJlc3VsdCA9 IGdfc3Ryam9pbigiLCIsICJwYXJ0MSIsIE5VTEwpOycsCiAgICAgICAgICAgICAnJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdnY2hhciogcmVzdWx0ID0gZ2RrX3Bp eGJ1Zl9zYXZlX3RvX2NhbGxiYWNrKHBpeGJ1ZiwgZnVuY3Rpb24sIGRhdGEsIHR5cGUsIGVycm9y LCBOVUxMKTsnLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisg ICAgICAgICAgICAnZ2NoYXIqIHJlc3VsdCA9IGdka19waXhidWZfc2F2ZV90b19idWZmZXIocGl4 YnVmLCBmdW5jdGlvbiwgZGF0YSwgdHlwZSwgZXJyb3IsIE5VTEwpOycsCisgICAgICAgICAgICAn JykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdnY2hhciogcmVzdWx0 ID0gZ2RrX3BpeGJ1Zl9zYXZlX3RvX3N0cmVhbShwaXhidWYsIGZ1bmN0aW9uLCBkYXRhLCB0eXBl LCBlcnJvciwgTlVMTCk7JywKKyAgICAgICAgICAgICcnKQogCiAgICAgICAgICMgMi4gQysrIGFu ZCBDIGJvb2wgdmFsdWVzIHNob3VsZCBiZSB3cml0dGVuIGFzIHRydWUgYW5kCiAgICAgICAgICMg ICAgZmFsc2UuIE9iamVjdGl2ZS1DIEJPT0wgdmFsdWVzIHNob3VsZCBiZSB3cml0dGVuIGFzIFlF UyBhbmQgTk8uCg==