4309 2005-08-06 20:14:16 -0700 CSSStyleSheet objects don't get Obj-C DOMCSSStyleSheet wrappers 2006-07-28 05:16:16 -0700 1 1 1 Unclassified WebKit WebKit API 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 darin darin eric todd oldest_to_newest 16045 0 darin 2005-08-06 20:14:16 -0700 When calling a method that returns a style sheet object, the Objective-C DOM wrappers don't create the right type of wrapper for a CSSStyleSheet. You end up with a DOMStyleSheet instead of a DOMCSSStyleSheet. 16046 1 3246 darin 2005-08-06 20:16:51 -0700 Created attachment 3246 patch to fix the problem Added code to handle this like other DOM wrappers with subclasses. Looks like there's also a double-deref bug here that this fixes. 16202 2 3246 sullivan 2005-08-08 09:27:28 -0700 Comment on attachment 3246 patch to fix the problem Patch looks good, but needs some sort of testing. r=me if you find a way to test it. 19808 3 3246 eric 2005-09-17 14:54:55 -0700 Comment on attachment 3246 patch to fix the problem Looks fine. I think this is a good change (simplifies code). I will note however, your current solution may have some rather odd failure symantics when passed the wrong pointer type to the wrong class. If you call _CSSStyleSheetWithImpl and pass a DOMStyleSheetImpl, you'll get back a valid pointer to an Obj-C object, but it will be a DOMStyleSheet *. Likewise if you call _DOMStyleSheetWithImpl and pass a DOMCSSStyleSheetImpl *, you'll get back a DOMCSSStyleSheet * instead of the expected DOMStyleSheet * In an ideal world, at least the first case (passing a DOMStyleSheetImpl * to the DOMCSSStyleSheet creation method) should return nil instead of a DOMStyleSheet *. But hopefully all this code will be going away in the next 6 months anyway (to be replaced by autogeneration). r=me. 19966 4 eric 2005-09-18 14:44:44 -0700 As ggaren correctly points out, all of these really should have layout tests. For better or worse I ignored that fact, realizing that we don't currently (AFAIK) have any way of testing the Obj-C DOM API. I talked with andersca a bit on IRC, he said he started the py-objc Obj-C DOM testing system, but hasn't finished yet. 20310 5 darin 2005-09-23 10:38:32 -0700 Eric, the way this is supposed to work is that you get a compile-time error if you try to pass a DOMStyleSheetImpl to _CSSStyleSheetWithImpl. There's no need for the code to handle this case at runtime. Same for the other cases you mentioned. 20311 6 darin 2005-09-23 10:40:39 -0700 Sorry, the other case was in the other direction. If you call _DOMStyleSheetWithImpl and pass a DOMCSSStyleSheetImpl *, you *must* get a DOMCSSStyleSheet *. That's a feature of the DOM binding, not a bug. The same is true of any subclasses of DOM nodes in a similar way. So the first of the two cases you mentioned is an error that is supposed to be caught at compile time, not runtime. And the second of the two cases is a feature, not a bug. I don't think there's anything wrong here. Lets talk about this in person if you're still concerned. 51027 7 ap 2006-07-28 05:16:16 -0700 *** Bug 6680 has been marked as a duplicate of this bug. *** 3246 2005-08-06 20:16:51 -0700 2005-09-17 14:54:55 -0700 patch to fix the problem ObjCStyleSheetPatch.txt text/plain 2270 darin SW5kZXg6IGt3cS9ET00tQ1NTLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJD b3JlL2t3cS9ET00tQ1NTLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIzCmRpZmYgLXAgLXUg LXUgLXAgLXIxLjIzIGt3cS9ET00tQ1NTLm1tCi0tLSBrd3EvRE9NLUNTUy5tbQkxNCBKdWwgMjAw NSAwMjoyMjoxMSAtMDAwMAkxLjIzCisrKyBrd3EvRE9NLUNTUy5tbQk3IEF1ZyAyMDA1IDAyOjU5 OjMzIC0wMDAwCkBAIC0xNjksNyArMTc0LDcgQEAgdXNpbmcgRE9NOjpTdHlsZVNoZWV0TGlzdElt cGw7CiAKIEBpbXBsZW1lbnRhdGlvbiBET01TdHlsZVNoZWV0IChXZWJDb3JlSW50ZXJuYWwpCiAK LS0gKGlkKV9pbml0V2l0aERPTVN0eWxlU2hlZXRJbXBsOihTdHlsZVNoZWV0SW1wbCAqKWltcGwK Ky0gKGlkKV9pbml0V2l0aFN0eWxlU2hlZXRJbXBsOihTdHlsZVNoZWV0SW1wbCAqKWltcGwKIHsK ICAgICBbc3VwZXIgX2luaXRdOwogICAgIF9pbnRlcm5hbCA9IERPTV9jYXN0PERPTU9iamVjdElu dGVybmFsICo+KGltcGwpOwpAQCAtMTg4LDcgKzE5MywxMiBAQCB1c2luZyBET006OlN0eWxlU2hl ZXRMaXN0SW1wbDsKICAgICBpZiAoY2FjaGVkSW5zdGFuY2UpCiAgICAgICAgIHJldHVybiBbW2Nh Y2hlZEluc3RhbmNlIHJldGFpbl0gYXV0b3JlbGVhc2VdOwogICAgIAotICAgIHJldHVybiBbW1tz ZWxmIGFsbG9jXSBfaW5pdFdpdGhET01TdHlsZVNoZWV0SW1wbDppbXBsXSBhdXRvcmVsZWFzZV07 CisgICAgQ2xhc3Mgd3JhcHBlckNsYXNzOworICAgIGlmIChpbXBsLT5pc0NTU1N0eWxlU2hlZXQo KSkKKyAgICAgICAgd3JhcHBlckNsYXNzID0gW0RPTUNTU1N0eWxlU2hlZXQgY2xhc3NdOworICAg IGVsc2UKKyAgICAgICAgd3JhcHBlckNsYXNzID0gW0RPTVN0eWxlU2hlZXQgY2xhc3NdOworICAg IHJldHVybiBbW1t3cmFwcGVyQ2xhc3MgYWxsb2NdIF9pbml0V2l0aFN0eWxlU2hlZXRJbXBsOmlt cGxdIGF1dG9yZWxlYXNlXTsKIH0KIAogQGVuZApAQCAtMjYyLDIyICsyNzIsNiBAQCB1c2luZyBE T006OlN0eWxlU2hlZXRMaXN0SW1wbDsKIAogQGltcGxlbWVudGF0aW9uIERPTUNTU1N0eWxlU2hl ZXQKIAotLSAodm9pZClkZWFsbG9jCi17Ci0gICAgaWYgKF9pbnRlcm5hbCkgewotICAgICAgICBE T01fY2FzdDxDU1NTdHlsZVNoZWV0SW1wbCAqPihfaW50ZXJuYWwpLT5kZXJlZigpOwotICAgIH0K LSAgICBbc3VwZXIgZGVhbGxvY107Ci19Ci0KLS0gKHZvaWQpZmluYWxpemUKLXsKLSAgICBpZiAo X2ludGVybmFsKSB7Ci0gICAgICAgIERPTV9jYXN0PENTU1N0eWxlU2hlZXRJbXBsICo+KF9pbnRl cm5hbCktPmRlcmVmKCk7Ci0gICAgfQotICAgIFtzdXBlciBmaW5hbGl6ZV07Ci19Ci0KIC0gKENT U1N0eWxlU2hlZXRJbXBsICopX0NTU1N0eWxlU2hlZXRJbXBsCiB7CiAgICAgcmV0dXJuIERPTV9j YXN0PENTU1N0eWxlU2hlZXRJbXBsICo+KF9pbnRlcm5hbCk7CkBAIC0zMTIsMjYgKzMwNiw5IEBA IHVzaW5nIERPTTo6U3R5bGVTaGVldExpc3RJbXBsOwogCiBAaW1wbGVtZW50YXRpb24gRE9NQ1NT U3R5bGVTaGVldCAoV2ViQ29yZUludGVybmFsKQogCi0tIChpZClfaW5pdFdpdGhDU1NTdHlsZVNo ZWV0SW1wbDooQ1NTU3R5bGVTaGVldEltcGwgKilpbXBsCi17Ci0gICAgW3N1cGVyIF9pbml0XTsK LSAgICBfaW50ZXJuYWwgPSBET01fY2FzdDxET01PYmplY3RJbnRlcm5hbCAqPihpbXBsKTsKLSAg ICBpbXBsLT5yZWYoKTsKLSAgICBhZGRET01XcmFwcGVyKHNlbGYsIGltcGwpOwotICAgIHJldHVy biBzZWxmOwotfQotCiArIChET01DU1NTdHlsZVNoZWV0ICopX0NTU1N0eWxlU2hlZXRXaXRoSW1w bDooQ1NTU3R5bGVTaGVldEltcGwgKilpbXBsCiB7Ci0gICAgaWYgKCFpbXBsKQotICAgICAgICBy ZXR1cm4gbmlsOwotICAgIAotICAgIGlkIGNhY2hlZEluc3RhbmNlOwotICAgIGNhY2hlZEluc3Rh bmNlID0gZ2V0RE9NV3JhcHBlcihpbXBsKTsKLSAgICBpZiAoY2FjaGVkSW5zdGFuY2UpCi0gICAg ICAgIHJldHVybiBbW2NhY2hlZEluc3RhbmNlIHJldGFpbl0gYXV0b3JlbGVhc2VdOwotICAgIAot ICAgIHJldHVybiBbW1tzZWxmIGFsbG9jXSBfaW5pdFdpdGhDU1NTdHlsZVNoZWV0SW1wbDppbXBs XSBhdXRvcmVsZWFzZV07CisgICAgcmV0dXJuIChET01DU1NTdHlsZVNoZWV0ICopW0RPTVN0eWxl U2hlZXQgX0RPTVN0eWxlU2hlZXRXaXRoSW1wbDppbXBsXTsKIH0KIAogQGVuZAo=