43080 2010-07-27 14:48:38 -0700 History.pushState() + navigation operates on top frame when called from nested context 2010-07-30 13:56:42 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jschuh fishd abarth beidson eric webkit.review.bot oldest_to_newest 256858 0 62749 jschuh 2010-07-27 14:48:38 -0700 Created attachment 62749 repro I've attached two files that demonstrate an iframe using pushState() and back() to force navigation of the parent frame. The scripts work automatically on Chrome, but you can observe the same behavior with manual navigation in Safari. Based on my read of the standard we should be navigating the iframe's nested browsing context, not the top frame. This might be a regression from bug 36435. 256939 1 62773 fishd 2010-07-27 16:53:47 -0700 Created attachment 62773 simple fix (wip) Here's the fix. I still need to add a layout test, etc. I'm also thinking of changing createItemTree to return the target item as an out param so that we can avoid the recursive walk done by HistoryItem::targetItem(). 257033 2 62795 fishd 2010-07-27 22:19:05 -0700 Created attachment 62795 v1 patch 258357 3 fishd 2010-07-30 13:40:11 -0700 Landed as http://trac.webkit.org/changeset/64369 258364 4 webkit.review.bot 2010-07-30 13:56:42 -0700 http://trac.webkit.org/changeset/64369 might have broken Qt Linux Release 62749 2010-07-27 14:48:38 -0700 2010-07-27 14:48:38 -0700 repro history.zip application/x-zip-compressed 393 jschuh UEsDBBQAAAAIAHBs+zyFJp4WcwAAAM0AAAASAAAAaGlzdG9yeV9mcmFtZS5odG1s88zLSy1ScCtK zE3l5bIpTi7KLCix4+Uqz8xLyS/Xy8/LyU9MUbBVSCvNSy7JzM9T0NBUqOblUgCCjMzikvyiSr2C 0uKM4JLEklSNvNKcHB0FCKkElY5PAxmtl1GSm6OkaU0tnUmJydkaIMFaoKP14a4GAFBLAwQUAAAA CAAtbPs8VcpShSwAAAAwAAAADAAAAGhpc3RvcnkuaHRtbPMvLUktUnArSsxN5eWyyUwDMRSKi5Jt lTIyi0vyiyrjwUJ6GSW5OUp2vFwAUEsBAhQAFAAAAAgAcGz7PIUmnhZzAAAAzQAAABIAAAAAAAAA AQAgAAAAAAAAAGhpc3RvcnlfZnJhbWUuaHRtbFBLAQIUABQAAAAIAC1s+zxVylKFLAAAADAAAAAM AAAAAAAAAAEAIAAAAKMAAABoaXN0b3J5Lmh0bWxQSwUGAAAAAAIAAgB6AAAA+QAAAAAA 62773 2010-07-27 16:53:47 -0700 2010-07-27 22:19:05 -0700 simple fix (wip) p.diff text/plain 919 fishd SW5kZXg6IEhpc3RvcnlDb250cm9sbGVyLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEhpc3RvcnlDb250 cm9sbGVyLmNwcAkocmV2aXNpb24gNjQxMDEpDQorKysgSGlzdG9yeUNvbnRyb2xsZXIuY3BwCSh3 b3JraW5nIGNvcHkpDQpAQCAtNjMzLDEzICs2MzMsMTMgQEANCiAgICAgQVNTRVJUKHBhZ2UpOwog CiAgICAgLy8gR2V0IGEgSGlzdG9yeUl0ZW0gdHJlZSBmb3IgdGhlIGN1cnJlbnQgZnJhbWUgdHJl ZS4KLSAgICBSZWZQdHI8SGlzdG9yeUl0ZW0+IGl0ZW0gPSBjcmVhdGVJdGVtVHJlZShtX2ZyYW1l LCBmYWxzZSk7Ci0gICAgQVNTRVJUKGl0ZW0tPmlzVGFyZ2V0SXRlbSgpKTsKKyAgICBSZWZQdHI8 SGlzdG9yeUl0ZW0+IGl0ZW0gPSBwYWdlLT5tYWluRnJhbWUoKS0+bG9hZGVyKCktPmhpc3Rvcnko KS0+Y3JlYXRlSXRlbVRyZWUobV9mcmFtZSwgZmFsc2UpOwogICAgIAogICAgIC8vIE92ZXJyaWRl IGRhdGEgaW4gdGhlIHRhcmdldCBpdGVtIHRvIHJlZmxlY3QgdGhlIHB1c2hTdGF0ZSgpIGFyZ3Vt ZW50cy4KLSAgICBpdGVtLT5zZXRUaXRsZSh0aXRsZSk7Ci0gICAgaXRlbS0+c2V0U3RhdGVPYmpl Y3Qoc3RhdGVPYmplY3QpOwotICAgIGl0ZW0tPnNldFVSTFN0cmluZyh1cmxTdHJpbmcpOworICAg IEhpc3RvcnlJdGVtKiB0YXJnZXRJdGVtID0gaXRlbS0+dGFyZ2V0SXRlbSgpOworICAgIHRhcmdl dEl0ZW0tPnNldFRpdGxlKHRpdGxlKTsKKyAgICB0YXJnZXRJdGVtLT5zZXRTdGF0ZU9iamVjdChz dGF0ZU9iamVjdCk7CisgICAgdGFyZ2V0SXRlbS0+c2V0VVJMU3RyaW5nKHVybFN0cmluZyk7CiAK ICAgICBwYWdlLT5iYWNrRm9yd2FyZExpc3QoKS0+cHVzaFN0YXRlSXRlbShpdGVtLnJlbGVhc2Uo KSk7CiB9Cg== 62795 2010-07-27 22:19:05 -0700 2010-07-30 12:47:50 -0700 v1 patch push_1.txt text/plain 6202 fishd SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY0MTg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMjcgIERhcmluIEZpc2hlciAgPGRh cmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBIaXN0b3J5LnB1c2hTdGF0ZSgpICsgbmF2aWdhdGlvbiBvcGVyYXRlcyBvbiB0 b3AgZnJhbWUgd2hlbiBjYWxsZWQgZnJvbQorICAgICAgICBuZXN0ZWQgY29udGV4dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMwODAKKworICAgICAg ICAqIGZhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9wdXNoc3RhdGUtaW4taWZyYW1lLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3B1c2hzdGF0 ZS1pbi1pZnJhbWUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVvYmpl Y3RzL3Jlc291cmNlcy9wdXNoc3RhdGUtaW4taWZyYW1lLWNoaWxkLmh0bWw6IEFkZGVkLgorCiAy MDEwLTA3LTI3ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkOyByZW1vdmUgcGxhdGZvcm0tc3BlY2lmaWMgZXhwZWN0ZWQgcmVzdWx0cy4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9wdXNoc3RhdGUtaW4taWZyYW1l LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0 ZW9iamVjdHMvcHVzaHN0YXRlLWluLWlmcmFtZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvcHVzaHN0YXRlLWluLWlmcmFt ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMiBAQAorZnJhbWUgIjwhLS1m cmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IiAtIGhhcyAxIG9udW5sb2FkIGhhbmRsZXIocykK K1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9wdXNoc3Rh dGUtaW4taWZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIv c3RhdGVvYmplY3RzL3B1c2hzdGF0ZS1pbi1pZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9wdXNoc3RhdGUtaW4taWZyYW1lLmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNyBAQAorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OworICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9Cis8L3NjcmlwdD4K KzxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvcHVzaHN0YXRlLWluLWlmcmFtZS1jaGlsZC5odG1sIj4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9yZXNvdXJjZXMvcHVz aHN0YXRlLWluLWlmcmFtZS1jaGlsZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9yZXNvdXJjZXMvcHVzaHN0YXRlLWluLWlmcmFtZS1jaGls ZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVvYmpl Y3RzL3Jlc291cmNlcy9wdXNoc3RhdGUtaW4taWZyYW1lLWNoaWxkLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMjIgQEAKKzxzY3JpcHQ+CitvbnVubG9hZCA9IGZ1bmN0aW9uKCkgeworICAv LyBkaXNhYmxlIHBhZ2UgY2FjaGUKK30KKworb25wb3BzdGF0ZSA9IGZ1bmN0aW9uKCkgeworICAv LyBWZXJpZnkgdGhhdCB3ZSBhcmUgc3RpbGwgaW4gYW4gaWZyYW1lCisgIGlmICh0b3AgPT0gd2lu ZG93KSB7CisgICAgdG9wLmRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gIkZBSUwiOworICB9IGVs c2UgeworICAgIHRvcC5kb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICJQQVNTIjsKKyAgfQorICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKK30KKworb25sb2FkID0gZnVuY3Rpb24oKSB7CisgIGhpc3RvcnkucHVz aFN0YXRlKG51bGwsIG51bGwpOworICBoaXN0b3J5LnB1c2hTdGF0ZShudWxsLCBudWxsKTsKKyAg c2V0VGltZW91dChmdW5jdGlvbigpIHsgaGlzdG9yeS5iYWNrKCkgfSwgMCk7Cit9Cis8L3Njcmlw dD4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiA2NDE4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMjcgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBIaXN0b3J5LnB1c2hTdGF0ZSgpICsgbmF2aWdhdGlvbiBvcGVyYXRlcyBvbiB0b3AgZnJhbWUg d2hlbiBjYWxsZWQgZnJvbQorICAgICAgICBuZXN0ZWQgY29udGV4dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMwODAKKworICAgICAgICBUZXN0OiBm YXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvcHVzaHN0YXRlLWluLWlmcmFtZS5odG1sCisKKyAgICAg ICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlz dG9yeUNvbnRyb2xsZXI6OnB1c2hTdGF0ZSk6IGNyZWF0ZVRyZWVJdGVtIHNob3VsZCBiZQorICAg ICAgICBjYWxsZWQgb24gdGhlIHRvcC1tb3N0IEhpc3RvcnlDb250cm9sbGVyIHNvIHRoYXQgd2Ug cHJvcGVybHkgY2xvbmUKKyAgICAgICAgdGhlIEhpc3RvcnlJdGVtIHRyZWUgc3RhcnRpbmcgYXQg dGhlIHJvb3Qgbm9kZS4KKwogMjAxMC0wNy0yNiAgWXV6byBGdWppc2hpbWEgIDx5dXpvQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBIYW1hamkuCkluZGV4OiBX ZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA2NDE2OCkKKysrIFdlYkNv cmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMzLDE1 ICs2MzMsMTUgQEAgdm9pZCBIaXN0b3J5Q29udHJvbGxlcjo6cHVzaFN0YXRlKFBhc3NSZQogICAg IEFTU0VSVChwYWdlKTsKIAogICAgIC8vIEdldCBhIEhpc3RvcnlJdGVtIHRyZWUgZm9yIHRoZSBj dXJyZW50IGZyYW1lIHRyZWUuCi0gICAgUmVmUHRyPEhpc3RvcnlJdGVtPiBpdGVtID0gY3JlYXRl SXRlbVRyZWUobV9mcmFtZSwgZmFsc2UpOwotICAgIEFTU0VSVChpdGVtLT5pc1RhcmdldEl0ZW0o KSk7CisgICAgUmVmUHRyPEhpc3RvcnlJdGVtPiB0b3BJdGVtID0gcGFnZS0+bWFpbkZyYW1lKCkt PmxvYWRlcigpLT5oaXN0b3J5KCktPmNyZWF0ZUl0ZW1UcmVlKG1fZnJhbWUsIGZhbHNlKTsKICAg ICAKICAgICAvLyBPdmVycmlkZSBkYXRhIGluIHRoZSB0YXJnZXQgaXRlbSB0byByZWZsZWN0IHRo ZSBwdXNoU3RhdGUoKSBhcmd1bWVudHMuCi0gICAgaXRlbS0+c2V0VGl0bGUodGl0bGUpOwotICAg IGl0ZW0tPnNldFN0YXRlT2JqZWN0KHN0YXRlT2JqZWN0KTsKLSAgICBpdGVtLT5zZXRVUkxTdHJp bmcodXJsU3RyaW5nKTsKKyAgICBIaXN0b3J5SXRlbSogdGFyZ2V0SXRlbSA9IG1fZnJhbWUtPmxv YWRlcigpLT5oaXN0b3J5KCktPmN1cnJlbnRJdGVtKCk7CisgICAgdGFyZ2V0SXRlbS0+c2V0VGl0 bGUodGl0bGUpOworICAgIHRhcmdldEl0ZW0tPnNldFN0YXRlT2JqZWN0KHN0YXRlT2JqZWN0KTsK KyAgICB0YXJnZXRJdGVtLT5zZXRVUkxTdHJpbmcodXJsU3RyaW5nKTsKIAotICAgIHBhZ2UtPmJh Y2tGb3J3YXJkTGlzdCgpLT5wdXNoU3RhdGVJdGVtKGl0ZW0ucmVsZWFzZSgpKTsKKyAgICBwYWdl LT5iYWNrRm9yd2FyZExpc3QoKS0+cHVzaFN0YXRlSXRlbSh0b3BJdGVtLnJlbGVhc2UoKSk7CiB9 CiAKIHZvaWQgSGlzdG9yeUNvbnRyb2xsZXI6OnJlcGxhY2VTdGF0ZShQYXNzUmVmUHRyPFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZT4gc3RhdGVPYmplY3QsIGNvbnN0IFN0cmluZyYgdGl0bGUsIGNvbnN0 IFN0cmluZyYgdXJsU3RyaW5nKQpJbmRleDogV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2NDE4OCkKKysr IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBA QAorMjAxMC0wNy0yNyAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhpc3RvcnkucHVzaFN0 YXRlKCkgKyBuYXZpZ2F0aW9uIG9wZXJhdGVzIG9uIHRvcCBmcmFtZSB3aGVuIGNhbGxlZCBmcm9t CisgICAgICAgIG5lc3RlZCBjb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MzA4MAorCisgICAgICAgICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50 SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6cGx1Z2lu TG9hZE9ic2VydmVyKTogVGhlIFdlYkRhdGFTb3VyY2UKKyAgICAgICAgY2FuIGJlIG51bGwgaWYg dGhlIEZyYW1lIGhhcyBhbHJlYWR5IGJlZW4gZGV0YWNoZWQgZnJvbSB0aGUgUGFnZS4gIFRoaXMK KyAgICAgICAgaGFwcGVucyBpZiBhIHBvcHN0YXRlIGV2ZW50IGhhbmRsZXIgcmVtb3ZlcyB0aGUg ZnJhbWUuCisKIDIwMTAtMDctMjcgIEphbWVzIEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBCdWlsZCBGaXguIApJbmRleDogV2ViS2l0L2Nocm9t aXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9j aHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNjQxNjgpCisr KyBXZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTE0ODgsNiArMTQ4OCwxMiBAQCBQYXNzT3duUHRyPFdlYlBsdWdpbkxvYWRPYnNl cnZlcj4gRnJhbWVMCiB7CiAgICAgV2ViRGF0YVNvdXJjZUltcGwqIGRzID0gV2ViRGF0YVNvdXJj ZUltcGw6OmZyb21Eb2N1bWVudExvYWRlcigKICAgICAgICAgbV93ZWJGcmFtZS0+ZnJhbWUoKS0+ bG9hZGVyKCktPmFjdGl2ZURvY3VtZW50TG9hZGVyKCkpOworICAgIGlmICghZHMpIHsKKyAgICAg ICAgLy8gV2UgY2FuIGFycml2ZSBoZXJlIGlmIGEgcG9wc3RhdGUgZXZlbnQgaGFuZGxlciBkZXRh Y2hlcyB0aGlzIGZyYW1lLgorICAgICAgICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgY29kZSBvbmNl IGh0dHA6Ly93ZWJraXQub3JnL2IvMzYyMDIgaXMgZml4ZWQuCisgICAgICAgIEFTU0VSVCghbV93 ZWJGcmFtZS0+ZnJhbWUoKS0+cGFnZSgpKTsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQogICAg IHJldHVybiBkcy0+cmVsZWFzZVBsdWdpbkxvYWRPYnNlcnZlcigpOwogfQogCg==