43072 2010-07-27 13:09:21 -0700 Update numbered header element closing to match recent spec change 2010-07-28 15:31:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 256776 0 abarth 2010-07-27 13:09:21 -0700 Update numbered header element closing to match recent spec change 256778 1 62734 abarth 2010-07-27 13:13:46 -0700 Created attachment 62734 Patch 256782 2 62734 eric 2010-07-27 13:18:33 -0700 Comment on attachment 62734 Patch WebCore/html/HTMLElementStack.cpp:43 + inline bool isNumberedHeaderElement(Element* element) We need to create a header and stuff all these in it sometime. WebCore/html/HTMLElementStack.cpp:387 + bool HTMLElementStack::hasNumberedHeaderElementInScope() const We could template these if we really wanted to. 257398 3 62734 commit-queue 2010-07-28 15:31:52 -0700 Comment on attachment 62734 Patch Clearing flags on attachment: 62734 Committed r64237: <http://trac.webkit.org/changeset/64237> 257399 4 commit-queue 2010-07-28 15:31:57 -0700 All reviewed patches have been landed. Closing bug. 62734 2010-07-27 13:13:46 -0700 2010-07-28 15:31:52 -0700 Patch bug-43072-20100727221343.patch text/plain 6630 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmOTAzZTlmOWY4ODk0MjkyZjZjYTJiODA1NDE4NGRkZjZhMTA2NGNjLi44NjZjMTNm MTExMDQyNzA0YjlmNmRiZjZkZDRhNmZjNzQzODM5NzQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDctMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgbnVtYmVyZWQgaGVh ZGVyIGVsZW1lbnQgY2xvc2luZyB0byBtYXRjaCByZWNlbnQgc3BlYyBjaGFuZ2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMDcyCisKKyAgICAgICAg KiBodG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQtaHRtbDUudHh0OgorCiAyMDEwLTA3LTI1ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5uZXItZXhwZWN0 ZWQtaHRtbDUudHh0IGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLWh0bWw1 LnR4dAppbmRleCA4OTJhNTYzMTcxYjQxNjgzMzdjYWQ2N2VkYmViNGM4ZGE5ZGMxNDcwLi4zYTU0 NDJiNjcyMjcxYTZhNzE2ZDNiZWM3YmQ2NzU1YTZlNGM0MzIyIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9odG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQtaHRtbDUudHh0CisrKyBiL0xheW91dFRlc3Rz L2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQKQEAgLTE2MSw4ICsxNjEsNiBAQCBy ZXNvdXJjZXMvdGVzdHMxNy5kYXQ6IFBBU1MKIHJlc291cmNlcy90ZXN0czE4LmRhdDogUEFTUwog CiByZXNvdXJjZXMvdGVzdHMxOS5kYXQ6Ci0yMgotMjQKIDYzCiA3NwogNzgKQEAgLTE3MSw0OSAr MTY5LDYgQEAgcmVzb3VyY2VzL3Rlc3RzMTkuZGF0OgogMTAxCiAxMDIKIAotVGVzdCAyMiBvZiAx MDIgaW4gcmVzb3VyY2VzL3Rlc3RzMTkuZGF0IGZhaWxlZC4gSW5wdXQ6Ci08IWRvY3R5cGUgaHRt bD48aDE+PGRpdj48aDM+PHNwYW4+PC9oMT5mb28KLUdvdDoKLXwgPCFET0NUWVBFIGh0bWw+Ci18 IDxodG1sPgotfCAgIDxoZWFkPgotfCAgIDxib2R5PgotfCAgICAgPGgxPgotfCAgICAgICA8ZGl2 PgotfCAgICAgICAgIDxoMz4KLXwgICAgICAgICAgIDxzcGFuPgotfCAgICAgImZvbyIKLUV4cGVj dGVkOgotfCA8IURPQ1RZUEUgaHRtbD4KLXwgPGh0bWw+Ci18ICAgPGhlYWQ+Ci18ICAgPGJvZHk+ Ci18ICAgICA8aDE+Ci18ICAgICAgIDxkaXY+Ci18ICAgICAgICAgPGgzPgotfCAgICAgICAgICAg PHNwYW4+Ci18ICAgICAgICAgImZvbyIKLQotVGVzdCAyNCBvZiAxMDIgaW4gcmVzb3VyY2VzL3Rl c3RzMTkuZGF0IGZhaWxlZC4gSW5wdXQ6Ci08IWRvY3R5cGUgaHRtbD48aDM+PGxpPmFiYzwvaDI+ Zm9vCi1Hb3Q6Ci18IDwhRE9DVFlQRSBodG1sPgotfCA8aHRtbD4KLXwgICA8aGVhZD4KLXwgICA8 Ym9keT4KLXwgICAgIDxoMz4KLXwgICAgICAgPGxpPgotfCAgICAgICAgICJhYmNmb28iCi1FeHBl Y3RlZDoKLXwgPCFET0NUWVBFIGh0bWw+Ci18IDxodG1sPgotfCAgIDxoZWFkPgotfCAgIDxib2R5 PgotfCAgICAgPGgzPgotfCAgICAgICA8bGk+Ci18ICAgICAgICAgImFiYyIKLXwgICAgICJmb28i Ci0KIFRlc3QgNjMgb2YgMTAyIGluIHJlc291cmNlcy90ZXN0czE5LmRhdCBmYWlsZWQuIElucHV0 OgogPCFkb2N0eXBlIGh0bWw+PGtleWdlbj48ZnJhbWVzZXQ+CiBHb3Q6CmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDIyMzBjZmQ2ZTdkYmRj MmMwZTExM2NkMDY0ZWZhOGViYmEwNzVjMzAuLjAyOTc5NTU3ZjdiYTI0MzZhMGY0MThlYzQwYjdl OTA4NjA0M2QzMzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMjcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVcGRhdGUgbnVtYmVyZWQgaGVhZGVyIGVsZW1lbnQgY2xvc2luZyB0byBtYXRjaCBy ZWNlbnQgc3BlYyBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQzMDcyCisKKyAgICAgICAgUHJldHR5IHN0cmFpZ2h0Zm9yd2FyZCB0cmFuc2Ny aXB0aW9uIG9mIHRoZSBzcGVjIGNoYW5nZS4KKworICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnRT dGFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTmFtZXM6OmlzTnVtYmVyZWRIZWFkZXJF bGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50U3RhY2s6OnBvcFVudGlsTnVt YmVyZWRIZWFkZXJFbGVtZW50UG9wcGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50 U3RhY2s6Omhhc09ubHlIVE1MRWxlbWVudHNJblNjb3BlKToKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxFbGVtZW50U3RhY2s6Omhhc051bWJlcmVkSGVhZGVyRWxlbWVudEluU2NvcGUpOgorICAgICAg ICAqIGh0bWwvSFRNTEVsZW1lbnRTdGFjay5oOgorICAgICAgICAqIGh0bWwvSFRNTFRyZWVCdWls ZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6SFRNTFRyZWVCdWls ZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZ0Zv ckluQm9keSk6CisKIDIwMTAtMDctMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaHRtbC9IVE1MRWxlbWVudFN0YWNrLmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudFN0 YWNrLmNwcAppbmRleCA3NWFlNzUxNDJjMDk2ZjBlYjliYjdkMzBhYmI0N2U2NjA5NTc1ZGE2Li41 MzFhM2I0MjAzZjBlODgyMzk1YzFjZjU5YjM2NjZhMmNiN2M3ZjdhIDEwMDY0NAotLS0gYS9XZWJD b3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxFbGVt ZW50U3RhY2suY3BwCkBAIC00MCw2ICs0MCwxNiBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVz OwogCiBuYW1lc3BhY2UgewogCitpbmxpbmUgYm9vbCBpc051bWJlcmVkSGVhZGVyRWxlbWVudChF bGVtZW50KiBlbGVtZW50KQoreworICAgIHJldHVybiBlbGVtZW50LT5oYXNUYWdOYW1lKGgxVGFn KQorICAgICAgICB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKGgyVGFnKQorICAgICAgICB8fCBlbGVt ZW50LT5oYXNUYWdOYW1lKGgzVGFnKQorICAgICAgICB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKGg0 VGFnKQorICAgICAgICB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKGg1VGFnKQorICAgICAgICB8fCBl bGVtZW50LT5oYXNUYWdOYW1lKGg2VGFnKTsKK30KKwogaW5saW5lIGJvb2wgaXNTY29wZU1hcmtl cihFbGVtZW50KiBlbGVtZW50KQogewogICAgIHJldHVybiBlbGVtZW50LT5oYXNUYWdOYW1lKGFw cGxldFRhZykKQEAgLTE4MCw2ICsxOTAsMTMgQEAgdm9pZCBIVE1MRWxlbWVudFN0YWNrOjpwb3BV bnRpbFBvcHBlZChjb25zdCBBdG9taWNTdHJpbmcmIHRhZ05hbWUpCiAgICAgcG9wKCk7CiB9CiAK K3ZvaWQgSFRNTEVsZW1lbnRTdGFjazo6cG9wVW50aWxOdW1iZXJlZEhlYWRlckVsZW1lbnRQb3Bw ZWQoKQoreworICAgIHdoaWxlICghaXNOdW1iZXJlZEhlYWRlckVsZW1lbnQodG9wKCkpKQorICAg ICAgICBwb3AoKTsKKyAgICBwb3AoKTsKK30KKwogdm9pZCBIVE1MRWxlbWVudFN0YWNrOjpwb3BV bnRpbChFbGVtZW50KiBlbGVtZW50KQogewogICAgIHdoaWxlICh0b3AoKSAhPSBlbGVtZW50KQpA QCAtMzY3LDYgKzM4NCwxOSBAQCBib29sIEhUTUxFbGVtZW50U3RhY2s6Omhhc09ubHlIVE1MRWxl bWVudHNJblNjb3BlKCkgY29uc3QKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorYm9vbCBIVE1MRWxl bWVudFN0YWNrOjpoYXNOdW1iZXJlZEhlYWRlckVsZW1lbnRJblNjb3BlKCkgY29uc3QKK3sKKyAg ICBmb3IgKEVsZW1lbnRSZWNvcmQqIHJlY29yZCA9IG1fdG9wLmdldCgpOyByZWNvcmQ7IHJlY29y ZCA9IHJlY29yZC0+bmV4dCgpKSB7CisgICAgICAgIEVsZW1lbnQqIGVsZW1lbnQgPSByZWNvcmQt PmVsZW1lbnQoKTsKKyAgICAgICAgaWYgKGlzTnVtYmVyZWRIZWFkZXJFbGVtZW50KGVsZW1lbnQp KQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIGlmIChpc1Njb3BlTWFya2VyKGVs ZW1lbnQpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKyAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsgLy8gPGh0bWw+IGlzIGFsd2F5cyBvbiB0aGUgc3RhY2sgYW5kIGlzIGEgc2Nv cGUgbWFya2VyLgorICAgIHJldHVybiBmYWxzZTsKK30KKwogYm9vbCBIVE1MRWxlbWVudFN0YWNr OjppblNjb3BlKEVsZW1lbnQqIHRhcmdldEVsZW1lbnQpIGNvbnN0CiB7CiAgICAgZm9yIChFbGVt ZW50UmVjb3JkKiBwb3MgPSBtX3RvcC5nZXQoKTsgcG9zOyBwb3MgPSBwb3MtPm5leHQoKSkgewpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50U3RhY2suaCBiL1dlYkNvcmUvaHRt bC9IVE1MRWxlbWVudFN0YWNrLmgKaW5kZXggN2ZjNDA0Mzg1ODEwMDEzNmUyZjdlYzA2NjM0OGQy YWQ2MjkzNTkyOC4uNjJkMDMxZmE0ZGM2NTQ5NWIzZTZlNDU1ZDc4NWFiM2QwNDY0MGE4NiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50U3RhY2suaAorKysgYi9XZWJDb3JlL2h0 bWwvSFRNTEVsZW1lbnRTdGFjay5oCkBAIC05NCw2ICs5NCw3IEBAIHB1YmxpYzoKICAgICB2b2lk IHBvcFVudGlsKEVsZW1lbnQqKTsKICAgICB2b2lkIHBvcFVudGlsUG9wcGVkKGNvbnN0IEF0b21p Y1N0cmluZyYgdGFnTmFtZSk7CiAgICAgdm9pZCBwb3BVbnRpbFBvcHBlZChFbGVtZW50Kik7Cisg ICAgdm9pZCBwb3BVbnRpbE51bWJlcmVkSGVhZGVyRWxlbWVudFBvcHBlZCgpOwogICAgIHZvaWQg cG9wVW50aWxUYWJsZVNjb3BlTWFya2VyKCk7IC8vICJjbGVhciB0aGUgc3RhY2sgYmFjayB0byBh IHRhYmxlIGNvbnRleHQiIGluIHRoZSBzcGVjLgogICAgIHZvaWQgcG9wVW50aWxUYWJsZUJvZHlT Y29wZU1hcmtlcigpOyAvLyAiY2xlYXIgdGhlIHN0YWNrIGJhY2sgdG8gYSB0YWJsZSBib2R5IGNv bnRleHQiIGluIHRoZSBzcGVjLgogICAgIHZvaWQgcG9wVW50aWxUYWJsZVJvd1Njb3BlTWFya2Vy KCk7IC8vICJjbGVhciB0aGUgc3RhY2sgYmFjayB0byBhIHRhYmxlIHJvdyBjb250ZXh0IiBpbiB0 aGUgc3BlYy4KQEAgLTExOCw2ICsxMTksNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBpbkJ1dHRvblNj b3BlKGNvbnN0IFF1YWxpZmllZE5hbWUmKSBjb25zdDsKIAogICAgIGJvb2wgaGFzT25seUhUTUxF bGVtZW50c0luU2NvcGUoKSBjb25zdDsKKyAgICBib29sIGhhc051bWJlcmVkSGVhZGVyRWxlbWVu dEluU2NvcGUoKSBjb25zdDsKIAogICAgIEVsZW1lbnQqIGh0bWxFbGVtZW50KCkgY29uc3Q7CiAg ICAgRWxlbWVudCogaGVhZEVsZW1lbnQoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRt bC9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAK aW5kZXggZGNjNjc5NGQwY2I2OTIyM2FiYTI5ZjZiNTY0OTA0NmEwM2QyYzU4ZS4uZTliZjI5ZmNm YTE5ZWIyNDgxYThjYmY4ZTVhMTU4YjMxMGIyZGY0NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1s L0hUTUxUcmVlQnVpbGRlci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5j cHAKQEAgLTIwMTMsMTQgKzIwMTMsMTQgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NF bmRUYWdGb3JJbkJvZHkoQXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICAgICAgcmV0dXJuOwog ICAgIH0KICAgICBpZiAoaXNOdW1iZXJlZEhlYWRlclRhZyh0b2tlbi5uYW1lKCkpKSB7Ci0gICAg ICAgIGlmICghbV90cmVlLm9wZW5FbGVtZW50cygpLT5pblNjb3BlKHRva2VuLm5hbWUoKSkpIHsK KyAgICAgICAgaWYgKCFtX3RyZWUub3BlbkVsZW1lbnRzKCktPmhhc051bWJlcmVkSGVhZGVyRWxl bWVudEluU2NvcGUoKSkgewogICAgICAgICAgICAgcGFyc2VFcnJvcih0b2tlbik7CiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgbV90cmVlLmdlbmVyYXRlSW1wbGllZEVu ZFRhZ3MoKTsKICAgICAgICAgaWYgKCFtX3RyZWUuY3VycmVudEVsZW1lbnQoKS0+aGFzTG9jYWxO YW1lKHRva2VuLm5hbWUoKSkpCiAgICAgICAgICAgICBwYXJzZUVycm9yKHRva2VuKTsKLSAgICAg ICAgbV90cmVlLm9wZW5FbGVtZW50cygpLT5wb3BVbnRpbFBvcHBlZCh0b2tlbi5uYW1lKCkpOwor ICAgICAgICBtX3RyZWUub3BlbkVsZW1lbnRzKCktPnBvcFVudGlsTnVtYmVyZWRIZWFkZXJFbGVt ZW50UG9wcGVkKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgaWYgKHRva2VuLm5hbWUo KSA9PSAic2FyY2FzbSIpIHsK