43067 2010-07-27 12:06:03 -0700 fast/dom/prototype-inheritance.html fails from r64141 2010-08-06 13:29:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 victorw webkit-unassigned andreip jorlow victorw oldest_to_newest 256739 0 victorw 2010-07-27 12:06:03 -0700 This layout test fails on chromium webkit canary bot: fast/dom/prototype-inheritance.html Looks like http://trac.webkit.org/changeset/64141 causes this failure. 256899 1 andreip 2010-07-27 15:39:40 -0700 Hmm, are you sure that's what's causing it? Seems unlikely. Anyway, I will look tomorrow (I am in London and it's midnight right now). If you are certain that my change is the cause, please roll it out and I will fix it tomorrow. 256916 2 victorw 2010-07-27 15:56:46 -0700 (In reply to comment #1) > Hmm, are you sure that's what's causing it? Seems unlikely. Anyway, I will look tomorrow (I am in London and it's midnight right now). If you are certain that my change is the cause, please roll it out and I will fix it tomorrow. Looks to me this is the cause. I did not manually run it to verify so not 100% sure. Here are the actual test results: ---- Make sure prototypes are set up using the window a property came from, instead of the lexical global object. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS inner.Array.isInner is true ... FAIL inner.IDBKeyRange.isInner should be true. Was false. FAIL inner.IDBKeyRange.constructor.isInner should be true. Was false. PASS inner.Image.isInner is true ... FAIL inner.Infinity.isInner should be true. Was false. FAIL inner.Infinity.constructor.isInner should be true. Was false. PASS inner.JSON.isInner is true 257086 3 jorlow 2010-07-28 03:29:43 -0700 Andrei, I'm guessing this failure is why all this stuff is hand-written right now. There must be some subtle differences in semantics that matter. And/or you need to add it to the list of stuff it doesn't check. ....actually I think it's the latter. :-) 257136 4 62818 andreip 2010-07-28 07:18:32 -0700 Created attachment 62818 Patch 257178 5 62818 jorlow 2010-07-28 08:41:21 -0700 Comment on attachment 62818 Patch LayoutTests/ChangeLog:11 + Reviewed by NOBODY (OOPS!). This should go first. r=me 257203 6 andreip 2010-07-28 09:37:09 -0700 Committed r64210: <http://trac.webkit.org/changeset/64210> Please mark the bug as fixed if you are satisfied. 62818 2010-07-28 07:18:32 -0700 2010-07-28 08:41:21 -0700 Patch bug-43067-20100728151829.patch text/plain 2614 andreip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYWJlZTBhNmNjNzhkNzYyOWE4N2VlYWJjNjc3ZWU0MTMxNzc2OTllLi5iOTkxZGRk OWQxMzk3YWQ5ZmFjNjBmMzNkODZhZmE1Zjk3MjNlYjQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDctMjggIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29nbGUuY29tPgorCisgICAg ICAgIFNraXAgSURCS2V5UmFuZ2UgZnJvbSB0aGUgcHJvdG90eXBlLWluaGVyaXRhbmNlIGxheW91 dCB0ZXN0LgorICAgICAgICBJREJLZXlSYW5nZSBpcyBhIERPTSBvYmplY3QgYW5kLCB3aXRoIFY4 LCBpdCBzZWVtcyB0aGF0IHN1Y2ggb2JqZWN0cworICAgICAgICBkbyBub3QgcmVzcGVjdCB0aGUg cHJvdG90eXBlIGluaGVyaXRhbmNlLgorCisgICAgICAgIE9uY2UgSW5kZXhlZERhdGFiYXNlIGlz IGRvbmUsIHdlIHNob3VsZCByZW1vdmUgaW5kZXhlZERCIGFuZCBJREJLZXlSYW5nZQorICAgICAg ICBmcm9tIHRoZSBsaXN0IG9mIHNraXBwZWQgd2luZG93IHByb3BlcnRpZXMgYW5kIHdlIHNob3Vs ZCB1cGRhdGUgdGhlCisgICAgICAgIENocm9taXVtIGFuZCBBbmRyb2lkIHRlc3QgZXhwZWN0YXRp b25zLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZh c3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS5odG1sIGZhaWxzIGZyb20gcjY0MTQxCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzA2NworCisgICAg ICAgICogZmFzdC9kb20vc2NyaXB0LXRlc3RzL3Byb3RvdHlwZS1pbmhlcml0YW5jZS5qczoKKyAg ICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAt MDctMjggIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAg ICAgTm90IHJldmlld2VkLiBGaXggdHdvIGxheW91dCB0ZXN0IGZhaWx1cmUgb24gdGhlIHdpbmRv d3Mgc2xhdmUuIFJlbW92ZSB3aW4teHAgc3BlY2lmaWMgcmVzdWx0cyBhZnRlciB0aGUgcjY0MTg2 IGNoYW5nZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0cy9w cm90b3R5cGUtaW5oZXJpdGFuY2UuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVz dHMvcHJvdG90eXBlLWluaGVyaXRhbmNlLmpzCmluZGV4IDQxYTRlYzgwMTZlYmNjYzliMWU1MzBm MTI5NDUwOTEyNjdiZmJiYjUuLmViZjk0Mzg3ODZjMDA1Zjk5NDNlNmJmYjM2OWQ2YWQ2NGY4MzVi ZTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0cy9wcm90b3R5 cGUtaW5oZXJpdGFuY2UuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LXRlc3Rz L3Byb3RvdHlwZS1pbmhlcml0YW5jZS5qcwpAQCAtMjAsNyArMjAsOCBAQCB2YXIgc2tpcHBlZFBy b3BlcnRpZXMgPSBbCiAgICAgIkFycmF5QnVmZmVyIiwKICAgICAiSW50OEFycmF5IiwgIlVpbnQ4 QXJyYXkiLCAiSW50MTZBcnJheSIsICJVaW50MTZBcnJheSIsICJJbnQzMkFycmF5IiwgIlVpbnQz MkFycmF5IiwgIkZsb2F0MzJBcnJheSIsCiAgICAgIkZpbGVFcnJvciIsICJGaWxlUmVhZGVyIiwK LSAgICAiaW5kZXhlZERCIiwgInNob3dNb2RhbERpYWxvZyIsCisgICAgImluZGV4ZWREQiIsICJJ REJLZXlSYW5nZSIsCisgICAgInNob3dNb2RhbERpYWxvZyIsCiAgICAgLy8gSWdub3JlIHRoaXMg cHJvcGVydHkgYmVjYXVzZSBpdCBvbmx5IGFwcGVhcnMgaW4gZGVidWcgYnVpbGRzLgogICAgICJq c2NwcmludCIKIF07CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggOTg4MzdmMzk2OGVjM2I2M2FhODU3MTRiNDczMjg5OGUw ZmIyMDgwYi4uM2VmNGE2OGZhOWZjODNlNDc5OWM0YTVkMzZjMTE2MTY0ODc5Njk2OCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0 CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dApAQCAtMzEzMSw5ICszMTMxLDYgQEAgQlVHV0s0Mjk2NCBTTE9XIDogdGFibGVzL21vemlsbGEv b3RoZXIvc2xhc2hsb2dvLmh0bWwgPSBGQUlMCiAvLyBGbGFreSBzaW5jZSBXZWJLaXQgcjYzOTk0 CiBCVUdXSzQyOTY0IFdJTiBMSU5VWCA6IHRhYmxlcy9tb3ppbGxhX2V4cGVjdGVkX2ZhaWx1cmVz L2J1Z3MvYnVnODkzMTUuaHRtbCA9IFBBU1MgRkFJTAogCi0vLyBGYWlscyBzaW5jZSBXZWJLaXQg cjY0MTQxCi1CVUdXSzQzMDY3IDogZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLmh0bWwg PSBURVhUCi0KIC8vIEZhaWxzIHNpbmNlIFdlYktpdCByNjQxNTYKIEJVR1dLNDMwODYgOiBmYXN0 L2NhbnZhcy9jYW52YXMtSW1hZ2VEYXRhLWJlaGF2aW91ci5odG1sID0gVEVYVAogCg==