43048 2010-07-27 07:41:19 -0700 UI process needs a way to find out when the web process crashes 2010-07-27 09:08:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 43047 1 aroben webkit-unassigned andersca sam webkit.review.bot oldest_to_newest 256580 0 aroben 2010-07-27 07:41:19 -0700 There's no API for the UI process to find out when the web process crashes. We should add one! Probably adding a WKPageProcessDidExitCallback member to WKPageLoaderClient is the way to go for now (though we might move it to wherever the DidBecome[Un]ResponsiveCallbacks go, once they move to a new client). 256583 1 aroben 2010-07-27 07:42:36 -0700 <rdar://problem/8239458> 256616 2 62694 aroben 2010-07-27 08:32:29 -0700 Created attachment 62694 Patch 256617 3 webkit.review.bot 2010-07-27 08:33:20 -0700 Attachment 62694 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:96: Extra space between WKPageProcessDidExitCallback and processDidExit [whitespace/declaration] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 256633 4 aroben 2010-07-27 09:08:56 -0700 Committed r64132: <http://trac.webkit.org/changeset/64132> 62694 2010-07-27 08:32:29 -0700 2010-07-27 08:34:49 -0700 Patch bug-43048-20100727113229.patch text/plain 4863 aroben ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZDY5ZThlZTc0MzQ2YjAwN2FiNGYwYTFhZTk5MTg0MTMzMzcyMWNjNC4uYTRkMjhjYjRiYWUzMGJl MWY4Mzg2NmI4OGY1YjcyMjNkOWMyOWQyYSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNy0yNyAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgUHJvY2Vzc0RpZEV4 aXQgY2FsbGJhY2sgdG8gdGhlIFdLUGFnZUxvYWRlckNsaWVudAorCisgICAgICAgIEZpeGVzIDxo dHRwOi8vd2Via2l0Lm9yZy9iLzQzMDQ4PiBVSSBwcm9jZXNzIG5lZWRzIGEgd2F5IHRvIGZpbmQg b3V0CisgICAgICAgIHdoZW4gdGhlIHdlYiBwcm9jZXNzIGNyYXNoZXMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1Bh Z2UuaDogQWRkZWQgV0tQYWdlUHJvY2Vzc0RpZEV4aXRDYWxsYmFjaywgYW5kIGEKKyAgICAgICAg cHJvY2Vzc0RpZEV4aXQgbWVtYmVyIG9mIHRoYXQgdHlwZSB0byBXS1BhZ2VMb2FkZXJDbGllbnQu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViTG9hZGVyQ2xpZW50Ojpwcm9jZXNzRGlkRXhpdCk6IEFkZGVkLiBDYWxscyB0aHJv dWdoIHRvIHRoZQorICAgICAgICBXS1BhZ2VMb2FkZXJDbGllbnQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViTG9hZGVyQ2xpZW50Lmg6IEFkZGVkIHByb2Nlc3NEaWRFeGl0LgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6cHJvY2Vzc0RpZEV4aXQpOiBUZWxsIHRoZSBsb2FkZXIgY2xpZW50IHRoZQorICAgICAg ICBwcm9jZXNzIGV4aXRlZC4KKwogMjAxMC0wNy0yNyAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaCBiL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCmluZGV4IDYwMWY1NTUzYTU3OGY3MjQ1NTU1M2U4 YTQ3NmRhMDM5OTRhMGQwMWMuLmFlNjQ2OWM1ZjMxNzIwMGY3MGRmZTNiYTBjZGNiMWExNDBiZjIx ZDQgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCisrKyBiL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCkBAIC02NSw5ICs2NSwxMCBAQCB0eXBlZGVm IHZvaWQgKCpXS1BhZ2VEaWRDaGFuZ2VQcm9ncmVzc0NhbGxiYWNrKShXS1BhZ2VSZWYgcGFnZSwg Y29uc3Qgdm9pZCAqY2xpZQogdHlwZWRlZiB2b2lkICgqV0tQYWdlRGlkRmluaXNoUHJvZ3Jlc3ND YWxsYmFjaykoV0tQYWdlUmVmIHBhZ2UsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogCiAvLyBX ZWJQYWdlTmFtZXNwYWNlIENsaWVudAotLy8gRklYTUU6IFRoZXNlIHR3byBtZXRob2RzIHNob3Vs ZCBub3QgYmUgcGFydCBvZiB0aGlzIGNsaWVudC4KKy8vIEZJWE1FOiBUaGVzZSB0aHJlZSBmdW5j dGlvbnMgc2hvdWxkIG5vdCBiZSBwYXJ0IG9mIHRoaXMgY2xpZW50LgogdHlwZWRlZiB2b2lkICgq V0tQYWdlRGlkQmVjb21lVW5yZXNwb25zaXZlQ2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBjb25z dCB2b2lkICpjbGllbnRJbmZvKTsKIHR5cGVkZWYgdm9pZCAoKldLUGFnZURpZEJlY29tZVJlc3Bv bnNpdmVDYWxsYmFjaykoV0tQYWdlUmVmIHBhZ2UsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwor dHlwZWRlZiB2b2lkICgqV0tQYWdlUHJvY2Vzc0RpZEV4aXRDYWxsYmFjaykoV0tQYWdlUmVmIHBh Z2UsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogCiB0eXBlZGVmIHZvaWQgKCpXS1BhZ2VEaWRD aGFuZ2VCYWNrRm9yd2FyZExpc3RDYWxsYmFjaykoV0tQYWdlUmVmIHBhZ2UsIGNvbnN0IHZvaWQg KmNsaWVudEluZm8pOwogCkBAIC04OSw5ICs5MCwxMCBAQCBzdHJ1Y3QgV0tQYWdlTG9hZGVyQ2xp ZW50IHsKICAgICBXS1BhZ2VEaWRDaGFuZ2VQcm9ncmVzc0NhbGxiYWNrICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGRpZENoYW5nZVByb2dyZXNzOwogICAgIFdLUGFnZURpZEZp bmlzaFByb2dyZXNzQ2FsbGJhY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGlkRmluaXNoUHJvZ3Jlc3M7CiAKLSAgICAvLyBGSVhNRTogVGhlc2UgdHdvIG1ldGhvZHMgc2hv dWxkIG5vdCBiZSBwYXJ0IG9mIHRoaXMgY2xpZW50LgorICAgIC8vIEZJWE1FOiBUaGVzZSB0aHJl ZSBmdW5jdGlvbnMgc2hvdWxkIG5vdCBiZSBwYXJ0IG9mIHRoaXMgY2xpZW50LgogICAgIFdLUGFn ZURpZEJlY29tZVVucmVzcG9uc2l2ZUNhbGxiYWNrICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZGlkQmVjb21lVW5yZXNwb25zaXZlOwogICAgIFdLUGFnZURpZEJlY29tZVJlc3BvbnNp dmVDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlkQmVjb21lUmVz cG9uc2l2ZTsKKyAgICBXS1BhZ2VQcm9jZXNzRGlkRXhpdENhbGxiYWNrICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHByb2Nlc3NEaWRFeGl0OwogCiAgICAgV0tQYWdlRGlk Q2hhbmdlQmFja0ZvcndhcmRMaXN0Q2FsbGJhY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBkaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3Q7CiB9OwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViTG9hZGVyQ2xpZW50LmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNs aWVudC5jcHAKaW5kZXggYWIyYTY2NDgzZWU2MDI0NDNhNDFmYzI0ODA3ODkzZjRmN2JmODM5Ni4u ZmQ2YmMxNzhkNDA0OTI4M2JhOTEwMWQ3MWZlM2QxYTJhMWMyODhjMCAxMDA2NDQKLS0tIGEvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViTG9hZGVyQ2xpZW50LmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJMb2FkZXJDbGllbnQuY3BwCkBAIC0xMjcsNiArMTI3LDEyIEBAIHZvaWQgV2ViTG9hZGVy Q2xpZW50OjpkaWRCZWNvbWVSZXNwb25zaXZlKFdlYlBhZ2VQcm94eSogcGFnZSkKICAgICAgICAg bV9wYWdlTG9hZGVyQ2xpZW50LmRpZEJlY29tZVJlc3BvbnNpdmUodG9SZWYocGFnZSksIG1fcGFn ZUxvYWRlckNsaWVudC5jbGllbnRJbmZvKTsKIH0KIAordm9pZCBXZWJMb2FkZXJDbGllbnQ6OnBy b2Nlc3NEaWRFeGl0KFdlYlBhZ2VQcm94eSogcGFnZSkKK3sKKyAgICBpZiAobV9wYWdlTG9hZGVy Q2xpZW50LnByb2Nlc3NEaWRFeGl0KQorICAgICAgICBtX3BhZ2VMb2FkZXJDbGllbnQucHJvY2Vz c0RpZEV4aXQodG9SZWYocGFnZSksIG1fcGFnZUxvYWRlckNsaWVudC5jbGllbnRJbmZvKTsKK30K Kwogdm9pZCBXZWJMb2FkZXJDbGllbnQ6OmRpZENoYW5nZUJhY2tGb3J3YXJkTGlzdChXZWJQYWdl UHJveHkqIHBhZ2UpCiB7CiAgICAgaWYgKG1fcGFnZUxvYWRlckNsaWVudC5kaWRDaGFuZ2VCYWNr Rm9yd2FyZExpc3QpCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGll bnQuaCBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5oCmluZGV4IGY5ZTBjMmZj ZDZjMzEzOTRkMGRhOTgyOTlkNDBkZTZkYzg2YzBmM2UuLjE5MDlmOTQyZjYzOGE1OWZiOTg0YmM5 OWVlMmJkMTI2NjVjZjVhNjUgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRl ckNsaWVudC5oCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5oCkBAIC01 NSw5ICs1NSwxMCBAQCBwdWJsaWM6CiAgICAgdm9pZCBkaWRDaGFuZ2VQcm9ncmVzcyhXZWJQYWdl UHJveHkqKTsKICAgICB2b2lkIGRpZEZpbmlzaFByb2dyZXNzKFdlYlBhZ2VQcm94eSopOwogCi0g ICAgLy8gRklYTUU6IFRoZXNlIHR3byBtZXRob2RzIHNob3VsZCBub3QgYmUgcGFydCBvZiB0aGlz IGNsaWVudC4gCisgICAgLy8gRklYTUU6IFRoZXNlIHRocmVlIGZ1bmN0aW9ucyBzaG91bGQgbm90 IGJlIHBhcnQgb2YgdGhpcyBjbGllbnQuCiAgICAgdm9pZCBkaWRCZWNvbWVVbnJlc3BvbnNpdmUo V2ViUGFnZVByb3h5Kik7CiAgICAgdm9pZCBkaWRCZWNvbWVSZXNwb25zaXZlKFdlYlBhZ2VQcm94 eSopOworICAgIHZvaWQgcHJvY2Vzc0RpZEV4aXQoV2ViUGFnZVByb3h5Kik7CiAKICAgICB2b2lk IGRpZENoYW5nZUJhY2tGb3J3YXJkTGlzdChXZWJQYWdlUHJveHkqKTsKIApkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKaW5kZXggODYzZDZkOWU2ZGQ3ODkyNTQwNTM1ZmZkY2QxZTkzMTliZjkx NTYzMi4uNWNkODFhOGYxYjFjNzM3NDE0OTQ0NWQwMzVkN2Q0NjVkZGVkYzU0ZCAxMDA2NDQKLS0t IGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0xMDE0LDggKzEwMTQsOSBAQCB2b2lkIFdlYlBhZ2VQ cm94eTo6cHJvY2Vzc0RpZEV4aXQoKQogICAgIG1fcmVuZGVyVHJlZUV4dGVybmFsUmVwcmVzZW50 YXRpb25DYWxsYmFja3MuY2xlYXIoKTsKIAogICAgIG1fZXN0aW1hdGVkUHJvZ3Jlc3MgPSAwLjA7 Ci0gICAgCisKICAgICBtX3BhZ2VDbGllbnQtPnByb2Nlc3NEaWRFeGl0KCk7CisgICAgbV9sb2Fk ZXJDbGllbnQucHJvY2Vzc0RpZEV4aXQodGhpcyk7CiB9CiAKIHZvaWQgV2ViUGFnZVByb3h5Ojpw cm9jZXNzRGlkUmV2aXZlKCkK