43001 2010-07-26 14:27:47 -0700 WebAccessibilityObject should expose the node and document. 2010-07-27 01:33:59 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 0 dmazzoni webkit-unassigned commit-queue oldest_to_newest 256235 0 dmazzoni 2010-07-26 14:27:47 -0700 Windows screenreaders need properties about the HTML node and containing document in some accessibility objects. 256262 1 62614 dmazzoni 2010-07-26 14:51:36 -0700 Created attachment 62614 Implements proposed feature 256330 2 62614 cfleizach 2010-07-26 16:42:01 -0700 Comment on attachment 62614 Implements proposed feature WebKit/chromium/src/WebAccessibilityObject.cpp:427 + you don't have to cast to a render object. node() exists on AccessibilityObject 256366 3 62636 dmazzoni 2010-07-26 18:37:40 -0700 Created attachment 62636 Fixed previous patch to access node and document without needing a render object. 256411 4 62636 cfleizach 2010-07-27 00:01:11 -0700 Comment on attachment 62636 Fixed previous patch to access node and document without needing a render object. r=me 256441 5 62636 commit-queue 2010-07-27 01:33:53 -0700 Comment on attachment 62636 Fixed previous patch to access node and document without needing a render object. Clearing flags on attachment: 62636 Committed r64113: <http://trac.webkit.org/changeset/64113> 256442 6 commit-queue 2010-07-27 01:33:59 -0700 All reviewed patches have been landed. Closing bug. 62614 2010-07-26 14:51:36 -0700 2010-07-26 18:37:40 -0700 Implements proposed feature webkit2-1 text/plain 3309 dmazzoni SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjQwNzQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMjYgIERvbWlu aWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFjY2Vzc29ycyBmb3Igbm9kZSBhbmQgZG9j dW1lbnQgdG8gV2ViQWNjZXNzaWJpbGl0eU9iamVjdCwKKyAgICAgICAgbmVlZGVkIHRvIHN1cHBv cnQgc29tZSBXaW5kb3dzIHNjcmVlbnJlYWRlciBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzAwMQorICAgICAgICAKKyAg ICAgICAgKiBwdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oOgorICAgICAgICAqIHNyYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQWNjZXNzaWJp bGl0eU9iamVjdDo6bm9kZSk6CisgICAgICAgIChXZWJLaXQ6OldlYkFjY2Vzc2liaWxpdHlPYmpl Y3Q6OmRvY3VtZW50KToKKwogMjAxMC0wNy0yNiAgU2F0aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJsb2NrLgpJbmRleDogV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlz aW9uIDY0MDQ1KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDggQEAgbmFtZXNwYWNlIFdURiB7IHRl bXBsYXRlIDx0eXBlbmFtZSBUPiBjbAogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIFdlYkFj Y2Vzc2liaWxpdHlPYmplY3RQcml2YXRlOworY2xhc3MgV2ViTm9kZTsKK2NsYXNzIFdlYkRvY3Vt ZW50OwogY2xhc3MgV2ViU3RyaW5nOwogc3RydWN0IFdlYlBvaW50Owogc3RydWN0IFdlYlJlY3Q7 CkBAIC0xMDMsNiArMTA1LDkgQEAgcHVibGljOgogICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIHN0 cmluZ1ZhbHVlKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgdGl0bGUoKSBjb25z dDsKIAorICAgIFdFQktJVF9BUEkgV2ViTm9kZSBub2RlKCkgY29uc3Q7CisgICAgV0VCS0lUX0FQ SSBXZWJEb2N1bWVudCBkb2N1bWVudCgpIGNvbnN0OworCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFU SU9OCiAgICAgV2ViQWNjZXNzaWJpbGl0eU9iamVjdChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2Vi Q29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdD4mKTsKICAgICBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0 JiBvcGVyYXRvcj0oY29uc3QgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlP YmplY3Q+Jik7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxpdHlPYmpl Y3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAJKHJldmlzaW9uIDY0MDQ1KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIsOSArMzIsMTMgQEAK ICNpbmNsdWRlICJXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgiCiAKICNpbmNsdWRlICJBY2Nlc3Np YmlsaXR5T2JqZWN0LmgiCisjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oIgog I2luY2x1ZGUgIkV2ZW50SGFuZGxlci5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgorI2luY2x1 ZGUgIk5vZGUuaCIKICNpbmNsdWRlICJQbGF0Zm9ybUtleWJvYXJkRXZlbnQuaCIKKyNpbmNsdWRl ICJXZWJEb2N1bWVudC5oIgorI2luY2x1ZGUgIldlYk5vZGUuaCIKICNpbmNsdWRlICJXZWJQb2lu dC5oIgogI2luY2x1ZGUgIldlYlJlY3QuaCIKICNpbmNsdWRlICJXZWJTdHJpbmcuaCIKQEAgLTQw MSw2ICs0MDUsMzkgQEAgV2ViU3RyaW5nIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OnRpdGxlKAog ICAgIHJldHVybiBtX3ByaXZhdGUtPnRpdGxlKCk7CiB9CiAKKworV2ViTm9kZSBXZWJBY2Nlc3Np YmlsaXR5T2JqZWN0Ojpub2RlKCkgY29uc3QKK3sKKyAgICBpZiAoIW1fcHJpdmF0ZSkKKyAgICAg ICAgcmV0dXJuIFdlYk5vZGUoKTsKKworICAgIG1fcHJpdmF0ZS0+dXBkYXRlQmFja2luZ1N0b3Jl KCk7CisKKyAgICBpZiAoIW1fcHJpdmF0ZS0+aXNBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0KCkp CisgICAgICAgIHJldHVybiBXZWJOb2RlKCk7CisKKyAgICBBY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0KiByZW5kZXJPYmplY3QgPQorICAgICAgICByZWludGVycHJldF9jYXN0PEFjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3QqPihtX3ByaXZhdGUpOworICAgIE5vZGUqIG5vZGUgPSByZW5kZXJPYmpl Y3QtPm5vZGUoKTsKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJldHVybiBXZWJOb2RlKCk7CisK KyAgICByZXR1cm4gV2ViTm9kZShub2RlKTsKK30KKworV2ViRG9jdW1lbnQgV2ViQWNjZXNzaWJp bGl0eU9iamVjdDo6ZG9jdW1lbnQoKSBjb25zdAoreworICAgIGlmICghbV9wcml2YXRlKQorICAg ICAgICByZXR1cm4gV2ViRG9jdW1lbnQoKTsKKworICAgIG1fcHJpdmF0ZS0+dXBkYXRlQmFja2lu Z1N0b3JlKCk7CisKKyAgICBpZiAoIW1fcHJpdmF0ZS0+aXNBY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0KCkpCisgICAgICAgIHJldHVybiBXZWJEb2N1bWVudCgpOworCisgICAgcmV0dXJuIFdlYkRv Y3VtZW50KG1fcHJpdmF0ZS0+ZG9jdW1lbnQoKSk7Cit9CisKIFdlYkFjY2Vzc2liaWxpdHlPYmpl Y3Q6OldlYkFjY2Vzc2liaWxpdHlPYmplY3QoY29uc3QgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6 OkFjY2Vzc2liaWxpdHlPYmplY3Q+JiBvYmplY3QpCiAgICAgOiBtX3ByaXZhdGUoc3RhdGljX2Nh c3Q8V2ViQWNjZXNzaWJpbGl0eU9iamVjdFByaXZhdGUqPihvYmplY3QucmVsZWFzZVJlZigpKSkK IHsK 62636 2010-07-26 18:37:40 -0700 2010-07-27 01:33:53 -0700 Fixed previous patch to access node and document without needing a render object. webkit2-2 text/plain 3103 dmazzoni SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjQwOTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMjYgIERvbWlu aWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFjY2Vzc29ycyBmb3Igbm9kZSBhbmQgZG9j dW1lbnQgdG8gV2ViQWNjZXNzaWJpbGl0eU9iamVjdCwKKyAgICAgICAgbmVlZGVkIHRvIHN1cHBv cnQgc29tZSBXaW5kb3dzIHNjcmVlbnJlYWRlciBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzAwMQorICAgICAgICAKKyAg ICAgICAgKiBwdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oOgorICAgICAgICAqIHNyYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQWNjZXNzaWJp bGl0eU9iamVjdDo6bm9kZSk6CisgICAgICAgIChXZWJLaXQ6OldlYkFjY2Vzc2liaWxpdHlPYmpl Y3Q6OmRvY3VtZW50KToKKwogMjAxMC0wNy0yNiAgRG9taW5pYyBNYXp6b25pICA8ZG1henpvbmlA Z29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBGbGVpemFjaC4KSW5kZXg6 IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oCShy ZXZpc2lvbiA2NDA5NikKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw4IEBAIG5hbWVzcGFjZSBXVEYg eyB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gY2wKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBX ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0UHJpdmF0ZTsKK2NsYXNzIFdlYk5vZGU7CitjbGFzcyBXZWJE b2N1bWVudDsKIGNsYXNzIFdlYlN0cmluZzsKIHN0cnVjdCBXZWJQb2ludDsKIHN0cnVjdCBXZWJS ZWN0OwpAQCAtMTAzLDYgKzEwNSw5IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfQVBJIFdlYlN0cmlu ZyBzdHJpbmdWYWx1ZSgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIHRpdGxlKCkg Y29uc3Q7CiAKKyAgICBXRUJLSVRfQVBJIFdlYk5vZGUgbm9kZSgpIGNvbnN0OworICAgIFdFQktJ VF9BUEkgV2ViRG9jdW1lbnQgZG9jdW1lbnQoKSBjb25zdDsKKwogI2lmIFdFQktJVF9JTVBMRU1F TlRBVElPTgogICAgIFdlYkFjY2Vzc2liaWxpdHlPYmplY3QoY29uc3QgV1RGOjpQYXNzUmVmUHRy PFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q+Jik7CiAgICAgV2ViQWNjZXNzaWJpbGl0eU9i amVjdCYgb3BlcmF0b3I9KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpBY2Nlc3NpYmls aXR5T2JqZWN0PiYpOwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2li aWxpdHlPYmplY3QuY3BwCShyZXZpc2lvbiA2NDA5NikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDkgKzMyLDEz IEBACiAjaW5jbHVkZSAiV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oIgogCiAjaW5jbHVkZSAiQWNj ZXNzaWJpbGl0eU9iamVjdC5oIgorI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRXZl bnRIYW5kbGVyLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCisjaW5jbHVkZSAiTm9kZS5oIgog I2luY2x1ZGUgIlBsYXRmb3JtS2V5Ym9hcmRFdmVudC5oIgorI2luY2x1ZGUgIldlYkRvY3VtZW50 LmgiCisjaW5jbHVkZSAiV2ViTm9kZS5oIgogI2luY2x1ZGUgIldlYlBvaW50LmgiCiAjaW5jbHVk ZSAiV2ViUmVjdC5oIgogI2luY2x1ZGUgIldlYlN0cmluZy5oIgpAQCAtNDAxLDYgKzQwNSwzNSBA QCBXZWJTdHJpbmcgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6dGl0bGUoCiAgICAgcmV0dXJuIG1f cHJpdmF0ZS0+dGl0bGUoKTsKIH0KIAorCitXZWJOb2RlIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6 Om5vZGUoKSBjb25zdAoreworICAgIGlmICghbV9wcml2YXRlKQorICAgICAgICByZXR1cm4gV2Vi Tm9kZSgpOworCisgICAgbV9wcml2YXRlLT51cGRhdGVCYWNraW5nU3RvcmUoKTsKKworICAgIE5v ZGUqIG5vZGUgPSBtX3ByaXZhdGUtPm5vZGUoKTsKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJl dHVybiBXZWJOb2RlKCk7CisKKyAgICByZXR1cm4gV2ViTm9kZShub2RlKTsKK30KKworV2ViRG9j dW1lbnQgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6ZG9jdW1lbnQoKSBjb25zdAoreworICAgIGlm ICghbV9wcml2YXRlKQorICAgICAgICByZXR1cm4gV2ViRG9jdW1lbnQoKTsKKworICAgIG1fcHJp dmF0ZS0+dXBkYXRlQmFja2luZ1N0b3JlKCk7CisKKyAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBt X3ByaXZhdGUtPmRvY3VtZW50KCk7CisgICAgaWYgKCFkb2N1bWVudCkKKyAgICAgICAgcmV0dXJu IFdlYkRvY3VtZW50KCk7CisKKyAgICByZXR1cm4gV2ViRG9jdW1lbnQoZG9jdW1lbnQpOworfQor CiBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0OjpXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KGNvbnN0IFdU Rjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0PiYgb2JqZWN0KQogICAg IDogbV9wcml2YXRlKHN0YXRpY19jYXN0PFdlYkFjY2Vzc2liaWxpdHlPYmplY3RQcml2YXRlKj4o b2JqZWN0LnJlbGVhc2VSZWYoKSkpCiB7Cg==