42990 2010-07-26 12:09:44 -0700 REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling 2010-07-26 15:54:38 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar, Regression P1 Major --- 1 smkolins mrowe abarth ap arv commit-queue darin eric.carlson eric hyatt me mjs mrowe peter usingpond webkit webkit.review.bot oldest_to_newest 256155 0 smkolins 2010-07-26 12:09:44 -0700 sometimes rss feeds don't show anything but the first entry and sometimes the trail to the right but cut off, and sometimes there is a navigation step sideways provided. The traditional vertical list is by far the best but doesn't work at all. See <feed:https://service.govdelivery.com/service/rss/updates.rss?code=USLOC> (entries go sideways to the right but get chopped off) <feed://www.physorg.com/rss-feed/space-news/> where no entries except the first are visible at all <feed://www.sciencecentric.com/feeds/> where sideways steps are provided but of far less utility than the original vertical default. The end result is that reading rss feeds is almost useless. 256177 1 mrowe 2010-07-26 12:43:52 -0700 This broke with <http://trac.webkit.org/changeset/63854>. 256179 2 mrowe 2010-07-26 12:45:02 -0700 Sadly r63854 doesn’t mention which bug it is related to. 256181 3 mrowe 2010-07-26 12:45:59 -0700 Found it. It seems to be related to bug 42093. 256185 4 mrowe 2010-07-26 12:50:07 -0700 <rdar://problem/8235718> 256187 5 eric 2010-07-26 12:53:14 -0700 cd "/System/Library/Frameworks/PubSub.framework/Versions/A/Resources/PubSubAgent.app/Contents/Resources/" grep -e "-apple-" -r . Main.css: -apple-text-size-adjust: none; Main.css: -apple-line-clamp: 100%; Main.css: -apple-text-size-adjust: none; grep -e "-khtml-" -r . Main.css: -khtml-user-select: none; Main.css: display: -khtml-box; Main.css: -khtml-box-orient: vertical; Main.css: display: -khtml-box; Main.css: -khtml-box-orient: horizontal; Main.css: -khtml-box-align: baseline; Main.css: -khtml-user-select: none; Main.css: -khtml-margin-top-collapse:discard; Main.css: -khtml-margin-top-collapse:discard; Main.css: -khtml-user-select: none; Main.css:.apple-rss-multi-line-mode .apple-rss-subject { -khtml-box-flex: 60; } Main.css:.apple-rss-multi-line-mode .apple-rss-author { -khtml-box-flex: 40; } Main.css:.apple-rss-single-line-mode .apple-rss-subject { -khtml-box-flex: 1; -khtml-box-flex-group: 1; } Main.css:.apple-rss-single-line-mode .apple-rss-source { -khtml-box-flex: 1; -khtml-box-flex-group: 2; font-size: 12px; } Main.css:.apple-rss-single-line-mode .apple-rss-summary { -khtml-box-flex: 1; -khtml-box-flex-group: 4; } Main.css:.apple-rss-single-line-mode .apple-rss-date { -khtml-box-flex: 1; -khtml-box-flex-group: 100; font-size: 12px; text-align: right; margin-right: 0; } Are the culprits 256192 6 mrowe 2010-07-26 13:03:29 -0700 I find it incredibly unlikely that Safari RSS is the only thing that uses -khtml or -apple vendor prefixes. Dashboard widgets, Dashcode templates, and third-party applications (Yahoo! Messenger) all appear to make use of these prefixes in some form. 256193 7 mrowe 2010-07-26 13:09:46 -0700 I would like to propose rolling out r63854 and having that issue revisited in a manner that takes backwards-compatibility in to consideration. 256204 8 62599 mrowe 2010-07-26 13:46:31 -0700 Created attachment 62599 Patch This reverts only the WebCore portion of r63854. I see no reason to revert the layout test portion of that revision. 256207 9 webkit.review.bot 2010-07-26 13:47:57 -0700 Attachment 62599 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/css/CSSParser.cpp:5622: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 256212 10 mrowe 2010-07-26 13:53:15 -0700 Landed in r64071. 256230 11 webkit.review.bot 2010-07-26 14:11:25 -0700 http://trac.webkit.org/changeset/64071 might have broken GTK Linux 32-bit Release 256306 12 mrowe 2010-07-26 15:54:03 -0700 *** Bug 42896 has been marked as a duplicate of this bug. *** 256308 13 mrowe 2010-07-26 15:54:38 -0700 *** Bug 42898 has been marked as a duplicate of this bug. *** 62599 2010-07-26 13:46:31 -0700 2010-07-26 13:48:20 -0700 Patch 0001-REGRESSION-r63854-Safari-RSS-layout-is-broken-due-to.patch text/plain 4953 mrowe RnJvbSA3YzUzMWNjMTA4YmVhZDBmZWRjMGMwMzViMDQ1NTg1MTEwMmZmMjg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogTW9u LCAyNiBKdWwgMjAxMCAxMzo0NTowOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFJFR1JFU1NJT04g KHI2Mzg1NCk6IFNhZmFyaSBSU1MgbGF5b3V0IGlzIGJyb2tlbiBkdWUgdG8gY2hhbmdlcyBpbiB2 ZW5kb3IgcHJlZml4IGhhbmRsaW5nCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkluIHI2 Mzg1NCBzdXBwb3J0IGZvciBwcm9wZXJ0aWVzIHdpdGggdGhlIC1raHRtbCB2ZW5kb3IgcHJlZml4 IHdhcyByZW1vdmVkLiBUaGlzIGJyZWFrcyB0aGUgbGF5b3V0IG9mClNhZmFyaSdzIFJTUyBpbnRl cmZhY2UsIHNldmVyYWwgRGFzaGJvYXJkIHdpZGdldHMgdGhhdCBhcmUgaW5jbHVkZWQgd2l0aCBN YWMgT1MgWCwgYW5kIGF0IGxlYXN0IG9uZQpwb3B1bGFyIHRoaXJkLXBhcnR5IE1hYyBPUyBYIGFw cGxpY2F0aW9uLiBUaGlzIGNoYW5nZSB3aWxsIG5lZWQgdG8gYmUgcmV2aXNpdGVkIGluIGEgbWFu bmVyIHRoYXQgaGFzCmEgY2xlYXJlciBiYWNrd2FyZHMtY29tcGF0aWJpbGl0eSBzdHJhdGVneS4g PGh0dHA6Ly93ZWJraXQub3JnL2IvNDIwOTM+IHdpbGwgYmUgcmVvcGVuZWQgdG8gdHJhY2sgdGhh dC4KCiogY3NzL0NTU1BhcnNlci5jcHA6CihXZWJDb3JlOjpjc3NQcm9wZXJ0eUlEKTogUmV2ZXJ0 IHRoZSBXZWJDb3JlIGNoYW5nZSBmcm9tIHI2Mzg1NC4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCB8 ICAgNDAgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBhODdlMDEuLjc3ZmUx YjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDUgKzEsMTkgQEAKIDIwMTAtMDctMjYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNv bT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNjM4NTQpOiBTYWZhcmkgUlNTIGxheW91dCBpcyBicm9rZW4gZHVlIHRvIGNoYW5n ZXMgaW4gdmVuZG9yIHByZWZpeCBoYW5kbGluZworCisgICAgICAgIEluIHI2Mzg1NCBzdXBwb3J0 IGZvciBwcm9wZXJ0aWVzIHdpdGggdGhlIC1raHRtbCB2ZW5kb3IgcHJlZml4IHdhcyByZW1vdmVk LiBUaGlzIGJyZWFrcyB0aGUgbGF5b3V0IG9mCisgICAgICAgIFNhZmFyaSdzIFJTUyBpbnRlcmZh Y2UsIHNldmVyYWwgRGFzaGJvYXJkIHdpZGdldHMgdGhhdCBhcmUgaW5jbHVkZWQgd2l0aCBNYWMg T1MgWCwgYW5kIGF0IGxlYXN0IG9uZQorICAgICAgICBwb3B1bGFyIHRoaXJkLXBhcnR5IE1hYyBP UyBYIGFwcGxpY2F0aW9uLiBUaGlzIGNoYW5nZSB3aWxsIG5lZWQgdG8gYmUgcmV2aXNpdGVkIGlu IGEgbWFubmVyIHRoYXQgaGFzCisgICAgICAgIGEgY2xlYXJlciBiYWNrd2FyZHMtY29tcGF0aWJp bGl0eSBzdHJhdGVneS4gPGh0dHA6Ly93ZWJraXQub3JnL2IvNDIwOTM+IHdpbGwgYmUgcmVvcGVu ZWQgdG8gdHJhY2sgdGhhdC4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Y3NzUHJvcGVydHlJRCk6IFJldmVydCB0aGUgV2ViQ29yZSBjaGFuZ2UgZnJv bSByNjM4NTQuCisKKzIwMTAtMDctMjYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKwog ICAgICAgICBGaXggYW4gI2lmIGluIFdlYkNvcmUuZXhwLmluIHRvIGNvcnJlY3RseSBkZXRlY3Qg d2hldGhlciBTVkcgZmlsdGVycyBhcmUgZW5hYmxlZC4KIAogICAgICAgICAqIFdlYkNvcmUuZXhw LmluOgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKaW5kZXggY2UxZjA1Zi4uYmQ1ZGI0NCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC01 NjEwLDI3ICs1NjEwLDMxIEBAIHN0YXRpYyBpbnQgY3NzUHJvcGVydHlJRChjb25zdCBVQ2hhciog cHJvcGVydHlOYW1lLCB1bnNpZ25lZCBsZW5ndGgpCiAKICAgICBjb25zdCBjaGFyKiBuYW1lID0g YnVmZmVyOwogICAgIGlmIChidWZmZXJbMF0gPT0gJy0nKSB7Ci0gICAgICAgIGlmICghc3RyY21w KGJ1ZmZlciwgIi1hcHBsZS1kYXNoYm9hcmQtcmVnaW9uIikgfHwgIXN0cmNtcChidWZmZXIsICIt YXBwbGUtbGluZS1jbGFtcCIpKSB7Ci0gICAgICAgICAgICAvLyBTdXBwb3J0IHR3byBBcHBsZS1z cGVjaWZpYyBDU1MgcHJvcGVydGllcyBwcmV2aW91c2x5IHVzZWQgZm9yCi0gICAgICAgICAgICAv LyB0aGUgRGFzaGJvYXJkIGFuZCBTYWZhcmkgUlNTIGxpbmUgY2xhbXBpbmcuCisgICAgICAgIC8v IElmIHRoZSBwcmVmaXggaXMgLWFwcGxlLSBvciAta2h0bWwtLCBjaGFuZ2UgaXQgdG8gLXdlYmtp dC0uCisgICAgICAgIC8vIFRoaXMgbWFrZXMgdGhlIHN0cmluZyBvbmUgY2hhcmFjdGVyIGxvbmdl ci4KKyAgICAgICAgaWYgKGhhc1ByZWZpeChidWZmZXIsIGxlbmd0aCwgIi1hcHBsZS0iKSB8fCBo YXNQcmVmaXgoYnVmZmVyLCBsZW5ndGgsICIta2h0bWwtIikpIHsKICAgICAgICAgICAgIG1lbW1v dmUoYnVmZmVyICsgNywgYnVmZmVyICsgNiwgbGVuZ3RoICsgMSAtIDYpOwogICAgICAgICAgICAg bWVtY3B5KGJ1ZmZlciwgIi13ZWJraXQiLCA3KTsKICAgICAgICAgICAgICsrbGVuZ3RoOwotICAg ICAgICB9IGVsc2UgaWYgKCFzdHJjbXAoYnVmZmVyLCAiLXdlYmtpdC1vcGFjaXR5IikpIHsKLSAg ICAgICAgICAgIC8vIEhvbm9yIC13ZWJraXQtb3BhY2l0eSBhcyBhIHN5bm9ueW0gZm9yIG9wYWNp dHkuIFRoaXMgd2FzIHRoZSBvbmx5Ci0gICAgICAgICAgICAvLyBzeW50YXggdGhhdCB3b3JrZWQg aW4gU2FmYXJpIDEuMSwgYW5kIG1heSBiZSBpbiB1c2Ugb24gc29tZSB3ZWJzaXRlcyBhbmQgd2lk Z2V0cy4KLSAgICAgICAgICAgIGNvbnN0IGNoYXIqIGNvbnN0IG9wYWNpdHkgPSAib3BhY2l0eSI7 Ci0gICAgICAgICAgICBuYW1lID0gb3BhY2l0eTsKLSAgICAgICAgICAgIGxlbmd0aCA9IDc7Ci0g ICAgICAgIH0gZWxzZSBpZiAoaGFzUHJlZml4KGJ1ZmZlciwgbGVuZ3RoLCAiLXdlYmtpdC1ib3Jk ZXItIikpIHsKLSAgICAgICAgICAgIC8vIC13ZWJraXQtYm9yZGVyLSotKi1yYWRpdXMgd29ya2Vk IGluIFNhZmFyaSA0IGFuZCBlYXJsaWVyLiAtd2Via2l0LWJvcmRlci1yYWRpdXMgc3ludGF4Ci0g ICAgICAgICAgICAvLyBkaWZmZXJzIGZyb20gYm9yZGVyLXJhZGl1cywgc28gaXQgcmVtYWlucyBh cyBhIGRpc3RpbmN0IHByb3BlcnR5LgotICAgICAgICAgICAgaWYgKCFzdHJjbXAoYnVmZmVyICsg MTUsICJ0b3AtbGVmdC1yYWRpdXMiKQotICAgICAgICAgICAgICAgICAgICB8fCAhc3RyY21wKGJ1 ZmZlciArIDE1LCAidG9wLXJpZ2h0LXJhZGl1cyIpCi0gICAgICAgICAgICAgICAgICAgIHx8ICFz dHJjbXAoYnVmZmVyICsgMTUsICJib3R0b20tcmlnaHQtcmFkaXVzIikKLSAgICAgICAgICAgICAg ICAgICAgfHwgIXN0cmNtcChidWZmZXIgKyAxNSwgImJvdHRvbS1sZWZ0LXJhZGl1cyIpKSB7Ci0g ICAgICAgICAgICAgICAgbmFtZSA9IGJ1ZmZlciArIDg7Ci0gICAgICAgICAgICAgICAgbGVuZ3Ro IC09IDg7CisgICAgICAgIH0KKworICAgICAgICBpZiAoaGFzUHJlZml4KGJ1ZmZlciwgbGVuZ3Ro LCAiLXdlYmtpdCIpKSB7CisgICAgICAgICAgICBpZiAoc3RyY21wKGJ1ZmZlciwgIi13ZWJraXQt b3BhY2l0eSIpID09IDApIHsKKyAgICAgICAgICAgICAgICAvLyBIb25vciAtd2Via2l0LW9wYWNp dHkgYXMgYSBzeW5vbnltIGZvciBvcGFjaXR5LgorICAgICAgICAgICAgICAgIC8vIFRoaXMgd2Fz IHRoZSBvbmx5IHN5bnRheCB0aGF0IHdvcmtlZCBpbiBTYWZhcmkgMS4xLCBhbmQgbWF5IGJlIGlu IHVzZSBvbiBzb21lIHdlYnNpdGVzIGFuZCB3aWRnZXRzLgorICAgICAgICAgICAgICAgIGNvbnN0 IGNoYXIqIGNvbnN0IG9wYWNpdHkgPSAib3BhY2l0eSI7CisgICAgICAgICAgICAgICAgbmFtZSA9 IG9wYWNpdHk7CisgICAgICAgICAgICAgICAgbGVuZ3RoID0gc3RybGVuKG9wYWNpdHkpOworICAg ICAgICAgICAgfSBlbHNlIGlmIChoYXNQcmVmaXgoYnVmZmVyICsgNywgbGVuZ3RoIC0gNywgIi1i b3JkZXItIikpIHsKKyAgICAgICAgICAgICAgICAvLyAtd2Via2l0LWJvcmRlci0qLSotcmFkaXVz IHdvcmtlZCBpbiBTYWZhcmkgNCBhbmQgZWFybGllci4gLXdlYmtpdC1ib3JkZXItcmFkaXVzIHN5 bnRheAorICAgICAgICAgICAgICAgIC8vIGRpZmZlcnMgZnJvbSBib3JkZXItcmFkaXVzLCBzbyBp dCBpcyByZW1haW5zIGFzIGEgZGlzdGluY3QgcHJvcGVydHkuCisgICAgICAgICAgICAgICAgaWYg KCFzdHJjbXAoYnVmZmVyICsgMTUsICJ0b3AtbGVmdC1yYWRpdXMiKQorICAgICAgICAgICAgICAg ICAgICAgICAgfHwgIXN0cmNtcChidWZmZXIgKyAxNSwgInRvcC1yaWdodC1yYWRpdXMiKQorICAg ICAgICAgICAgICAgICAgICAgICAgfHwgIXN0cmNtcChidWZmZXIgKyAxNSwgImJvdHRvbS1yaWdo dC1yYWRpdXMiKQorICAgICAgICAgICAgICAgICAgICAgICAgfHwgIXN0cmNtcChidWZmZXIgKyAx NSwgImJvdHRvbS1sZWZ0LXJhZGl1cyIpKSB7CisgICAgICAgICAgICAgICAgICAgIG5hbWUgPSBi dWZmZXIgKyA4OworICAgICAgICAgICAgICAgICAgICBsZW5ndGggLT0gODsKKyAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9Ci0tIAoxLjcuMgoK