42974 2010-07-26 08:04:48 -0700 [Qt] WebKit::PageClient implementation needs a dedicated class 2010-07-27 05:27:44 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kbalazs kbalazs abecsi commit-queue kenneth koivisto tonikitoo oldest_to_newest 256042 0 kbalazs 2010-07-26 08:04:48 -0700 WebPageProxy is the owner of the PageClient so setting the QWKPagePrivate as PageClient is wrong (QWKPagePrivate holds the WebPageProxy and that would destroy it so the callchain ends in double destruction). 256043 1 62574 kbalazs 2010-07-26 08:10:26 -0700 Created attachment 62574 proposed patch 256051 2 62577 kbalazs 2010-07-26 08:32:28 -0700 Created attachment 62577 proposed patch Oops, the last one did not build. 256086 3 62577 kenneth 2010-07-26 10:09:34 -0700 Comment on attachment 62577 proposed patch page->setPageClient(new PageClientImpl(qq)); If this is being deleted automatically (is it an OwnPtr?), it would be nice with a comment here. 256514 4 62682 kbalazs 2010-07-27 04:44:30 -0700 Created attachment 62682 proposed patch Comment - suggested by Kenneth - has been added. 256530 5 62682 commit-queue 2010-07-27 05:27:40 -0700 Comment on attachment 62682 proposed patch Clearing flags on attachment: 62682 Committed r64122: <http://trac.webkit.org/changeset/64122> 256531 6 commit-queue 2010-07-27 05:27:44 -0700 All reviewed patches have been landed. Closing bug. 62574 2010-07-26 08:10:26 -0700 2010-07-26 08:32:28 -0700 proposed patch pageclientimpl_ch.diff text/plain 3777 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODI3YmUxYy4uNjI2NmRmYSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNy0yNiAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBXZWJLaXQ6OlBhZ2VDbGllbnQgaW1wbGVtZW50YXRpb24g bmVlZHMgYSBkZWRpY2F0ZWQgY2xhc3MKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDI5NzQKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdr cGFnZS5jcHA6CisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6UGFnZUNsaWVudEltcGwpOgorICAg ICAgICAoUGFnZUNsaWVudEltcGw6OnBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcp OgorICAgICAgICAoUGFnZUNsaWVudEltcGw6OnBhZ2VEaWRMZWF2ZUFjY2VsZXJhdGVkQ29tcG9z aXRpbmcpOgorICAgICAgICAoUGFnZUNsaWVudEltcGw6OnByb2Nlc3NEaWRFeGl0KToKKyAgICAg ICAgKFBhZ2VDbGllbnRJbXBsOjpwcm9jZXNzRGlkUmV2aXZlKToKKyAgICAgICAgKFBhZ2VDbGll bnRJbXBsOjpzZXRDdXJzb3IpOgorICAgICAgICAoUGFnZUNsaWVudEltcGw6OnRha2VGb2N1cyk6 CisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6dG9vbFRpcENoYW5nZWQpOgorICAgICAgICAoUVdL UGFnZVByaXZhdGU6OlFXS1BhZ2VQcml2YXRlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2VfcC5oOgorCiAyMDEwLTA3LTE5IEJhbGF6cyBLZWxlbWVuIDxrYkBpbmYudS1zemVn ZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4u CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggNTA3NGMyYS4uYzI5N2M3MSAx MDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtMzcsMTMgKzM3LDQwIEBACiB1 c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKK2NsYXNz IFBhZ2VDbGllbnRJbXBsIDogcHVibGljIFdlYktpdDo6UGFnZUNsaWVudCB7CitwdWJsaWM6Cisg ICAgUGFnZUNsaWVudEltcGwoUVdLUGFnZSopCisgICAgICAgIDogbV9wYWdlKHBhZ2UpCisgICAg eworICAgIH0KKworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICB2b2lkIHBh Z2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KKyAgICB2b2lkIHBhZ2VEaWRM ZWF2ZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KKyNlbmRpZiAvLyBVU0UoQUNDRUxFUkFU RURfQ09NUE9TSVRJTkcpCisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRFeGl0KCkgeyB9Cisg ICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRSZXZpdmUoKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQg c2V0Q3Vyc29yKGNvbnN0IFdlYkNvcmU6OkN1cnNvciYpIHsgfQorICAgIHZpcnR1YWwgdm9pZCB0 YWtlRm9jdXMoYm9vbCBkaXJlY3Rpb24pIHsgfQorCisgICAgdmlydHVhbCB2b2lkIHRvb2xUaXBD aGFuZ2VkKGNvbnN0IFdlYkNvcmU6OlN0cmluZyYsIGNvbnN0IFdlYkNvcmU6OlN0cmluZyYpOwor Citwcml2YXRlOgorICAgIFFXS1BhZ2UqIG1fcGFnZTsKK307CisKK3ZvaWQgUGFnZUNsaWVudElt cGw6OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYgbmV3VG9vbHRp cCkKK3sKKyAgICBlbWl0IG1fcGFnZS0+c3RhdHVzQmFyTWVzc2FnZShRU3RyaW5nKG5ld1Rvb2x0 aXApKTsKK30KKwogUVdLUGFnZVByaXZhdGU6OlFXS1BhZ2VQcml2YXRlKFFXS1BhZ2UqIHFxLCBX S1BhZ2VOYW1lc3BhY2VSZWYgbmFtZXNwYWNlUmVmKQogICAgIDogcShxcSkKICAgICAsIGNyZWF0 ZU5ld1BhZ2VGbigwKQogewogICAgIG1lbXNldChhY3Rpb25zLCAwLCBzaXplb2YoYWN0aW9ucykp OwogICAgIHBhZ2UgPSB0b1dLKG5hbWVzcGFjZVJlZiktPmNyZWF0ZVdlYlBhZ2UoKTsKLSAgICBw YWdlLT5zZXRQYWdlQ2xpZW50KHRoaXMpOworICAgIHBhZ2UtPnNldFBhZ2VDbGllbnQobmV3IFBh Z2VDbGllbnRJbXBsKHFxKSk7CiB9CiAKIFFXS1BhZ2VQcml2YXRlOjp+UVdLUGFnZVByaXZhdGUo KQpAQCAtNTYsMTEgKzgzLDYgQEAgdm9pZCBRV0tQYWdlUHJpdmF0ZTo6aW5pdChjb25zdCBRU2l6 ZSYgdmlld3BvcnRTaXplLCBEcmF3aW5nQXJlYVByb3h5KiBwcm94eSkKICAgICBwYWdlLT5pbml0 aWFsaXplV2ViUGFnZShJbnRTaXplKHZpZXdwb3J0U2l6ZSksIHByb3h5KTsKIH0KIAotdm9pZCBR V0tQYWdlUHJpdmF0ZTo6dG9vbFRpcENoYW5nZWQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5n JiBuZXdUb29sdGlwKQotewotICAgIGVtaXQgcS0+c3RhdHVzQmFyTWVzc2FnZShRU3RyaW5nKG5l d1Rvb2x0aXApKTsKLX0KLQogdm9pZCBRV0tQYWdlUHJpdmF0ZTo6cGFpbnQoUVBhaW50ZXIqIHBh aW50ZXIsIFFSZWN0IGFyZWEpCiB7CiAgICAgcGFpbnRlci0+c2F2ZSgpOwpkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2VfcC5oIGIvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3F3a3BhZ2VfcC5oCmluZGV4IDNlNjc2ZWYuLjBjNjE3YTMgMTAwNjQ0Ci0tLSBhL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZV9wLmgKQEAgLTMxLDcgKzMxLDcgQEAKICNpbmNsdWRlIDxRR3JhcGhp Y3NWaWV3PgogI2luY2x1ZGUgPFFLZXlFdmVudD4KIAotY2xhc3MgUVdLUGFnZVByaXZhdGUgOiBw dWJsaWMgV2ViS2l0OjpQYWdlQ2xpZW50IHsKK2NsYXNzIFFXS1BhZ2VQcml2YXRlIHsKIHB1Ymxp YzoKICAgICBRV0tQYWdlUHJpdmF0ZShRV0tQYWdlKiwgV0tQYWdlTmFtZXNwYWNlUmVmKTsKICAg ICB+UVdLUGFnZVByaXZhdGUoKTsKQEAgLTQwLDE2ICs0MCw2IEBAIHB1YmxpYzoKIAogICAgIHZv aWQgaW5pdChjb25zdCBRU2l6ZSYgdmlld3BvcnRTaXplLCBXZWJLaXQ6OkRyYXdpbmdBcmVhUHJv eHkqKTsKIAotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICB2b2lkIHBhZ2VE aWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7fQotICAgIHZvaWQgcGFnZURpZExlYXZl QWNjZWxlcmF0ZWRDb21wb3NpdGluZygpIHt9Ci0jZW5kaWYgLy8gVVNFKEFDQ0VMRVJBVEVEX0NP TVBPU0lUSU5HKQotICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkRXhpdCgpIHt9Ci0gICAgdmly dHVhbCB2b2lkIHByb2Nlc3NEaWRSZXZpdmUoKSB7fQotICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJz b3IoY29uc3QgV2ViQ29yZTo6Q3Vyc29yJikge30KLSAgICB2aXJ0dWFsIHZvaWQgdGFrZUZvY3Vz KGJvb2wgZGlyZWN0aW9uKSB7fQotICAgIHZpcnR1YWwgdm9pZCB0b29sVGlwQ2hhbmdlZChjb25z dCBXZWJDb3JlOjpTdHJpbmcmLCBjb25zdCBXZWJDb3JlOjpTdHJpbmcmKTsKLQogICAgIHZvaWQg cGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIsIFFSZWN0KTsKIAogICAgIHZvaWQga2V5UHJlc3NFdmVu dChRS2V5RXZlbnQqKTsK 62577 2010-07-26 08:32:28 -0700 2010-07-27 04:44:30 -0700 proposed patch pageclientimpl_ch.diff text/plain 3782 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODI3YmUxYy4uNjI2NmRmYSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNy0yNiAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBXZWJLaXQ6OlBhZ2VDbGllbnQgaW1wbGVtZW50YXRpb24g bmVlZHMgYSBkZWRpY2F0ZWQgY2xhc3MKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDI5NzQKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdr cGFnZS5jcHA6CisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6UGFnZUNsaWVudEltcGwpOgorICAg ICAgICAoUGFnZUNsaWVudEltcGw6OnBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcp OgorICAgICAgICAoUGFnZUNsaWVudEltcGw6OnBhZ2VEaWRMZWF2ZUFjY2VsZXJhdGVkQ29tcG9z aXRpbmcpOgorICAgICAgICAoUGFnZUNsaWVudEltcGw6OnByb2Nlc3NEaWRFeGl0KToKKyAgICAg ICAgKFBhZ2VDbGllbnRJbXBsOjpwcm9jZXNzRGlkUmV2aXZlKToKKyAgICAgICAgKFBhZ2VDbGll bnRJbXBsOjpzZXRDdXJzb3IpOgorICAgICAgICAoUGFnZUNsaWVudEltcGw6OnRha2VGb2N1cyk6 CisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6dG9vbFRpcENoYW5nZWQpOgorICAgICAgICAoUVdL UGFnZVByaXZhdGU6OlFXS1BhZ2VQcml2YXRlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2VfcC5oOgorCiAyMDEwLTA3LTE5IEJhbGF6cyBLZWxlbWVuIDxrYkBpbmYudS1zemVn ZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4u CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggNTA3NGMyYS4uZmQxMmI0ZCAx MDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtMzcsMTMgKzM3LDQwIEBACiB1 c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKK2NsYXNz IFBhZ2VDbGllbnRJbXBsIDogcHVibGljIFdlYktpdDo6UGFnZUNsaWVudCB7CitwdWJsaWM6Cisg ICAgUGFnZUNsaWVudEltcGwoUVdLUGFnZSogcGFnZSkKKyAgICAgICAgOiBtX3BhZ2UocGFnZSkK KyAgICB7CisgICAgfQorCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIHZv aWQgcGFnZURpZEVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpIHsgfQorICAgIHZvaWQgcGFn ZURpZExlYXZlQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpIHsgfQorI2VuZGlmIC8vIFVTRShBQ0NF TEVSQVRFRF9DT01QT1NJVElORykKKyAgICB2aXJ0dWFsIHZvaWQgcHJvY2Vzc0RpZEV4aXQoKSB7 IH0KKyAgICB2aXJ0dWFsIHZvaWQgcHJvY2Vzc0RpZFJldml2ZSgpIHsgfQorICAgIHZpcnR1YWwg dm9pZCBzZXRDdXJzb3IoY29uc3QgV2ViQ29yZTo6Q3Vyc29yJikgeyB9CisgICAgdmlydHVhbCB2 b2lkIHRha2VGb2N1cyhib29sIGRpcmVjdGlvbikgeyB9CisKKyAgICB2aXJ0dWFsIHZvaWQgdG9v bFRpcENoYW5nZWQoY29uc3QgV2ViQ29yZTo6U3RyaW5nJiwgY29uc3QgV2ViQ29yZTo6U3RyaW5n Jik7CisKK3ByaXZhdGU6CisgICAgUVdLUGFnZSogbV9wYWdlOworfTsKKwordm9pZCBQYWdlQ2xp ZW50SW1wbDo6dG9vbFRpcENoYW5nZWQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBuZXdU b29sdGlwKQoreworICAgIGVtaXQgbV9wYWdlLT5zdGF0dXNCYXJNZXNzYWdlKFFTdHJpbmcobmV3 VG9vbHRpcCkpOworfQorCiBRV0tQYWdlUHJpdmF0ZTo6UVdLUGFnZVByaXZhdGUoUVdLUGFnZSog cXEsIFdLUGFnZU5hbWVzcGFjZVJlZiBuYW1lc3BhY2VSZWYpCiAgICAgOiBxKHFxKQogICAgICwg Y3JlYXRlTmV3UGFnZUZuKDApCiB7CiAgICAgbWVtc2V0KGFjdGlvbnMsIDAsIHNpemVvZihhY3Rp b25zKSk7CiAgICAgcGFnZSA9IHRvV0sobmFtZXNwYWNlUmVmKS0+Y3JlYXRlV2ViUGFnZSgpOwot ICAgIHBhZ2UtPnNldFBhZ2VDbGllbnQodGhpcyk7CisgICAgcGFnZS0+c2V0UGFnZUNsaWVudChu ZXcgUGFnZUNsaWVudEltcGwocXEpKTsKIH0KIAogUVdLUGFnZVByaXZhdGU6On5RV0tQYWdlUHJp dmF0ZSgpCkBAIC01NiwxMSArODMsNiBAQCB2b2lkIFFXS1BhZ2VQcml2YXRlOjppbml0KGNvbnN0 IFFTaXplJiB2aWV3cG9ydFNpemUsIERyYXdpbmdBcmVhUHJveHkqIHByb3h5KQogICAgIHBhZ2Ut PmluaXRpYWxpemVXZWJQYWdlKEludFNpemUodmlld3BvcnRTaXplKSwgcHJveHkpOwogfQogCi12 b2lkIFFXS1BhZ2VQcml2YXRlOjp0b29sVGlwQ2hhbmdlZChjb25zdCBTdHJpbmcmLCBjb25zdCBT dHJpbmcmIG5ld1Rvb2x0aXApCi17Ci0gICAgZW1pdCBxLT5zdGF0dXNCYXJNZXNzYWdlKFFTdHJp bmcobmV3VG9vbHRpcCkpOwotfQotCiB2b2lkIFFXS1BhZ2VQcml2YXRlOjpwYWludChRUGFpbnRl ciogcGFpbnRlciwgUVJlY3QgYXJlYSkKIHsKICAgICBwYWludGVyLT5zYXZlKCk7CmRpZmYgLS1n aXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZV9wLmggYi9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXdrcGFnZV9wLmgKaW5kZXggM2U2NzZlZi4uMGM2MTdhMyAxMDA2NDQKLS0t IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2VfcC5oCisrKyBiL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaApAQCAtMzEsNyArMzEsNyBAQAogI2luY2x1ZGUgPFFH cmFwaGljc1ZpZXc+CiAjaW5jbHVkZSA8UUtleUV2ZW50PgogCi1jbGFzcyBRV0tQYWdlUHJpdmF0 ZSA6IHB1YmxpYyBXZWJLaXQ6OlBhZ2VDbGllbnQgeworY2xhc3MgUVdLUGFnZVByaXZhdGUgewog cHVibGljOgogICAgIFFXS1BhZ2VQcml2YXRlKFFXS1BhZ2UqLCBXS1BhZ2VOYW1lc3BhY2VSZWYp OwogICAgIH5RV0tQYWdlUHJpdmF0ZSgpOwpAQCAtNDAsMTYgKzQwLDYgQEAgcHVibGljOgogCiAg ICAgdm9pZCBpbml0KGNvbnN0IFFTaXplJiB2aWV3cG9ydFNpemUsIFdlYktpdDo6RHJhd2luZ0Fy ZWFQcm94eSopOwogCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAgIHZvaWQg cGFnZURpZEVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpIHt9Ci0gICAgdm9pZCBwYWdlRGlk TGVhdmVBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCkge30KLSNlbmRpZiAvLyBVU0UoQUNDRUxFUkFU RURfQ09NUE9TSVRJTkcpCi0gICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRFeGl0KCkge30KLSAg ICB2aXJ0dWFsIHZvaWQgcHJvY2Vzc0RpZFJldml2ZSgpIHt9Ci0gICAgdmlydHVhbCB2b2lkIHNl dEN1cnNvcihjb25zdCBXZWJDb3JlOjpDdXJzb3ImKSB7fQotICAgIHZpcnR1YWwgdm9pZCB0YWtl Rm9jdXMoYm9vbCBkaXJlY3Rpb24pIHt9Ci0gICAgdmlydHVhbCB2b2lkIHRvb2xUaXBDaGFuZ2Vk KGNvbnN0IFdlYkNvcmU6OlN0cmluZyYsIGNvbnN0IFdlYkNvcmU6OlN0cmluZyYpOwotCiAgICAg dm9pZCBwYWludChRUGFpbnRlciogcGFpbnRlciwgUVJlY3QpOwogCiAgICAgdm9pZCBrZXlQcmVz c0V2ZW50KFFLZXlFdmVudCopOwo= 62682 2010-07-27 04:44:30 -0700 2010-07-27 05:27:39 -0700 proposed patch pageclientimpl_ch.diff text/plain 4032 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODI3YmUxYy4uODRiMGZlYiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNy0yNyAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBXZWJLaXQ6OlBhZ2VDbGllbnQgaW1wbGVtZW50YXRpb24g bmVlZHMgYSBkZWRpY2F0ZWQgY2xhc3MKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDI5NzQKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdr cGFnZS5jcHA6CisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6UGFnZUNsaWVudEltcGwpOiBBZGRl ZC4KKyAgICAgICAgKFBhZ2VDbGllbnRJbXBsOjpwYWdlRGlkRW50ZXJBY2NlbGVyYXRlZENvbXBv c2l0aW5nKTogTW92ZWQgZnJvbSBRV0tQYWdlUHJpdmF0ZS4KKyAgICAgICAgKFBhZ2VDbGllbnRJ bXBsOjpwYWdlRGlkTGVhdmVBY2NlbGVyYXRlZENvbXBvc2l0aW5nKTogRGl0dG8uCisgICAgICAg IChQYWdlQ2xpZW50SW1wbDo6cHJvY2Vzc0RpZEV4aXQpOiBEaXR0by4KKyAgICAgICAgKFBhZ2VD bGllbnRJbXBsOjpwcm9jZXNzRGlkUmV2aXZlKTogRGl0dG8uCisgICAgICAgIChQYWdlQ2xpZW50 SW1wbDo6c2V0Q3Vyc29yKTogRGl0dG8uCisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6dGFrZUZv Y3VzKTogRGl0dG8uCisgICAgICAgIChQYWdlQ2xpZW50SW1wbDo6dG9vbFRpcENoYW5nZWQpOiBE aXR0by4KKyAgICAgICAgKFFXS1BhZ2VQcml2YXRlOjpRV0tQYWdlUHJpdmF0ZSk6IFNldCBhIG5l dyBpbnN0YW5jZSBvZiB0aGUgUGFnZUNsaWVudEltcGwgYXMgUGFnZUNsaWVudCByYXRoZXIgdGhh biAndGhpcycuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaDogUmVtb3Zl ZCBQYWdlQ2xpZW50IGltcGxlbWVudGF0aW9uIG1ldGhvZHMgZnJvbSBRV0tQYWdlUHJpdmF0ZS4K KwogMjAxMC0wNy0xOSBCYWxhenMgS2VsZW1lbiA8a2JAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3F3a3BhZ2UuY3BwCmluZGV4IDUwNzRjMmEuLmViZmQ3OTUgMTAwNjQ0Ci0tLSBhL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZS5jcHAKQEAgLTM3LDEzICszNyw0MCBAQAogdXNpbmcgbmFtZXNwYWNl IFdlYktpdDsKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCitjbGFzcyBQYWdlQ2xpZW50SW1w bCA6IHB1YmxpYyBXZWJLaXQ6OlBhZ2VDbGllbnQgeworcHVibGljOgorICAgIFBhZ2VDbGllbnRJ bXBsKFFXS1BhZ2UqIHBhZ2UpCisgICAgICAgIDogbV9wYWdlKHBhZ2UpCisgICAgeworICAgIH0K KworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICB2b2lkIHBhZ2VEaWRFbnRl ckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KKyAgICB2b2lkIHBhZ2VEaWRMZWF2ZUFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KKyNlbmRpZiAvLyBVU0UoQUNDRUxFUkFURURfQ09NUE9T SVRJTkcpCisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRFeGl0KCkgeyB9CisgICAgdmlydHVh bCB2b2lkIHByb2Nlc3NEaWRSZXZpdmUoKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgc2V0Q3Vyc29y KGNvbnN0IFdlYkNvcmU6OkN1cnNvciYpIHsgfQorICAgIHZpcnR1YWwgdm9pZCB0YWtlRm9jdXMo Ym9vbCBkaXJlY3Rpb24pIHsgfQorCisgICAgdmlydHVhbCB2b2lkIHRvb2xUaXBDaGFuZ2VkKGNv bnN0IFdlYkNvcmU6OlN0cmluZyYsIGNvbnN0IFdlYkNvcmU6OlN0cmluZyYpOworCitwcml2YXRl OgorICAgIFFXS1BhZ2UqIG1fcGFnZTsKK307CisKK3ZvaWQgUGFnZUNsaWVudEltcGw6OnRvb2xU aXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYgbmV3VG9vbHRpcCkKK3sKKyAg ICBlbWl0IG1fcGFnZS0+c3RhdHVzQmFyTWVzc2FnZShRU3RyaW5nKG5ld1Rvb2x0aXApKTsKK30K KwogUVdLUGFnZVByaXZhdGU6OlFXS1BhZ2VQcml2YXRlKFFXS1BhZ2UqIHFxLCBXS1BhZ2VOYW1l c3BhY2VSZWYgbmFtZXNwYWNlUmVmKQogICAgIDogcShxcSkKICAgICAsIGNyZWF0ZU5ld1BhZ2VG bigwKQogewogICAgIG1lbXNldChhY3Rpb25zLCAwLCBzaXplb2YoYWN0aW9ucykpOwogICAgIHBh Z2UgPSB0b1dLKG5hbWVzcGFjZVJlZiktPmNyZWF0ZVdlYlBhZ2UoKTsKLSAgICBwYWdlLT5zZXRQ YWdlQ2xpZW50KHRoaXMpOworICAgIHBhZ2UtPnNldFBhZ2VDbGllbnQobmV3IFBhZ2VDbGllbnRJ bXBsKHFxKSk7IC8vIE93bmVyc2hpcCBpcyBwYXNzZWQgdG8gdGhlIHBhZ2UuCiB9CiAKIFFXS1Bh Z2VQcml2YXRlOjp+UVdLUGFnZVByaXZhdGUoKQpAQCAtNTYsMTEgKzgzLDYgQEAgdm9pZCBRV0tQ YWdlUHJpdmF0ZTo6aW5pdChjb25zdCBRU2l6ZSYgdmlld3BvcnRTaXplLCBEcmF3aW5nQXJlYVBy b3h5KiBwcm94eSkKICAgICBwYWdlLT5pbml0aWFsaXplV2ViUGFnZShJbnRTaXplKHZpZXdwb3J0 U2l6ZSksIHByb3h5KTsKIH0KIAotdm9pZCBRV0tQYWdlUHJpdmF0ZTo6dG9vbFRpcENoYW5nZWQo Y29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBuZXdUb29sdGlwKQotewotICAgIGVtaXQgcS0+ c3RhdHVzQmFyTWVzc2FnZShRU3RyaW5nKG5ld1Rvb2x0aXApKTsKLX0KLQogdm9pZCBRV0tQYWdl UHJpdmF0ZTo6cGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIsIFFSZWN0IGFyZWEpCiB7CiAgICAgcGFp bnRlci0+c2F2ZSgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3Bh Z2VfcC5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2VfcC5oCmluZGV4IDNlNjc2 ZWYuLjBjNjE3YTMgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdl X3AuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZV9wLmgKQEAgLTMxLDcg KzMxLDcgQEAKICNpbmNsdWRlIDxRR3JhcGhpY3NWaWV3PgogI2luY2x1ZGUgPFFLZXlFdmVudD4K IAotY2xhc3MgUVdLUGFnZVByaXZhdGUgOiBwdWJsaWMgV2ViS2l0OjpQYWdlQ2xpZW50IHsKK2Ns YXNzIFFXS1BhZ2VQcml2YXRlIHsKIHB1YmxpYzoKICAgICBRV0tQYWdlUHJpdmF0ZShRV0tQYWdl KiwgV0tQYWdlTmFtZXNwYWNlUmVmKTsKICAgICB+UVdLUGFnZVByaXZhdGUoKTsKQEAgLTQwLDE2 ICs0MCw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgaW5pdChjb25zdCBRU2l6ZSYgdmlld3BvcnRT aXplLCBXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHkqKTsKIAotI2lmIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKLSAgICB2b2lkIHBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmco KSB7fQotICAgIHZvaWQgcGFnZURpZExlYXZlQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpIHt9Ci0j ZW5kaWYgLy8gVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAgIHZpcnR1YWwgdm9pZCBw cm9jZXNzRGlkRXhpdCgpIHt9Ci0gICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRSZXZpdmUoKSB7 fQotICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJzb3IoY29uc3QgV2ViQ29yZTo6Q3Vyc29yJikge30K LSAgICB2aXJ0dWFsIHZvaWQgdGFrZUZvY3VzKGJvb2wgZGlyZWN0aW9uKSB7fQotICAgIHZpcnR1 YWwgdm9pZCB0b29sVGlwQ2hhbmdlZChjb25zdCBXZWJDb3JlOjpTdHJpbmcmLCBjb25zdCBXZWJD b3JlOjpTdHJpbmcmKTsKLQogICAgIHZvaWQgcGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIsIFFSZWN0 KTsKIAogICAgIHZvaWQga2V5UHJlc3NFdmVudChRS2V5RXZlbnQqKTsK