42961 2010-07-26 02:51:49 -0700 Web Inspector: make sure proxy objects are JSON-stringifiable. 2010-07-26 14:29:14 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth bweinstein eric joepeck keishi pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 255953 0 pfeldman 2010-07-26 02:51:49 -0700 Patch to follow. 255955 1 62551 pfeldman 2010-07-26 02:55:02 -0700 Created attachment 62551 [PATCH] Proposed fix. 255969 2 62551 hamaji 2010-07-26 04:13:58 -0700 Comment on attachment 62551 [PATCH] Proposed fix. Looks good 255973 3 pfeldman 2010-07-26 04:21:59 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r64040 255974 4 webkit.review.bot 2010-07-26 04:28:11 -0700 http://trac.webkit.org/changeset/64040 might have broken Qt Linux Release minimal 256073 5 joepeck 2010-07-26 09:45:07 -0700 Which value was breaking this such that !! fixed the problem? 256236 6 pfeldman 2010-07-26 14:29:14 -0700 (In reply to comment #5) > Which value was breaking this such that !! fixed the problem? I guess it was object with no own property names: type === "object" && object !== null && (Object.getOwnPropertyNames(object).length || object.__proto__)) || type === "function" evaluated to "object.__proto__" that was non-boolean. Then proto was serialized which was wrong thing to do... 62551 2010-07-26 02:55:02 -0700 2010-07-26 04:13:58 -0700 [PATCH] Proposed fix. stringifiable_proxy text/plain 1344 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGQ3MWRlMS4uMTFjNTQxNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0yNiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBtYWtlIHN1cmUgcHJveHkgb2JqZWN0 cyBhcmUgSlNPTi1zdHJpbmdpZmlhYmxlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00Mjk2MQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9JbmplY3RlZFNjcmlwdC5qczoKKyAgICAgICAgKGluamVjdGVkU2NyaXB0Q29uc3RydWN0b3Ip OgorCiAyMDEwLTA3LTIzICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggZmRlZWExZi4uY2UxODdkMiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwpAQCAtMzg4 LDcgKzM4OCw3IEBAIEluamVjdGVkU2NyaXB0LmNyZWF0ZVByb3h5T2JqZWN0ID0gZnVuY3Rpb24o b2JqZWN0LCBvYmplY3RJZCwgYWJicmV2aWF0ZSkKIAogICAgIHZhciB0eXBlID0gdHlwZW9mIG9i amVjdDsKICAgICAKLSAgICByZXN1bHQuaGFzQ2hpbGRyZW4gPSAodHlwZSA9PT0gIm9iamVjdCIg JiYgb2JqZWN0ICE9PSBudWxsICYmIChPYmplY3QuZ2V0T3duUHJvcGVydHlOYW1lcyhvYmplY3Qp Lmxlbmd0aCB8fCBvYmplY3QuX19wcm90b19fKSkgfHwgdHlwZSA9PT0gImZ1bmN0aW9uIjsKKyAg ICByZXN1bHQuaGFzQ2hpbGRyZW4gPSAodHlwZSA9PT0gIm9iamVjdCIgJiYgb2JqZWN0ICE9PSBu dWxsICYmIChPYmplY3QuZ2V0T3duUHJvcGVydHlOYW1lcyhvYmplY3QpLmxlbmd0aCB8fCAhIW9i amVjdC5fX3Byb3RvX18pKSB8fCB0eXBlID09PSAiZnVuY3Rpb24iOwogICAgIHRyeSB7CiAgICAg ICAgIHJlc3VsdC5kZXNjcmlwdGlvbiA9IEluamVjdGVkU2NyaXB0Ll9kZXNjcmliZShvYmplY3Qs IGFiYnJldmlhdGUpOwogICAgIH0gY2F0Y2ggKGUpIHsK