42960 2010-07-26 01:16:01 -0700 [GStreamer] media/invalid-media-url-crash.html fails 2010-08-16 23:49:21 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo slomo oldest_to_newest 255934 0 pnormand 2010-07-26 01:16:01 -0700 Because our webkitmediasrc element doesn't push an error on the GStreamer bus if a wrong url is loaded. 255937 1 62549 pnormand 2010-07-26 01:29:36 -0700 Created attachment 62549 proposed patch 265169 2 62549 mrobinson 2010-08-16 11:00:37 -0700 Comment on attachment 62549 proposed patch > void StreamingClient::wasBlocked(ResourceHandle*) > { > + WebKitWebSrcPrivate* priv = m_src->priv; > + GST_ERROR_OBJECT(m_src, "Request was blocked"); > + GST_ELEMENT_ERROR(m_src, RESOURCE, OPEN_READ, ("Access to \"%s\" was blocked", priv->uri), (0)); > } > void StreamingClient::cannotShowURL(ResourceHandle*) > { > + WebKitWebSrcPrivate* priv = m_src->priv; Just a minor nit, you can simply use m_src->priv->uri here instead of caching the pointer locally. LGTM with those lines changed. 265376 3 pnormand 2010-08-16 23:49:21 -0700 Thanks, landed in http://trac.webkit.org/changeset/65486 62549 2010-07-26 01:29:36 -0700 2010-08-16 11:00:37 -0700 proposed patch proposed-patch.patch text/plain 3311 pnormand RnJvbSAzMGIxNTc0NjNlNjAwZDI2ZWY1NzBhOWYxYzNkMDlhMzhhNzJlMDE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDI2IEp1bCAyMDEwIDEwOjI5OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQgICAgICAgICAgICAgICAgICAgfCAgICAxIC0KIFdlYkNvcmUvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIC4u Li9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCAgICAgICAgIHwgICAgNiAr KysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZjI0YmU5Ni4uNmY4NDU5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA3 LTI2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBtZWRpYS9p bnZhbGlkLW1lZGlhLXVybC1jcmFzaC5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjk2MAorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1NraXBwZWQ6IFVuc2tpcCBmaXhlZCB0ZXN0CisKIDIwMTAtMDctMjUgIERhcmluIEFkbGVyICA8 ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IGIxMjkzMTQuLmEzMzk5MDAgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9Ta2lwcGVkCkBAIC00NCw3ICs0NCw2IEBAIGh0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QvWE1MSHR0cFJlcXVlc3RFeGNlcHRpb24uaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVz dC9jb25uZWN0aW9uLWVycm9yLXN5bmMuaHRtbAogZmFzdC94bWxodHRwcmVxdWVzdC9udWxsLWRv Y3VtZW50LXhtbGh0dHByZXF1ZXN0LW9wZW4uaHRtbAogaHR0cC90ZXN0cy9taXNjL2Zhdmljb24t YXMtaW1hZ2UuaHRtbAotbWVkaWEvaW52YWxpZC1tZWRpYS11cmwtY3Jhc2guaHRtbAogbWVkaWEv dW5zdXBwb3J0ZWQtcnRzcC5odG1sCiBzZWN1cml0eS9hdXRvY29tcGxldGUtY2xlYXJlZC1vbi1i YWNrLmh0bWwKIGh0dHAvdGVzdHMvc2VjdXJpdHkvZnJhbWVOYXZpZ2F0aW9uL2Nyb3NzLW9yaWdp bi1vcGVuZXIuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZDcxZGUxLi5hNzY5YzI5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA3LTI2 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBtZWRpYS9pbnZh bGlkLW1lZGlhLXVybC1jcmFzaC5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjk2MAorCisgICAgICAgIEltcGxlbWVudGVkIHR3byBS ZXNvdXJjZUhhbmRsZUNsaWVudCBjYWxsYmFja3MgdGhhdCBuZWVkIHRvIG5vdGlmeQorICAgICAg ICBkb3duc3RyZWFtIEdTdHJlYW1lciBlbGVtZW50cyBvZiBlcnJvcnMgd2hpbGUgYWNjZXNzaW5n IHRoZQorICAgICAgICByZXNvdXJjZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3RyZWFtaW5n Q2xpZW50Ojp3YXNCbG9ja2VkKToKKyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6Y2Fubm90U2hv d1VSTCk6CisKIDIwMTAtMDctMjMgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1l ci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwCmluZGV4IGQzYjVmMWIuLmQ1MDM1N2QgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5j cHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291 cmNlR1N0cmVhbWVyLmNwcApAQCAtNzgwLDkgKzc4MCwxNSBAQCB2b2lkIFN0cmVhbWluZ0NsaWVu dDo6ZGlkRmFpbChSZXNvdXJjZUhhbmRsZSosIGNvbnN0IFJlc291cmNlRXJyb3ImIGVycm9yKQog CiB2b2lkIFN0cmVhbWluZ0NsaWVudDo6d2FzQmxvY2tlZChSZXNvdXJjZUhhbmRsZSopCiB7Cisg ICAgV2ViS2l0V2ViU3JjUHJpdmF0ZSogcHJpdiA9IG1fc3JjLT5wcml2OworICAgIEdTVF9FUlJP Ul9PQkpFQ1QobV9zcmMsICJSZXF1ZXN0IHdhcyBibG9ja2VkIik7CisgICAgR1NUX0VMRU1FTlRf RVJST1IobV9zcmMsIFJFU09VUkNFLCBPUEVOX1JFQUQsICgiQWNjZXNzIHRvIFwiJXNcIiB3YXMg YmxvY2tlZCIsIHByaXYtPnVyaSksICgwKSk7CiB9CiAKIHZvaWQgU3RyZWFtaW5nQ2xpZW50Ojpj YW5ub3RTaG93VVJMKFJlc291cmNlSGFuZGxlKikKIHsKKyAgICBXZWJLaXRXZWJTcmNQcml2YXRl KiBwcml2ID0gbV9zcmMtPnByaXY7CisgICAgR1NUX0VSUk9SX09CSkVDVChtX3NyYywgIkNhbm5v dCBzaG93IFVSTCIpOworICAgIEdTVF9FTEVNRU5UX0VSUk9SKG1fc3JjLCBSRVNPVVJDRSwgT1BF Tl9SRUFELCAoIkNhbid0IHNob3cgXCIlc1wiIiwgcHJpdi0+dXJpKSwgKDApKTsKIH0KIAotLSAK MS43LjE=