42951 2010-07-25 14:12:00 -0700 Functions supporting the legacy tree builder are confusing 2010-07-25 14:36:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 255843 0 abarth 2010-07-25 14:12:00 -0700 Functions supporting the legacy tree builder are confusing 255845 1 62532 abarth 2010-07-25 14:13:57 -0700 Created attachment 62532 Patch 255847 2 62532 eric 2010-07-25 14:16:45 -0700 Comment on attachment 62532 Patch Agreed. Another way to solve this would be to rip out this into some other support class. But I think this code is about to die anyway. 255855 3 62532 commit-queue 2010-07-25 14:36:45 -0700 Comment on attachment 62532 Patch Clearing flags on attachment: 62532 Committed r64023: <http://trac.webkit.org/changeset/64023> 255856 4 commit-queue 2010-07-25 14:36:49 -0700 All reviewed patches have been landed. Closing bug. 62532 2010-07-25 14:13:57 -0700 2010-07-25 14:36:44 -0700 Patch bug-42951-20100725231354.patch text/plain 5136 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmVjNDk5NTU1OTAxZTE4Y2EyODAzMzdhNmEyNDBmZWFkMDAwMDlhMy4uYzkzZDYyYWIwZmUxMTA2 ODIwNzUwZmZiY2VmOGM2MzM0YzU0YjcxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMyBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEZ1bmN0aW9ucyBzdXBwb3J0aW5nIHRo ZSBsZWdhY3kgdHJlZSBidWlsZGVyIGFyZSBjb25mdXNpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyOTUxCisKKyAgICAgICAgVGhpcyBwYXRjaCBq dXN0IGlubGluZXMgdGhlc2UgZnVuY3Rpb25zIGludG8gdGhlaXIgb25lIGNhbGwgc2l0ZSBhbmQK KyAgICAgICAgcmVtb3ZlcyB0aGUgbm90SW1wbGVtZW50ZWQoKSBjYWxscy4gIFdlIHRob3VnaHQg d2Ugd2VyZSBnb2luZyB0byBncm93CisgICAgICAgIHRoZXNlIHRvIHN1cHBvcnQgdGhlIG5ldyB0 cmVlIGJ1aWxkZXIsIGJ1dCB3ZSB0b29rIGEgZGlmZmVyZW50IHBhdGguCisgICAgICAgIFByZXZp b3VzIHRvIHRoaXMgcGF0Y2gsIHRoZXNlIGZ1bmN0aW9ucyB3ZXJlIGNvbmZ1c2luZyBiZWNhdXNl IHRoZXkKKyAgICAgICAgbG9va2VkIGxpa2UgcGFydCBvZiB0aGUgbmV3IHRyZWUgYnVpbGRlci4K KworICAgICAgICAqIGh0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxUcmVlQnVpbGRlcjo6cGFzc1Rva2VuVG9MZWdhY3lQYXJzZXIpOgorICAgICAgICAqIGh0 bWwvSFRNTFRyZWVCdWlsZGVyLmg6CisKKzIwMTAtMDctMjUgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAg ICAgICBmYXN0L3BhcnNlci9yZXNpZHVhbC1zdHlsZS1oYW5nLmh0bWwgaGFuZ3MKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyOTUwCiAKZGlmZiAtLWdp dCBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxU cmVlQnVpbGRlci5jcHAKaW5kZXggYmFlMGMyZDZhMTM2NzJhYTdkOGYxNDRiNGU0OThmNjY5OWNk NGIyMi4uMjFhNDAxZTk3YzlhZjljOGRiZTRlOTU1YjE3ZmUxYWNhYjM1ZmZlOSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hU TUxUcmVlQnVpbGRlci5jcHAKQEAgLTM5MiwyNyArMzkyLDYgQEAgc3RhdGljIHZvaWQgY29udmVy dFRvT2xkU3R5bGUoQXRvbWljSFRNTFRva2VuJiB0b2tlbiwgVG9rZW4mIG9sZFN0eWxlVG9rZW4p CiAgICAgfQogfQogCi12b2lkIEhUTUxUcmVlQnVpbGRlcjo6aGFuZGxlU2NyaXB0U3RhcnRUYWco KQotewotICAgIG5vdEltcGxlbWVudGVkKCk7IC8vIFRoZSBIVE1MIGZyZ21lbnQgY2FzZT8KLSAg ICBtX3Rva2VuaXplci0+c2V0U3RhdGUoSFRNTFRva2VuaXplcjo6U2NyaXB0RGF0YVN0YXRlKTsK LSAgICBub3RJbXBsZW1lbnRlZCgpOyAvLyBTYXZlIGluc2VydGlvbiBtb2RlLgotfQotCi12b2lk IEhUTUxUcmVlQnVpbGRlcjo6aGFuZGxlU2NyaXB0RW5kVGFnKEVsZW1lbnQqIHNjcmlwdEVsZW1l bnQsIGludCBzY3JpcHRTdGFydExpbmUpCi17Ci0gICAgQVNTRVJUKCFtX3NjcmlwdFRvUHJvY2Vz cyk7IC8vIENhbGxlciBuZXZlciBjYWxsZWQgdGFrZVNjcmlwdFRvUHJvY2VzcyEKLSAgICBBU1NF UlQobV9zY3JpcHRUb1Byb2Nlc3NTdGFydExpbmUgPT0gdW5pbml0aWFsaXplZExpbmVOdW1iZXJW YWx1ZSk7IC8vIENhbGxlciBuZXZlciBjYWxsZWQgdGFrZVNjcmlwdFRvUHJvY2VzcyEKLSAgICBu b3RJbXBsZW1lbnRlZCgpOyAvLyBTYXZlIGluc2VydGlvbiBtb2RlIGFuZCBpbnNlcnRpb24gcG9p bnQ/Ci0KLSAgICAvLyBQYXVzZSBvdXJzZWx2ZXMgc28gdGhhdCBwYXJzaW5nIHN0b3BzIHVudGls IHRoZSBzY3JpcHQgY2FuIGJlIHByb2Nlc3NlZCBieSB0aGUgY2FsbGVyLgotICAgIG1faXNQYXVz ZWQgPSB0cnVlOwotICAgIG1fc2NyaXB0VG9Qcm9jZXNzID0gc2NyaXB0RWxlbWVudDsKLSAgICAv LyBMZXhlciBsaW5lIG51bWJlcnMgYXJlIDAtYmFzZWQsIFNjcmlwdFNvdXJjZUNvZGUgZXhwZWN0 cyAxLWJhc2VkIGxpbmVzLAotICAgIC8vIHNvIHdlIGNvbnZlcnQgaGVyZSBiZWZvcmUgcGFzc2lu ZyB0aGUgbGluZSBudW1iZXIgb2ZmIHRvIEhUTUxTY3JpcHRSdW5uZXIuCi0gICAgbV9zY3JpcHRU b1Byb2Nlc3NTdGFydExpbmUgPSBzY3JpcHRTdGFydExpbmUgKyAxOwotfQotCiBQYXNzUmVmUHRy PEVsZW1lbnQ+IEhUTUxUcmVlQnVpbGRlcjo6dGFrZVNjcmlwdFRvUHJvY2VzcyhpbnQmIHNjcmlw dFN0YXJ0TGluZSkKIHsKICAgICAvLyBVbnBhdXNlIG91cnNlbHZlcywgY2FsbGVycyBtYXkgcGF1 c2UgdXMgYWdhaW4gd2hlbiBwcm9jZXNzaW5nIHRoZSBzY3JpcHQuCkBAIC00NzAsNyArNDQ5LDcg QEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnBhc3NUb2tlblRvTGVnYWN5UGFyc2VyKEhUTUxUb2tl biYgdG9rZW4pCiAgICAgICAgIC8vIFRoaXMgd29yayBpcyBzdXBwb3NlZCB0byBiZSBkb25lIGJ5 IHRoZSBwYXJzZXIsIGJ1dAogICAgICAgICAvLyB3aGVuIHVzaW5nIHRoZSBvbGQgcGFyc2VyIGZv ciB3ZSBoYXZlIHRvIGRvIHRoaXMgbWFudWFsbHkuCiAgICAgICAgIGlmIChvbGRTdHlsZVRva2Vu LnRhZ05hbWUgPT0gc2NyaXB0VGFnKSB7Ci0gICAgICAgICAgICBoYW5kbGVTY3JpcHRTdGFydFRh ZygpOworICAgICAgICAgICAgbV90b2tlbml6ZXItPnNldFN0YXRlKEhUTUxUb2tlbml6ZXI6OlNj cmlwdERhdGFTdGF0ZSk7CiAgICAgICAgICAgICBtX2xhc3RTY3JpcHRFbGVtZW50ID0gc3RhdGlj X3BvaW50ZXJfY2FzdDxFbGVtZW50PihyZXN1bHQpOwogICAgICAgICAgICAgbV9sYXN0U2NyaXB0 RWxlbWVudFN0YXJ0TGluZSA9IG1fdG9rZW5pemVyLT5saW5lTnVtYmVyKCk7CiAgICAgICAgIH0g ZWxzZSBpZiAob2xkU3R5bGVUb2tlbi50YWdOYW1lID09IHByZVRhZyB8fCBvbGRTdHlsZVRva2Vu LnRhZ05hbWUgPT0gbGlzdGluZ1RhZykKQEAgLTQ4Nyw4ICs0NjYsMTYgQEAgdm9pZCBIVE1MVHJl ZUJ1aWxkZXI6OnBhc3NUb2tlblRvTGVnYWN5UGFyc2VyKEhUTUxUb2tlbiYgdG9rZW4pCiAgICAg ICAgICAgICAgICAgICAgIC8vIGEgRG9jdW1lbnRGcmFnbWVudCBmb3IgcGFzdGluZyBzbyB0aGF0 IGphdmFzY3JpcHQgY29udGVudAogICAgICAgICAgICAgICAgICAgICAvLyBkb2VzIG5vdCBzaG93 IHVwIGluIHBhc3RlZCBIVE1MLgogICAgICAgICAgICAgICAgICAgICBtX2xhc3RTY3JpcHRFbGVt ZW50LT5yZW1vdmVDaGlsZHJlbigpOwotICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAoaW5zZXJ0 aW9uTW9kZSgpICE9IEFmdGVyRnJhbWVzZXRNb2RlKQotICAgICAgICAgICAgICAgICAgICBoYW5k bGVTY3JpcHRFbmRUYWcobV9sYXN0U2NyaXB0RWxlbWVudC5nZXQoKSwgbV9sYXN0U2NyaXB0RWxl bWVudFN0YXJ0TGluZSk7CisgICAgICAgICAgICAgICAgfSBlbHNlIGlmIChpbnNlcnRpb25Nb2Rl KCkgIT0gQWZ0ZXJGcmFtZXNldE1vZGUpIHsKKyAgICAgICAgICAgICAgICAgICAgQVNTRVJUKCFt X3NjcmlwdFRvUHJvY2Vzcyk7IC8vIENhbGxlciBuZXZlciBjYWxsZWQgdGFrZVNjcmlwdFRvUHJv Y2VzcyEKKyAgICAgICAgICAgICAgICAgICAgQVNTRVJUKG1fc2NyaXB0VG9Qcm9jZXNzU3RhcnRM aW5lID09IHVuaW5pdGlhbGl6ZWRMaW5lTnVtYmVyVmFsdWUpOyAvLyBDYWxsZXIgbmV2ZXIgY2Fs bGVkIHRha2VTY3JpcHRUb1Byb2Nlc3MhCisgICAgICAgICAgICAgICAgICAgIC8vIFBhdXNlIG91 cnNlbHZlcyBzbyB0aGF0IHBhcnNpbmcgc3RvcHMgdW50aWwgdGhlIHNjcmlwdCBjYW4gYmUgcHJv Y2Vzc2VkIGJ5IHRoZSBjYWxsZXIuCisgICAgICAgICAgICAgICAgICAgIG1faXNQYXVzZWQgPSB0 cnVlOworICAgICAgICAgICAgICAgICAgICBtX3NjcmlwdFRvUHJvY2VzcyA9IG1fbGFzdFNjcmlw dEVsZW1lbnQuZ2V0KCk7CisgICAgICAgICAgICAgICAgICAgIC8vIExleGVyIGxpbmUgbnVtYmVy cyBhcmUgMC1iYXNlZCwgU2NyaXB0U291cmNlQ29kZSBleHBlY3RzIDEtYmFzZWQgbGluZXMsCisg ICAgICAgICAgICAgICAgICAgIC8vIHNvIHdlIGNvbnZlcnQgaGVyZSBiZWZvcmUgcGFzc2luZyB0 aGUgbGluZSBudW1iZXIgb2ZmIHRvIEhUTUxTY3JpcHRSdW5uZXIuCisgICAgICAgICAgICAgICAg ICAgIG1fc2NyaXB0VG9Qcm9jZXNzU3RhcnRMaW5lID0gbV9sYXN0U2NyaXB0RWxlbWVudFN0YXJ0 TGluZSArIDE7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIG1fbGFzdFNjcmlw dEVsZW1lbnQgPSAwOwogICAgICAgICAgICAgICAgIG1fbGFzdFNjcmlwdEVsZW1lbnRTdGFydExp bmUgPSB1bmluaXRpYWxpemVkTGluZU51bWJlclZhbHVlOwogICAgICAgICAgICAgfQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5oIGIvV2ViQ29yZS9odG1sL0hUTUxU cmVlQnVpbGRlci5oCmluZGV4IDczNWM5ZjM5NTYzYTUyZjk1ZWJiMGVlNzhlOGZmMmFlYWU4Yjky ZTEuLmQ3MjMzODQ0NjlhMDZkMjMwNzM3MGZjNDVkYzYzZDgyZDRhZTdiNTkgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuaAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRy ZWVCdWlsZGVyLmgKQEAgLTE3Myw5ICsxNzMsNiBAQCBwcml2YXRlOgogICAgIC8vIEZJWE1FOiBJ bXBsZW1lbnQgZXJyb3IgcmVwb3J0aW5nLgogICAgIHZvaWQgcGFyc2VFcnJvcihBdG9taWNIVE1M VG9rZW4mKSB7IH0KIAotICAgIHZvaWQgaGFuZGxlU2NyaXB0U3RhcnRUYWcoKTsKLSAgICB2b2lk IGhhbmRsZVNjcmlwdEVuZFRhZyhFbGVtZW50KiwgaW50IHNjcmlwdFN0YXJ0TGluZSk7Ci0KICAg ICBJbnNlcnRpb25Nb2RlIGluc2VydGlvbk1vZGUoKSBjb25zdCB7IHJldHVybiBtX2luc2VydGlv bk1vZGU7IH0KICAgICB2b2lkIHNldEluc2VydGlvbk1vZGUoSW5zZXJ0aW9uTW9kZSBtb2RlKQog ICAgIHsK