42940 2010-07-24 18:28:38 -0700 popstate events are lost when network connection is in progress 2010-11-19 00:07:59 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED http://www.bcherry.net/playground/pushstate InRadar P2 Normal --- 1 bcherry mihaip abarth ap beidson commit-queue fishd mathias mihaip rik tonyg zr oldest_to_newest 255778 0 bcherry 2010-07-24 18:28:38 -0700 User history navigation (back/forward buttons) while there is network traffic does not always fire a popstate event. These events are completely lost, and can get an application into the wrong state, where the user navigated through their history, but the app was never notified. Seen in Chrome 5 and 6 and Safari 5 on OS X 10.6. Mozilla's Firefox 4 implementation of popstate does not show this behavior. Reproduced here by downloading an image for 1s in the popstate handler, which prevents further popstates from firing while the image downloads: http://www.bcherry.net/playground/pushstate 257214 1 beidson 2010-07-28 09:53:10 -0700 <rdar://problem/8245251> 286694 2 zr 2010-09-28 18:51:41 -0700 We're experiencing a similar error at Facebook with our implementation of HTML5 history. We have a workaround that verifies that the current location actually matches the most recently fired popstate event, but that's an ugly hack and we'd greatly prefer that multiple presses of "Back" actually generated the correct number of popstate events. 291702 3 mihaip 2010-10-08 09:22:24 -0700 Looking into this. 291793 4 70273 mihaip 2010-10-08 11:58:36 -0700 Created attachment 70273 Patch 291795 5 mihaip 2010-10-08 12:01:16 -0700 Darin or Brady, could you take a look at this? 291804 6 70273 abarth 2010-10-08 12:23:35 -0700 Comment on attachment 70273 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70273&action=review > WebCore/loader/FrameLoader.cpp:661 > + m_frame->document()->setReadyState(Document::Loading); Is this change detectable by reading document.readyState? If so, we should add a test that shows the change. 291812 7 mihaip 2010-10-08 12:39:35 -0700 (In reply to comment #6) > (From update of attachment 70273 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70273&action=review > > > WebCore/loader/FrameLoader.cpp:661 > > + m_frame->document()->setReadyState(Document::Loading); > > Is this change detectable by reading document.readyState? If so, we should add a test that shows the change. Without this change a couple of tests in fast/loader/stateobjects fail (document-destroyed-navigate-back-with-fragment-scroll.html and document-destroyed-navigate-back.html) since they navigate back to a page that had a state object attached to its history entry. I don't think it's otherwise directly testable from layout tests though, since no script runs between FrameLoader::didBeginDocument and Document::implicitOpen. 291819 8 70273 abarth 2010-10-08 12:44:21 -0700 Comment on attachment 70273 Patch Okiedokes. This looks good to me, but it wouldn't hurt to have a pushState/popState expert look it over. 291952 9 70273 fishd 2010-10-08 16:35:20 -0700 Comment on attachment 70273 Patch LGTM 291968 10 70273 commit-queue 2010-10-08 17:02:09 -0700 Comment on attachment 70273 Patch Clearing flags on attachment: 70273 Committed r69432: <http://trac.webkit.org/changeset/69432> 291969 11 commit-queue 2010-10-08 17:02:15 -0700 All reviewed patches have been landed. Closing bug. 292648 12 zr 2010-10-11 14:17:00 -0700 Confirmed fixed for FB, thanks Mihai. 292748 13 bcherry 2010-10-11 16:19:42 -0700 Fixed on my test case as well. Thanks to everyone involved! 70273 2010-10-08 11:58:36 -0700 2010-10-08 17:02:09 -0700 Patch bug-42940-20101008145834.patch text/plain 6840 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMTQ4NzkzYjFiZWJjMjFjNzNhMzhhMjFhYWM4ZTVjNDFlZWE5ZjQyLi43YzcxNWNj OWZkOGY0YzJhYjVjODAxN2Q2NGNmOTlkOGY5YTkxMzY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMTAtMDggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcG9wc3RhdGUgZXZl bnRzIGFyZSBsb3N0IHdoZW4gbmV0d29yayBjb25uZWN0aW9uIGlzIGluIHByb2dyZXNzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjk0MAorICAgICAg ICAKKyAgICAgICAgQWRkIHRlc3QgY2FzZSB3aGVyZSB3ZSBoYXZlIGFuIGltYWdlIHJlcXVlc3Qg dGhhdCBuZXZlciBmaW5pc2hlcyB3aGlsZQorICAgICAgICB1c2luZyBwdXNoU3RhdGUgYW5kIGhp c3RvcnkuYmFjaygpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9oaXN0b3J5L3BvcHN0YXRlLWZp cmVzLXdpdGgtcGVuZGluZy1yZXF1ZXN0cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGh0dHAvdGVzdHMvaGlzdG9yeS9wb3BzdGF0ZS1maXJlcy13aXRoLXBlbmRpbmctcmVxdWVzdHMu aHRtbDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9oaXN0b3J5L3Jlc291cmNlcy9zbG93 LWltYWdlLnBocDogQWRkZWQuCisKIDIwMTAtMTAtMDcgIEFsYmVydCBKLiBXb25nICA8YWp3b25n QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQuIE5ldyBiYXNl bGluZXMsIGFuZCBleHBlY3RhdGlvbnMgdXBkYXRlcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvaGlzdG9yeS9wb3BzdGF0ZS1maXJlcy13aXRoLXBlbmRpbmctcmVxdWVzdHMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9oaXN0b3J5L3BvcHN0YXRlLWZp cmVzLXdpdGgtcGVuZGluZy1yZXF1ZXN0cy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjNjY2Ji YjUzM2UyZjhiYzU5ZWE5ZWRlOTZmNTQ0YmMwMmExOTdlZAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvaGlzdG9yeS9wb3BzdGF0ZS1maXJlcy13aXRoLXBlbmRpbmct cmVxdWVzdHMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTYgQEAKK1Rlc3RzIHRoYXQgcG9wc3Rh dGUgZXZlbnRzIGZpcmUgd2hlbiBnb2luZyBiYWNrLCBldmVuIHdoZW4gdGhlcmUgYXJlIHJlc291 cmNlIHJlcXVlc3RzIHBlbmRpbmcuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitT dGFydGluZyBzbG93IGltYWdlIHJlcXVlc3QKK1B1c2hpbmcgbmV3U3RhdGUxCitDdXJyZW50IHNl YXJjaDogP25ld1N0YXRlMQorUHVzaGluZyBuZXdTdGF0ZTIKK0N1cnJlbnQgc2VhcmNoOiA/bmV3 U3RhdGUyCitHb2luZyBiYWNrCitQQVNTIGV2ZW50LnN0YXRlIGlzICJuZXdTdGF0ZTEiCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9oaXN0b3J5L3BvcHN0YXRlLWZpcmVzLXdpdGgtcGVu ZGluZy1yZXF1ZXN0cy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9oaXN0b3J5L3BvcHN0 YXRlLWZpcmVzLXdpdGgtcGVuZGluZy1yZXF1ZXN0cy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmRhOTE4NzY2 NDJjMTFjNWI1YTE0OWY3ZDM5NjkwYzBkNDBiZmE5NjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2hpc3RvcnkvcG9wc3RhdGUtZmlyZXMtd2l0aC1wZW5kaW5nLXJl cXVlc3RzLmh0bWwKQEAgLTAsMCArMSw1NCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxo ZWFkPgorICA8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzLXRlc3QtcmVzb3Vy Y2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKyAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzLXRlc3QtcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9 ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4K K2Rlc2NyaXB0aW9uKCdUZXN0cyB0aGF0IHBvcHN0YXRlIGV2ZW50cyBmaXJlIHdoZW4gZ29pbmcg YmFjaywgZXZlbiB3aGVuIHRoZXJlIGFyZSByZXNvdXJjZSByZXF1ZXN0cyBwZW5kaW5nLicpOwor CitvbnBvcHN0YXRlID0gZnVuY3Rpb24oZXZlbnQpCit7CisgICAgaWYgKGV2ZW50LnN0YXRlKSB7 CisgICAgICAgIHNob3VsZEJlKCdldmVudC5zdGF0ZScsICcibmV3U3RhdGUxIicpOworICAgICAg ICAvLyBTdG9wIHRoZSBwZW5kaW5nIGltYWdlIHJlcXVlc3QsIG90aGVyd2lzZSB0aGUgRFJUIGRv ZXNuJ3QgY29uc2lkZXIgdGhlCisgICAgICAgIC8vIHRlc3Qgb3Zlci4KKyAgICAgICAgd2luZG93 LnN0b3AoKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9 CisgICAgCisgICAgZGVidWcoJ1N0YXJ0aW5nIHNsb3cgaW1hZ2UgcmVxdWVzdCcpOworICAgICAg CisgICAgdmFyIHNsb3dJbWFnZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2ltZycpOworICAg IHNsb3dJbWFnZS5zcmMgPSAncmVzb3VyY2VzL3Nsb3ctaW1hZ2UucGhwJzsKKyAgICBkb2N1bWVu dC5ib2R5LmFwcGVuZENoaWxkKHNsb3dJbWFnZSk7CisgICAgCisgICAgZGVidWcoJ1B1c2hpbmcg bmV3U3RhdGUxJyk7CisgICAgaGlzdG9yeS5wdXNoU3RhdGUoJ25ld1N0YXRlMScsIG51bGwsICc/ bmV3U3RhdGUxJyk7CisgICAgCisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAg ZGVidWcoJ0N1cnJlbnQgc2VhcmNoOiAnICsgbG9jYXRpb24uc2VhcmNoKTsKKyAgICAKKyAgICAg ICAgZGVidWcoJ1B1c2hpbmcgbmV3U3RhdGUyJyk7CisgICAgICAgIGhpc3RvcnkucHVzaFN0YXRl KCduZXdTdGF0ZTInLCBudWxsLCAnP25ld1N0YXRlMicpOworICAgICAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgeworICAgICAgICAgICAgZGVidWcoJ0N1cnJlbnQgc2VhcmNoOiAnICsgbG9jYXRp b24uc2VhcmNoKTsKKyAgICAgICAgICAgIGRlYnVnKCdHb2luZyBiYWNrJyk7CisgICAgICAgICAg ICBoaXN0b3J5LmJhY2soKTsKKyAgICAgICAgfSwgMCk7CisgICAgfSwgMCk7Cit9CisKKwordmFy IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cit2YXIganNUZXN0SXNBc3luYyA9IHRydWU7Cis8 L3NjcmlwdD4gCisKKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy10ZXN0LXJlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9oaXN0b3J5L3Jlc291cmNlcy9zbG93LWltYWdlLnBocCBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvaGlzdG9yeS9yZXNvdXJjZXMvc2xvdy1pbWFnZS5waHAKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uY2YyMTBjNGFlOTMzNmY2NmE5OTYwODczNGExYzEyYjdjMmVmMzVhOAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaGlzdG9yeS9yZXNvdXJjZXMvc2xvdy1p bWFnZS5waHAKQEAgLTAsMCArMSw0IEBACis8P3BocAorc2xlZXAoMzApOworaGVhZGVyKCdMb2Nh dGlvbjogZGF0YTppbWFnZS9naWY7YmFzZTY0LFIwbEdPRGxoQVFBQkFKQUFBTWpJeUFBQUFDd0FB QUFBQVFBQkFBQUNBZ1FCQURzJTNEJykKKz8+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDhlMjM4YmZhMjM2MGE0MWMxMTlmZjZiOWVhY2I0 OWVhOTMwOTJhYjguLmFhYWI1NmEwMjIxNDI1YmRhOTczNWEyMmFhMTBiZjM3ZDk5OGUzZmMgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjYgQEAKKzIwMTAtMTAtMDggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg cG9wc3RhdGUgZXZlbnRzIGFyZSBsb3N0IHdoZW4gbmV0d29yayBjb25uZWN0aW9uIGlzIGluIHBy b2dyZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 Mjk0MAorICAgICAgICAKKyAgICAgICAgSW5zdGVhZCBvZiBjaGVja2luZyBGcmFtZUxvYWRlcjo6 aXNDb21wbGV0ZSgpICh3aGljaCBpc24ndCB0cnVlIGlmIHRoZQorICAgICAgICBkb2N1bWVudCdz IHJlc291cmNlIGxvYWRlciBoYXMgcmVxdWVzdHMgb3V0c3RhbmRpbmcpLCBjaGVjayB0aGF0IHRo ZQorICAgICAgICBkb2N1bWVudCdzIHJlYWR5U3RhdGUgaXMgY29tcGxldGUsIGFzIHRoZSBzcGVj IHNheXMuCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9oaXN0b3J5L3BvcHN0YXRlLWZpcmVz LXdpdGgtcGVuZGluZy1yZXF1ZXN0cy5odG1sCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnN0YXRlUG9wcGVkKToKKyAgICAgICAgKiBs b2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmRp ZEJlZ2luRG9jdW1lbnQpOiBBZGRlZCBjYWxsIHRvIHNldCByZWFkeVN0YXRlCisgICAgICAgIHRv IExvYWRpbmcgZWFybGllci4gT3RoZXJ3aXNlLCByZWFkeVN0YXRlJ3MgaW5pdGlhbCB2YWx1ZSBp cyBDb21wbGV0ZSwKKyAgICAgICAgYW5kIHdlIG9ubHkgc2V0IGl0IHRvIExvYWRpbmcgaW4gRG9j dW1lbnQ6OmltcGxpY2l0T3BlbiAod2hpY2ggaXMgY2FsbGVkCisgICAgICAgIGFmdGVyIEZyYW1l TG9hZGVyOjpkaWRCZWdpbkRvY3VtZW50IGJ5IERvY3VtZW50V3JpdGVyOjpiZWdpbiksIHNvIHdl IAorICAgICAgICBjb3VsZCBlbmQgdXAgaW4gRG9jdW1lbnQ6OnN0YXRlUG9wcGVkIGFuZCBoYXZl IHRoZSByZWFkeVN0YXRlIGJlCisgICAgICAgIENvbXBsZXRlLCBldmVuIGlmIHdlIGhhZG4ndCBl dmVuIGJlZ2luIGxvYWRpbmcgdGhlIGRvY3VtZW50LgorCiAyMDEwLTEwLTA3ICBLd2FuZyBZdWwg U2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBU YW11cmEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKaW5kZXggYzMxMWNhMjZmYjkwYTg5ZjgxOTI3MjU4MzlkZTViMzEwZjU5 NmFlMC4uYmY2NWNhZDk4MmEyYmNiZGFjZTM1NWEyOTlhNjg1YWI2MTE3NWRkOSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cApAQCAtNDQyOCwxMSArNDQyOCwxMiBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVVUkxGb3JQdXNo T3JSZXBsYWNlU3RhdGUoY29uc3QgS1VSTCYgdXJsKQogCiB2b2lkIERvY3VtZW50OjpzdGF0ZVBv cHBlZChTZXJpYWxpemVkU2NyaXB0VmFsdWUqIHN0YXRlT2JqZWN0KQogewotICAgIEZyYW1lKiBm ID0gZnJhbWUoKTsKLSAgICBpZiAoIWYpCisgICAgaWYgKCFmcmFtZSgpKQogICAgICAgICByZXR1 cm47CiAgICAgCi0gICAgaWYgKGYtPmxvYWRlcigpLT5pc0NvbXBsZXRlKCkpCisgICAgLy8gUGVy IHN0ZXAgMTEgb2Ygc2VjdGlvbiA2LjUuOSAoaGlzdG9yeSB0cmF2ZXJzYWwpIG9mIHRoZSBIVE1M NSBzcGVjLCB3ZSAKKyAgICAvLyBkZWZlciBmaXJpbmcgb2YgcG9wc3RhdGUgdW50aWwgd2UncmUg aW4gdGhlIGNvbXBsZXRlIHN0YXRlLgorICAgIGlmIChtX3JlYWR5U3RhdGUgPT0gQ29tcGxldGUp CiAgICAgICAgIGVucXVldWVQb3BzdGF0ZUV2ZW50KHN0YXRlT2JqZWN0KTsKICAgICBlbHNlCiAg ICAgICAgIG1fcGVuZGluZ1N0YXRlT2JqZWN0ID0gc3RhdGVPYmplY3Q7CmRpZmYgLS1naXQgYS9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5jcHAKaW5kZXggZTJiZDQyNzkyYzc0YzNjMzg2MmRlZDY4ZjYzYTI3MjJjZjVhZWQxZC4uMmY5 MzEwMjJiOTU2MjAwZjY4ODhhZjE1NDIzM2VhOTdkZDdjNjgxOCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcApAQCAtNjU4LDYgKzY1OCw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmRpZEJlZ2luRG9jdW1l bnQoYm9vbCBkaXNwYXRjaCkKICAgICBtX2lzQ29tcGxldGUgPSBmYWxzZTsKICAgICBtX2RpZENh bGxJbXBsaWNpdENsb3NlID0gZmFsc2U7CiAgICAgbV9pc0xvYWRpbmdNYWluUmVzb3VyY2UgPSB0 cnVlOworICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPnNldFJlYWR5U3RhdGUoRG9jdW1lbnQ6Okxv YWRpbmcpOwogCiAgICAgaWYgKG1fcGVuZGluZ1N0YXRlT2JqZWN0KSB7CiAgICAgICAgIG1fZnJh bWUtPmRvY3VtZW50KCktPnN0YXRlUG9wcGVkKG1fcGVuZGluZ1N0YXRlT2JqZWN0LmdldCgpKTsK