42935 2010-07-24 06:06:11 -0700 [MSVC] Ensure 4 byte alignment on ARM 2010-07-24 17:40:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned commit-queue ggaren oliver oldest_to_newest 255706 0 paroga 2010-07-24 06:06:11 -0700 see patch 255707 1 62502 paroga 2010-07-24 06:07:26 -0700 Created attachment 62502 Patch 255736 2 62502 darin 2010-07-24 12:41:23 -0700 Comment on attachment 62502 Patch > +#if COMPILER(MSVC) > +#pragma pack(push) > +#pragma pack(4) > +#endif // COMPILER(MSVC) I think having a comment on an endif that is only 2 lines away from the #if is overkill! > +#if COMPILER(MSVC) > +#pragma pack(pop) > +#endif // COMPILER(MSVC) And even moreso here. 255739 3 paroga 2010-07-24 12:45:45 -0700 (In reply to comment #2) > I think having a comment on an endif that is only 2 lines away from the #if is overkill! I think too, but I only did the same like for the X86 part. ;-) 255766 4 62502 commit-queue 2010-07-24 17:40:41 -0700 Comment on attachment 62502 Patch Clearing flags on attachment: 62502 Committed r64017: <http://trac.webkit.org/changeset/64017> 255767 5 commit-queue 2010-07-24 17:40:46 -0700 All reviewed patches have been landed. Closing bug. 62502 2010-07-24 06:07:26 -0700 2010-07-24 17:40:41 -0700 Patch bug-42935.patch text/plain 1482 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0MDA4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMjQgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW01TVkNdIEVuc3VyZSA0IGJ5dGUgYWxpZ25tZW50IG9u IEFSTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI5 MzUKKworICAgICAgICAqIGppdC9KSVRTdHVicy5oOiBBZGRlZCAjcHJhZ21hIHBhY2soNCkgYXJv dW5kIEpJVFN0YWNrRnJhbWUuCisKIDIwMTAtMDctMjMgIFJhZmFlbCBBbnRvZ25vbGxpICA8YW50 b2dub2xsaUBwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdv bWVzLgpJbmRleDogSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmgJKHJldmlzaW9uIDYyNTQ3KQorKysgSmF2YVNj cmlwdENvcmUvaml0L0pJVFN0dWJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTE3MSw2ICsxNzEsMTAg QEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIFJldHVybkFkZHJlc3NQdHIqIHJldHVybkFkZHJl c3NTbG90KCkgeyByZXR1cm4gJnRodW5rUmV0dXJuQWRkcmVzczsgfQogICAgIH07CiAjZWxpZiBD UFUoQVJNX1RSQURJVElPTkFMKQorI2lmIENPTVBJTEVSKE1TVkMpCisjcHJhZ21hIHBhY2socHVz aCkKKyNwcmFnbWEgcGFjayg0KQorI2VuZGlmIC8vIENPTVBJTEVSKE1TVkMpCiAgICAgc3RydWN0 IEpJVFN0YWNrRnJhbWUgewogICAgICAgICBKSVRTdHViQXJnIHBhZGRpbmc7IC8vIFVudXNlZAog ICAgICAgICBKSVRTdHViQXJnIGFyZ3NbN107CkBAIC0xOTUsNiArMTk5LDkgQEAgbmFtZXNwYWNl IEpTQyB7CiAgICAgICAgIC8vIFdoZW4gSklUIGNvZGUgbWFrZXMgYSBjYWxsLCBpdCBwdXNoZXMg aXRzIHJldHVybiBhZGRyZXNzIGp1c3QgYmVsb3cgdGhlIHJlc3Qgb2YgdGhlIHN0YWNrLgogICAg ICAgICBSZXR1cm5BZGRyZXNzUHRyKiByZXR1cm5BZGRyZXNzU2xvdCgpIHsgcmV0dXJuICZ0aHVu a1JldHVybkFkZHJlc3M7IH0KICAgICB9OworI2lmIENPTVBJTEVSKE1TVkMpCisjcHJhZ21hIHBh Y2socG9wKQorI2VuZGlmIC8vIENPTVBJTEVSKE1TVkMpCiAjZWxpZiBDUFUoTUlQUykKICAgICBz dHJ1Y3QgSklUU3RhY2tGcmFtZSB7CiAgICAgICAgIHZvaWQqIHJlc2VydmVkOyAvLyBVbnVzZWQK