42933 2010-07-24 05:43:44 -0700 Cleanup defines in Platform.h 2010-07-24 17:09:11 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned commit-queue oldest_to_newest 255700 0 paroga 2010-07-24 05:43:44 -0700 see patch 255701 1 62500 paroga 2010-07-24 05:45:55 -0700 Created attachment 62500 Patch All defines are handeld by buildsystem now. 255735 2 62500 darin 2010-07-24 12:40:24 -0700 Comment on attachment 62500 Patch > -#if PLATFORM(WIN) > +#if PLATFORM(WIN) && !OS(WINCE) Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong. 255737 3 62500 paroga 2010-07-24 12:44:03 -0700 Comment on attachment 62500 Patch (In reply to comment #2) > (From update of attachment 62500 [details]) > > -#if PLATFORM(WIN) > > +#if PLATFORM(WIN) && !OS(WINCE) > > Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong. WinCE+GDI defines PLATFORM(WIN), so it is correct. Cleaning up the PLATFORM() checks for WinCE is IMHO an other task. (e.g. There a too many OS(WINCE) && !PLATFORM(QT)) 255740 4 62500 darin 2010-07-24 12:46:26 -0700 Comment on attachment 62500 Patch That use of PLATFORM(WIN) is going to create tons of problems! 255754 5 62500 commit-queue 2010-07-24 17:09:07 -0700 Comment on attachment 62500 Patch Clearing flags on attachment: 62500 Committed r64016: <http://trac.webkit.org/changeset/64016> 255755 6 commit-queue 2010-07-24 17:09:11 -0700 All reviewed patches have been landed. Closing bug. 62500 2010-07-24 05:45:55 -0700 2010-07-24 17:09:07 -0700 Patch bug-42933.patch text/plain 1768 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY0MDA3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMjQgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTkNFXSBDbGVhbnVwIGRlZmluZXMgaW4gUGxhdGZv cm0uaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI5 MzMKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEwLTA3LTIzICBSYWZhZWwgQW50 b2dub2xsaSAgPGFudG9nbm9sbGlAcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQW50b25pbyBHb21lcy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA2NDAw NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC01 NDgsMTYgKzU0OCw2IEBACiAjZW5kaWYKIAogI2lmIE9TKFdJTkNFKSAmJiAhUExBVEZPUk0oUVQp Ci0jdW5kZWYgRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTCi0jZGVmaW5lIEVOQUJMRV9KU0Nf TVVMVElQTEVfVEhSRUFEUyAgICAgICAgMAotI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAgICAg ICAgICAgICAgICAgIDAKLSNkZWZpbmUgRU5BQkxFX0lDT05EQVRBQkFTRSAgICAgICAgICAgICAg ICAwCi0jZGVmaW5lIEVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSICAgICAgICAgMAotI2RlZmlu ZSBFTkFCTEVfRlRQRElSICAgICAgICAgICAgICAgICAgICAgIDAKLSNkZWZpbmUgRU5BQkxFX1BB Tl9TQ1JPTExJTkcgICAgICAgICAgICAgICAwCi0jZGVmaW5lIEVOQUJMRV9XTUwgICAgICAgICAg ICAgICAgICAgICAgICAgMQotI2RlZmluZSBIQVZFX0FDQ0VTU0lCSUxJVFkgICAgICAgICAgICAg ICAgIDAKLQogI2RlZmluZSBOT01JTk1BWCAgICAgICAvKiBXaW5kb3dzIG1pbiBhbmQgbWF4IGNv bmZsaWN0IHdpdGggc3RhbmRhcmQgbWFjcm9zICovCiAjZGVmaW5lIE5PU0hMV0FQSSAgICAgIC8q IHNobHdhcGkuaCBub3QgYXZhaWxhYmxlIG9uIFdpbkNlICovCiAKQEAgLTEwODQsNyArMTA3NCw3 IEBAIG9uIE1pbkdXLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2gKIC8qIEZJWE1FOiBE ZWZpbmluZyBFTkFCTEVfM0RfUkVOREVSSU5HIGhlcmUgaXNuJ3QgcmVhbGx5IHJpZ2h0LCBidXQg aXQncyBhbHdheXMgdXNlZCB3aXRoCiAgICB3aXRoIFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9T SVRJTkcsIGFuZCBpdCBhbGxvd3MgdGhlIGZlYXR1cmUgdG8gYmUgdHVybmVkIG9uIGFuZAogICAg b2ZmIGluIG9uZSBwbGFjZS4gKi8KLSNpZiBQTEFURk9STShXSU4pCisjaWYgUExBVEZPUk0oV0lO KSAmJiAhT1MoV0lOQ0UpCiAjaW5jbHVkZSAiUXVhcnR6Q29yZVByZXNlbnQuaCIKICNpZiBRVUFS VFpDT1JFX1BSRVNFTlQKICNkZWZpbmUgV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORyAx Cg==