42928 2010-07-24 01:53:22 -0700 [WINCE] Buildfix for ImageBufferWince 2010-07-25 20:48:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned aroben commit-queue webkit.review.bot oldest_to_newest 255680 0 paroga 2010-07-24 01:53:22 -0700 see patch 255681 1 62492 paroga 2010-07-24 01:56:21 -0700 Created attachment 62492 Patch 255682 2 webkit.review.bot 2010-07-24 01:58:44 -0700 Attachment 62492 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/wince/ImageBufferWince.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 255683 3 62493 paroga 2010-07-24 02:02:08 -0700 Created attachment 62493 Patch 255884 4 62493 commit-queue 2010-07-25 20:48:55 -0700 Comment on attachment 62493 Patch Clearing flags on attachment: 62493 Committed r64026: <http://trac.webkit.org/changeset/64026> 255885 5 commit-queue 2010-07-25 20:48:59 -0700 All reviewed patches have been landed. Closing bug. 62492 2010-07-24 01:56:21 -0700 2010-07-24 02:02:08 -0700 Patch bug-42928.patch text/plain 3751 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDAwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1dJTkNFXSBCdWlsZGZpeCBmb3IgSW1hZ2VCdWZmZXJXaW5jZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI5MjgKKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3dpbmNlL0ltYWdlQnVmZmVyV2luY2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6KToKKyAgICAgICAgKFdlYkNvcmU6OkJ1ZmZlcmVkSW1hZ2U6OmRyYXcpOiBQYXNzIHRocm91 Z2ggQ29sb3JTcGFjZSBwYXJhbWV0ZXIuCisgICAgICAgIChXZWJDb3JlOjpCdWZmZXJlZEltYWdl OjpkcmF3UGF0dGVybik6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnBs YXRmb3JtVHJhbnNmb3JtQ29sb3JTcGFjZSk6IEFkZGVkLgorCiAyMDEwLTA3LTIzICBQYXRyaWNr IEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9JbWFnZUJ1 ZmZlcldpbmNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp bmNlL0ltYWdlQnVmZmVyV2luY2UuY3BwCShyZXZpc2lvbiA2NDAwNykKKysrIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luY2UvSW1hZ2VCdWZmZXJXaW5jZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI3LDcgKzI3LDkgQEAKICNpbmNsdWRlICJJbWFnZURhdGEuaCIKICNpbmNsdWRlICJKUEVH RW5jb2Rlci5oIgogI2luY2x1ZGUgIlBOR0VuY29kZXIuaCIKKyNpbmNsdWRlICJOb3RJbXBsZW1l bnRlZC5oIgogI2luY2x1ZGUgIlNoYXJlZEJpdG1hcC5oIgorI2luY2x1ZGUgIlVudXNlZFBhcmFt LmgiCiAjaW5jbHVkZSA8d3RmL1VudXNlZFBhcmFtLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK QEAgLTQzLDI0ICs0NSwyNCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBJbnRTaXplIHNpemUoKSBj b25zdCB7IHJldHVybiBJbnRTaXplKG1fZGF0YS0+bV9iaXRtYXAtPndpZHRoKCksIG1fZGF0YS0+ bV9iaXRtYXAtPmhlaWdodCgpKTsgfQogICAgIHZpcnR1YWwgdm9pZCBkZXN0cm95RGVjb2RlZERh dGEoYm9vbCBkZXN0cm95QWxsID0gdHJ1ZSkge30KICAgICB2aXJ0dWFsIHVuc2lnbmVkIGRlY29k ZWRTaXplKCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1YWwgdm9pZCBkcmF3KEdyYXBo aWNzQ29udGV4dCosIGNvbnN0IEZsb2F0UmVjdCYgZHN0UmVjdCwgY29uc3QgRmxvYXRSZWN0JiBz cmNSZWN0LCBDb21wb3NpdGVPcGVyYXRvcik7CisgICAgdmlydHVhbCB2b2lkIGRyYXcoR3JhcGhp Y3NDb250ZXh0KiwgY29uc3QgRmxvYXRSZWN0JiBkc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNy Y1JlY3QsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBDb21wb3NpdGVPcGVyYXRvcik7CiAg ICAgdmlydHVhbCB2b2lkIGRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEZsb2F0 UmVjdCYgc3JjUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJhbnNmb3JtLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBGbG9hdFBvaW50JiBwaGFzZSwgQ29t cG9zaXRlT3BlcmF0b3IsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJlY3QpOworICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBGbG9hdFBvaW50JiBwaGFzZSwgQ29sb3JTcGFjZSBzdHls ZUNvbG9yU3BhY2UsIENvbXBvc2l0ZU9wZXJhdG9yLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0 KTsKIAogICAgIGNvbnN0IEltYWdlQnVmZmVyRGF0YSogbV9kYXRhOwogfTsKIAotdm9pZCBCdWZm ZXJlZEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBk c3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIENvbXBvc2l0ZU9wZXJhdG9yIGNvbXBv c2l0ZU9wKQordm9pZCBCdWZmZXJlZEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4dCwg Y29uc3QgRmxvYXRSZWN0JiBkc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIENvbG9y U3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBDb21wb3NpdGVPcGVyYXRvciBjb21wb3NpdGVPcCkKIHsK ICAgICBJbnRSZWN0IGludERzdFJlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KGRzdFJlY3QpOwogICAg IEludFJlY3QgaW50U3JjUmVjdChzcmNSZWN0KTsKLSAgICBtX2RhdGEtPm1fYml0bWFwLT5kcmF3 KGN0eHQsIGludERzdFJlY3QsIGludFNyY1JlY3QsIGNvbXBvc2l0ZU9wKTsKKyAgICBtX2RhdGEt Pm1fYml0bWFwLT5kcmF3KGN0eHQsIGludERzdFJlY3QsIGludFNyY1JlY3QsIHN0eWxlQ29sb3JT cGFjZSwgY29tcG9zaXRlT3ApOwogfQogCiB2b2lkIEJ1ZmZlcmVkSW1hZ2U6OmRyYXdQYXR0ZXJu KEdyYXBoaWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiB0aWxlUmVjdEluLCBjb25z dCBBZmZpbmVUcmFuc2Zvcm0mIHBhdHRlcm5UcmFuc2Zvcm0sCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbnN0IEZsb2F0UG9pbnQmIHBoYXNlLCBDb21wb3NpdGVPcGVyYXRvciBvcCwg Y29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3QgRmxvYXRQb2ludCYgcGhhc2UsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBDb21w b3NpdGVPcGVyYXRvciBvcCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCkKIHsKLSAgICBtX2Rh dGEtPm1fYml0bWFwLT5kcmF3UGF0dGVybihjdHh0LCB0aWxlUmVjdEluLCBwYXR0ZXJuVHJhbnNm b3JtLCBwaGFzZSwgb3AsIGRlc3RSZWN0LCBzaXplKCkpOworICAgIG1fZGF0YS0+bV9iaXRtYXAt PmRyYXdQYXR0ZXJuKGN0eHQsIHRpbGVSZWN0SW4sIHBhdHRlcm5UcmFuc2Zvcm0sIHBoYXNlLCBz dHlsZUNvbG9yU3BhY2UsIG9wLCBkZXN0UmVjdCwgc2l6ZSgpKTsKIH0KIAogSW1hZ2VCdWZmZXJE YXRhOjpJbWFnZUJ1ZmZlckRhdGEoY29uc3QgSW50U2l6ZSYgc2l6ZSkKQEAgLTIxNiw2ICsyMTgs MTIgQEAgdm9pZCBJbWFnZUJ1ZmZlcjo6cHV0UHJlbXVsdGlwbGllZEltYWdlRAogICAgIHB1dElt YWdlRGF0YTx0cnVlPihzb3VyY2UsIHNvdXJjZVJlY3QsIGRlc3RQb2ludCwgbV9kYXRhLm1fYml0 bWFwLmdldCgpKTsKIH0KIAordm9pZCBJbWFnZUJ1ZmZlcjo6cGxhdGZvcm1UcmFuc2Zvcm1Db2xv clNwYWNlKGNvbnN0IFZlY3RvcjxpbnQ+JiBsb29rVXBUYWJsZSkKK3sKKyAgICBVTlVTRURfUEFS QU0obG9va1VwVGFibGUpOworICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKIFN0cmluZyBJbWFn ZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IGRvdWJsZSop IGNvbnN0CiB7CiAgICAgaWYgKCFtX2RhdGEubV9iaXRtYXAtPmJ5dGVzKCkpCg== 62493 2010-07-24 02:02:08 -0700 2010-07-25 20:48:55 -0700 Patch bug-42928b.patch text/plain 3772 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDAwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1dJTkNFXSBCdWlsZGZpeCBmb3IgSW1hZ2VCdWZmZXJXaW5jZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI5MjgKKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3dpbmNlL0ltYWdlQnVmZmVyV2luY2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6KToKKyAgICAgICAgKFdlYkNvcmU6OkJ1ZmZlcmVkSW1hZ2U6OmRyYXcpOiBQYXNzIHRocm91 Z2ggQ29sb3JTcGFjZSBwYXJhbWV0ZXIuCisgICAgICAgIChXZWJDb3JlOjpCdWZmZXJlZEltYWdl OjpkcmF3UGF0dGVybik6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnBs YXRmb3JtVHJhbnNmb3JtQ29sb3JTcGFjZSk6IEFkZGVkLgorCiAyMDEwLTA3LTIzICBQYXRyaWNr IEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9JbWFnZUJ1 ZmZlcldpbmNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp bmNlL0ltYWdlQnVmZmVyV2luY2UuY3BwCShyZXZpc2lvbiA2NDAwNykKKysrIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luY2UvSW1hZ2VCdWZmZXJXaW5jZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI2LDggKzI2LDEwIEBACiAjaW5jbHVkZSAiSW1hZ2UuaCIKICNpbmNsdWRlICJJbWFnZURh dGEuaCIKICNpbmNsdWRlICJKUEVHRW5jb2Rlci5oIgorI2luY2x1ZGUgIk5vdEltcGxlbWVudGVk LmgiCiAjaW5jbHVkZSAiUE5HRW5jb2Rlci5oIgogI2luY2x1ZGUgIlNoYXJlZEJpdG1hcC5oIgor I2luY2x1ZGUgIlVudXNlZFBhcmFtLmgiCiAjaW5jbHVkZSA8d3RmL1VudXNlZFBhcmFtLmg+CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTQzLDI0ICs0NSwyNCBAQCBwdWJsaWM6CiAgICAgdmly dHVhbCBJbnRTaXplIHNpemUoKSBjb25zdCB7IHJldHVybiBJbnRTaXplKG1fZGF0YS0+bV9iaXRt YXAtPndpZHRoKCksIG1fZGF0YS0+bV9iaXRtYXAtPmhlaWdodCgpKTsgfQogICAgIHZpcnR1YWwg dm9pZCBkZXN0cm95RGVjb2RlZERhdGEoYm9vbCBkZXN0cm95QWxsID0gdHJ1ZSkge30KICAgICB2 aXJ0dWFsIHVuc2lnbmVkIGRlY29kZWRTaXplKCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZp cnR1YWwgdm9pZCBkcmF3KEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEZsb2F0UmVjdCYgZHN0UmVj dCwgY29uc3QgRmxvYXRSZWN0JiBzcmNSZWN0LCBDb21wb3NpdGVPcGVyYXRvcik7CisgICAgdmly dHVhbCB2b2lkIGRyYXcoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgRmxvYXRSZWN0JiBkc3RSZWN0 LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBD b21wb3NpdGVPcGVyYXRvcik7CiAgICAgdmlydHVhbCB2b2lkIGRyYXdQYXR0ZXJuKEdyYXBoaWNz Q29udGV4dCosIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3Jt JiBwYXR0ZXJuVHJhbnNmb3JtLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBG bG9hdFBvaW50JiBwaGFzZSwgQ29tcG9zaXRlT3BlcmF0b3IsIGNvbnN0IEZsb2F0UmVjdCYgZGVz dFJlY3QpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBGbG9hdFBvaW50JiBw aGFzZSwgQ29sb3JTcGFjZSBzdHlsZUNvbG9yU3BhY2UsIENvbXBvc2l0ZU9wZXJhdG9yLCBjb25z dCBGbG9hdFJlY3QmIGRlc3RSZWN0KTsKIAogICAgIGNvbnN0IEltYWdlQnVmZmVyRGF0YSogbV9k YXRhOwogfTsKIAotdm9pZCBCdWZmZXJlZEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4 dCwgY29uc3QgRmxvYXRSZWN0JiBkc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIENv bXBvc2l0ZU9wZXJhdG9yIGNvbXBvc2l0ZU9wKQordm9pZCBCdWZmZXJlZEltYWdlOjpkcmF3KEdy YXBoaWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBkc3RSZWN0LCBjb25zdCBGbG9h dFJlY3QmIHNyY1JlY3QsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBDb21wb3NpdGVPcGVy YXRvciBjb21wb3NpdGVPcCkKIHsKICAgICBJbnRSZWN0IGludERzdFJlY3QgPSBlbmNsb3NpbmdJ bnRSZWN0KGRzdFJlY3QpOwogICAgIEludFJlY3QgaW50U3JjUmVjdChzcmNSZWN0KTsKLSAgICBt X2RhdGEtPm1fYml0bWFwLT5kcmF3KGN0eHQsIGludERzdFJlY3QsIGludFNyY1JlY3QsIGNvbXBv c2l0ZU9wKTsKKyAgICBtX2RhdGEtPm1fYml0bWFwLT5kcmF3KGN0eHQsIGludERzdFJlY3QsIGlu dFNyY1JlY3QsIHN0eWxlQ29sb3JTcGFjZSwgY29tcG9zaXRlT3ApOwogfQogCiB2b2lkIEJ1ZmZl cmVkSW1hZ2U6OmRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRS ZWN0JiB0aWxlUmVjdEluLCBjb25zdCBBZmZpbmVUcmFuc2Zvcm0mIHBhdHRlcm5UcmFuc2Zvcm0s Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IEZsb2F0UG9pbnQmIHBoYXNlLCBD b21wb3NpdGVPcGVyYXRvciBvcCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgRmxvYXRQb2ludCYgcGhhc2UsIENvbG9yU3BhY2Ug c3R5bGVDb2xvclNwYWNlLCBDb21wb3NpdGVPcGVyYXRvciBvcCwgY29uc3QgRmxvYXRSZWN0JiBk ZXN0UmVjdCkKIHsKLSAgICBtX2RhdGEtPm1fYml0bWFwLT5kcmF3UGF0dGVybihjdHh0LCB0aWxl UmVjdEluLCBwYXR0ZXJuVHJhbnNmb3JtLCBwaGFzZSwgb3AsIGRlc3RSZWN0LCBzaXplKCkpOwor ICAgIG1fZGF0YS0+bV9iaXRtYXAtPmRyYXdQYXR0ZXJuKGN0eHQsIHRpbGVSZWN0SW4sIHBhdHRl cm5UcmFuc2Zvcm0sIHBoYXNlLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBkZXN0UmVjdCwgc2l6ZSgp KTsKIH0KIAogSW1hZ2VCdWZmZXJEYXRhOjpJbWFnZUJ1ZmZlckRhdGEoY29uc3QgSW50U2l6ZSYg c2l6ZSkKQEAgLTIxNiw2ICsyMTgsMTIgQEAgdm9pZCBJbWFnZUJ1ZmZlcjo6cHV0UHJlbXVsdGlw bGllZEltYWdlRAogICAgIHB1dEltYWdlRGF0YTx0cnVlPihzb3VyY2UsIHNvdXJjZVJlY3QsIGRl c3RQb2ludCwgbV9kYXRhLm1fYml0bWFwLmdldCgpKTsKIH0KIAordm9pZCBJbWFnZUJ1ZmZlcjo6 cGxhdGZvcm1UcmFuc2Zvcm1Db2xvclNwYWNlKGNvbnN0IFZlY3RvcjxpbnQ+JiBsb29rVXBUYWJs ZSkKK3sKKyAgICBVTlVTRURfUEFSQU0obG9va1VwVGFibGUpOworICAgIG5vdEltcGxlbWVudGVk KCk7Cit9CisKIFN0cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0IFN0cmluZyYgbWlt ZVR5cGUsIGNvbnN0IGRvdWJsZSopIGNvbnN0CiB7CiAgICAgaWYgKCFtX2RhdGEubV9iaXRtYXAt PmJ5dGVzKCkpCg==