42923 2010-07-23 18:19:37 -0700 Re-order whitespace checks in the tokenizer 2010-07-24 13:02:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 255624 0 abarth 2010-07-23 18:19:37 -0700 Re-order whitespace checks in the tokenizer 255626 1 62482 abarth 2010-07-23 18:20:32 -0700 Created attachment 62482 Patch 255635 2 62482 eric 2010-07-23 20:05:19 -0700 Comment on attachment 62482 Patch Interesting. Again, would be nice to have a comment about why they're in this order. 255640 3 62482 abarth 2010-07-23 20:15:52 -0700 Comment on attachment 62482 Patch There's an extensive comment in ASCIIType.h that explains the proper order and has statistics. 255689 4 62482 commit-queue 2010-07-24 03:04:22 -0700 Comment on attachment 62482 Patch Rejecting patch 62482 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20715 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 11.51s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3567416 255708 5 62482 eric 2010-07-24 07:51:16 -0700 Comment on attachment 62482 Patch Bug 42821. 255743 6 62482 commit-queue 2010-07-24 13:02:48 -0700 Comment on attachment 62482 Patch Clearing flags on attachment: 62482 Committed r64012: <http://trac.webkit.org/changeset/64012> 255744 7 commit-queue 2010-07-24 13:02:53 -0700 All reviewed patches have been landed. Closing bug. 62482 2010-07-23 18:20:32 -0700 2010-07-24 13:02:48 -0700 Patch bug-42923-20100723182031.patch text/plain 1260 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDZjNWFjMTI3N2VmODU1MTI3ZGU2ZGQ5ODYwYTk5N2QyMzQxZmI0MS4uNDg0NDNhNzJhNDI3MjYw ZmQ4YTY1MTMzM2FjMGE4NjZmZTMwNDQyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNyBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFJlLW9yZGVyIHdoaXRlc3BhY2UgY2hl Y2tzIGluIHRoZSB0b2tlbml6ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQyOTIzCisKKyAgICAgICAgVGhpcyBzYXZlcyBhYm91dCAwLjUlIG9uIHRo ZSBwYXJzaW5nIGJlbmNobWFyay4KKworICAgICAgICAqIGh0bWwvSFRNTFRva2VuaXplci5jcHA6 CisKKzIwMTAtMDctMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBTYXZlIGEgcGVyLWNoYXJh Y3RlciBicmFuY2ggaW4gdGhlIEhUTUwgcGFyc2VyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjkyMQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv SFRNTFRva2VuaXplci5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTFRva2VuaXplci5jcHAKaW5kZXgg MzgyOTU4MDczYTY3YWEzZDc3ZThjYWE1NmYxN2RjMDhiMDNlYjQzNS4uYzgyMzRlNDdhYzkyZTE4 ZGVjNGQyMTQ4NGIwNGY1NTJlNzlmMDhmOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxU b2tlbml6ZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmNwcApAQCAtNTgs NyArNTgsNyBAQCBpbmxpbmUgVUNoYXIgdG9Mb3dlckNhc2UoVUNoYXIgY2MpCiAKIGlubGluZSBi b29sIGlzVG9rZW5pemVyV2hpdGVzcGFjZShVQ2hhciBjYykKIHsKLSAgICByZXR1cm4gY2MgPT0g J1x4MDknIHx8IGNjID09ICdceDBBJyB8fCBjYyA9PSAnXHgwQycgfHwgY2MgPT0gJyAnOworICAg IHJldHVybiBjYyA9PSAnICcgfHwgY2MgPT0gJ1x4MEEnIHx8IGNjID09ICdceDA5JyB8fCBjYyA9 PSAnXHgwQyc7CiB9CiAKIGlubGluZSB2b2lkIGFkdmFuY2VTdHJpbmdBbmRBU1NFUlRJZ25vcmlu Z0Nhc2UoU2VnbWVudGVkU3RyaW5nJiBzb3VyY2UsIGNvbnN0IGNoYXIqIGV4cGVjdGVkQ2hhcmFj dGVycykK