42921 2010-07-23 17:56:31 -0700 Save a per-character branch in the HTML parser 2010-07-24 10:33:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 255618 0 abarth 2010-07-23 17:56:31 -0700 Save a per-character branch in the HTML parser 255619 1 62479 abarth 2010-07-23 17:58:03 -0700 Created attachment 62479 Patch 255636 2 62479 eric 2010-07-23 20:09:03 -0700 Comment on attachment 62479 Patch So I'm confused by the m_data.clear()s being moved to .clear(). When is ::clear() called? I guess either the branch isn't actually that hot, or branch prediction is just winning out here. 255641 3 abarth 2010-07-23 20:17:57 -0700 > So I'm confused by the m_data.clear()s being moved to .clear(). When is ::clear() called? Clear is called by the HTMLDocumentParser after each token. It reset the token. Before we were using lazy clearing where we delayed zeroing everything out until we started a new token. I want to get rid of the branch, so i made this eager. > I guess either the branch isn't actually that hot, or branch prediction is just winning out here. Probably. Or maybe moving the clear is costing us. In any case, I think this is prettier. 255650 4 62479 commit-queue 2010-07-23 21:42:29 -0700 Comment on attachment 62479 Patch Rejecting patch 62479 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20715 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 12.72s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3623012 255710 5 62479 eric 2010-07-24 07:53:27 -0700 Comment on attachment 62479 Patch Bug 42821, again. 255726 6 62479 commit-queue 2010-07-24 10:07:47 -0700 Comment on attachment 62479 Patch Rejecting patch 62479 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20715 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 11.55s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3572410 255727 7 62479 eric 2010-07-24 10:15:11 -0700 Comment on attachment 62479 Patch Broken animation test. :( 255728 8 abarth 2010-07-24 10:21:38 -0700 The failure rate on that test is out of control. Can we do something about it? 255729 9 62479 commit-queue 2010-07-24 10:33:24 -0700 Comment on attachment 62479 Patch Clearing flags on attachment: 62479 Committed r64010: <http://trac.webkit.org/changeset/64010> 255730 10 commit-queue 2010-07-24 10:33:29 -0700 All reviewed patches have been landed. Closing bug. 62479 2010-07-23 17:58:03 -0700 2010-07-24 10:33:23 -0700 Patch bug-42921-20100723175802.patch text/plain 3376 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTUyNDZjOGNjMzg5NzBiNDg0M2Y3ODg2YWJmZjQ0ODFlZmFkZmM1NS4uNDZjNWFjMTI3N2VmODU1 MTI3ZGU2ZGQ5ODYwYTk5N2QyMzQxZmI0MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNSBAQAogMjAxMC0wNy0yMyAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNhdmUgYSBwZXItY2hhcmFjdGVyIGJyYW5jaCBpbiB0aGUg SFRNTCBwYXJzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQyOTIxCisKKyAgICAgICAgVGhlIHBhcnNpbmcgYmVuY2htYXJrIGNsYWltcyB0aGlzIGlz IGEgd2FzaCwgYnV0IGl0IG1ha2VzIG1lIGZlZWwKKyAgICAgICAgYmV0dGVyLgorCisgICAgICAg ICogaHRtbC9IVE1MVG9rZW4uaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUb2tlbjo6Y2xlYXIp OgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRva2VuOjpiZWdpblN0YXJ0VGFnKToKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxUb2tlbjo6YmVnaW5FbmRUYWcpOgorICAgICAgICAoV2ViQ29yZTo6SFRN TFRva2VuOjplbnN1cmVJc0NoYXJhY3RlclRva2VuKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxU b2tlbjo6YmVnaW5Db21tZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUb2tlbjo6YmVnaW5E T0NUWVBFKToKKyAgICAgICAgKiBodG1sL0hUTUxUb2tlbml6ZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTFRva2VuaXplcjo6YnVmZmVyQ2hhcmFjdGVyKToKKworMjAxMC0wNy0yMyAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgogCiAgICAgICAgIFJlc2VydmUgY2FwYWNpdHkgZm9yIGF0dHJpYnV0ZXMKZGlmZiAt LWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW4uaCBiL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW4u aAppbmRleCA0MDdlNWQ3MTNmYzQzZjQ5NWM5ZGU2MzE3ZDU1OTQ4YmI4ZDQ0M2Q5Li44NDY1YTM1 ZDEzYTM5OTFjZjMyZDZhMmQxMDBiZGJiNGMxODE5ZTdmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0 bWwvSFRNTFRva2VuLmgKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxUb2tlbi5oCkBAIC01OSw2ICs1 OSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGNsZWFyKCkKICAgICB7CiAgICAgICAgIG1fdHlwZSA9 IFVuaW5pdGlhbGl6ZWQ7CisgICAgICAgIG1fZGF0YS5jbGVhcigpOwogICAgIH0KIAogICAgIHZv aWQgbWFrZUVuZE9mRmlsZSgpCkBAIC03Miw3ICs3Myw2IEBAIHB1YmxpYzoKICAgICAgICAgQVNT RVJUKGNoYXJhY3Rlcik7CiAgICAgICAgIEFTU0VSVChtX3R5cGUgPT0gVW5pbml0aWFsaXplZCk7 CiAgICAgICAgIG1fdHlwZSA9IFN0YXJ0VGFnOwotICAgICAgICBtX2RhdGEuY2xlYXIoKTsKICAg ICAgICAgbV9zZWxmQ2xvc2luZyA9IGZhbHNlOwogICAgICAgICBtX2N1cnJlbnRBdHRyaWJ1dGUg PSAwOwogICAgICAgICBtX2F0dHJpYnV0ZXMuY2xlYXIoKTsKQEAgLTg1LDcgKzg1LDYgQEAgcHVi bGljOgogICAgIHsKICAgICAgICAgQVNTRVJUKG1fdHlwZSA9PSBVbmluaXRpYWxpemVkKTsKICAg ICAgICAgbV90eXBlID0gRW5kVGFnOwotICAgICAgICBtX2RhdGEuY2xlYXIoKTsKICAgICAgICAg bV9zZWxmQ2xvc2luZyA9IGZhbHNlOwogICAgICAgICBtX2N1cnJlbnRBdHRyaWJ1dGUgPSAwOwog ICAgICAgICBtX2F0dHJpYnV0ZXMuY2xlYXIoKTsKQEAgLTkzLDI3ICs5MiwyNCBAQCBwdWJsaWM6 CiAgICAgICAgIG1fZGF0YS5hcHBlbmQoY2hhcmFjdGVycyk7CiAgICAgfQogCi0gICAgdm9pZCBi ZWdpbkNoYXJhY3RlcihVQ2hhciBjaGFyYWN0ZXIpCisgICAgLy8gU3RhcnRpbmcgYSBjaGFyYWN0 ZXIgdG9rZW4gd29ya3Mgc2xpZ2h0bHkgZGlmZmVyZW50bHkgdGhhbiBzdGFydGluZworICAgIC8v IG90aGVyIHR5cGVzIG9mIHRva2VucyBiZWNhdXNlIHdlIHdhbnQgdG8gc2F2ZSBhIHBlci1jaGFy YWN0ZXIgYnJhbmNoLgorICAgIHZvaWQgZW5zdXJlSXNDaGFyYWN0ZXJUb2tlbigpCiAgICAgewot ICAgICAgICBBU1NFUlQoY2hhcmFjdGVyKTsKLSAgICAgICAgQVNTRVJUKG1fdHlwZSA9PSBVbmlu aXRpYWxpemVkKTsKKyAgICAgICAgQVNTRVJUKG1fdHlwZSA9PSBVbmluaXRpYWxpemVkIHx8IG1f dHlwZSA9PSBDaGFyYWN0ZXIpOwogICAgICAgICBtX3R5cGUgPSBDaGFyYWN0ZXI7Ci0gICAgICAg IG1fZGF0YS5jbGVhcigpOwotICAgICAgICBtX2RhdGEuYXBwZW5kKGNoYXJhY3Rlcik7CiAgICAg fQogCiAgICAgdm9pZCBiZWdpbkNvbW1lbnQoKQogICAgIHsKICAgICAgICAgQVNTRVJUKG1fdHlw ZSA9PSBVbmluaXRpYWxpemVkKTsKICAgICAgICAgbV90eXBlID0gQ29tbWVudDsKLSAgICAgICAg bV9kYXRhLmNsZWFyKCk7CiAgICAgfQogCiAgICAgdm9pZCBiZWdpbkRPQ1RZUEUoKQogICAgIHsK ICAgICAgICAgQVNTRVJUKG1fdHlwZSA9PSBVbmluaXRpYWxpemVkKTsKICAgICAgICAgbV90eXBl ID0gRE9DVFlQRTsKLSAgICAgICAgbV9kYXRhLmNsZWFyKCk7CiAgICAgICAgIG1fZG9jdHlwZURh dGEuc2V0KG5ldyBEb2N0eXBlRGF0YSgpKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv aHRtbC9IVE1MVG9rZW5pemVyLmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmNwcApp bmRleCA1NWZkMWNhNDg0NDJlMWVlODNkZmNhZDY1ZmY3NGIzZjczOTQ5OWRjLi4zODI5NTgwNzNh NjdhYTNkNzdlOGNhYTU2ZjE3ZGMwOGIwM2ViNDM1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwv SFRNTFRva2VuaXplci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwCkBA IC0xNjA4LDEwICsxNjA4LDcgQEAgaW5saW5lIGJvb2wgSFRNTFRva2VuaXplcjo6aXNBcHByb3By aWF0ZUVuZFRhZygpCiBpbmxpbmUgdm9pZCBIVE1MVG9rZW5pemVyOjpidWZmZXJDaGFyYWN0ZXIo VUNoYXIgY2hhcmFjdGVyKQogewogICAgIEFTU0VSVChjaGFyYWN0ZXIgIT0gSW5wdXRTdHJlYW1Q cmVwcm9jZXNzb3I6OmVuZE9mRmlsZU1hcmtlcik7Ci0gICAgaWYgKG1fdG9rZW4tPnR5cGUoKSAh PSBIVE1MVG9rZW46OkNoYXJhY3RlcikgewotICAgICAgICBtX3Rva2VuLT5iZWdpbkNoYXJhY3Rl cihjaGFyYWN0ZXIpOwotICAgICAgICByZXR1cm47Ci0gICAgfQorICAgIG1fdG9rZW4tPmVuc3Vy ZUlzQ2hhcmFjdGVyVG9rZW4oKTsKICAgICBtX3Rva2VuLT5hcHBlbmRUb0NoYXJhY3RlcihjaGFy YWN0ZXIpOwogfQogCg==