42910 2010-07-23 14:24:01 -0700 [Chromium] In PopupMenuChromium label and text can overlap 2010-07-28 08:19:43 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue dglazkov dhollowa jhawkins oldest_to_newest 255553 0 jcivelli 2010-07-23 14:24:01 -0700 When using the autofill feature in Chrome, the text and label in the popup can overlap if they are long. 255563 1 62462 jcivelli 2010-07-23 14:41:42 -0700 Created attachment 62462 Initial patch 255564 2 62462 jcivelli 2010-07-23 14:42:19 -0700 Comment on attachment 62462 Initial patch Uploaded wrong patch 255565 3 62463 jcivelli 2010-07-23 14:44:49 -0700 Created attachment 62463 Right patch this time 255568 4 jhawkins 2010-07-23 14:47:58 -0700 LGTM 255573 5 dhollowa 2010-07-23 15:08:35 -0700 LGTM. 256853 6 62463 commit-queue 2010-07-27 14:41:54 -0700 Comment on attachment 62463 Right patch this time Rejecting patch 62463 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20722 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 18.11s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3612277 256863 7 jhawkins 2010-07-27 14:56:14 -0700 Speaking on behalf of Jay, who I'm not sure is around: I'm pretty positive this CL is not causing the test failure. 257159 8 62463 commit-queue 2010-07-28 08:19:39 -0700 Comment on attachment 62463 Right patch this time Clearing flags on attachment: 62463 Committed r64205: <http://trac.webkit.org/changeset/64205> 257160 9 commit-queue 2010-07-28 08:19:43 -0700 All reviewed patches have been landed. Closing bug. 62462 2010-07-23 14:41:42 -0700 2010-07-23 14:44:49 -0700 Initial patch popup_width.patch text/plain 1405 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzI0OSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNy0xMyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBkb24ndCByZXN0cmljdCB0aGUg d2lkdGggb2YgdGhlIGF1dG9maWxsIHBvcHVwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIyMDYKKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5j cHA6CisKIDIwMTAtMDctMTMgIEFsYmVydCBKLiBXb25nICA8YWp3b25nQGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCkluZGV4OiBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA2MzEzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsNyArMTYwLDggQEAgc3RhdGlj IGNvbnN0IFBvcHVwQ29udGFpbmVyU2V0dGluZ3MgYXV0bwogICAgIGZhbHNlLCAgLy8gc2V0VGV4 dE9uSW5kZXhDaGFuZ2UKICAgICBmYWxzZSwgIC8vIGFjY2VwdE9uQWJhbmRvbgogICAgIHRydWUs ICAgLy8gbG9vcFNlbGVjdGlvbk5hdmlnYXRpb24KLSAgICB0cnVlLCAgIC8vIHJlc3RyaWN0V2lk dGhPZkxpc3RCb3guIFNhbWUgYXMgb3RoZXIgYnJvd3NlciAoRngsIElFLCBhbmQgc2FmYXJpKQor ICAgIGZhbHNlLCAgLy8gcmVzdHJpY3RXaWR0aE9mTGlzdEJveCAoZm9yIHNlY3VyaXR5IHJlYXNv bnMgc2hvdyB0aGUgZW50aXJlCisgICAgICAgICAgICAvLyBlbnRyeSBzbyB0aGUgdXNlciBkb2Vz bid0IGVudGVyIGluZm9ybWF0aW9uIGl0IGRpZCBub3QgaW50ZW5kIHRvKQogICAgIC8vIEZvciBz dWdnZXN0aW9ucywgd2UgdXNlIHRoZSBkaXJlY3Rpb24gb2YgdGhlIGlucHV0IGZpZWxkIGFzIHRo ZSBkaXJlY3Rpb24KICAgICAvLyBvZiB0aGUgcG9wdXAgaXRlbXMuIFRoZSBtYWluIHJlYXNvbiBp cyB0byBrZWVwIHRoZSBkaXNwbGF5IG9mIGl0ZW1zIGluCiAgICAgLy8gZHJvcC1kb3duIHRoZSBz YW1lIGFzIHRoZSBpdGVtcyBpbiB0aGUgaW5wdXQgZmllbGQuCg== 62463 2010-07-23 14:44:49 -0700 2010-07-28 08:19:39 -0700 Right patch this time popup_width.patch text/plain 1798 jcivelli SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDYzOTk1KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0yMyAgSmF5IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0Nocm9taXVtXSBUaGUgcG9wdXAgbm93IGxheW91dHMgcHJvcGVybHkgaXRzIHJvd3MgYnkK KyAgICAgICAgdGFraW5nIGludG8gYWNjb3VudCB0aGUgbGFiZWwgd2lkdGguCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjkxMAorCisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UG9wdXBMaXN0Qm94OjpsYXlvdXQpOgorCiAyMDEwLTA3LTIzICBmc2FtdWVsQGNocm9taXVt Lm9yZyAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlk IEh5YXR0LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1 bS5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVu dUNocm9taXVtLmNwcAkocmV2aXNpb24gNjM5ODgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9t aXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI0MywxMCArMTI0 MywxNiBAQCB2b2lkIFBvcHVwTGlzdEJveDo6bGF5b3V0KCkKIAogICAgICAgICAvLyBFbnN1cmUg dGhlIHBvcHVwIGlzIHdpZGUgZW5vdWdoIHRvIGZpdCB0aGlzIGl0ZW0uCiAgICAgICAgIFN0cmlu ZyB0ZXh0ID0gbV9wb3B1cENsaWVudC0+aXRlbVRleHQoaSk7Ci0gICAgICAgIGlmICghdGV4dC5p c0VtcHR5KCkpIHsKLSAgICAgICAgICAgIGludCB3aWR0aCA9IGl0ZW1Gb250LndpZHRoKFRleHRS dW4odGV4dCkpOwotICAgICAgICAgICAgYmFzZVdpZHRoID0gbWF4KGJhc2VXaWR0aCwgd2lkdGgp OworICAgICAgICBTdHJpbmcgbGFiZWwgPSBtX3BvcHVwQ2xpZW50LT5pdGVtTGFiZWwoaSk7Cisg ICAgICAgIGludCB3aWR0aCA9IDA7CisgICAgICAgIGlmICghdGV4dC5pc0VtcHR5KCkpCisgICAg ICAgICAgICB3aWR0aCA9IGl0ZW1Gb250LndpZHRoKFRleHRSdW4odGV4dCkpOworICAgICAgICBp ZiAoIWxhYmVsLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgaWYgKHdpZHRoID4gMCkKKyAgICAg ICAgICAgICAgICB3aWR0aCArPSBrVGV4dFRvTGFiZWxQYWRkaW5nOworICAgICAgICAgICAgd2lk dGggKz0gaXRlbUZvbnQud2lkdGgoVGV4dFJ1bihsYWJlbCkpOwogICAgICAgICB9CisgICAgICAg IGJhc2VXaWR0aCA9IG1heChiYXNlV2lkdGgsIHdpZHRoKTsKICAgICAgICAgLy8gRklYTUU6IGh0 dHA6Ly9iLzEyMTA0ODEgV2Ugc2hvdWxkIGdldCB0aGUgcGFkZGluZyBvZiBpbmRpdmlkdWFsIG9w dGlvbiBlbGVtZW50cy4KICAgICAgICAgcGFkZGluZ1dpZHRoID0gbWF4KHBhZGRpbmdXaWR0aCwK ICAgICAgICAgICAgIG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdMZWZ0KCkgKyBtX3BvcHVw Q2xpZW50LT5jbGllbnRQYWRkaW5nUmlnaHQoKSk7Cg==