42893 2010-07-23 06:26:24 -0700 Chromium DevTools: refactor query params, add basic support for WebSocket-based backend. 2010-07-26 01:29:42 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned commit-queue loislo yurys oldest_to_newest 255346 0 pfeldman 2010-07-23 06:26:24 -0700 subj. 255373 1 62426 loislo 2010-07-23 07:53:16 -0700 Created attachment 62426 [patch] initial version. 255938 2 62426 commit-queue 2010-07-26 01:29:37 -0700 Comment on attachment 62426 [patch] initial version. Clearing flags on attachment: 62426 Committed r64035: <http://trac.webkit.org/changeset/64035> 255939 3 commit-queue 2010-07-26 01:29:42 -0700 All reviewed patches have been landed. Closing bug. 62426 2010-07-23 07:53:16 -0700 2010-07-26 01:29:37 -0700 [patch] initial version. patch text/plain 5331 loislo ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYzYjMxYWUuLjcxYjJiMTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEwLTA3LTIzICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJv bWl1bSBEZXZUb29sczogcmVmYWN0b3IgcXVlcnkgcGFyYW1zLCBhZGQgYmFzaWMKKyAgICAgICAg c3VwcG9ydCBmb3IgV2ViU29ja2V0LWJhc2VkIGJhY2tlbmQuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyODkzCisKKyAgICAgICAgKiBzcmMvanMv RGV2VG9vbHMuanM6CisgICAgICAgIChkZXZ0b29scy5Ub29sc0FnZW50LnByb3RvdHlwZS5kaXNw YXRjaE9uQ2xpZW50Xyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5kb0xvYWRlZERvbmUpOgorICAgICAgICAoZGV2dG9vbHMuZG9tQ29udGVu dExvYWRlZCk6CisgICAgICAgICogc3JjL2pzL0luc3BlY3RvckNvbnRyb2xsZXJJbXBsLmpzOgor CiAyMDEwLTA3LTIzICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1n aXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpzIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9qcy9EZXZUb29scy5qcwppbmRleCAzNWNjYTJmLi41MzMwOWFkIDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpzCisrKyBiL1dlYktpdC9jaHJvbWl1bS9z cmMvanMvRGV2VG9vbHMuanMKQEAgLTkzLDcgKzkzLDcgQEAgZGV2dG9vbHMuVG9vbHNBZ2VudC5w cm90b3R5cGUuZ2V0UHJvZmlsZXJBZ2VudCA9IGZ1bmN0aW9uKCkKICAqLwogZGV2dG9vbHMuVG9v bHNBZ2VudC5wcm90b3R5cGUuZGlzcGF0Y2hPbkNsaWVudF8gPSBmdW5jdGlvbihtZXNzYWdlKQog ewotICAgIHZhciBhcmdzID0gSlNPTi5wYXJzZShtZXNzYWdlKTsKKyAgICB2YXIgYXJncyA9IHR5 cGVvZiBtZXNzYWdlID09PSAic3RyaW5nIiA/IEpTT04ucGFyc2UobWVzc2FnZSkgOiBtZXNzYWdl OwogICAgIHZhciBtZXRob2ROYW1lID0gYXJnc1swXTsKICAgICB2YXIgcGFyYW1ldGVycyA9IGFy Z3Muc2xpY2UoMSk7CiAgICAgV2ViSW5zcGVjdG9yW21ldGhvZE5hbWVdLmFwcGx5KFdlYkluc3Bl Y3RvciwgcGFyYW1ldGVycyk7CkBAIC0xMjksNiArMTI5LDI4IEBAIGRldnRvb2xzLnRvb2xzID0g bnVsbDsKIAogdmFyIGNvbnRleHQgPSB7fTsgIC8vIFVzZWQgYnkgV2ViQ29yZSdzIGluc3BlY3Rv ciByb3V0aW5lcy4KIAorKGZ1bmN0aW9uKCkgeworICAgIFdlYkluc3BlY3Rvci5fcGFyYW1zT2Jq ZWN0ID0ge307CisKKyAgICB2YXIgcXVlcnlQYXJhbXMgPSB3aW5kb3cubG9jYXRpb24uc2VhcmNo OworICAgIGlmIChxdWVyeVBhcmFtcykgeworICAgICAgICB2YXIgcGFyYW1zID0gcXVlcnlQYXJh bXMuc3Vic3RyaW5nKDEpLnNwbGl0KCImIik7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwg cGFyYW1zLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICB2YXIgcGFpciA9IHBhcmFtc1tpXS5z cGxpdCgiPSIpOworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLl9wYXJhbXNPYmplY3RbcGFpclsw XV0gPSBwYWlyWzFdOworICAgICAgICB9CisgICAgfQorICAgIGlmICgicGFnZSIgaW4gV2ViSW5z cGVjdG9yLl9wYXJhbXNPYmplY3QpIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnNvY2tldCA9IG5l dyBXZWJTb2NrZXQoIndzOi8vIiArIHdpbmRvdy5sb2NhdGlvbi5ob3N0ICsgIi9kZXZ0b29scy9w YWdlLyIgKyBXZWJJbnNwZWN0b3IuX3BhcmFtc09iamVjdC5wYWdlKTsKKyAgICAgICAgV2ViSW5z cGVjdG9yLnNvY2tldC5vbm1lc3NhZ2UgPSBmdW5jdGlvbihtZXNzYWdlKSB7IGV2YWwobWVzc2Fn ZS5kYXRhKTsgfQorICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0Lm9uZXJyb3IgPSBmdW5jdGlv bihlcnJvcikgeyBjb25zb2xlLmVycihlcnJvcik7IH0KKyAgICAgICAgV2ViSW5zcGVjdG9yLnNv Y2tldC5vbm9wZW4gPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5zb2Nr ZXRPcGVuZWQgPSB0cnVlOworICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5sb2FkZWREb25l KQorICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kb0xvYWRlZERvbmUoKTsKKyAgICAgICAg fTsKKyAgICB9Cit9KSgpOwogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogLy8gSGVyZSBhbmQgYmVs b3cgYXJlIG92ZXJyaWRlcyB0byBleGlzdGluZyBXZWJJbnNwZWN0b3IgbWV0aG9kcyBvbmx5Lgog Ly8gVE9ETyhwZmVsZG1hbik6IFBhdGNoIFdlYkNvcmUgYW5kIHVwc3RyZWFtIGNoYW5nZXMuCkBA IC0xNDUsMjUgKzE2NywyNSBAQCBXZWJJbnNwZWN0b3IubG9hZGVkID0gZnVuY3Rpb24oKQogICAg IFByZWZlcmVuY2VzLmNhbkVkaXRTY3JpcHRTb3VyY2UgPSB0cnVlOwogICAgIFByZWZlcmVuY2Vz LmFwcENhY2hlRW5hYmxlZCA9IGZhbHNlOwogCi0gICAgb2xkTG9hZGVkLmNhbGwodGhpcyk7Cisg ICAgaWYgKCJwYWdlIiBpbiBXZWJJbnNwZWN0b3IuX3BhcmFtc09iamVjdCkgeworICAgICAgICBX ZWJJbnNwZWN0b3IubG9hZGVkRG9uZSA9IHRydWU7CisgICAgICAgIGlmIChXZWJJbnNwZWN0b3Iu c29ja2V0T3BlbmVkKQorICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRvTG9hZGVkRG9uZSgpOwor ICAgICAgICByZXR1cm47CisgICAgfQorICAgIFdlYkluc3BlY3Rvci5kb0xvYWRlZERvbmUoKTsK K30KIAorV2ViSW5zcGVjdG9yLmRvTG9hZGVkRG9uZSA9IGZ1bmN0aW9uKCkgeworICAgIG9sZExv YWRlZC5jYWxsKHRoaXMpOwogICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5sb2FkZWQoKTsKLX07 Cit9CiAKIGRldnRvb2xzLmRvbUNvbnRlbnRMb2FkZWQgPSBmdW5jdGlvbigpCiB7Ci0gICAgdmFy IHF1ZXJ5UGFyYW1zID0gd2luZG93LmxvY2F0aW9uLnNlYXJjaDsKLSAgICBpZiAocXVlcnlQYXJh bXMpIHsKLSAgICAgICAgdmFyIHBhcmFtcyA9IHF1ZXJ5UGFyYW1zLnN1YnN0cmluZygxKS5zcGxp dCgiJiIpOwotICAgICAgICB2YXIgcGFyYW1zT2JqZWN0ID0ge307Ci0gICAgICAgIGZvciAodmFy IGkgPSAwOyBpIDwgcGFyYW1zLmxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICB2YXIgcGFpciA9 IHBhcmFtc1tpXS5zcGxpdCgiPSIpOwotICAgICAgICAgICAgcGFyYW1zT2JqZWN0W3BhaXJbMF1d ID0gcGFpclsxXTsKLSAgICAgICAgfQotICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0QXR0YWNoZWRX aW5kb3cocGFyYW1zT2JqZWN0LmRvY2tlZCA9PT0gInRydWUiKTsKLSAgICAgICAgaWYgKHBhcmFt c09iamVjdC50b29sYmFyX2NvbG9yICYmIHBhcmFtc09iamVjdC50ZXh0X2NvbG9yKQotICAgICAg ICAgICAgV2ViSW5zcGVjdG9yLnNldFRvb2xiYXJDb2xvcnMocGFyYW1zT2JqZWN0LnRvb2xiYXJf Y29sb3IsIHBhcmFtc09iamVjdC50ZXh0X2NvbG9yKTsKLSAgICB9CisgICAgV2ViSW5zcGVjdG9y LnNldEF0dGFjaGVkV2luZG93KFdlYkluc3BlY3Rvci5fcGFyYW1zT2JqZWN0LmRvY2tlZCA9PT0g InRydWUiKTsKKyAgICBpZiAoV2ViSW5zcGVjdG9yLl9wYXJhbXNPYmplY3QudG9vbGJhcl9jb2xv ciAmJiBXZWJJbnNwZWN0b3IuX3BhcmFtc09iamVjdC50ZXh0X2NvbG9yKQorICAgICAgICBXZWJJ bnNwZWN0b3Iuc2V0VG9vbGJhckNvbG9ycyhXZWJJbnNwZWN0b3IuX3BhcmFtc09iamVjdC50b29s YmFyX2NvbG9yLCBXZWJJbnNwZWN0b3IuX3BhcmFtc09iamVjdC50ZXh0X2NvbG9yKTsKIH0KIGRv Y3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIkRPTUNvbnRlbnRMb2FkZWQiLCBkZXZ0b29scy5kb21D b250ZW50TG9hZGVkLCBmYWxzZSk7CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMv anMvSW5zcGVjdG9yQ29udHJvbGxlckltcGwuanMgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0lu c3BlY3RvckNvbnRyb2xsZXJJbXBsLmpzCmluZGV4IGJlZDAwOWUuLmI1ZjY4NjAgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvSW5zcGVjdG9yQ29udHJvbGxlckltcGwuanMKKysr IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9JbnNwZWN0b3JDb250cm9sbGVySW1wbC5qcwpAQCAt MTQwLDExICsxNDAsMTUgQEAgZGV2dG9vbHMuSW5zcGVjdG9yQmFja2VuZEltcGwucHJvdG90eXBl Lmluc3RhbGxJbnNwZWN0b3JDb250cm9sbGVyRGVsZWdhdGVfID0gZnUKICAqIEJvdW5kIGZ1bmN0 aW9uIHdpdGggdGhlIGluc3RhbGxJbmplY3RlZFNjcmlwdERlbGVnYXRlXyBhY3R1YWwKICAqIGlt cGxlbWVudGF0aW9uLgogICovCi1kZXZ0b29scy5JbnNwZWN0b3JCYWNrZW5kSW1wbC5wcm90b3R5 cGUuY2FsbEluc3BlY3RvckNvbnRyb2xsZXJfID0gZnVuY3Rpb24obWV0aG9kTmFtZSwgdmFyX2Fy ZykKK2RldnRvb2xzLkluc3BlY3RvckJhY2tlbmRJbXBsLnByb3RvdHlwZS5jYWxsSW5zcGVjdG9y Q29udHJvbGxlcl8gPSBmdW5jdGlvbigpCiB7Ci0gICAgdmFyIGFyZ3MgPSBBcnJheS5wcm90b3R5 cGUuc2xpY2UuY2FsbChhcmd1bWVudHMsIDEpOwotICAgIGFyZ3MudW5zaGlmdChtZXRob2ROYW1l KTsKLSAgICBSZW1vdGVUb29sc0FnZW50LmRpc3BhdGNoT25JbnNwZWN0b3JDb250cm9sbGVyKFdl Ykluc3BlY3Rvci5DYWxsYmFjay53cmFwKGZ1bmN0aW9uKCl7fSksIEpTT04uc3RyaW5naWZ5KGFy Z3MpKTsKKyAgICB2YXIgYXJncyA9IEFycmF5LnByb3RvdHlwZS5zbGljZS5jYWxsKGFyZ3VtZW50 cyk7CisgICAgdmFyIG1lc3NhZ2UgPSBKU09OLnN0cmluZ2lmeShhcmdzKTsKKyAgICB2YXIgY2Fs bGJhY2tJZCA9IFdlYkluc3BlY3Rvci5DYWxsYmFjay53cmFwKGZ1bmN0aW9uKCl7fSk7CisgICAg aWYgKCJwYWdlIiBpbiBXZWJJbnNwZWN0b3IuX3BhcmFtc09iamVjdCkKKyAgICAgICAgV2ViSW5z cGVjdG9yLnNvY2tldC5zZW5kKGNhbGxiYWNrSWQgKyAiICIgKyBtZXNzYWdlKTsKKyAgICBlbHNl CisgICAgICAgIFJlbW90ZVRvb2xzQWdlbnQuZGlzcGF0Y2hPbkluc3BlY3RvckNvbnRyb2xsZXIo Y2FsbGJhY2tJZCwgbWVzc2FnZSk7CiB9OwogCiAK