<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>42881</bug_id>
          
          <creation_ts>2010-07-23 01:30:30 -0700</creation_ts>
          <short_desc>Add fast-reject path for InputStreamPreprocessor::peek</short_desc>
          <delta_ts>2010-07-23 11:27:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>41123</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>255257</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-07-23 01:30:30 -0700</bug_when>
    <thetext>Add fast-reject path for InputStreamPreprocessor::peek</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255258</commentid>
    <comment_count>1</comment_count>
      <attachid>62393</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-07-23 01:31:23 -0700</bug_when>
    <thetext>Created attachment 62393
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255329</commentid>
    <comment_count>2</comment_count>
      <attachid>62393</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-07-23 05:06:41 -0700</bug_when>
    <thetext>Comment on attachment 62393
Patch

Thank you for the comment!  Would be nice to see your perf results in the bug, but the % in the ChangeLog is sufficient.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255384</commentid>
    <comment_count>3</comment_count>
      <attachid>62393</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-23 08:18:27 -0700</bug_when>
    <thetext>Comment on attachment 62393
Patch

Rejecting patch 62393 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--ignore-tests&apos;, &apos;compositing&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default&apos;.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20713 test cases.
fast/js/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3.html -&gt; failed

Exiting early after 1 failures. 8599 tests run.
165.74s total testing time

8598 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
1 test case (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/3618060</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255446</commentid>
    <comment_count>4</comment_count>
      <attachid>62437</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-07-23 10:00:25 -0700</bug_when>
    <thetext>Created attachment 62437
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255473</commentid>
    <comment_count>5</comment_count>
      <attachid>62437</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-23 11:00:21 -0700</bug_when>
    <thetext>Comment on attachment 62437
Patch for landing

Rejecting patch 62437 from commit-queue.

Failed to run &quot;[u&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;, u&apos;--force&apos;]&quot; exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLTokenizer.h
Hunk #1 FAILED at 152.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLTokenizer.h.rej

Full output: http://queues.webkit.org/results/3558401</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255481</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-07-23 11:27:12 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/63987</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>62393</attachid>
            <date>2010-07-23 01:31:23 -0700</date>
            <delta_ts>2010-07-23 10:00:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-42881-20100723013122.patch</filename>
            <type>text/plain</type>
            <size>1762</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZjhhNjhlOTczZWZhMWRiZTA0M2Q2MjllOTRhZmNkODIxNmNmNDM3NC4uYTVmMDc5N2U1YzMzOTE4
MzIwYmNmZGM2ZGI4NDkzNDIzMWM2ZmRjZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOCBAQAogCiAgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEFkZCBmYXN0LXJlamVjdCBwYXRoIGZv
ciBJbnB1dFN0cmVhbVByZXByb2Nlc3Nvcjo6cGVlaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI4ODEKKworICAgICAgICBUaGlzIGlzIGFib3V0IGEg
Mi41JSBzcGVlZHVwIG9uIHRoZSBwYXJzaW5nIGJlbmNobWFyay4KKworICAgICAgICAqIGh0bWwv
SFRNTFRva2VuaXplci5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRva2VuaXplcjo6SW5wdXRT
dHJlYW1QcmVwcm9jZXNzb3I6OnBlZWspOgorCisyMDEwLTA3LTIzICBBZGFtIEJhcnRoICA8YWJh
cnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
ICAgICAgICAgSW5saW5lIEhUTUxUb2tlbml6ZXI6OklucHV0U3RyZWFtUHJlcHJvY2Vzc29yOjpw
ZWVrCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjg4
MAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRva2VuaXplci5oIGIvV2ViQ29yZS9o
dG1sL0hUTUxUb2tlbml6ZXIuaAppbmRleCA2Nzc4YWY0NTE1ZmMxNGE5YzM5MDI5YzA5Y2JiNzMy
YTY1YzRiZWE5Li40YmY1NzE0M2U2ZmJkNTM5ZDlhYjFmM2Q3OGJjMjM0YzZiMzVhMjc0IDEwMDY0
NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRva2VuaXplci5oCisrKyBiL1dlYkNvcmUvaHRtbC9I
VE1MVG9rZW5pemVyLmgKQEAgLTE1Miw2ICsxNTIsMTUgQEAgcHJpdmF0ZToKICAgICAgICAgQUxX
QVlTX0lOTElORSBib29sIHBlZWsoU2VnbWVudGVkU3RyaW5nJiBzb3VyY2UsIGludCYgbGluZU51
bWJlcikKICAgICAgICAgewogICAgICAgICAgICAgbV9uZXh0SW5wdXRDaGFyYWN0ZXIgPSAqc291
cmNlOworCisgICAgICAgICAgICAvLyBFdmVyeSBicmFuY2ggaW4gdGhpcyBmdW5jdGlvbiBpcyBl
eHBlbnNpdmUsIHNvIHdlIGhhdmUgYQorICAgICAgICAgICAgLy8gZmFzdC1yZWplY3QgYnJhbmNo
IGZvciBjaGFyYWN0ZXJzIHRoYXQgZG9uJ3QgcmVxdWlyZSBzcGVjaWFsCisgICAgICAgICAgICAv
LyBoYW5kbGluZy4gIFBsZWFzZSBydW4gdGhlIHBhcnNlciBiZW5jaG1hcmsgd2hlbmV2ZXIgeW91
IHRvdWNoCisgICAgICAgICAgICAvLyB0aGlzIGZ1bmN0aW9uLiAgSXQncyB2ZXJ5IGhvdC4KKyAg
ICAgICAgICAgIHN0YXRpYyBjb25zdCBVQ2hhciBzcGVjaWFsQ2hhcmFjdGVyTWFzayA9ICdcbicg
fCAnXHInIHwgJ1wwJzsKKyAgICAgICAgICAgIGlmIChtX25leHRJbnB1dENoYXJhY3RlciAmIH5z
cGVjaWFsQ2hhcmFjdGVyTWFzaykKKyAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAg
ICAgICAgICAgaWYgKG1fbmV4dElucHV0Q2hhcmFjdGVyID09ICdcbicgJiYgbV9za2lwTmV4dE5l
d0xpbmUpIHsKICAgICAgICAgICAgICAgICBtX3NraXBOZXh0TmV3TGluZSA9IGZhbHNlOwogICAg
ICAgICAgICAgICAgIHNvdXJjZS5hZHZhbmNlUGFzdE5ld2xpbmUobGluZU51bWJlcik7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>62437</attachid>
            <date>2010-07-23 10:00:25 -0700</date>
            <delta_ts>2010-07-23 11:00:21 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-42881-20100723100024.patch</filename>
            <type>text/plain</type>
            <size>1690</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2Mzk4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y
Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBBZGQgZmFz
dC1yZWplY3QgcGF0aCBmb3IgSW5wdXRTdHJlYW1QcmVwcm9jZXNzb3I6OnBlZWsKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyODgxCisKKyAgICAgICAg
VGhpcyBpcyBhYm91dCBhIDIuNSUgc3BlZWR1cCBvbiB0aGUgcGFyc2luZyBiZW5jaG1hcmsuCisK
KyAgICAgICAgKiBodG1sL0hUTUxUb2tlbml6ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxU
b2tlbml6ZXI6OklucHV0U3RyZWFtUHJlcHJvY2Vzc29yOjpwZWVrKToKKwogMjAxMC0wNy0yMyAg
SnVzdGluIFNjaHVoICA8anNjaHVoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk
LCByb2xsaW5nIG91dCByNjM5MjUuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFRva2VuaXplci5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmgJKHJldmlzaW9uIDYz
OTg0KQorKysgV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuaAkod29ya2luZyBjb3B5KQpAQCAt
MTUyLDYgKzE1MiwxNyBAQCBwcml2YXRlOgogICAgICAgICBBTFdBWVNfSU5MSU5FIGJvb2wgcGVl
ayhTZWdtZW50ZWRTdHJpbmcmIHNvdXJjZSwgaW50JiBsaW5lTnVtYmVyKQogICAgICAgICB7CiAg
ICAgICAgICAgICBtX25leHRJbnB1dENoYXJhY3RlciA9ICpzb3VyY2U7CisKKyAgICAgICAgICAg
IC8vIEV2ZXJ5IGJyYW5jaCBpbiB0aGlzIGZ1bmN0aW9uIGlzIGV4cGVuc2l2ZSwgc28gd2UgaGF2
ZSBhCisgICAgICAgICAgICAvLyBmYXN0LXJlamVjdCBicmFuY2ggZm9yIGNoYXJhY3RlcnMgdGhh
dCBkb24ndCByZXF1aXJlIHNwZWNpYWwKKyAgICAgICAgICAgIC8vIGhhbmRsaW5nLiAgUGxlYXNl
IHJ1biB0aGUgcGFyc2VyIGJlbmNobWFyayB3aGVuZXZlciB5b3UgdG91Y2gKKyAgICAgICAgICAg
IC8vIHRoaXMgZnVuY3Rpb24uICBJdCdzIHZlcnkgaG90LgorICAgICAgICAgICAgc3RhdGljIGNv
bnN0IFVDaGFyIHNwZWNpYWxDaGFyYWN0ZXJNYXNrID0gJ1xuJyB8ICdccicgfCAnXDAnOworICAg
ICAgICAgICAgaWYgKG1fbmV4dElucHV0Q2hhcmFjdGVyICYgfnNwZWNpYWxDaGFyYWN0ZXJNYXNr
KSB7CisgICAgICAgICAgICAgICAgbV9za2lwTmV4dE5ld0xpbmUgPSBmYWxzZTsKKyAgICAgICAg
ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgaWYgKG1f
bmV4dElucHV0Q2hhcmFjdGVyID09ICdcbicgJiYgbV9za2lwTmV4dE5ld0xpbmUpIHsKICAgICAg
ICAgICAgICAgICBtX3NraXBOZXh0TmV3TGluZSA9IGZhbHNlOwogICAgICAgICAgICAgICAgIHNv
dXJjZS5hZHZhbmNlUGFzdE5ld2xpbmUobGluZU51bWJlcik7Cg==
</data>
<flag name="commit-queue"
          id="50640"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>