42877 2010-07-23 00:37:52 -0700 Reserve capacity for attributes 2010-07-23 12:08:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 255237 0 abarth 2010-07-23 00:37:52 -0700 Reserve capacity for attributes 255238 1 62387 abarth 2010-07-23 00:39:01 -0700 Created attachment 62387 Patch 255239 2 abarth 2010-07-23 00:39:49 -0700 Laptop / battery caveat: == pre == Running 20 times Ignoring warm-up run (4825) 4251 4298 4262 4262 4282 4312 4346 4312 4304 4327 4325 4319 4342 4343 4337 4379 4352 4358 4376 4363 avg 4322.5 stdev 36.51232668565508 == post == Running 20 times Ignoring warm-up run (4734) 4185 4244 4196 4192 4210 4200 4240 4217 4254 4240 4260 4263 4259 4280 4265 4253 4321 4268 4288 4289 avg 4246.2 stdev 35.68697241291281 255325 3 62387 eric 2010-07-23 05:02:48 -0700 Comment on attachment 62387 Patch Would be ideal to put a comment next to that line explaining how you reached that number 10, and that it's a speedup. 255430 4 abarth 2010-07-23 09:38:49 -0700 I just copied it from the old code. :) 255454 5 62441 abarth 2010-07-23 10:12:10 -0700 Created attachment 62441 Patch for landing 255497 6 62441 commit-queue 2010-07-23 12:08:55 -0700 Comment on attachment 62441 Patch for landing Clearing flags on attachment: 62441 Committed r63991: <http://trac.webkit.org/changeset/63991> 255498 7 commit-queue 2010-07-23 12:08:59 -0700 All reviewed patches have been landed. Closing bug. 62387 2010-07-23 00:39:01 -0700 2010-07-23 10:11:58 -0700 Patch bug-42877-20100723003900.patch text/plain 1563 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzZhNjI2MGY4OGVhYjEyZDI1MDhhYTBkNGE2YmI1YzQ3N2IwMTJlNC4uYTJmNTdhMWU0MmM5ZWRm MzI5Mzc3YjQ2ZGJlMDMyYjAxOTRlZTAzYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOCBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFJlc2VydmUgY2FwYWNpdHkgZm9yIGF0 dHJpYnV0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQyODc3CisKKyAgICAgICAgVGhpcyBpcyBhYm91dCBhIDEuNyUgaW1wcm92ZW1lbnQgdG8gdGhl IHBhcnNpbmcgYmVuY2htYXJrLgorCisgICAgICAgICogaHRtbC9IVE1MVG9rZW4uaDoKKyAgICAg ICAgKFdlYkNvcmU6OkF0b21pY0hUTUxUb2tlbjo6QXRvbWljSFRNTFRva2VuKToKKworMjAxMC0w Ny0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIEF0b21pemUgc3RyaW5ncyB1c2VkIGJ5IHRo ZSBIVE1MNSB0cmVlIGJ1aWxkZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQyODc1CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW4u aCBiL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW4uaAppbmRleCBkMjk4N2Y0ODU2MTRlMmM4NDA4NjZh ZWE2YWI4YmE3OTc0ZWVlMDlmLi5lNmM1MjdlODBjODVmMmI5YjQ0NDEwYzc1M2MxOTU1NWMyMzc5 YjhlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRva2VuLmgKKysrIGIvV2ViQ29yZS9o dG1sL0hUTUxUb2tlbi5oCkBAIC0zMjgsOCArMzI4LDEwIEBAIHB1YmxpYzoKICAgICAgICAgICAg ICAgICAgICAgU3RyaW5nIG5hbWUoaXRlci0+bV9uYW1lLmRhdGEoKSwgaXRlci0+bV9uYW1lLnNp emUoKSk7CiAgICAgICAgICAgICAgICAgICAgIFN0cmluZyB2YWx1ZShpdGVyLT5tX3ZhbHVlLmRh dGEoKSwgaXRlci0+bV92YWx1ZS5zaXplKCkpOwogICAgICAgICAgICAgICAgICAgICBSZWZQdHI8 QXR0cmlidXRlPiBtYXBwZWRBdHRyaWJ1dGUgPSBBdHRyaWJ1dGU6OmNyZWF0ZU1hcHBlZChuYW1l LCB2YWx1ZSk7Ci0gICAgICAgICAgICAgICAgICAgIGlmICghbV9hdHRyaWJ1dGVzKQorICAgICAg ICAgICAgICAgICAgICBpZiAoIW1fYXR0cmlidXRlcykgewogICAgICAgICAgICAgICAgICAgICAg ICAgbV9hdHRyaWJ1dGVzID0gTmFtZWROb2RlTWFwOjpjcmVhdGUoKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgIG1fYXR0cmlidXRlcy0+cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eSgxMCk7CisgICAg ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgbV9hdHRyaWJ1dGVzLT5pbnNl cnRBdHRyaWJ1dGUobWFwcGVkQXR0cmlidXRlLnJlbGVhc2UoKSwgZmFsc2UpOwogICAgICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIH0K 62441 2010-07-23 10:12:10 -0700 2010-07-23 12:08:55 -0700 Patch for landing bug-42877-20100723101208.patch text/plain 1942 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Mzk4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBSZXNlcnZl IGNhcGFjaXR5IGZvciBhdHRyaWJ1dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00Mjg3NworCisgICAgICAgIFRoaXMgaXMgYWJvdXQgYSAxLjclIGlt cHJvdmVtZW50IHRvIHRoZSBwYXJzaW5nIGJlbmNobWFyay4KKworICAgICAgICAqIGh0bWwvSFRN TFRva2VuLmg6CisgICAgICAgIChXZWJDb3JlOjpBdG9taWNIVE1MVG9rZW46OkF0b21pY0hUTUxU b2tlbik6CisKIDIwMTAtMDctMjMgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjYzOTI1LgpJbmRleDogV2ViQ29y ZS9odG1sL0hUTUxUb2tlbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MVG9rZW4u aAkocmV2aXNpb24gNjM5ODQpCisrKyBXZWJDb3JlL2h0bWwvSFRNTFRva2VuLmgJKHdvcmtpbmcg Y29weSkKQEAgLTI5NCw3ICsyOTQsNyBAQCBwcml2YXRlOgogCiAgICAgLy8gRm9yIFN0YXJ0VGFn IGFuZCBFbmRUYWcKICAgICBib29sIG1fc2VsZkNsb3Npbmc7Ci0gICAgQXR0cmlidXRlTGlzdCBt X2F0dHJpYnV0ZXM7IC8vIE9sZCB0b2tlbml6ZXIgcmVzZXJ2ZXMgMTAuCisgICAgQXR0cmlidXRl TGlzdCBtX2F0dHJpYnV0ZXM7CiAKICAgICAvLyBBIHBvaW50ZXIgaW50byBtX2F0dHJpYnV0ZXMg dXNlZCBkdXJpbmcgbGV4aW5nLgogICAgIEF0dHJpYnV0ZSogbV9jdXJyZW50QXR0cmlidXRlOwpA QCAtMzI4LDggKzMyOCwxMyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgICAgIFN0cmluZyBu YW1lKGl0ZXItPm1fbmFtZS5kYXRhKCksIGl0ZXItPm1fbmFtZS5zaXplKCkpOwogICAgICAgICAg ICAgICAgICAgICBTdHJpbmcgdmFsdWUoaXRlci0+bV92YWx1ZS5kYXRhKCksIGl0ZXItPm1fdmFs dWUuc2l6ZSgpKTsKICAgICAgICAgICAgICAgICAgICAgUmVmUHRyPEF0dHJpYnV0ZT4gbWFwcGVk QXR0cmlidXRlID0gQXR0cmlidXRlOjpjcmVhdGVNYXBwZWQobmFtZSwgdmFsdWUpOwotICAgICAg ICAgICAgICAgICAgICBpZiAoIW1fYXR0cmlidXRlcykKKyAgICAgICAgICAgICAgICAgICAgaWYg KCFtX2F0dHJpYnV0ZXMpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIG1fYXR0cmlidXRlcyA9 IE5hbWVkTm9kZU1hcDo6Y3JlYXRlKCk7CisgICAgICAgICAgICAgICAgICAgICAgICAvLyBSZXNl cnZpbmcgY2FwYWNpdHkgaGVyZSBpbXByb3ZlcyB0aGUgcGFyc2VyCisgICAgICAgICAgICAgICAg ICAgICAgICAvLyBiZW5jaG1hcmsuICBJdCBtaWdodCBiZSB3b3J0aCBleHBlcmltZW50aW5nIHdp dGgKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIHRoZSBjb25zdGFudCB0byBzZWUgd2hlcmUg dGhlIG9wdGltYWwgcG9pbnQgaXMuCisgICAgICAgICAgICAgICAgICAgICAgICBtX2F0dHJpYnV0 ZXMtPnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoMTApOworICAgICAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICAgICAgICAgIG1fYXR0cmlidXRlcy0+aW5zZXJ0QXR0cmlidXRlKG1hcHBlZEF0 dHJpYnV0ZS5yZWxlYXNlKCksIGZhbHNlKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAg ICB9Cg==