<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>42855</bug_id>
          
          <creation_ts>2010-07-22 16:14:24 -0700</creation_ts>
          <short_desc>Support emit_op_mod() for MIPS</short_desc>
          <delta_ts>2010-08-31 12:45:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chao-ying Fu">fu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>commit-queue</cc>
    
    <cc>kent.hansen</cc>
    
    <cc>zherczeg</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>255041</commentid>
    <comment_count>0</comment_count>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2010-07-22 16:14:24 -0700</bug_when>
    <thetext>Hi,

  I will post a patch to support emit_op_mod() for MIPS.  This helps SunSpider by 0.2% on MIPS.  Thanks!

Regards,
Chao-ying</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255052</commentid>
    <comment_count>1</comment_count>
      <attachid>62358</attachid>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2010-07-22 16:24:49 -0700</bug_when>
    <thetext>Created attachment 62358
Use div for MIPS op_mod

The patch replaces X86Registers::eax/ecx/edx with regT0/regT2/regT1, so that MIPS can reuse source code to implement op_mod.  The MIPS build was ok, while I didn&apos;t test x86 build.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255521</commentid>
    <comment_count>2</comment_count>
    <who name="Kent Hansen">kent.hansen</who>
    <bug_when>2010-07-23 12:55:19 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=62358) [details]
&gt; Use div for MIPS op_mod
&gt; 
&gt; The patch replaces X86Registers::eax/ecx/edx with regT0/regT2/regT1, so that MIPS can reuse source code to implement op_mod.  The MIPS build was ok, while I didn&apos;t test x86 build.  Thanks!

For X86 I&apos;d ASSERT(regT0 == eax), etc., since the registers are implicit in the div instruction. It&apos;s important that this information is preserved, e.g. in case someone decides to change regT0 to r13 on x64. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255551</commentid>
    <comment_count>3</comment_count>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2010-07-23 14:20:35 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; Created an attachment (id=62358) [details] [details]
&gt; &gt; Use div for MIPS op_mod
&gt; &gt; 
&gt; &gt; The patch replaces X86Registers::eax/ecx/edx with regT0/regT2/regT1, so that MIPS can reuse source code to implement op_mod.  The MIPS build was ok, while I didn&apos;t test x86 build.  Thanks!
&gt; 
&gt; For X86 I&apos;d ASSERT(regT0 == eax), etc., since the registers are implicit in the div instruction. It&apos;s important that this information is preserved, e.g. in case someone decides to change regT0 to r13 on x64. :)

Yes.  You are right.  I will update the patch to have ASSERT() for X86 and X86_64.  Thanks!

Regards,
Chao-ying</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255591</commentid>
    <comment_count>4</comment_count>
      <attachid>62470</attachid>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2010-07-23 16:09:57 -0700</bug_when>
    <thetext>Created attachment 62470
Assert x86 registers

Add ASSERT() to check x86 registers for x86 IDIV instructions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>255941</commentid>
    <comment_count>5</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2010-07-26 01:33:30 -0700</bug_when>
    <thetext>I think this is a nice cleanup. Although the whole code should be moved to their respective MacroAssembler header files, and refactor this code to be platform independent (This happened with other math functions as well, like the floating point division).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270213</commentid>
    <comment_count>6</comment_count>
      <attachid>62470</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-08-26 16:53:05 -0700</bug_when>
    <thetext>Comment on attachment 62470
Assert x86 registers

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270411</commentid>
    <comment_count>7</comment_count>
      <attachid>62470</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-27 04:12:28 -0700</bug_when>
    <thetext>Comment on attachment 62470
Assert x86 registers

Rejecting patch 62470 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--wait-for-httpd&apos;, &apos;--ignore-tests&apos;, &apos;compositing,media&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Last 500 characters of output:
mpiling Java tests
make: Nothing to be done for `default&apos;.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained &apos;media/video-source-error.html	&apos;, but no file of that name could be found
Testing 20843 test cases.
http/tests/security/xssAuditor/object-embed-tag.html -&gt; failed

Exiting early after 1 failures. 20546 tests run.
530.92s total testing time

20545 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
28 test cases (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/3835017</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272244</commentid>
    <comment_count>8</comment_count>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2010-08-31 11:50:26 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 62470 [details])
&gt; Rejecting patch 62470 from commit-queue.
&gt; 
&gt; Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--wait-for-httpd&apos;, &apos;--ignore-tests&apos;, &apos;compositing,media&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
&gt; Last 500 characters of output:
&gt; mpiling Java tests
&gt; make: Nothing to be done for `default&apos;.
&gt; Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
&gt; Skipped list contained &apos;media/video-source-error.html    &apos;, but no file of that name could be found
&gt; Testing 20843 test cases.
&gt; http/tests/security/xssAuditor/object-embed-tag.html -&gt; failed
&gt; 
&gt; Exiting early after 1 failures. 20546 tests run.
&gt; 530.92s total testing time
&gt; 
&gt; 20545 test cases (99%) succeeded
&gt; 1 test case (&lt;1%) had incorrect layout
&gt; 28 test cases (&lt;1%) had stderr output
&gt; 
&gt; Full output: http://queues.webkit.org/results/3835017

Hi,

  Does anyone know why the test failed after applying the patch?  Thanks!

Regards,
Chao-ying</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272275</commentid>
    <comment_count>9</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2010-08-31 12:27:29 -0700</bug_when>
    <thetext>Hey Chao-ying,

This test was failing intermittently at the end of last week, I can land this patch for you.

cheers,
G.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272287</commentid>
    <comment_count>10</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2010-08-31 12:45:49 -0700</bug_when>
    <thetext>fixed in r66524</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>62358</attachid>
            <date>2010-07-22 16:24:49 -0700</date>
            <delta_ts>2010-07-23 16:09:57 -0700</delta_ts>
            <desc>Use div for MIPS op_mod</desc>
            <filename>mips-op-mod.diff</filename>
            <type>text/plain</type>
            <size>4245</size>
            <attacher name="Chao-ying Fu">fu</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzOTE4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMjIgIENoYW8teWlu
ZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFN1cHBvcnQgZW1pdF9vcF9tb2QoKSBmb3IgTUlQUworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI4NTUKKworICAgICAgICBUaGlz
IHBhdGNoIHVzZXMgTUlQUyBkaXYgaW5zdHJ1Y3Rpb25zIGZvciBvcF9tb2QgdG8gaW1wcm92ZSBw
ZXJmb3JtYW5jZS4KKworICAgICAgICAqIGFzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmg6CisgICAg
ICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OmRpdik6CisgICAgICAgICogaml0L0pJVEFyaXRobWV0
aWMuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfbW9kKToKKyAgICAgICAgKEpTQzo6
SklUOjplbWl0U2xvd19vcF9tb2QpOgorCiAyMDEwLTA3LTIyICBLZW50IEhhbnNlbiAgPGtlbnQu
aGFuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KSW5k
ZXg6IEphdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAkocmV2aXNpb24gNjM4
NDcpCisrKyBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCSh3b3JraW5n
IGNvcHkpCkBAIC0yODcsNiArMjg3LDExIEBAIHB1YmxpYzoKICAgICAgICAgZW1pdEluc3QoMHgw
MDAwMDAxOCB8IChycyA8PCBPUF9TSF9SUykgfCAocnQgPDwgT1BfU0hfUlQpKTsKICAgICB9CiAK
KyAgICB2b2lkIGRpdihSZWdpc3RlcklEIHJzLCBSZWdpc3RlcklEIHJ0KQorICAgIHsKKyAgICAg
ICAgZW1pdEluc3QoMHgwMDAwMDAxYSB8IChycyA8PCBPUF9TSF9SUykgfCAocnQgPDwgT1BfU0hf
UlQpKTsKKyAgICB9CisKICAgICB2b2lkIG1maGkoUmVnaXN0ZXJJRCByZCkKICAgICB7CiAgICAg
ICAgIGVtaXRJbnN0KDB4MDAwMDAwMTAgfCAocmQgPDwgT1BfU0hfUkQpKTsKSW5kZXg6IEphdmFT
Y3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAJKHJldmlzaW9uIDYzODQ3KQorKysgSmF2YVNjcmlw
dENvcmUvaml0L0pJVEFyaXRobWV0aWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTM5LDcgKzEx
MzksNyBAQCB2b2lkIEpJVDo6ZW1pdFNsb3dfb3BfcHJlX2RlYyhJbnN0cnVjdGlvCiAKIC8qIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSBCRUdJTjogT1BfTU9EIC0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLSAqLwogCi0jaWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKKyNpZiBD
UFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoTUlQUykKIAogdm9pZCBKSVQ6OmVtaXRfb3Bf
bW9kKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCiB7CkBAIC0xMTQ3LDIxICsxMTQ3
LDI3IEBAIHZvaWQgSklUOjplbWl0X29wX21vZChJbnN0cnVjdGlvbiogY3VycmUKICAgICB1bnNp
Z25lZCBvcDEgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kOwogICAgIHVuc2lnbmVk
IG9wMiA9IGN1cnJlbnRJbnN0cnVjdGlvblszXS51Lm9wZXJhbmQ7CiAKLSAgICBlbWl0R2V0Vmly
dHVhbFJlZ2lzdGVycyhvcDEsIFg4NlJlZ2lzdGVyczo6ZWF4LCBvcDIsIFg4NlJlZ2lzdGVyczo6
ZWN4KTsKLSAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1lZGlhdGVJbnRlZ2VyKFg4NlJlZ2lz
dGVyczo6ZWF4KTsKLSAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1lZGlhdGVJbnRlZ2VyKFg4
NlJlZ2lzdGVyczo6ZWN4KTsKKyAgICBlbWl0R2V0VmlydHVhbFJlZ2lzdGVycyhvcDEsIHJlZ1Qw
LCBvcDIsIHJlZ1QyKTsKKyAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1lZGlhdGVJbnRlZ2Vy
KHJlZ1QwKTsKKyAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1lZGlhdGVJbnRlZ2VyKHJlZ1Qy
KTsKKwogI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgYWRkU2xvd0Nhc2UoYnJhbmNoUHRyKEVxdWFs
LCBYODZSZWdpc3RlcnM6OmVjeCwgSW1tUHRyKEpTVmFsdWU6OmVuY29kZShqc051bWJlcihtX2ds
b2JhbERhdGEsIDApKSkpKTsKKyAgICBhZGRTbG93Q2FzZShicmFuY2hQdHIoRXF1YWwsIHJlZ1Qy
LCBJbW1QdHIoSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKG1fZ2xvYmFsRGF0YSwgMCkpKSkpOwog
ICAgIG1fYXNzZW1ibGVyLmNkcSgpOwotICAgIG1fYXNzZW1ibGVyLmlkaXZsX3IoWDg2UmVnaXN0
ZXJzOjplY3gpOworICAgIG1fYXNzZW1ibGVyLmlkaXZsX3IocmVnVDIpOwogI2Vsc2UKLSAgICBl
bWl0RmFzdEFyaXRoRGVUYWdJbW1lZGlhdGUoWDg2UmVnaXN0ZXJzOjplYXgpOwotICAgIGFkZFNs
b3dDYXNlKGVtaXRGYXN0QXJpdGhEZVRhZ0ltbWVkaWF0ZUp1bXBJZlplcm8oWDg2UmVnaXN0ZXJz
OjplY3gpKTsKKyAgICBlbWl0RmFzdEFyaXRoRGVUYWdJbW1lZGlhdGUocmVnVDApOworICAgIGFk
ZFNsb3dDYXNlKGVtaXRGYXN0QXJpdGhEZVRhZ0ltbWVkaWF0ZUp1bXBJZlplcm8ocmVnVDIpKTsK
KyNpZiBDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KQogICAgIG1fYXNzZW1ibGVyLmNkcSgpOwotICAg
IG1fYXNzZW1ibGVyLmlkaXZsX3IoWDg2UmVnaXN0ZXJzOjplY3gpOwotICAgIHNpZ25FeHRlbmQz
MlRvUHRyKFg4NlJlZ2lzdGVyczo6ZWR4LCBYODZSZWdpc3RlcnM6OmVkeCk7CisgICAgbV9hc3Nl
bWJsZXIuaWRpdmxfcihyZWdUMik7CisgICAgc2lnbkV4dGVuZDMyVG9QdHIocmVnVDEsIHJlZ1Qx
KTsKKyNlbGlmIENQVShNSVBTKQorICAgIG1fYXNzZW1ibGVyLmRpdihyZWdUMCwgcmVnVDIpOwor
ICAgIG1fYXNzZW1ibGVyLm1maGkocmVnVDEpOwogI2VuZGlmCi0gICAgZW1pdEZhc3RBcml0aFJl
VGFnSW1tZWRpYXRlKFg4NlJlZ2lzdGVyczo6ZWR4LCBYODZSZWdpc3RlcnM6OmVheCk7CisjZW5k
aWYKKyAgICBlbWl0RmFzdEFyaXRoUmVUYWdJbW1lZGlhdGUocmVnVDEsIHJlZ1QwKTsKICAgICBl
bWl0UHV0VmlydHVhbFJlZ2lzdGVyKHJlc3VsdCk7CiB9CiAKQEAgLTExNzcsMTggKzExODMsMTgg
QEAgdm9pZCBKSVQ6OmVtaXRTbG93X29wX21vZChJbnN0cnVjdGlvbiogYwogICAgIEp1bXAgbm90
SW1tMSA9IGdldFNsb3dDYXNlKGl0ZXIpOwogICAgIEp1bXAgbm90SW1tMiA9IGdldFNsb3dDYXNl
KGl0ZXIpOwogICAgIGxpbmtTbG93Q2FzZShpdGVyKTsKLSAgICBlbWl0RmFzdEFyaXRoUmVUYWdJ
bW1lZGlhdGUoWDg2UmVnaXN0ZXJzOjplYXgsIFg4NlJlZ2lzdGVyczo6ZWF4KTsKLSAgICBlbWl0
RmFzdEFyaXRoUmVUYWdJbW1lZGlhdGUoWDg2UmVnaXN0ZXJzOjplY3gsIFg4NlJlZ2lzdGVyczo6
ZWN4KTsKKyAgICBlbWl0RmFzdEFyaXRoUmVUYWdJbW1lZGlhdGUocmVnVDAsIHJlZ1QwKTsKKyAg
ICBlbWl0RmFzdEFyaXRoUmVUYWdJbW1lZGlhdGUocmVnVDIsIHJlZ1QyKTsKICAgICBub3RJbW0x
LmxpbmsodGhpcyk7CiAgICAgbm90SW1tMi5saW5rKHRoaXMpOwogI2VuZGlmCiAgICAgSklUU3R1
YkNhbGwgc3R1YkNhbGwodGhpcywgY3RpX29wX21vZCk7Ci0gICAgc3R1YkNhbGwuYWRkQXJndW1l
bnQoWDg2UmVnaXN0ZXJzOjplYXgpOwotICAgIHN0dWJDYWxsLmFkZEFyZ3VtZW50KFg4NlJlZ2lz
dGVyczo6ZWN4KTsKKyAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChyZWdUMCk7CisgICAgc3R1YkNh
bGwuYWRkQXJndW1lbnQocmVnVDIpOwogICAgIHN0dWJDYWxsLmNhbGwocmVzdWx0KTsKIH0KIAot
I2Vsc2UgLy8gQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKKyNlbHNlIC8vIENQVShYODYpIHx8IENQ
VShYODZfNjQpIHx8IENQVShNSVBTKQogCiB2b2lkIEpJVDo6ZW1pdF9vcF9tb2QoSW5zdHJ1Y3Rp
b24qIGN1cnJlbnRJbnN0cnVjdGlvbikKIHsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>62470</attachid>
            <date>2010-07-23 16:09:57 -0700</date>
            <delta_ts>2010-08-27 04:12:28 -0700</delta_ts>
            <desc>Assert x86 registers</desc>
            <filename>mips-op-mod20100723.diff</filename>
            <type>text/plain</type>
            <size>4474</size>
            <attacher name="Chao-ying Fu">fu</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzOTIyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMjIgIENoYW8teWlu
ZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFN1cHBvcnQgZW1pdF9vcF9tb2QoKSBmb3IgTUlQUworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI4NTUKKworICAgICAgICBUaGlz
IHBhdGNoIHVzZXMgTUlQUyBkaXYgaW5zdHJ1Y3Rpb25zIGZvciBvcF9tb2QgdG8gaW1wcm92ZSBw
ZXJmb3JtYW5jZS4KKworICAgICAgICAqIGFzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmg6CisgICAg
ICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OmRpdik6CisgICAgICAgICogaml0L0pJVEFyaXRobWV0
aWMuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfbW9kKToKKyAgICAgICAgKEpTQzo6
SklUOjplbWl0U2xvd19vcF9tb2QpOgorCiAyMDEwLTA3LTIyICBLZW50IEhhbnNlbiAgPGtlbnQu
aGFuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KSW5k
ZXg6IEphdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAkocmV2aXNpb24gNjM5
MjIpCisrKyBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCSh3b3JraW5n
IGNvcHkpCkBAIC0yODcsNiArMjg3LDExIEBAIHB1YmxpYzoKICAgICAgICAgZW1pdEluc3QoMHgw
MDAwMDAxOCB8IChycyA8PCBPUF9TSF9SUykgfCAocnQgPDwgT1BfU0hfUlQpKTsKICAgICB9CiAK
KyAgICB2b2lkIGRpdihSZWdpc3RlcklEIHJzLCBSZWdpc3RlcklEIHJ0KQorICAgIHsKKyAgICAg
ICAgZW1pdEluc3QoMHgwMDAwMDAxYSB8IChycyA8PCBPUF9TSF9SUykgfCAocnQgPDwgT1BfU0hf
UlQpKTsKKyAgICB9CisKICAgICB2b2lkIG1maGkoUmVnaXN0ZXJJRCByZCkKICAgICB7CiAgICAg
ICAgIGVtaXRJbnN0KDB4MDAwMDAwMTAgfCAocmQgPDwgT1BfU0hfUkQpKTsKSW5kZXg6IEphdmFT
Y3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAJKHJldmlzaW9uIDYzOTIyKQorKysgSmF2YVNjcmlw
dENvcmUvaml0L0pJVEFyaXRobWV0aWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTM5LDcgKzEx
MzksNyBAQCB2b2lkIEpJVDo6ZW1pdFNsb3dfb3BfcHJlX2RlYyhJbnN0cnVjdGlvCiAKIC8qIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSBCRUdJTjogT1BfTU9EIC0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLSAqLwogCi0jaWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKKyNpZiBD
UFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoTUlQUykKIAogdm9pZCBKSVQ6OmVtaXRfb3Bf
bW9kKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCiB7CkBAIC0xMTQ3LDIxICsxMTQ3
LDM0IEBAIHZvaWQgSklUOjplbWl0X29wX21vZChJbnN0cnVjdGlvbiogY3VycmUKICAgICB1bnNp
Z25lZCBvcDEgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kOwogICAgIHVuc2lnbmVk
IG9wMiA9IGN1cnJlbnRJbnN0cnVjdGlvblszXS51Lm9wZXJhbmQ7CiAKLSAgICBlbWl0R2V0Vmly
dHVhbFJlZ2lzdGVycyhvcDEsIFg4NlJlZ2lzdGVyczo6ZWF4LCBvcDIsIFg4NlJlZ2lzdGVyczo6
ZWN4KTsKLSAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1lZGlhdGVJbnRlZ2VyKFg4NlJlZ2lz
dGVyczo6ZWF4KTsKLSAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1lZGlhdGVJbnRlZ2VyKFg4
NlJlZ2lzdGVyczo6ZWN4KTsKKyNpZiBDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KQorICAgIC8vIE1h
a2Ugc3VyZSByZWdpc3RlcnMgYXJlIGNvcnJlY3QgZm9yIHg4NiBJRElWIGluc3RydWN0aW9ucy4K
KyAgICBBU1NFUlQocmVnVDAgPT0gWDg2UmVnaXN0ZXJzOjplYXgpOworICAgIEFTU0VSVChyZWdU
MSA9PSBYODZSZWdpc3RlcnM6OmVkeCk7CisgICAgQVNTRVJUKHJlZ1QyID09IFg4NlJlZ2lzdGVy
czo6ZWN4KTsKKyNlbmRpZgorCisgICAgZW1pdEdldFZpcnR1YWxSZWdpc3RlcnMob3AxLCByZWdU
MCwgb3AyLCByZWdUMik7CisgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SW1tZWRpYXRlSW50ZWdl
cihyZWdUMCk7CisgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SW1tZWRpYXRlSW50ZWdlcihyZWdU
Mik7CisKICNpZiBVU0UoSlNWQUxVRTY0KQotICAgIGFkZFNsb3dDYXNlKGJyYW5jaFB0cihFcXVh
bCwgWDg2UmVnaXN0ZXJzOjplY3gsIEltbVB0cihKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIobV9n
bG9iYWxEYXRhLCAwKSkpKSk7CisgICAgYWRkU2xvd0Nhc2UoYnJhbmNoUHRyKEVxdWFsLCByZWdU
MiwgSW1tUHRyKEpTVmFsdWU6OmVuY29kZShqc051bWJlcihtX2dsb2JhbERhdGEsIDApKSkpKTsK
ICAgICBtX2Fzc2VtYmxlci5jZHEoKTsKLSAgICBtX2Fzc2VtYmxlci5pZGl2bF9yKFg4NlJlZ2lz
dGVyczo6ZWN4KTsKKyAgICBtX2Fzc2VtYmxlci5pZGl2bF9yKHJlZ1QyKTsKICNlbHNlCi0gICAg
ZW1pdEZhc3RBcml0aERlVGFnSW1tZWRpYXRlKFg4NlJlZ2lzdGVyczo6ZWF4KTsKLSAgICBhZGRT
bG93Q2FzZShlbWl0RmFzdEFyaXRoRGVUYWdJbW1lZGlhdGVKdW1wSWZaZXJvKFg4NlJlZ2lzdGVy
czo6ZWN4KSk7CisgICAgZW1pdEZhc3RBcml0aERlVGFnSW1tZWRpYXRlKHJlZ1QwKTsKKyAgICBh
ZGRTbG93Q2FzZShlbWl0RmFzdEFyaXRoRGVUYWdJbW1lZGlhdGVKdW1wSWZaZXJvKHJlZ1QyKSk7
CisjaWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKICAgICBtX2Fzc2VtYmxlci5jZHEoKTsKLSAg
ICBtX2Fzc2VtYmxlci5pZGl2bF9yKFg4NlJlZ2lzdGVyczo6ZWN4KTsKLSAgICBzaWduRXh0ZW5k
MzJUb1B0cihYODZSZWdpc3RlcnM6OmVkeCwgWDg2UmVnaXN0ZXJzOjplZHgpOworICAgIG1fYXNz
ZW1ibGVyLmlkaXZsX3IocmVnVDIpOworICAgIHNpZ25FeHRlbmQzMlRvUHRyKHJlZ1QxLCByZWdU
MSk7CisjZWxpZiBDUFUoTUlQUykKKyAgICBtX2Fzc2VtYmxlci5kaXYocmVnVDAsIHJlZ1QyKTsK
KyAgICBtX2Fzc2VtYmxlci5tZmhpKHJlZ1QxKTsKICNlbmRpZgotICAgIGVtaXRGYXN0QXJpdGhS
ZVRhZ0ltbWVkaWF0ZShYODZSZWdpc3RlcnM6OmVkeCwgWDg2UmVnaXN0ZXJzOjplYXgpOworI2Vu
ZGlmCisgICAgZW1pdEZhc3RBcml0aFJlVGFnSW1tZWRpYXRlKHJlZ1QxLCByZWdUMCk7CiAgICAg
ZW1pdFB1dFZpcnR1YWxSZWdpc3RlcihyZXN1bHQpOwogfQogCkBAIC0xMTc3LDE4ICsxMTkwLDE4
IEBAIHZvaWQgSklUOjplbWl0U2xvd19vcF9tb2QoSW5zdHJ1Y3Rpb24qIGMKICAgICBKdW1wIG5v
dEltbTEgPSBnZXRTbG93Q2FzZShpdGVyKTsKICAgICBKdW1wIG5vdEltbTIgPSBnZXRTbG93Q2Fz
ZShpdGVyKTsKICAgICBsaW5rU2xvd0Nhc2UoaXRlcik7Ci0gICAgZW1pdEZhc3RBcml0aFJlVGFn
SW1tZWRpYXRlKFg4NlJlZ2lzdGVyczo6ZWF4LCBYODZSZWdpc3RlcnM6OmVheCk7Ci0gICAgZW1p
dEZhc3RBcml0aFJlVGFnSW1tZWRpYXRlKFg4NlJlZ2lzdGVyczo6ZWN4LCBYODZSZWdpc3RlcnM6
OmVjeCk7CisgICAgZW1pdEZhc3RBcml0aFJlVGFnSW1tZWRpYXRlKHJlZ1QwLCByZWdUMCk7Cisg
ICAgZW1pdEZhc3RBcml0aFJlVGFnSW1tZWRpYXRlKHJlZ1QyLCByZWdUMik7CiAgICAgbm90SW1t
MS5saW5rKHRoaXMpOwogICAgIG5vdEltbTIubGluayh0aGlzKTsKICNlbmRpZgogICAgIEpJVFN0
dWJDYWxsIHN0dWJDYWxsKHRoaXMsIGN0aV9vcF9tb2QpOwotICAgIHN0dWJDYWxsLmFkZEFyZ3Vt
ZW50KFg4NlJlZ2lzdGVyczo6ZWF4KTsKLSAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChYODZSZWdp
c3RlcnM6OmVjeCk7CisgICAgc3R1YkNhbGwuYWRkQXJndW1lbnQocmVnVDApOworICAgIHN0dWJD
YWxsLmFkZEFyZ3VtZW50KHJlZ1QyKTsKICAgICBzdHViQ2FsbC5jYWxsKHJlc3VsdCk7CiB9CiAK
LSNlbHNlIC8vIENQVShYODYpIHx8IENQVShYODZfNjQpCisjZWxzZSAvLyBDUFUoWDg2KSB8fCBD
UFUoWDg2XzY0KSB8fCBDUFUoTUlQUykKIAogdm9pZCBKSVQ6OmVtaXRfb3BfbW9kKEluc3RydWN0
aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCiB7Cg==
</data>
<flag name="review"
          id="50682"
          type_id="1"
          status="+"
          setter="oliver"
    />
    <flag name="commit-queue"
          id="50683"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>