42831 2010-07-22 09:16:49 -0700 Web Inspector: test that inspector will log syntax error in console without crashing 2010-07-22 23:40:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 42642 1 yurys yurys bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 254837 0 yurys 2010-07-22 09:16:49 -0700 Web Inspector: test that inspector will log syntax error in console without crashing 254839 1 62306 yurys 2010-07-22 09:18:26 -0700 Created attachment 62306 Patch 254896 2 joepeck 2010-07-22 11:16:14 -0700 Cool. Are Syntax Error messages likely to be the same between JSC and V8 or could there be platform specific results? 254921 3 62306 ojan 2010-07-22 12:23:14 -0700 Comment on attachment 62306 Patch > +resources/syntax-error.js:1SyntaxError: Parse error The lack of space between "1" and "SyntaxError" looks strange. Is that a bug (obviously not from this patch though)? 255080 4 62306 commit-queue 2010-07-22 17:06:05 -0700 Comment on attachment 62306 Patch Clearing flags on attachment: 62306 Committed r63922: <http://trac.webkit.org/changeset/63922> 255081 5 commit-queue 2010-07-22 17:06:10 -0700 All reviewed patches have been landed. Closing bug. 255218 6 yurys 2010-07-22 23:40:40 -0700 (In reply to comment #2) > Cool. Are Syntax Error messages likely to be the same between JSC and V8 > or could there be platform specific results? In this patch I'm providing VM-specific results. There is a long discussion of the error message differences between JSC and V8 and it was agreed that they should eventually converge. There is a bug for that problem: https://bugs.webkit.org/show_bug.cgi?id=42181 (In reply to comment #3) > (From update of attachment 62306 [details]) > > +resources/syntax-error.js:1SyntaxError: Parse error > > The lack of space between "1" and "SyntaxError" looks strange. Is that a bug (obviously not from this patch though)? It's just a textContent of a DOM element representing the message in Web Inspector UI. Although there is no space in the text dump, there is one in the DOM UI and the message there looks nice. I don't thing we need to fix the text output since it's used only in the tests and it already gives a clear view of the logged message text. 62306 2010-07-22 09:18:26 -0700 2010-07-22 17:06:05 -0700 Patch bug-42831-20100722201824.patch text/plain 3009 yurys ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0M2NhYjFkNWQ0MmE4YjgyMGE2NTRjNDJiN2M2ZjU2NWE1ODNiMmVmLi4zODZjYzg3 MjcyZjNhMGZjNjIxMGQzYmE4MWZkMzBiMzJhMTZkNDNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDctMjIgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogdGVzdCB0aGF0IGluc3BlY3RvciB3aWxsIGxvZyBzeW50YXggZXJyb3IgaW4gY29uc29sZSB3 aXRob3V0IGNyYXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MjgzMQorCisgICAgICAgICogaW5zcGVjdG9yL2NvbnNvbGUtbG9nLXN5bnRheC1l cnJvci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9jb25zb2xlLWxv Zy1zeW50YXgtZXJyb3IuaHRtbDogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL3Jlc291cmNl cy9zeW50YXgtZXJyb3IuanM6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2lu c3BlY3Rvci9jb25zb2xlLWxvZy1zeW50YXgtZXJyb3ItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwog MjAxMC0wNy0yMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29s ZS1sb2ctc3ludGF4LWVycm9yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9j b25zb2xlLWxvZy1zeW50YXgtZXJyb3ItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBjMGYxNmEw ZDQ3Y2YzODJkYjM2YWI2NWUxNzhhNjc4ZDc1YmRjNDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS1sb2ctc3ludGF4LWVycm9yLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDUgQEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxOiBTeW50YXhFcnJvcjogUGFy c2UgZXJyb3IKK1Rlc3RzIHRoYXQgc3ludGF4IGVycm9ycyBhcmUgbG9nZ2VkIGludG8gY29uc29s ZSBhbmQgZG9lc24ndCBjYXVzZSBicm93c2VyIGNyYXNoLgorCityZXNvdXJjZXMvc3ludGF4LWVy cm9yLmpzOjFTeW50YXhFcnJvcjogUGFyc2UgZXJyb3IKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2NvbnNvbGUtbG9nLXN5bnRheC1lcnJvci5odG1sIGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NvbnNvbGUtbG9nLXN5bnRheC1lcnJvci5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NzU1CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY2OTE4 YmVhZTY1NDA0ZjNlN2NlNjY0MzI3MGZjNmUwMDBiYjZlYTYKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS1sb2ctc3ludGF4LWVycm9yLmh0bWwKQEAgLTAs MCArMSwxOCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9odHRwL3Rlc3RzL2lu c3BlY3Rvci9pbnNwZWN0b3ItdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vaHR0 cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS10ZXN0cy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0icmVzb3VyY2VzL3N5bnRheC1lcnJvci5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorZnVuY3Rp b24gZG9pdCgpCit7CisgICAgZHVtcENvbnNvbGVNZXNzYWdlcygpOworfQorPC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9Im9ubG9hZCgpIj4KKzxwPgorVGVzdHMgdGhhdCBzeW50YXgg ZXJyb3JzIGFyZSBsb2dnZWQgaW50byBjb25zb2xlIGFuZCBkb2Vzbid0IGNhdXNlIGJyb3dzZXIg Y3Jhc2guCis8L3A+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvcmVzb3VyY2VzL3N5bnRheC1lcnJvci5qcyBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9yZXNvdXJjZXMvc3ludGF4LWVycm9yLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJlYThjZDE3N2FmZjlkMWVj MmI5ZDFiMjFhY2U5YzQ1ZTIzYWU3ZGYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvcmVzb3VyY2VzL3N5bnRheC1lcnJvci5qcwpAQCAtMCwwICsxIEBACispCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9pbnNwZWN0b3IvY29uc29sZS1s b2ctc3ludGF4LWVycm9yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL2luc3BlY3Rvci9jb25zb2xlLWxvZy1zeW50YXgtZXJyb3ItZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmVmOGY2MGYyMWU3NjE0NzVmODRhNzM0YzMxMDNjNWMwMWRhMTdlN2QKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9pbnNwZWN0b3IvY29uc29s ZS1sb2ctc3ludGF4LWVycm9yLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK0NPTlNPTEUg TUVTU0FHRTogbGluZSAxOiBVbmNhdWdodCBTeW50YXhFcnJvcjogVW5leHBlY3RlZCB0b2tlbiAp DQorVGVzdHMgdGhhdCBzeW50YXggZXJyb3JzIGFyZSBsb2dnZWQgaW50byBjb25zb2xlIGFuZCBk b2Vzbid0IGNhdXNlIGJyb3dzZXIgY3Jhc2guDQorDQorcmVzb3VyY2VzL3N5bnRheC1lcnJvci5q czoxVW5jYXVnaHQgU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgdG9rZW4gKQ0K