42818 2010-07-22 06:01:03 -0700 [Qt] REGRESSION(63348): jsc is broken 2010-09-08 22:35:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 42280 1 ossy webkit-unassigned barraclough laszlo.gombos oliver zherczeg oldest_to_newest 254748 0 ossy 2010-07-22 06:01:03 -0700 After http://trac.webkit.org/changeset/63348 and http://trac.webkit.org/changeset/63378 (buildfix) on Windows all javascriptcore tests crash. (and QtTestBrowser too) (We really should setup a windows tester bot asap) Any idea how to fix it? I try to generate a gdb crash log asap. 255181 1 62377 barraclough 2010-07-22 20:24:11 -0700 Created attachment 62377 Speculative fix 255183 2 62377 oliver 2010-07-22 20:25:51 -0700 Comment on attachment 62377 Speculative fix r=speculation! 255186 3 barraclough 2010-07-22 20:29:53 -0700 I think the problem is that JIT_STUBS is not specifying the fastcall calling convention. I've landed a speculative fix in r63947, let's see how this goes. 255187 4 barraclough 2010-07-22 20:45:48 -0700 + r63948! 255216 5 ossy 2010-07-22 23:22:12 -0700 (In reply to comment #3) > I think the problem is that JIT_STUBS is not specifying the fastcall calling convention. I've landed a speculative fix in r63947, let's see how this goes. Unfortunately it broke the build: Creating library file: t:\WindowsRelease\buildslave\qt-windows-32bit-release\build\WebKitBuild\Release\lib\libQtWebKit4.a make.exe[1]: Leaving directory `T:/WindowsRelease/buildslave/qt-windows-32bit-release/build/WebKitBuild/Release/WebCore' ..\JavaScriptCore\release/libjscore.a(JITStubs.o):JITStubs.cpp:(.text+0x21): undefined reference to `cti_vm_throw' collect2: ld returned 1 exit status make.exe[1]: *** [..\lib\QtWebKit4.dll] Error 1 255222 6 ossy 2010-07-23 00:04:45 -0700 r63947 and r63948 were rolled out, because they broke Qt Windows build: http://trac.webkit.org/changeset/63950 255223 7 62377 ossy 2010-07-23 00:05:43 -0700 Comment on attachment 62377 Speculative fix Cleared r+ from obsolete attachment 255224 8 ossy 2010-07-23 00:06:29 -0700 (In reply to comment #6) > r63947 and r63948 were rolled out, because they broke Qt Windows build: > http://trac.webkit.org/changeset/63950 I mean http://trac.webkit.org/changeset/63954 . Sorry. 255429 9 barraclough 2010-07-23 09:37:59 -0700 So, the problem is that the JIT_STUB functions need to use fastcall calling conventions. But there is an extra difficulty, in that this seems to change the mangling of a symbol – when I tried making the calls use fastcall I seem to get a link error. I think the symbol seems to get mangled differently, I think the symbol may be ending up as _cti_vm_throw instead of cti_vm_throw. I've had a couple of tries at doing this blind with no success, so I think someone who is actually developing on QT/Win is going to have to try. If nobody is available to work on this then I suggest disabling the JIT for this build. 255961 10 ossy 2010-07-26 03:38:51 -0700 hello.js: print("Hello World!"); backtrace in debug mode (r64038): (gdb) run t:\hello.js Starting program: T:\WindowsDebug\buildslave\qt-windows-32bit-debug\build/WebKit Build\Debug\JavaScriptCore\jsc.exe t:\hello.js [New thread 1620.0x194] ASSERTION FAILED: this[RegisterFile::ScopeChain].Register::scopeChain() (..\..\..\JavaScriptCore\interpreter/CallFrame.h:45 JSC::ScopeChainNode* JSC::ExecState::scopeChain() const) Program received signal SIGSEGV, Segmentation fault. 0x0058bda2 in JSC::ExecState::scopeChain (this=0x51800a0) at ../../../JavaScriptCore/interpreter/CallFrame.h:45 45 ASSERT(this[RegisterFile::ScopeChain].Register::scopeChain()); (gdb) bt #0 0x0058bda2 in JSC::ExecState::scopeChain (this=0x51800a0) at ../../../JavaScriptCore/interpreter/CallFrame.h:45 #1 0x004869d7 in cti_op_resolve_with_base (args=0x3e94a8) at ..\..\..\JavaScriptCore\jit\JITStubs.cpp:2913 #2 0x04f501d5 in ?? () #3 0x003e94a8 in ?? () #4 0x05229fe0 in ?? () #5 0x00000002 in ?? () #6 0x00589fa5 in JSC::JITCode::operator! (this=0x610076) at ../../../JavaScriptCore/jit/JITCode.h:56 #7 0x00752254 in JSC::Profiler::s_sharedProfiler () #8 0x00610076 in JSC::PropertySlot::setValue(JSC::JSValue)::__PRETTY_FUNCTION__ () #9 0x003e890c in ?? () #10 0x0022fd58 in ?? () #11 0x005088c9 in JSC::JITCode::execute (this=0x752254, registerFile=0x3e5c48, callFrame=0x22fd83, globalData=0x22fd58, exception=0x4dd091) at ../../../JavaScriptCore/jit/JITCode.h:77 #12 0x0022fdf8 in ?? () #13 0x00752254 in JSC::Profiler::s_sharedProfiler () #14 0x003e5c48 in ?? () #15 0x0022fd83 in ?? () #16 0x0022fd58 in ?? () #17 0x004dd091 in CallRecord (this=0x0) at ../../../JavaScriptCore/bytecode/SamplingTool.h:178 #18 0x00000000 in ?? () 256194 11 barraclough 2010-07-26 13:21:14 -0700 This looks like expected behaviour. :-) 275042 12 66722 ossy 2010-09-07 08:12:32 -0700 Created attachment 66722 proposed fix Based on patches of Gavin Barraclough: r63947 and r63948. I added a new SYMBOL_STRING_RELOCATION(...) case for MinGW, because MinGW adds a "@" prefix and "@4" suffix to symbol names when you use fastcall conventions. 276161 13 66722 oliver 2010-09-08 16:29:56 -0700 Comment on attachment 66722 proposed fix r=me 276314 14 66722 ossy 2010-09-08 22:35:46 -0700 Comment on attachment 66722 proposed fix Clearing flags on attachment: 66722 Committed r67062: <http://trac.webkit.org/changeset/67062> 276315 15 ossy 2010-09-08 22:35:56 -0700 All reviewed patches have been landed. Closing bug. 62377 2010-07-22 20:24:11 -0700 2010-09-07 08:12:32 -0700 Speculative fix patch.qtwinfix.txt text/plain 1964 barraclough SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzOTQ0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMjIgIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA0MjgxOCAtIFtRdF0gUkVHUkVTU0lPTig2 MzM0OCk6IGpzYyBpcyBicm9rZW4KKyAgICAgICAgU3BlY3VsYXRpdmUgZml4LCBuZWVkIGZhc3Rj YWxsIGNvbnZlbnRpb25zIG9uIFF0L1dpbi4KKworICAgICAgICAqIGppdC9KSVRTdHVicy5jcHA6 CisgICAgICAgICogaml0L0pJVFN0dWJzLmg6CisKIDIwMTAtMDctMjIgIEtlbnQgSGFuc2VuICA8 a2VudC5oYW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJh LgpJbmRleDogSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCShyZXZpc2lvbiA2Mzk0NCkKKysrIEphdmFT Y3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5LDggKzc5LDEw IEBAIG5hbWVzcGFjZSBKU0MgewogCiAjaWYgT1MoTElOVVgpICYmIENQVShYODZfNjQpCiAjZGVm aW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAjbmFtZSAiQHBsdCIKKyNlbGlmIE9T KERBUldJTikKKyNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICJfIiAjbmFt ZQogI2Vsc2UKLSNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpIFNZTUJPTF9T VFJJTkcobmFtZSkKKyNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICNuYW1l CiAjZW5kaWYKIAogI2lmIE9TKERBUldJTikKSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ppdC9KSVRT dHVicy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5oCShyZXZp c2lvbiA2Mzk0NCkKKysrIEphdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5oCSh3b3JraW5nIGNv cHkpCkBAIC0yMjgsMTIgKzIyOCwxNCBAQCBuYW1lc3BhY2UgSlNDIHsKICNkZWZpbmUgU1RVQl9B UkdTX0RFQ0xBUkFUSU9OIHZvaWQqKiBhcmdzCiAjZGVmaW5lIFNUVUJfQVJHUyAoYXJncykKIAot I2lmIENQVShYODYpICYmIENPTVBJTEVSKE1TVkMpCi0jZGVmaW5lIEpJVF9TVFVCIF9fZmFzdGNh bGwKLSNlbGlmIENQVShYODYpICYmIENPTVBJTEVSKEdDQykgJiYgIU9TKFdJTkRPV1MpCi0jZGVm aW5lIEpJVF9TVFVCICBfX2F0dHJpYnV0ZV9fICgoZmFzdGNhbGwpKQotI2Vsc2UKLSNkZWZpbmUg SklUX1NUVUIKKyNpZiBDUFUoWDg2KQorICAgICNpZiBDT01QSUxFUihNU1ZDKQorICAgICNkZWZp bmUgSklUX1NUVUIgX19mYXN0Y2FsbAorICAgICNlbGlmIENPTVBJTEVSKEdDQykKKyAgICAjZGVm aW5lIEpJVF9TVFVCICBfX2F0dHJpYnV0ZV9fICgoZmFzdGNhbGwpKQorICAgICNlbHNlCisgICAg I2Vycm9yICJKSVRfU1RVQiBmdW5jdGlvbiBjYWxscyByZXF1aXJlIGZhc3RjYWxsIGNvbnZlbnRp b25zIG9uIHg4NiwgYWRkIGFwcHJvcHJpYXRlIGRpcmVjdGl2ZS9hdHRyaWJ1dGUgaGVyZSBmb3Ig eW91ciBjb21waWxlciEiCisgICAgI2VuZGlmCiAjZW5kaWYKIAogICAgIGV4dGVybiAiQyIgdm9p ZCBjdGlWTVRocm93VHJhbXBvbGluZSgpOwo= 66722 2010-09-07 08:12:32 -0700 2010-09-08 22:35:46 -0700 proposed fix 3.patch text/plain 2128 ossy SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2ODgyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMDcgIENzYWJhIE9z enRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04oNjMzNDgpOiBqc2MgaXMgYnJv a2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjgx OAorCisgICAgICAgIE5lZWQgZmFzdGNhbGwgY29udmVudGlvbnMgb24gUXQvV2luL01pbkdXLgor ICAgICAgICBCYXNlZCBvbiBwYXRjaGVzIG9mIEdhdmluIEJhcnJhY2xvdWdoOiByNjM5NDcgYW5k IHI2Mzk0OC4KKworICAgICAgICAqIGppdC9KSVRTdHVicy5jcHA6CisgICAgICAgICogaml0L0pJ VFN0dWJzLmg6CisKIDIwMTAtMDktMDYgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4K IAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeApJbmRleDogSmF2YVNjcmlwdENvcmUvaml0L0pJ VFN0dWJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3Bw CShyZXZpc2lvbiA2Njg4MikKKysrIEphdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTgwLDggKzgwLDEyIEBACiAKICNpZiBPUyhMSU5VWCkgJiYgQ1BVKFg4 Nl82NCkKICNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICNuYW1lICJAcGx0 IgorI2VsaWYgT1MoREFSV0lOKQorI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFt ZSkgIl8iICNuYW1lCisjZWxpZiBDUFUoWDg2KSAmJiBDT01QSUxFUihNSU5HVykKKyNkZWZpbmUg U1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICJAIiAjbmFtZSAiQDQiCiAjZWxzZQotI2Rl ZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFtZSkgU1lNQk9MX1NUUklORyhuYW1lKQor I2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFtZSkgI25hbWUKICNlbmRpZgogCiAj aWYgT1MoREFSV0lOKQpJbmRleDogSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmgJKHJldmlzaW9uIDY2ODgyKQor KysgSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzOSwx MiArMjM5LDE2IEBACiAjZGVmaW5lIFNUVUJfQVJHU19ERUNMQVJBVElPTiB2b2lkKiogYXJncwog I2RlZmluZSBTVFVCX0FSR1MgKGFyZ3MpCiAKLSNpZiBDUFUoWDg2KSAmJiBDT01QSUxFUihNU1ZD KQotI2RlZmluZSBKSVRfU1RVQiBfX2Zhc3RjYWxsCi0jZWxpZiBDUFUoWDg2KSAmJiBDT01QSUxF UihHQ0MpICYmICFPUyhXSU5ET1dTKQotI2RlZmluZSBKSVRfU1RVQiAgX19hdHRyaWJ1dGVfXyAo KGZhc3RjYWxsKSkKKyNpZiBDUFUoWDg2KQorICAgICNpZiBDT01QSUxFUihNU1ZDKQorICAgICNk ZWZpbmUgSklUX1NUVUIgX19mYXN0Y2FsbAorICAgICNlbGlmIENPTVBJTEVSKEdDQykKKyAgICAj ZGVmaW5lIEpJVF9TVFVCICBfX2F0dHJpYnV0ZV9fICgoZmFzdGNhbGwpKQorICAgICNlbHNlCisg ICAgI2Vycm9yICJKSVRfU1RVQiBmdW5jdGlvbiBjYWxscyByZXF1aXJlIGZhc3RjYWxsIGNvbnZl bnRpb25zIG9uIHg4NiwgYWRkIGFwcHJvcHJpYXRlIGRpcmVjdGl2ZS9hdHRyaWJ1dGUgaGVyZSBm b3IgeW91ciBjb21waWxlciEiCisgICAgI2VuZGlmCiAjZWxzZQotI2RlZmluZSBKSVRfU1RVQgor ICAgICNkZWZpbmUgSklUX1NUVUIKICNlbmRpZgogCiAgICAgZXh0ZXJuICJDIiB2b2lkIGN0aVZN VGhyb3dUcmFtcG9saW5lKCk7Cg==