42813 2010-07-22 03:33:03 -0700 [EFL] Build break for SVN r63881 2010-07-22 08:52:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned barbieri commit-queue leandro lucas.de.marchi oldest_to_newest 254712 0 gyuyoung.kim 2010-07-22 03:33:03 -0700 Build break on r63881. Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal(WebCore::String const&)' libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess(WebCore::String const&)' libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure(WebCore::String const&)' libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLAsLocal(WebCore::String const&)' collect2: ld returned 1 exit status 254713 1 62281 gyuyoung.kim 2010-07-22 03:36:26 -0700 Created attachment 62281 Patch 254715 2 62282 gyuyoung.kim 2010-07-22 03:40:30 -0700 Created attachment 62282 Patch Sorry. wrong file was uploaded. 254756 3 62282 leandro 2010-07-22 06:31:54 -0700 Comment on attachment 62282 Patch LGTM. Since it is a bug fix, I'm commit-queuing this without a formal review. 254758 4 leandro 2010-07-22 06:33:23 -0700 (In reply to comment #3) > (From update of attachment 62282 [details]) > LGTM. Since it is a bug fix, I'm commit-queuing this without a formal review. And by "bug fix", I meant *build* fix. 254789 5 62282 tonikitoo 2010-07-22 07:45:53 -0700 Comment on attachment 62282 Patch Not sure if the commit-queue understands cq+ for "unreviewed build fix" patches. Lets try r+'ing it. 254795 6 62282 tonikitoo 2010-07-22 08:05:03 -0700 Comment on attachment 62282 Patch Lets try without r+ 254802 7 62282 leandro 2010-07-22 08:20:28 -0700 Comment on attachment 62282 Patch Clearing flags on attachment: 62282 Committed r63894: <http://trac.webkit.org/changeset/63894> 254803 8 leandro 2010-07-22 08:20:38 -0700 All reviewed patches have been landed. Closing bug. 254829 9 62282 commit-queue 2010-07-22 08:47:44 -0700 Comment on attachment 62282 Patch Rejecting patch 62282 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20707 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 24.66s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3562345 254831 10 62282 tonikitoo 2010-07-22 08:50:47 -0700 Comment on attachment 62282 Patch lets try again: animations/play-state.html seems flaky, see bug 42821 254833 11 leandro 2010-07-22 08:52:43 -0700 (In reply to comment #10) > (From update of attachment 62282 [details]) > lets try again: animations/play-state.html seems flaky, see bug 42821 I'm clearing the flags, as this patch has already landed and this test has nothing to do with this build fix :) 62281 2010-07-22 03:36:26 -0700 2010-07-22 03:40:30 -0700 Patch patch.txt text/plain 969 gyuyoung.kim SW5kZXg6IFdlYktpdC9lZmwvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvQ2hh bmdlTG9nCShyZXZpc2lvbiA2Mzg3NykKKysrIFdlYktpdC9lZmwvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbRUZMXSBTZXQgcHJveHkgYWRkcmVzcyBmb3IgU291cAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI3MjEKKworICAgICAgICBT ZXQgcHJveHkgYWRkcmVzcyBieSBodHRwX3Byb3h5IGVudmlyb21lbnQgdmFyaWFibGUuCisKKyAg ICAgICAgKiBFV2ViTGF1bmNoZXIvbWFpbi5jOgorICAgICAgICAobWFpbik6IEludm9rZSBwcm94 eSBzZXQgbWV0aG9kLiAKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAg KGV3a19zZXR0aW5nc19wcm94eV91cmlfc2V0KTogU2V0IHByb3h5IGFkZHJlc3MuCisgICAgICAg ICogZXdrL2V3a19zZXR0aW5ncy5oOgorCiAyMDEwLTA3LTE2ICBMZWFuZHJvIFBlcmVpcmEgIDxs ZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9y b25oYSBTaWx2YS4KSW5kZXg6IFdlYktpdC9lZmwvRVdlYkxhdW5jaGVyL21haW4uYwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvZWZsL0VXZWJMYXVuY2hlci9tYWluLmMJKHJldmlzaW9uIDYzODc2KQor KysgV2ViS2l0L2VmbC9FV2ViTGF1bmNoZXIvbWFpbi5jCSh3b3JraW5nIGNvcHkpCkBAIC03NTYs 62282 2010-07-22 03:40:30 -0700 2010-07-22 08:52:57 -0700 Patch patch-buildbreak.txt text/plain 969 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Mzg4MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAgICBb RUZMXSBCdWlsZCBicmVhayBmb3IgU1ZOIHI2Mzg4MQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI4MTMKKworICAgICAgICAqIENNYWtlTGlzdHMudHh0 OiBBZGQgcGxhdGZvcm0vU2NoZW1lUmVnaXN0cnkuY3BwCisKIDIwMTAtMDctMjIgIEtlbnQgVGFt dXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiA2Mzg4MSkKKysrIFdlYkNvcmUvQ01ha2VMaXN0cy50 eHQJKHdvcmtpbmcgY29weSkKQEAgLTEyMDEsNiArMTIwMSw3IEBAIFNFVChXZWJDb3JlX1NPVVJD RVMKICAgICBwbGF0Zm9ybS9TY3JvbGxiYXJUaGVtZUNvbXBvc2l0ZS5jcHAKICAgICBwbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcAogICAgIHBsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAKKyAgICBwbGF0 Zm9ybS9TY2hlbWVSZWdpc3RyeS5jcHAKICAgICBwbGF0Zm9ybS9UaHJlYWRHbG9iYWxEYXRhLmNw cAogICAgIHBsYXRmb3JtL1RocmVhZFRpbWVycy5jcHAKICAgICBwbGF0Zm9ybS9UaW1lci5jcHAK